[Wikidata-bugs] [Maniphest] [Closed] T92532: [Bug] wikibase.getLanguageNameByCode: wikibase.getLanguageNameByCode() qunit test failure
Krinkle closed this task as "Resolved". Krinkle claimed this task. Krinkle added a comment. Was fixed. But still breaks REL1_26 – T128828: MediaWiki REL1_26 qunit failing "wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode() FAILED" <https://phabricator.wikimedia.org/T128828>. TASK DETAIL https://phabricator.wikimedia.org/T92532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, hashar, gerritbot, JanZerebecki, Lydia_Pintscher, aude, Aklapper, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Up For Grabs] T121083: Cannot find site jenkins_u3_mw
Krinkle placed this task up for grabs. TASK DETAIL https://phabricator.wikimedia.org/T121083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reopened] T121083: Cannot find site jenkins_u3_mw
Krinkle reopened this task as "Open".
Krinkle added a comment.
Still happening. Except now with the name `mywiki` and earlier (in
update.php).
https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/34327/consoleFull#console-section-1
00:00:38.563 PHP Notice: Cannot find site mywiki in sites table [Called
from Wikibase\Client\WikibaseClient::newSiteGroup in
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php
at line 611] in
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/includes/debug/MWDebug.php
on line 300
00:00:38.563 PHP Stack trace:
00:00:38.564 PHP 1. {main}()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/maintenance/update.php:0
00:00:38.564 PHP 2. require_once()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/maintenance/update.php:217
00:00:38.564 PHP 3. UpdateMediaWiki->execute()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/maintenance/doMaintenance.php:103
00:00:38.565 PHP 4. LoggedUpdateMaintenance->execute()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/maintenance/update.php:184
00:00:38.565 PHP 5. FlowCreateTemplates->doDBUpdates()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/maintenance/Maintenance.php:1438
00:00:38.565 PHP 6. FlowCreateTemplates->create()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/Flow/maintenance/FlowCreateTemplates.php:84
00:00:38.566 PHP 7. WikiPage->doEditContent()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/Flow/maintenance/FlowCreateTemplates.php:113
00:00:38.566 PHP 8. WikiPage->prepareContentForEdit()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/includes/page/WikiPage.php:1713
00:00:38.566 PHP 9. AbstractContent->getParserOutput()
/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/includes/page/WikiPage.php:2178
TASK DETAIL
https://phabricator.wikimedia.org/T121083
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Krinkle
Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki,
Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry,
Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T131036: Failed to find message key "wikibase-error-ui-client-error"
Krinkle created this task. Herald added a subscriber: Aklapper. TASK DESCRIPTION A Wikibase module requires this message, but no such message exists. > Failed to find 'wikibase-error-ui-client-error' (it) (Not blocking 129976 since it only seems to happen in test context, and not in the main build). TASK DETAIL https://phabricator.wikimedia.org/T131036 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: adrianheine, Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T121083: Cannot find site jenkins_u3_mw
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T121083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T128828: MediaWiki REL1_26 qunit failing "wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode() FAILED"
Krinkle created this task. TASK DESCRIPTION https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/33478/console 03:00:16 Chromium 48.0.2564 (Ubuntu 0.0.0) wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode() FAILED 03:00:16getLanguageNameByCode() returns language name. 03:00:16Expected: Deutsch 03:00:16Actual: German TASK DETAIL https://phabricator.wikimedia.org/T128828 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, matmarex, Krinkle, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T121083: Cannot find site jenkins_u3_mw
Krinkle added subscribers: gerritbot, thiemowmde, Krinkle, daniel. Krinkle merged a task: T128779: In CI, local wiki ID is not found in the sites table. TASK DETAIL https://phabricator.wikimedia.org/T121083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T128779: In CI, local wiki ID is not found in the sites table
Krinkle added a comment. @daniel This blocks T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown <https://phabricator.wikimedia.org/T50002>, which soft-blocks T53908: Jenkins should flag usage of deprecated features <https://phabricator.wikimedia.org/T53908>. TASK DETAIL https://phabricator.wikimedia.org/T128779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, thiemowmde, JanZerebecki, aude, Krinkle, Aklapper, daniel, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T128779: In CI, local wiki ID is not found in the sites table
Krinkle closed this task as a duplicate of T121083: Cannot find site jenkins_u3_mw. TASK DETAIL https://phabricator.wikimedia.org/T128779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, thiemowmde, JanZerebecki, aude, Krinkle, Aklapper, daniel, Lewizho99, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T121083: Cannot find site jenkins_u3_mw
Krinkle moved this task to Review on the Wikidata-Sprint-2016-03-01 workboard. TASK DETAIL https://phabricator.wikimedia.org/T121083 WORKBOARD https://phabricator.wikimedia.org/project/board/1780/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T121083: Cannot find site jenkins_u3_mw
Krinkle triaged this task as "High" priority. Krinkle added projects: MediaWiki-extensions-WikibaseClient, Wikidata-Sprint-2016-03-01. TASK DETAIL https://phabricator.wikimedia.org/T121083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T129185: Make Wikibase tests fail pass when user language is stored in request context
Krinkle created this task. Herald added a subscriber: Aklapper. TASK DESCRIPTION On https://gerrit.wikimedia.org/r/#/c/274025/, various Wikibase view seems to rely on setting the user language via $wgLang instead of RequestContext. https://phabricator.wikimedia.org/rEWBA0d6c80cc5f695bc414429c18868792ce66a65cd2 is not the only one apparently. After that one is fixed, 47 more tests started failing in Wikibase: Here is the first one: 23:38:42 There were 47 failures: 23:38:42 23:38:42 1) Wikibase\View\Tests\EntityTermsViewTest::testGetHtml_isMarkedAsEmptyValue 23:38:42 Failed asserting that ' 23:38:42 23:38:42 No description defined 23:38:42 No aliases defined 23:38:42 23:38:42 23:38:42 23:38:42 ' contains "(wikibase-description-empty)". 23:38:42 23:38:42 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/tests/phpunit/EntityTermsViewTest.php:124 23:38:42 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:147 - https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/53572/consoleFull#console-section-2 - rEWBA0d6c80cc5f69: Actually use the passed language in AutoCommentFormatter <https://phabricator.wikimedia.org/rEWBA0d6c80cc5f695bc414429c18868792ce66a65cd2> TASK DETAIL https://phabricator.wikimedia.org/T129185 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, hoo, aude, Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T68108: [Epic] Store media information for files on Wikimedia Commons as structured data
Krinkle added a comment.
Related and some may be a blocker:
- T28741: Clean up file tables (image and oldimage) database schema ('curr'
and 'old' strike back!) <https://phabricator.wikimedia.org/T28741>
- T589: RfC: image and oldimage tables
<https://phabricator.wikimedia.org/T589>
- T33257: File properties storage (tracking)
<https://phabricator.wikimedia.org/T33257>
TASK DETAIL
https://phabricator.wikimedia.org/T68108
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Krinkle
Cc: Krinkle, Deskana, DannyH, Tfinc, Smalyshev, Jheald, LikeLifer, Yann,
intracer, Spinster, Orofarne, Filceolaire, MZMcBride, bzimport,
wikibugs-l-list, TheDJ, zhuyifei1999, DixonD, Bugreporter, RP88, Aklapper,
Matanya, waldyrious, El_Grafo, Daniel_Mietchen, Jdforrester-WMF, GPHemsley,
Bene, Legoktm, Nemo_bis, Lokal_Profil, Tobi_WMDE_SW, He7d3r, Petrb, Gilles,
jayvdb, Kelson, MarkTraceur, Steinsplitter, JeroenDeDauw, Micru, revi,
JanZerebecki, JeanFred, Ricordisamoa, Snowolf, Keegan, Rillke, Bawolff,
Fabrice_Florin, Multichill, Liuxinyu970226, Ainali, Tgr, Lydia_Pintscher,
jeremyb, Stryn, Ltrlg, daniel, Dereckson, JohnLewis, D3r1ck01, Izno,
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T131424: WikidataPageBanner (Beta) often renders less-than-useful banners
Krinkle created this task. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION This seems specific to MobileFrontend Beta mode. It does not happen in the default/stable mode. Whenever the page's default associated image is of portrait aspect ratio, the banner brings negative value to the reading experience. For example: https://en.m.wikipedia.org/wiki/Tank_Girl_(film) F3806522: Screen Shot 2016-04-01 at 04.13.29.png <https://phabricator.wikimedia.org/F3806522> Short the top portion of someone's hair. Poorly cropped and rather pixelated due to it being stretched beyond the nominal size of the original photo. Presumably in a situation like this (bad aspect ratio, image too small) it may be better left out. Source of the image: F3806532: Screen Shot 2016-04-01 at 04.13.33.png <https://phabricator.wikimedia.org/F3806532> TASK DETAIL https://phabricator.wikimedia.org/T131424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T131424: WikidataPageBanner (Beta) often renders less-than-useful banners
Krinkle edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T131424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T98145: [EPIC] Lead images (WikidataPageBanner integration) to stable
Krinkle added a blocking task: T131424: WikidataPageBanner (Beta) often renders less-than-useful banners. TASK DETAIL https://phabricator.wikimedia.org/T98145 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Moushira, bd808, Jdlrobson, KHammerstein, phuedx, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, KLans_WMF, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T102156: Lead image - change crops to taller height so that less faces are cropped
Krinkle added a comment. See T131424: WikidataPageBanner (Beta) often renders less-than-useful banners <https://phabricator.wikimedia.org/T131424>. TASK DETAIL https://phabricator.wikimedia.org/T102156 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Sumit, Jhernandez, Aklapper, KHammerstein, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T131424: WikidataPageBanner (Beta) often renders less-than-useful banners
Krinkle added a blocked task: T98145: [EPIC] Lead images (WikidataPageBanner integration) to stable. TASK DETAIL https://phabricator.wikimedia.org/T131424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127275: Wikibase RL module mw.config.values.wbSiteDetails repeatedly flapping
Krinkle added a comment. This is still happening: Tuesday, May 10th, 2016 02:13 mw.config.values.wbSiteDetails: ndCefMab -> FZFlN+VX (changed after 6 days and 56 minutes) 02:18 mw.config.values.wbSiteDetails: FZFlN+VX -> ndCefMab (changed after 5 minutes and 3 seconds) 02:43 mw.config.values.wbSiteDetails: ndCefMab -> FZFlN+VX (changed after 25 minutes and 21 seconds) TASK DETAIL https://phabricator.wikimedia.org/T127275 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hoo, Krinkle, Aklapper, Jdforrester-WMF, StudiesWorld, Vali.matei, D3r1ck01, Izno, Wikidata-bugs, aude, GWicke, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T133000: Fatal BadMethodCallException: Call to a member function getText() on a non-object (null) in Wikidata/ArticlePlaceholder/SearchHookHandle
Krinkle edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T133000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Urbanecm, Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T133000: Fatal BadMethodCallException: Call to a member function getText() on a non-object (null) in Wikidata/ArticlePlaceholder/SearchHookHandle
Krinkle triaged this task as "Unbreak Now!" priority. Herald added a subscriber: Urbanecm. TASK DETAIL https://phabricator.wikimedia.org/T133000 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Urbanecm, Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T133000: Fatal BadMethodCallException: Call to a member function getText() on a non-object (null) in Wikidata/ArticlePlaceholder/SearchHookHandle
Krinkle created this task.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
https://test.wikipedia.org/w/index.php?search=sandbox=yes=Special%3ASearch=Go=1
Exception encountered, of type "BadMethodCallException"
[VxWM9QpAME4AALfcJyBC]
/w/index.php?search=sandbox=yes=Special%3ASearch=Go=1
BadMethodCallException from line 131 of
/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php:
Call to a member function getText() on a non-object (null)
Backtrace:
#0
/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(116):
ArticlePlaceholder\SearchHookHandler->createResult(Wikibase\Lib\Interactors\TermSearchResult,
string)
#1
/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(93):
ArticlePlaceholder\SearchHookHandler->getSearchResults(string)
#2
/srv/mediawiki/php-1.27.0-wmf.21/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(83):
ArticlePlaceholder\SearchHookHandler->addToSearch(SpecialSearch, OutputPage,
string)
#3 /srv/mediawiki/php-1.27.0-wmf.21/includes/Hooks.php(195):
ArticlePlaceholder\SearchHookHandler::onSpecialSearchResultsAppend(SpecialSearch,
OutputPage, string)
#4
/srv/mediawiki/php-1.27.0-wmf.21/includes/specials/SpecialSearch.php(435):
Hooks::run(string, array)
#5
/srv/mediawiki/php-1.27.0-wmf.21/includes/specials/SpecialSearch.php(131):
SpecialSearch->showResults(string)
#6
/srv/mediawiki/php-1.27.0-wmf.21/includes/specialpage/SpecialPage.php(412):
SpecialSearch->execute(NULL)
#7
/srv/mediawiki/php-1.27.0-wmf.21/includes/specialpage/SpecialPageFactory.php(572):
SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.27.0-wmf.21/includes/MediaWiki.php(282):
SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.27.0-wmf.21/includes/MediaWiki.php(738):
MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.27.0-wmf.21/includes/MediaWiki.php(519):
MediaWiki->main()
#11 /srv/mediawiki/php-1.27.0-wmf.21/index.php(43): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}
TASK DETAIL
https://phabricator.wikimedia.org/T133000
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Krinkle
Cc: Krinkle, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb,
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't add claims if a logged in user gets logged out
Krinkle added a comment. Note that the API has an `assert` parameter that may be useful here. https://www.mediawiki.org/w/api.php / https://www.mediawiki.org/wiki/API:Assert TASK DETAIL https://phabricator.wikimedia.org/T124451 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, D3r1ck01, Izno, Mpaulson, Wikidata-bugs, aude, jayvdb, Slaporte, csteipp, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T121083: Cannot find site jenkins_u3_mw
Krinkle removed a project: Continuous-Integration-Infrastructure. TASK DETAILhttps://phabricator.wikimedia.org/T121083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Bene, daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle edited the task description. (Show Details) EDIT DETAILS... > Failed to find 'wikibase-error-ui-client-error' (it) (Not blocking T129976 since it only seems to happen in test context, and not in the main build).> Failed to find 'wikibase-error-ui-client-error' (it) TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle edited the task description. (Show Details) EDIT DETAILSThe wikibase.api.RepoApiError.tests resource loader module (in the wikibase/_javascript_-api component) requires this message, but no such message exists. > Failed to find 'wikibase-error-ui-client-error' (it)...TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle added a comment. This is now blocking T129976. See https://gerrit.wikimedia.org/r/#/c/277457/ 1) ResourcesTest::testMissingMessages Message 'wikibase-error-ui-client-error' required by 'wikibase.api.RepoApiError.tests' must exist Failed asserting that false is true.TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle added a parent task: T129976: Provide a structural unit test to confirm each module message exists. TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reopened] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle reopened this task as "Open".Krinkle added a comment. It seems this wasn't pulled-through in the nightly build. It's still there in the Wikidata extension: https://github.com/wikimedia/mediawiki-extensions-Wikidata/blob/b9514fb4f579609e9157cac5ebd8510d42be776b/vendor/wikibase/_javascript_-api/tests/resources.php#L39 It looks like this is pulled in from a composer package, not the regularly embedded MediaWiki extension. Latest version at https://packagist.org/packages/wikibase/_javascript_-api is 2.0.0 from 2016-05-31. I guess a new version needs to be tagged? Also, even then, in extensions/Wikibase/composer.json it is installing "wikibase/_javascript_-api": "~1.1", which isn't even the latest version. Looks like that needs to be bumped as well.TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T131036: [Bug] Failed to find message key "wikibase-error-ui-client-error"
Krinkle added a comment. In T131036#2518549, @gerritbot wrote: Change 302684 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Update _javascript_ Api component to 2.0 https://gerrit.wikimedia.org/r/302684 Still waiting for this one to land, and then get pulled through from Wikibase to Wikidata.TASK DETAILhttps://phabricator.wikimedia.org/T131036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, thiemowmde, Jonas, JanZerebecki, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154017: compile number of http uses for http://www.wikidata.org/entity
Krinkle removed a project: Performance-Metrics. TASK DETAILhttps://phabricator.wikimedia.org/T154017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Lydia_Pintscher, Esc3300, Th3d3v1ls, EBjune, merbst, Avner, Zppix, debt, Gehel, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Dinoguy1000, Manybubbles, faidon, Seb35, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle created this task.Krinkle added projects: _javascript_, Wikibase-DataModel-_javascript_, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONDraft change with details at https://gerrit.wikimedia.org/r/323445/.
Each QUnit test should either return a Promise to QUnit.test (which QUnit will automatically wait for and also report a test failure if the Promise is rejected), or manually use assert.async() where needed.
Examples:
QUnit.test( 'example should pass', function ( assert ) {
return something().then( function ( val ) {
assert.equals( val, 'expected' );
} );
} );
QUnit.test( 'example should fail', function ( assert ) {
var done = assert.async();
something().fail( function ( val ) {
assert.equals( val, 'error message' );
} ).always( done );
} );
This is in preparation for jQuery 3.0, where $.Deferred callbacks are processed asynchronously. https://jquery.com/upgrade-guide/3.0/
Failures can be seen at the pending core patch: https://gerrit.wikimedia.org/r/322812/.TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: gerritbot, Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T119492: [Bug] Simple search suggestions box appears over Wikidata suggestions if search box is selected early
Krinkle added a project: Regression.Krinkle edited the task description. (Show Details)
EDIT DETAILSIf the user quickly clicks on the search box while some stuff is still loading/running, the "normal" search suggestions box (that is, the suggestions box that appears on other wikis) will appear over the special Wikidata search suggestions box as the user is typing. In most situations, the box will have just the "containing..." bit, unless the user inputs "Q" or some such. The Wikidata suggestions box has a z-index of 1, lower than the normal box which has a z-index of 1099, so the top suggestions are covered.
{F4493535}
This somakes the top suggestions are coveredfirst and most important search result inaccessible.TASK DETAILhttps://phabricator.wikimedia.org/T119492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Sjoerddebruin, aude, Zppix, thiemowmde, Lydia_Pintscher, Mbch331, Aklapper, Yair_rand, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119492: [Bug] Simple search suggestions box appears over Wikidata suggestions if search box is selected early
Krinkle added a comment. I run into this almost every time. The stable load point is somewhere around 2 seconds after the page has finished loading. I don't see how it can be considered uncommon or low priority to start searching within 2 seconds of page load. I can only imagine that searching something on Wikidata is the most common user intent from readers viewing the wikidata.org main page.TASK DETAILhttps://phabricator.wikimedia.org/T119492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, hoo, Sjoerddebruin, aude, Zppix, thiemowmde, Lydia_Pintscher, Mbch331, Aklapper, Yair_rand, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T151596: MediaWiki-Vagrant: Role 'wikidata' fails provisioning
Krinkle created this task.Krinkle added projects: MediaWiki-Vagrant, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWikidataBuildResources: Fatal error: Uncaught exception 'ErrorException' with message 'fork failed - Cannot allocate memory' in phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php:957 From /usr/local/bin/composer install --optimize-autoloader --prefer-source returned 255 instead of one of [0] .settings.yaml--- vagrant_ram: 2048 vagrant_cores: 4 out==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: [Thu Nov 24 22:27:46 2016] [hphp] [11317:7fbf0d6fe100:0:01] [] ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: Fatal error: Uncaught exception 'ErrorException' with message 'fork failed - Cannot allocate memory' in phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php:957 ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: Stack trace: ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #0 (): Composer\Util\ErrorHandler::handle() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #1 phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php(957): proc_open() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #2 phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php(757): Symfony\Component\Console\Application->getSttyColumns() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #3 phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php(718): Symfony\Component\Console\Application->getTerminalDimensions() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #4 phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php(651): Symfony\Component\Console\Application->getTerminalWidth() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #5 phar://composer.phar/bin/../src/../vendor/symfony/console/Application.php(130): Symfony\Component\Console\Application->renderException() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #6 phar://composer.phar/bin/../src/../src/Composer/Console/Application.php(104): Symfony\Component\Console\Application->run() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResources]/Exec[composer-install--vagrant-mediawiki-extensions-WikidataBuildResources]/returns: #7 phar://composer.phar/bin/composer(43): Composer\Console\Application->run() ==> default: Notice: /Stage[main]/Role::Wikidata/Mediawiki::Extension[WikidataBuildResources]/Php::Composer::Install[/vagrant/mediawiki/extensions/WikidataBuildResou
[Wikidata-bugs] [Maniphest] [Edited] T151596: MediaWiki-Vagrant: Role 'wikidata' fails provisioning
Krinkle edited the task description. (Show Details) EDIT DETAILS...``` Ran `vagrant provision` twice in case it corrects itself, but didn't.TASK DETAILhttps://phabricator.wikimedia.org/T151596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, aude, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T147798: Wikibase repo UI is sometimes not properly starting up (on Firefox)
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T147798EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, aude, thiemowmde, Jonas, Lydia_Pintscher, Tobi_WMDE_SW, hoo, Vali.matei, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T95899: MediaWiki core PHPUnit tests do not pass on MediaWiki-Vagrant
Krinkle added a project: Wikibase-DataModel.Herald added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T95899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, JanZerebecki, bd808, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, aude, JeroenDeDauw, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T95899: MediaWiki core PHPUnit tests do not pass on MediaWiki-Vagrant
Krinkle removed a project: Wikibase-DataModel. TASK DETAILhttps://phabricator.wikimedia.org/T95899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, JanZerebecki, bd808, D3r1ck01, Izno, Luke081515, mobrovac, Wikidata-bugs, aude, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T153729: CI tests throw warning "Cannot find site mywiki in sites table"
Krinkle added a parent task: T50002: Jenkins: Assert no PHP errors (notices, warnings) were raised or exceptions were thrown. TASK DETAILhttps://phabricator.wikimedia.org/T153729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, KrinkleCc: Tobi_WMDE_SW, KartikMistry, Amire80, santhosh, StudiesWorld, JanZerebecki, hoo, aude, Krinkle, Bene, demon, hashar, daniel, Lydia_Pintscher, thiemowmde, Nikerabbit, TerraCodes, Jay8g, gerritbot, Paladox, Aklapper, Tgr, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T155194: Remove QUnit CompletenessTest
Krinkle triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T155194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, gerritbot, srishakatux, adrianheine, aude, Jdforrester-WMF, Krinkle, Aklapper, QZanden, SamanthaNguyen, D3r1ck01, Izno, Wikidata-bugs, RandomDSdevel, He7d3r, Ladsgroup, Mbch331, Jay8g, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T155194: Remove QUnit CompletenessTest
Krinkle claimed this task.Krinkle added a comment. In T155194#3085546, @Krinkle wrote: @adrianheine @thiemowmde Can you tag a release for data-values/value-view so that the next Wikidata build will include these changes? Thanks. This was released as data-values/value-view 0.19.0 (bc77ec2ab5c3dbfafc8a1f9249555c9ced45dc19), and merged into Wikidata with ee92c55a9203d7d0044946c246110539bee4c95e. This is now unblocked from Wikidata. Next step is removal from MediaWiki core.TASK DETAILhttps://phabricator.wikimedia.org/T155194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thiemowmde, gerritbot, srishakatux, adrianheine, aude, Jdforrester-WMF, Krinkle, Aklapper, QZanden, SamanthaNguyen, D3r1ck01, Izno, Wikidata-bugs, RandomDSdevel, He7d3r, Ladsgroup, Mbch331, Jay8g, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T160678: Reduce ChronologyProtector init cost for load.php
Krinkle triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T160678EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: gerritbot, aude, hoo, Krinkle, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T113037: [Task] Run some Wikibase tests with different languages
Krinkle changed the title from "[Task] run some Wikibase CI jobs with different languages" to "[Task] Run some Wikibase tests with different languages".Krinkle edited projects, added MediaWiki-extensions-WikibaseClient; removed Continuous-Integration-Config.Krinkle edited the task description. (Show Details) EDIT DETAILSRun some of the Wikibase CI jobs withPHPUnit tests and/or browser tests in different languages to catch missing language fixtures and problems with other languages. One with LANG=ar and one with LANG=ru should cover most. Travis CI also has de`de` in addition to these, that might not exercises something not covered by the others?TASK DETAILhttps://phabricator.wikimedia.org/T113037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, JanZerebecki, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113037: [Task] Run some Wikibase tests with different languages
Krinkle added a comment. Un-tagging CI-config as this seems like something that should be done within the PHPUnit and/or browser tests run just for a few test suites. Not to fragment the entire matrix. You can even run all PHPUnit tests (if desired) by creating a TestSuite subclass that iterates the tests directory a second time with some default config change applied.TASK DETAILhttps://phabricator.wikimedia.org/T113037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, aude, JanZerebecki, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T125050: [Task] Add Scribunto to extension-gate in CI
Krinkle closed subtask T126670: Have CI set `$wgScribuntoDefaultEngine = 'luasandbox` to speed up parser tests as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T125050EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thcipriani, Addshore, Paladox, hoo, Aklapper, JanZerebecki, StudiesWorld, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Anomie, Jackmcbarn, Mbch331, hashar___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T160678: Reduce ChronologyProtector init cost for load.php
Krinkle closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T160678EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: gerritbot, aude, hoo, Krinkle, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160989: Revisit Jenkins jobs being triggered for Wikibase
Krinkle added a comment. Current For gate-and-submit we end up triggering: Job nameDescription npm-node-6-jessie_javascript_ lint/style and others composer-php55-trustylint/style composer-hhvm-jessielint/style php55lintLint on permanent slave. Composer already run parallel-lint mwext-testextension-php55-composer-trustyPHPUnit mwext-testextension-hhvm-composer-jessiePHPUnit mwext-qunit-composer-jessieQUnit tests with Karma mwext-mw-selenium-composer-jessieBrowser tests based on ruby/selenium Job nameAppDB PHP mwext-Wikibase-repo-tests-sqlite-php55-trustyReposqlite php55 mwext-Wikibase-repo-tests-sqlite-hhvm-jessieReposqliteHHVM mwext-Wikibase-client-tests-mysql-php55-trustyClientMySQLphp55 mwext-Wikibase-client-tests-sqlite-php55-trustyClient sqlitephp55 mwext-Wikibase-client-tests-mysql-hhvm-jessieClientMysqlHHVM mwext-Wikibase-client-tests-sqlite-hhvm-jessieClientsqliteHHVM Propose to change: mwext-testextension-php55-composer-trusty include composer test (for lint/style) mwext-testextension-hhvm-composer-trusty include composer test (for lint/style) Merge mwext-Wikibase-repo-* and mwext-Wikibase-client-* tests. Propose to remove: php55lint (redundant with composer-php55-trusty) composer-php55-trusty (redundant with mwext-testextension-php55-composer-trusty) composer-hhvm-jessie (redundant with mwext-testextension-hhvm-composer-trusty) all 6 mwext-Wikibase-*-tests-* jobs. Redunant with mwext-testextension-*-composer-*. Propose to add: mwext-testextension-hhvm-sqlite-composer-trusty to ensure sqlite is covered in addition to mysql. No need to cover it with both hhvm and php55. Questions: What is the difference between mwext-Wikibase-*-tests-* and mwext-testextension-*-composer-*? It seems like the latter already runs all PHPUnit tests (both client and repo). It also varies by PHP flavour already, but not by RDBMS. It would make sense to add a third variation to sqlite with one of the PHP flavours. Job nameDescription npm-node-6-jessie_javascript_ lint/style and others mwext-Wikibase-tests-php55-mysqlComposer test (lint, style, PHPUnit) mwext-Wikibase-tests-hhvm-mysqlComposer test (lint, style, PHPUnit) mwext-Wikibase-tests-hhvm-sqliteComposer test (lint, style, PHPUnit) mwext-qunit-composer-jessieQUnit tests with Karma mwext-mw-selenium-composer-jessieBrowser tests based on ruby/selenium This means a small amount is duplicated (2x lint/style for HHVM) but that seems marginal and unimportant, given they run in parallel anyway.TASK DETAILhttps://phabricator.wikimedia.org/T160989EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Paladox, Ladsgroup, greg, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Addshore, thcipriani, hashar, Aklapper, QZanden, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T43103: initialization of the Language object is very heavy
Krinkle added a comment. I think this comment from @tstarling at T85461 is also relevant here: In T85461#3100878, @tstarling wrote: Somewhat off topic, but speaking of lightweight Language object construction, I think having $wgLangObjCacheSize = 10 by default is actually bit rot, I don't think there's any reason for that anymore. Language objects used to hold message arrays, presumably that is the reason for it being so low. TASK DETAILhttps://phabricator.wikimedia.org/T43103EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Rical, Liuxinyu970226, Ltrlg, Elitre, Agabi10, adrianheine, gerritbot, Aklapper, Fomafix, Ricordisamoa, Jarekt, Purodha, Logicwiki, tstarling, bzimport, Wikidata-bugs, Amire80, siebrand, jeblad, SPQRobin, jayvdb, Denny, DanielFriesen, wikibugs-l-list, Nikerabbit, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Vali.matei, Lewizho99, Maathavan, MuhammadShuaib, Psychoslave, GWicke, Gryllida, Shizhao, Arrbee, KartikMistry, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Blocker] T127067: [Story] Reduce initialisation time of SiteLinks
Krinkle changed the status of subtask T127305: [Task] Change ellipsis from JS to CSS from "Declined" to "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T127067EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Incabell, Lydia_Pintscher, gerritbot, Aklapper, Jonas, thiemowmde, adrianheine, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Status] T127305: [Task] Change ellipsis from JS to CSS
Krinkle changed the task status from "Declined" to "Resolved".Krinkle added a comment. rEWBAcc8fe9fbd580: Make long site links wrap nicelyTASK DETAILhttps://phabricator.wikimedia.org/T127305EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, KrinkleCc: Krinkle, thiemowmde, Sjoerddebruin, gerritbot, adrianheine, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T155194: Remove QUnit CompletenessTest
Krinkle edited projects, added Wikidata; removed Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T155194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: thiemowmde, gerritbot, srishakatux, adrianheine, aude, Jdforrester-WMF, Krinkle, Aklapper, QZanden, SamanthaNguyen, D3r1ck01, Izno, Wikidata-bugs, RandomDSdevel, He7d3r, Ladsgroup, Mbch331, Jay8g, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T155194: Remove QUnit CompletenessTest
Krinkle added a project: DataValues-_javascript_. TASK DETAILhttps://phabricator.wikimedia.org/T155194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: thiemowmde, gerritbot, srishakatux, adrianheine, aude, Jdforrester-WMF, Krinkle, Aklapper, QZanden, SamanthaNguyen, D3r1ck01, Izno, Wikidata-bugs, RandomDSdevel, He7d3r, Ladsgroup, Mbch331, Jay8g, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T160685: Increase $wgExpensiveParserFunctionLimit on nowiki
Krinkle added a comment. In T160685#3109425, @jeblad wrote: Btw, the code at Wikidata can be found at d:Module:Cycling race. It may be based on that, but the relevant wikis all have their own copy of it. See https://no.wikipedia.org/w/index.php?title=Modul:Cycling_race=""> Looks like updating to the latest version from Wikidata might solve the problem. Some of the recent changes to that Lua module on Wikidata.org mention "Less expensive function calls". See https://www.wikidata.org/w/index.php?title=Module:Cycling_race="">TASK DETAILhttps://phabricator.wikimedia.org/T160685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Reedy, jeblad, Aklapper, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Zppix, Urbanecm, D3r1ck01, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, GWicke, faidon, Matanya, Mbch331, Rxy, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T125050: [Task] Add Scribunto to extension-gate in CI
Krinkle added a comment. https://gerrit.wikimedia.org/r/#/c/345628/1 https://integration.wikimedia.org/ci/job/mwext-testextension-php55-composer-trusty/259/console 153) LuaStandalone: LuaWikibaseLibraryTests[38]: ... proc_open(): fork failed - Cannot allocate memory Is failing 5x in a row in this and other commits. Has made merging in WikibaseQualityConstraints repo impossible.TASK DETAILhttps://phabricator.wikimedia.org/T125050EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Stashbot, Lydia_Pintscher, Aleksey_WMDE, Ladsgroup, WMDE-leszek, Anomie, hashar, aude, thcipriani, Addshore, Paladox, hoo, Aklapper, JanZerebecki, StudiesWorld, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T93404: [Task] run phpunit ResourcesTest from core for wikibase
Krinkle closed this task as "Resolved".Krinkle claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T93404EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, Lydia_Pintscher, gerritbot, JanZerebecki, Aklapper, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T108946: [Epic] Improve the development infrastructure
Krinkle closed subtask T93404: [Task] run phpunit ResourcesTest from core for wikibase as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T108946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Liuxinyu970226, Ricordisamoa, Aklapper, Lydia_Pintscher, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan
Krinkle edited projects, added Performance-Team; removed MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)), Patch-For-Review, MediaWiki-JobRunner. TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, Addshore, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Salgo60, Zppix, Izno, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T105845: Page components / content widgets
Krinkle removed a project: Architecture. TASK DETAILhttps://phabricator.wikimedia.org/T105845EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GWicke, KrinkleCc: SBisson, MZMcBride, Mholloway, RandomDSdevel, jmadler, Bianjiang, LikeLifer, MGChecker, -jem-, Daniel_Mietchen, StudiesWorld, Kelson, Jonas, daniel, Jhernandez, MrStradivarius, JanZerebecki, Quiddity, mobrovac, ssastry, Tgr, Ltrlg, Inez, cscott, TrevorParscal, Jdlrobson, GWicke, QZanden, Salgo60, D3r1ck01, Izno, Luke081515, Jrf, Wikidata-bugs, aude, Gryllida, jayvdb, fbstj, RobLa-WMF, santhosh, Arlolra, Mbch331, Jay8g, bd808, Krenair, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T160685: Increase $wgExpensiveParserFunctionLimit on nowiki
Krinkle removed a project: Performance. TASK DETAILhttps://phabricator.wikimedia.org/T160685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, Krinkle, Reedy, jeblad, Aklapper, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Salgo60, Zppix, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, faidon, Matanya, Mbch331, Rxy, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle closed this task as "Resolved".Krinkle added a comment. @Jonas Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, KrinkleCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle added a subscriber: Jonas.Krinkle added a comment. In T158941#3083796, @gerritbot wrote: Change 323445 merged by jenkins-bot: [mediawiki/extensions/Wikibase] Don't assume synchronous jQuery.Deferred in QUnit tests https://gerrit.wikimedia.org/r/323445 @Lydia_Pintscher @Jonas Per my comment on Gerrit, this patch was not finished. Please ensure the other tests are migrated as well. You can test locally by checking out https://gerrit.wikimedia.org/r/#/c/322812/ in your MediaWiki install and run the Wikibase test suite to observe the failures. Essentially just needs the same patterns in that patch applied to the remaining tests. This is blocking the migration to jQuery 3.0.TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, enigmaeth, rohitt, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, KrinkleCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, QZanden, enigmaeth, rohitt, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T158941: Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Krinkle added a comment. In T158941#3149925, @gerritbot wrote: Change 344405 merged by Hoo man: [mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async() https://gerrit.wikimedia.org/r/344405 In T158941#3158377, @Jdforrester-WMF wrote: What's outstanding here? From commenets on https://gerrit.wikimedia.org/r/344405: @Jonas wrote: @Krinkle this is what you need for all Wikibase tests right? @Krinkle wrote: LGTM, but there are a few more failures remaining still at https://gerrit.wikimedia.org/r/#/c/322812/ 11 FAILURES: wikibase.entityChangers.EntityTermsChanger save performs correct API calls for new label ..8 similar failures wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call FAILED wikibase.entityChangers.SiteLinkSetsChanger save performs correct API call for removal FAILED @Jonas wrote: I just wanted to check if that is the fix you need, before I fix all the places needed [..] So, similar to the first patch, this converted a few tests but there are still a handful left using the unsupported format. FAILED TESTS: wikibase.entityChangers.EntityTermsChanger ✖ save performs correct API calls for new label failed, expected argument to be truthy, was: false ✖ save performs correct API calls for changed label failed, expected argument to be truthy, was: false ✖ save performs correct API calls for removed label failed, expected argument to be truthy, was: false ✖ save performs correct API calls for new description failed, expected argument to be truthy, was: false ✖ save performs correct API calls for changed description failed, expected argument to be truthy, was: false ✖ save performs correct API calls for removed description failed, expected argument to be truthy, was: false ✖ save performs correct API calls for new aliases failed, expected argument to be truthy, was: false ✖ save performs correct API calls for changed aliases failed, expected argument to be truthy, was: false ✖ save performs correct API calls for removed aliases failed, expected argument to be truthy, was: false wikibase.entityChangers.SiteLinkSetsChanger ✖ save performs correct API call failed, expected argument to be truthy, was: false ✖ save performs correct API call for removal failed, expected argument to be truthy, was: false jquery.wikibase.entitytermsforlanguagelistview ✖ Create & destroy afterEach failed on Create & destroy: Unfinished animations: 2 Error: Unfinished animations: 2 ✖ setError() afterEach failed on setError(): Unfinished animations: 2 Error: Unfinished animations: 2TASK DETAILhttps://phabricator.wikimedia.org/T158941EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, KrinkleCc: Jdforrester-WMF, thiemowmde, Jonas, Lydia_Pintscher, gerritbot, Aklapper, Krinkle, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, Salgo60, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle added a subtask: T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope". TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle added a subtask: T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle added a parent task: T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle removed projects: Wikidata-Sprint, Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
Krinkle added a parent task: T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle added a subtask: T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
Krinkle added a parent task: T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope". TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle edited projects, added Regression; removed Traffic. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Jrbranaa, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T126596: During update.php (and install), add an entry in the sites table / SiteStore for the local wiki
Krinkle closed this task as "Resolved".Krinkle claimed this task.Krinkle added a comment. Per T153729: CI tests throw warning "Cannot find site mywiki in sites table"TASK DETAILhttps://phabricator.wikimedia.org/T126596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, daniel, JanZerebecki, Aklapper, aude, StudiesWorld, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T121083: Cannot find site jenkins_u3_mw
Krinkle closed subtask T126596: During update.php (and install), add an entry in the sites table / SiteStore for the local wiki as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T121083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, Jay8g, TerraCodes, Tgr, demon, Paladox, Bene, daniel, Krinkle, thiemowmde, gerritbot, aude, hoo, JanZerebecki, Lydia_Pintscher, Aklapper, StudiesWorld, santhosh, Amire80, KartikMistry, Nikerabbit, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T153729: CI tests throw warning "Cannot find site mywiki in sites table"
Krinkle closed subtask T126596: During update.php (and install), add an entry in the sites table / SiteStore for the local wiki as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T153729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, KrinkleCc: Tobi_WMDE_SW, KartikMistry, Amire80, santhosh, StudiesWorld, JanZerebecki, hoo, aude, Bene, demon, hashar, daniel, Lydia_Pintscher, thiemowmde, Nikerabbit, TerraCodes, Jay8g, gerritbot, Paladox, Aklapper, Tgr, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173222: Create wmf.13 branch for Wikidata extension
Krinkle created this task.Krinkle added projects: Wikidata, Regression.Herald added subscribers: PokestarFan, Aklapper. TASK DESCRIPTIONCommits backported for MediaWiki core wmf.13, or any other extension, are failing consistently in Jenkins with the following error: [efc43edb347f32d9a3043181] [no req] Wikimedia\Rdbms\DBQueryError from line 1145 of /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 00:03:29.553 Query: TRUNCATE TABLE `unittest_ip_changes` 00:03:29.553 Function: MediaWikiTestCase::resetDB 00:03:29.554 Error: 1146 Table 'jenkins_u0_mw.unittest_ip_changes' doesn't exist (127.0.0.1:3306) 00:03:29.554 00:03:29.554 Backtrace: 00:03:29.554 #0 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/libs/rdbms/database/Database.php(975): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean) 00:03:29.554 #1 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php(1323): Wikimedia\Rdbms\Database->query(string, string) I believe this is triggered by unit tests form the Wikidata extension. At first that seems fine (the table was recently added to MediaWiki core master, and Wikidata master uses it). The problem is that when submitting commits for wmf.13 branches of mediawiki-core or any deployed extension, the build fails because Wikidata does not have a wmf.13 branch, so Zuul falls back to checking out the master branch instead - which then fails because it's using tables that don't exist in core wmf.13. This is among the reasons all deployed extensions should be branched every week from master so that it contains a saved snapshot that is compatible (even if we maybe don't end up using the branch some weeks).TASK DETAILhttps://phabricator.wikimedia.org/T173222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, hoo, WMDE-leszek, aude, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, Jrbranaa, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T173222: Create wmf.13 branch for Wikidata extension
Krinkle triaged this task as "Unbreak Now!" priority.Krinkle added a subscriber: daniel.Krinkle added a comment.Herald added subscribers: Liuxinyu970226, Jay8g, TerraCodes. Marking UBN per @daniel.TASK DETAILhttps://phabricator.wikimedia.org/T173222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Jay8g, Liuxinyu970226, daniel, Addshore, hoo, WMDE-leszek, aude, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, Jrbranaa, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173222: Create wmf.13 branch for Wikidata extension
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...This is among the reasons all deployed extensions should be branched every week from master so that it contains a saved snapshot that is compatible (even if we maybe don't end up using the branch some weeks). Please create a wmf.13 branch for Wikidata, so that SWAT and other deployments can continue without needing to bypass Jenkins build failures.TASK DETAILhttps://phabricator.wikimedia.org/T173222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Jay8g, Liuxinyu970226, daniel, Addshore, hoo, WMDE-leszek, aude, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, Jrbranaa, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T153729: CI tests throw warning "Cannot find site mywiki in sites table"
Krinkle closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T153729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, KrinkleCc: Tobi_WMDE_SW, KartikMistry, Amire80, santhosh, StudiesWorld, JanZerebecki, hoo, aude, Bene, demon, hashar, daniel, Lydia_Pintscher, thiemowmde, Nikerabbit, TerraCodes, Jay8g, gerritbot, Paladox, Aklapper, Tgr, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle added a parent task: T168050: MW 1.30.0-wmf.10 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle created this task.Krinkle added projects: Wikimedia-log-errors, MediaWiki-extensions-WikibaseClient.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONStarted with wmf.10. Presumably caused by https://gerrit.wikimedia.org/r/364094 / rEWBA24d45d6d0cfc: Wait for replication after adding RC entries in WikiPageUpdater
Logstash:
https://logstash.wikimedia.org/goto/78333176c796825764e0d0c34ab43815
F8808868: Screen Shot 2017-07-21 at 19.27.46.png
Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: Wikibase\Client\Changes\WikiPageUpdater::injectRCRecords does not have outer scope.
#0 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/WikiPageUpdater.php(161): Wikimedia\Rdbms\LBFactory->getEmptyTransactionTicket()
#1 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(250): Wikibase\Client\Changes\WikiPageUpdater->injectRCRecords()
#2 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(169): Wikibase\Client\Changes\ChangeHandler->applyUpdateAction()
#3 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(137): Wikibase\Client\Changes\ChangeHandler->handleChange()
#4 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/ChangeNotificationJob.php(99): Wikibase\Client\Changes\ChangeHandler->handleChanges()
#5 /srv/mediawiki/php-1.30.0-wmf.10/includes/jobqueue/JobRunner.php(293): Wikibase\Client\ChangeNotificationJob->run()
#6 /srv/mediawiki/php-1.30.0-wmf.10/includes/jobqueue/JobRunner.php(193): JobRunner->executeJob()
#7 /srv/mediawiki/rpc/RunJobs.php(47): JobRunner->run()
#8 {main}
See also:
T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis.
TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...8333176c796825764e0d0c34ab4381509280746172b68115f62db346b06201>...TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle added a comment.Herald added a subscriber: PokestarFan.
In T164173#3435975, @gerritbot wrote:
Change 364094 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wait for replication after adding RC entries in WikiPageUpdater
https://gerrit.wikimedia.org/r/364094
@daniel @Ladsgroup This caused an error spike in Logstash:
https://logstash.wikimedia.org/goto/78333176c796825764e0d0c34ab43815
F8808868: Screen Shot 2017-07-21 at 19.27.46.png
Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: Wikibase\Client\Changes\WikiPageUpdater::injectRCRecords does not have outer scope.
#0 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/WikiPageUpdater.php(161): Wikimedia\Rdbms\LBFactory->getEmptyTransactionTicket()
#1 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(250): Wikibase\Client\Changes\WikiPageUpdater->injectRCRecords()
#2 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(169): Wikibase\Client\Changes\ChangeHandler->applyUpdateAction()
#3 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/ChangeHandler.php(137): Wikibase\Client\Changes\ChangeHandler->handleChange()
#4 /srv/mediawiki/php-1.30.0-wmf.10/extensions/Wikidata/extensions/Wikibase/client/includes/ChangeNotificationJob.php(99): Wikibase\Client\Changes\ChangeHandler->handleChanges()
#5 /srv/mediawiki/php-1.30.0-wmf.10/includes/jobqueue/JobRunner.php(293): Wikibase\Client\ChangeNotificationJob->run()
#6 /srv/mediawiki/php-1.30.0-wmf.10/includes/jobqueue/JobRunner.php(193): JobRunner->executeJob()
#7 /srv/mediawiki/rpc/RunJobs.php(47): JobRunner->run()
#8 {main}TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Minhnv-2809, Zppix, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code
Krinkle added a comment. Per https://gerrit.wikimedia.org/r/#/c/356121/, a good starting point would be to move the (new) HttpAcceptNegotiator and HttpAcceptParser classes to a Packagist-published PHP library. We can later consider moving other classes to it as well (such as Http::request, MWHttpRequest, and MultiHttpClient).TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, GoranSMilovanovic, DFelten, QZanden, HakanIST, Abbe98, Hannolans, Samwilson, Izno, Wikidata-bugs, aude, fbstj, Tpt, Mbch331, bd808___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T110022: Create a library with HTTP related functions/code
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONTo be considered: * * (includes/httpttp) `Http`, `MWHttpRequest`, `CurlHttpRequest` * (libs) HttpAcceptParser, HttpAcceptNegotiator * (libs) MultiHttpClient...TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, GoranSMilovanovic, DFelten, QZanden, HakanIST, Abbe98, Hannolans, Samwilson, Izno, Wikidata-bugs, aude, fbstj, Tpt, Mbch331, bd808___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T171667: Mirror wikibase/wikiba.se from Gerrit to Diffusion
Krinkle renamed this task from "Mirror wikibase/wikiba.se in diffusion" to "Mirror wikibase/wikiba.se from Gerrit to Diffusion". TASK DETAILhttps://phabricator.wikimedia.org/T171667EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: demon, Aklapper, Ladsgroup, PokestarFan, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, aude, zeljkofilipin, Mbch331, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle added a subscriber: demon.Krinkle added a comment. In T171370#3476108, @gerritbot wrote: Change 367328 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move injection of RC records to a separate job. https://gerrit.wikimedia.org/r/367328 At https://gerrit.wikimedia.org/r/367328, @demon wrote: Where do we need to cherry-pick this to so we can get it live? I see wmf.7 is the current Wikidata branch. In T171370#3479130, @gerritbot wrote: Change 368224 merged by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.10] Move injection of RC records to a separate job. https://gerrit.wikimedia.org/r/368224 The Wikibase extension isn't deployed. The Wikidata extension is, which needs to be rebuild in the wmf.10 branch (or something?) for it to take effect. And the wmf.10 branch in mediawiki would need to be updated to point to it. I don't see it yet at: https://github.com/wikimedia/mediawiki-extensions-Wikidata/tree/wmf/1.30.0-wmf.10/extensions/Wikibase/client/includes/Changes Current Wikidata commit in wmf.10 of mediawiki-core: 41db3da4c Also not at https://github.com/wikimedia/mediawiki-extensions-Wikidata/tree/41db3da4c/extensions/Wikibase/client/includes/Changes.TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle lowered the priority of this task from "Unbreak Now!" to "High". TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170668: "Unknown dependency: wikibase.mobile" on Wikidata element pages
Krinkle added a comment. In T170668#3457783, @Zache wrote: I raised the priority to high because this prevents the editing of the wikidata if bug hits before property edit buttons are added. The console warning Unknown dependency: wikibase.mobile may've looked like a fatal error (including stack trace), but I'm fairly sure it will not have caused edit buttons to not appear or any other sort of cascading failure. This error is an internal exception that is caught and logged to the console without affecting the loading of any other modules. The warning was recently introduced (previously it would be silently caught without logging). Given it looked new, that may've been why you associated the edit-button bug with this warning (but more likely being a "red herring"). This was a non-fatal error with no on-page impact. The commit that fixes the warning did so by not loading the module (meaning, same effective behaviour as before, but without the warning). As such, it seems unnecessary to have invalidated the entire parser cache on wikidata.org just to avoid a no-op warning from showing up in browser consoles to logged-in users for a few more days (whilst naturally rolling over the cache).TASK DETAILhttps://phabricator.wikimedia.org/T170668EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Krinkle, Lucas_Werkmeister_WMDE, aude, Jay8g, TerraCodes, Magnus, Ptolusque, Lea_Lacroix_WMDE, hoo, Ladsgroup, Lydia_Pintscher, Multichill, Sannita, Jdlrobson, Pigsonthewing, Liuxinyu970226, gerritbot, PokestarFan, Nikki, Zache, Fomafix, Aklapper, Danmichaelo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T113665: SitesModuleWorker::getSitesHash() is slow
Krinkle edited projects, added Performance-Team; removed Performance. TASK DETAILhttps://phabricator.wikimedia.org/T113665EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: gerritbot, adrianheine, Krenair, MaxSem, JeroenDeDauw, daniel, hoo, aude, ori, Aklapper, GoranSMilovanovic, QZanden, Vali.matei, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169429: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"
Krinkle added a comment.
Logstash shows 4 entries for that request id (WVeQXQpAIDMAAEhLwjIL). All recorded with the same timestamp.
DBQuery (WARNING)
Wikimedia\Rdbms\Database::query: lost connection to 10.64.16.15; reconnected:
#0 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(2903): Wikimedia\Rdbms\Database->query()
#1 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(2879): Wikimedia\Rdbms\Database->doCommit()
#2 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(756): Wikimedia\Rdbms\Database->commit()
#3 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1084): Wikimedia\Rdbms\Database->close()
#4 (): Closure$Wikimedia\Rdbms\LoadBalancer::closeAll()
#5 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1485): call_user_func_array()
#6 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1085): Wikimedia\Rdbms\LoadBalancer->forEachOpenConnection()
#7 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1076): Wikimedia\Rdbms\LoadBalancer->closeAll()
#8 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1665): Wikimedia\Rdbms\LoadBalancer->disable()
#9 (): Wikimedia\Rdbms\LoadBalancer->__destruct()
#10 {main}
exception (ERROR)
A database query error has occurred.
Query:
SELECT rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_user_text,rev_user,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,rev_content_format,rev_content_model,user_name,page_namespace,page_title,page_is_new,page_latest,page_is_redirect,page_len,(SELECT GROUP_CONCAT(ct_tag SEPARATOR ',') FROM `change_tag`WHERE ct_rev_id=rev_id ) AS `ts_tags`,ores_damaging_cls.oresc_probability AS `ores_damaging_score`,### AS `ores_damaging_threshold` FROM `revision` FORCE INDEX (user_timestamp) INNER JOIN `page` ON ((page_id = rev_page)) LEFT JOIN `user` ON ((rev_user != 0) AND (user_id = rev_user)) LEFT JOIN `ores_model` `ores_damaging_mdl` ON (ores_damaging_mdl.oresm_is_current = # AND ores_damaging_mdl.oresm_name = 'damaging') LEFT JOIN `ores_classification` `ores_damaging_cls` ON ((ores_damaging_cls.oresc_model = ores_damaging_mdl.oresm_id) AND (rev_id = ores_damaging_cls.oresc_rev) AND ores_damaging_cls.oresc_class = #) WHERE rev_user = ### AND (page_namespace = #) AND ((rev_deleted & #) = 0) ORDER BY rev_timestamp DESC LIMIT 51
Function:
IndexPager::buildQueryInfo (contributions page filtered for namespace or RevisionDeleted edits)
Error:
2062 Read timeout is reached (10.64.16.15)
#0 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(975): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#1 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(1339): Wikimedia\Rdbms\Database->query(string, string)
#2 /srv/mediawiki/php-1.30.0-wmf.7/includes/specials/pagers/ContribsPager.php(141): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#3 /srv/mediawiki/php-1.30.0-wmf.7/includes/pager/IndexPager.php(225): ContribsPager->reallyDoQuery(string, integer, boolean)
#4 /srv/mediawiki/php-1.30.0-wmf.7/includes/pager/IndexPager.php(557): IndexPager->doQuery()
#5 /srv/mediawiki/php-1.30.0-wmf.7/includes/specials/SpecialContributions.php(212): IndexPager->getNumRows()
#6 /srv/mediawiki/php-1.30.0-wmf.7/includes/specialpage/SpecialPage.php(522): SpecialContributions->execute(NULL)
#7 /srv/mediawiki/php-1.30.0-wmf.7/includes/specialpage/SpecialPageFactory.php(579): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.30.0-wmf.7/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.30.0-wmf.7/includes/MediaWiki.php(862): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.30.0-wmf.7/includes/MediaWiki.php(523): MediaWiki->main()
#11 /srv/mediawiki/php-1.30.0-wmf.7/index.php(43): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}
DBQuery (ERROR)
UndexPager::buildQueryInfo (contributions page filtered for namespace or RevisionDeleted edits) 10.64.16.15 2062 Read timeout is reached (10.64.16.15) SELECT rev_id ...
DBPerformance (INFO)
Expectation (readQueryTime <= 5) by MediaWiki::main not met (actual: 60.057598829269):
query: SELECT rev_id,rev_page,rev_text_id,... [TRX#43776f]
#0 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/TransactionProfiler.php(222): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated()
#1 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(1033): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion()
#2 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdbms/database/Database.php(933): Wikimedia\Rdbms\Database->doProfiledQuery()
#3 /srv/mediawiki/php-1.30.0-wmf.7/includes/libs/rdb
[Wikidata-bugs] [Maniphest] [Updated] T169429: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"
Krinkle added a project: MediaWiki-extensions-ORES.Herald added a project: Scoring-platform-team-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T169429EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, Josve05a, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Alchimista, Ladsgroup, Mbch331, Jay8g, Krenair, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T169023: Remove left-over alias for wikidata.org/ontology (doesn't work)
Krinkle renamed this task from "Wikibase ontology url: wikiba.se or wikidata.org?" to "Remove left-over alias for wikidata.org/ontology (doesn't work)". TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, JeroenDeDauw, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle created this task.Krinkle added projects: Wikidata, Wikibase-Internal-Serialization, Operations.Herald added a subscriber: Aklapper. TASK DESCRIPTIONI noticed the following Apache config in production: https://github.com/wikimedia/puppet/blob/7ac5f9a959924a6b51625b713e95c44ed7560ee8/modules/mediawiki/files/apache/sites/main.conf#L90 wikidata.org Apache configAlias /wiki /srv/mediawiki/docroot/wikidata.org/w/index.php Alias /ontology /srv/mediawiki/docroot/wikidata.org/w/extensions/Wikibase/docs/ontology.owl This alias doesn't actually work because Wikibase isn't installed in production, instead it comes as part of Wikidata (extensions/Wikidata/extensions/Wikibase). This is presumably a left-over from an early beta from before that was changed. 404 Not Foundhttps://www.wikidata.org/ontology https://www.wikidata.org/w/extensions/Wikibase/docs/ontology.owl The correct url destination would be https://www.wikidata.org/w/extensions/Wikidata/extensions/Wikibase/docs/ontology.owl, however that doesn't work either because owl is not a whitelisted file-type. Looking further it seems that most references to this concept in XML files actually use http://wikiba.se/ontology not wikidata.org, although there are a few references to http://www.wikidata.org/ontology on the web. Has the canonical url moved to wikiba.se? Is this a left-over that should be removed? TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* Is this a left-over that should be removed?
See also:
* {T166299}TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle added a comment. ChangeNotificationJob https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/6cfd514ee9/client/includes/ChangeNotificationJob.php#L99 ChangeHandler::handleChanges() -> handleChange() -> applyUpdateAction() ChangeHandler::applyUpdateAction(): One of: purgeParserCache(), purgeWebCache(), scheduleRefreshLinks(), or injectRCRecords(). Defined at https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/6cfd514ee99/client/includes/Changes/WikiPageUpdater.php#L74-L147 PageUpdater::purgeParserCache() -> foreach titles: Title::invalidateCache() PageUpdater::purgeWebCache() -> foreach titles: Title::purgeSquid() PageUpdater::scheduleRefreshLinks() -> foreach titles: JobQueueGroup->push( new RefreshLinksJob ) PageUpdater::injectRCRecords() -> foreach titles: Recentchange::save() Both the recentchanges INSERT and the page.page_touched UPDATE queries come from this job.TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle raised the priority of this task from "Normal" to "High". TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T169638: Option to Show and Hide Wikidata edits on RecentChanges is not working according to user or wiki preferences
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs a new user or a logged out user, when I go to RecentChanges page, I can click on a "show Wikidata edits". If I select it, I don't see Wikidata edits. It is confusing.
See also:
* {T169108}TASK DETAILhttps://phabricator.wikimedia.org/T169638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Trizek-WMF, Aklapper, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
