[Wikidata-bugs] [Maniphest] [Changed Project Column] T189329: jquery.wikibasea qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Krinkle
Krinkle moved this task from Resolved to Backlog on the Wikimedia-log-errors (Jenkins Failure) board.Krinkle added a comment. Still happening for jquery.wikibase.sitelinkview ✖ Create and destroy afterEach failed on Create and destroy: Pending AJAX requests: 0 (active: 3)TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Retitled] T189329: jquery.wikibasea qunit tests are flaky (Pending Ajax requests)

2018-05-02 Thread Krinkle
Krinkle renamed this task from "jquery.wikibase.edittoolbar and other qunit tests are flaky" to "jquery.wikibasea qunit tests are flaky (Pending Ajax requests)".Krinkle removed a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)). TASK DETAILhttps://phabr

[Wikidata-bugs] [Maniphest] [Updated] T120847: Use BCP 47 conform language codes for the HTML attribute lang

2018-04-20 Thread Krinkle
Krinkle removed a parent task: T2209: HTML validity (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T120847EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, Aklapper, Fomafix, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Closed] T173850: Possible PHP7 compatibility issues in WMF-deployed extensions

2018-04-18 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Smalyshev, Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie

[Wikidata-bugs] [Maniphest] [Updated] T189762: selenium test for Wikibase is unstable

2018-04-18 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Tgr, Jonas, WMDE-leszek, gerritbot, hoo, greg

[Wikidata-bugs] [Maniphest] [Edited] T189538: Reduce complexity of Wikibase JS module registration

2018-04-16 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* [x] / {3d15500abeda855e1a19155c4b159e97dbb401b9} * [ * [x] / {e9b71a058b24} * [ ] ...TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T189762: selenium test for Wikibase is unstable

2018-04-12 Thread Krinkle
Krinkle edited projects, added Wikimedia-log-errors (Jenkins Failure); removed MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)). TASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc

[Wikidata-bugs] [Maniphest] [Triaged] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2018-04-10 Thread Krinkle
Krinkle triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T122520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Aklapper, Krenair, StudiesWorld, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Updated] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2018-04-10 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors. TASK DETAILhttps://phabricator.wikimedia.org/T122520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Aklapper, Krenair, StudiesWorld, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata

[Wikidata-bugs] [Maniphest] [Updated] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2018-04-10 Thread Krinkle
Krinkle added a project: MediaWiki-extensions-WikibaseClient. TASK DETAILhttps://phabricator.wikimedia.org/T122520EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Aklapper, Krenair, StudiesWorld, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T165300: [Task] Drop PHP 5.3 and 5.4 support in all Wikidata code repositories

2018-04-10 Thread Krinkle
Krinkle removed a parent task: T172165: Require either PHP 7.0+ or HHVM in MW 1.31. TASK DETAILhttps://phabricator.wikimedia.org/T165300EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: Tobi_WMDE_SW, Lydia_Pintscher, hoo, aude, WMDE

[Wikidata-bugs] [Maniphest] [Edited] T189538: Reduce complexity of Wikibase JS module registration

2018-04-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION#patch-for-review: * [x] / {af6d8e1e97a74b4} * [x] / {3d15500abeda855e1a19155c4b159e97dbb401b9} * [ ] * [ ] --- Looking at flame graphs and overall code complexity, there's quite a bit of complexity in how

[Wikidata-bugs] [Maniphest] [Closed] T184638: Identify uses of Zend PHP5 in Wikimedia production

2018-04-09 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T184638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Imarlier, KrinkleCc: WMDE-leszek, Ladsgroup, thiemowmde, Jonas, hoo, Lydia_Pintscher, Reedy, Imarlier, Akla

[Wikidata-bugs] [Maniphest] [Retitled] T184638: Identify uses of Zend PHP5 in Wikimedia production

2018-04-09 Thread Krinkle
Krinkle renamed this task from "Remove dependency on Zend PHP5 in Wikimedia production" to "Identify uses of Zend PHP5 in Wikimedia production".Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION* {icon check color=green} mwscript: {T146285}

[Wikidata-bugs] [Maniphest] [Updated] T184638: Identify uses of Zend PHP5 in Wikimedia production

2018-04-09 Thread Krinkle
Krinkle added a parent task: T172165: Require either PHP 7.0+ or HHVM in MW 1.31. TASK DETAILhttps://phabricator.wikimedia.org/T184638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Imarlier, KrinkleCc: WMDE-leszek, Ladsgroup, thiemowmde, Jonas, hoo

[Wikidata-bugs] [Maniphest] [Retitled] T184638: Remove dependency on Zend PHP5 in Wikimedia production

2018-04-09 Thread Krinkle
Krinkle renamed this task from "Identify things that require Zend PHP5" to "Remove dependency on Zend PHP5 in Wikimedia production".Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION* {icon check color=green} mwscript: {T146285}, used to b

[Wikidata-bugs] [Maniphest] [Edited] T110022: Create a library with HTTP related functions/code

2018-04-02 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* (libs) MultiHttpClient * (libs) HttpStatus ...TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Dereckson

[Wikidata-bugs] [Maniphest] [Updated] T189596: Run deleteAutopatrolLogs script for Wikidata (WMF)

2018-03-26 Thread Krinkle
Krinkle edited projects, added Wikimedia-maintenance-script-run, Wikidata; removed DBA, MediaWiki-Patrolling, MediaWiki-Logging. TASK DETAILhttps://phabricator.wikimedia.org/T189596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-22 Thread Krinkle
Krinkle added a comment. In T189329#4074806, @Huji wrote: I assume the failed test on PS1 of https://gerrit.wikimedia.org/r/#/c/421468/ is the same issue, right? No, this task is about a flaky QUnit _javascript_ Test from Wikibase’s editor. The failure on your Gerrit change is from HHVM

[Wikidata-bugs] [Maniphest] [Closed] T155043: "Don't initialize MWServices super early" causes test failure on .7

2018-03-19 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a project: Wikimedia-log-errors (Jenkins Failure).Krinkle claimed this task.Krinkle added a comment. Seems resolved. Re-open if it pops back.TASK DETAILhttps://phabricator.wikimedia.org/T155043EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Merged] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a subscriber: Tgr.Krinkle merged a task: T186286: Wikibase selenium test is flaky. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse

[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure). TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle closed this task as a duplicate of T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky. TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure). TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T189538WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-15 Thread Krinkle
Krinkle added a comment. It's been a week. I think it's fair to expect the following at this point: Wikibase has 24 hours to either fix or disable the offending QUnit test(s). Alternatively, Wikibase will be removed from the extension gate sometime tomorrow. The small amount of code coverage loss

[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

2018-03-13 Thread Krinkle
Krinkle added a comment. @thiemowmde Sounds like a good point to start. I won't press on the file reduction for now. I've published three patches to start the conversation. Feel free to take over at any moment as you see fit, e.g. by amending or by forking to a different change-id and abandoning

[Wikidata-bugs] [Maniphest] [Created] T189538: Reduce complexity of Wikibase JS module registration

2018-03-12 Thread Krinkle
Krinkle created this task.Krinkle added projects: Wikibase-DataModel-_javascript_, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team.Herald added a subscriber: Aklapper. TASK DESCRIPTIONLooking at flame graphs and overall code complexity, there's quite a bit of complexity in how

[Wikidata-bugs] [Maniphest] [Edited] T188425: Investigate implementing T184485 (Disable autopatrol logging)

2018-02-27 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION{T184485} The Wikidata team is willing to pick this up as it has considerable storage implications for WikidataTASK DETAILhttps://phabricator.wikimedia.org/T188425EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Retitled] T188425: Investigate implementing T184485 (Disable autopatrol logging)

2018-02-27 Thread Krinkle
Krinkle renamed this task from "Investiagte implemenating T184485" to "Investigate implementing T184485 (Disable autopatrol logging)". TASK DETAILhttps://phabricator.wikimedia.org/T188425EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Updated] T49415: excessive autopatrol log entries on wikidata

2018-02-16 Thread Krinkle
Krinkle closed this task as a duplicate of T184485: Stop logging autopatrol actions. TASK DETAILhttps://phabricator.wikimedia.org/T49415EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: kaldari, Ricordisamoa, Wikidata-bugs, Jdforrester-WMF, Abraham

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2018-02-13 Thread Krinkle
Krinkle added a comment. In T173710#3966996, @Ladsgroup wrote: The jobqueue size [..] will go down more once we enable "lua fine grained usage tracking" and "statement fine grained usage tracking" in more wikis. Ref: T184322: Enable fine grained lua tracking gradually

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2018-02-12 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Jeff_G, Addshore, zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2018-02-12 Thread Krinkle
Krinkle removed projects: Discovery, CirrusSearch. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Jeff_G, Addshore, zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn

[Wikidata-bugs] [Maniphest] [Retitled] T173850: Possible PHP7 compatibility issues in WMF-deployed extensions

2018-02-08 Thread Krinkle
Krinkle renamed this task from "Possible WMF deployed extension PHP 7 issues" to "Possible PHP7 compatibility issues in WMF-deployed extensions". TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues

2018-02-08 Thread Krinkle
Krinkle added a parent task: T173786: Convert Wikimedia production HHVM instances to have hhvm.php7.all set true. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Smalyshev, Paladox, Ottomata

[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues

2018-02-08 Thread Krinkle
Krinkle removed a parent task: T173786: Convert Wikimedia production HHVM instances to have hhvm.php7.all set true. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Smalyshev, Paladox, Ottomata

[Wikidata-bugs] [Maniphest] [Updated] T105845: RFC: Page components / content widgets

2018-01-30 Thread Krinkle
Krinkle removed a parent task: T111588: RFC: API-driven web front-end. TASK DETAILhttps://phabricator.wikimedia.org/T105845EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: brion, leila, Reasno, SBisson, MZMcBride, Mholloway, RandomDSdevel, jmadler

[Wikidata-bugs] [Maniphest] [Retitled] T105845: RFC: Page components / content widgets

2018-01-30 Thread Krinkle
Krinkle renamed this task from "Page components / content widgets" to "RFC: Page components / content widgets". TASK DETAILhttps://phabricator.wikimedia.org/T105845EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: brion, le

[Wikidata-bugs] [Maniphest] [Edited] T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions)

2018-01-24 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONChecking the format constraint on a SPARQL query service### Problem Wikidata validates each newly stored statement against the constraints from the associated property. The properties themselves are user-generated

[Wikidata-bugs] [Maniphest] [Closed] T183101: Items missing from Wikidata index due to LinksUpdate lock failures

2018-01-16 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a comment. In T183101#3894373, @Smalyshev wrote: Unfortunately, I have no access to see T180918. (Access was fixed.) In T183101#3892382, @jcrespo wrote: Based on the comments, I highly suspect this is related to T180918

[Wikidata-bugs] [Maniphest] [Unblock] T46529: Wikidata search problems (tracking)

2018-01-16 Thread Krinkle
Krinkle closed subtask T183101: Items missing from Wikidata index due to LinksUpdate lock failures as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T46529EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Liuxinyu970226, P

[Wikidata-bugs] [Maniphest] [Updated] T170281: Raise PHP version requirement of Wikibase (and its related extensions) to 5.6

2018-01-10 Thread Krinkle
Krinkle removed a subtask: T178538: Bump PHP requirement to 5.6 in 1.31. TASK DETAILhttps://phabricator.wikimedia.org/T170281EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, Ricordisamoa, PokestarFan, thiemowmde, Reedy

[Wikidata-bugs] [Maniphest] [Edited] T107595: [RFC] Multi-Content Revisions

2018-01-10 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...For details, see **[[<https://www.mediawiki.org/wiki/Multi-Content_Revisions|the MCR design document on mediawiki.org]]**Requests_for_comment/Multi-Content_Revisions>**.TASK DETAILhttps://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Edited] T107595: [RFC] Multi-Content Revisions

2018-01-10 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...We currently do this for categories, infoboxes and template data. But embedding this in wikitext has downsides (TODO: which downsides). While it is possible to extract data via the Parser (as for categories

[Wikidata-bugs] [Maniphest] [Edited] T107595: [RFC] Multi-Content Revisions

2018-01-10 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION**(proposal rewritten 2016-09-05)**### Problem Storing information within the page revision content, has the following benefits: * Part of page history, comparable and reversible together with other related content

[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions

2018-01-10 Thread Krinkle
Krinkle removed projects: Wikidata-Sprint-2015-11-03, Wikidata-Sprint-2015-10-13, Wikidata-Sprint-2015-09-29. TASK DETAILhttps://phabricator.wikimedia.org/T107595EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: brion, KrinkleCc: Nirmos, CCicalese_WMF

[Wikidata-bugs] [Maniphest] [Updated] T76706: Design caching infrastructure for SiteStore

2018-01-03 Thread Krinkle
Krinkle removed a project: Architecture. TASK DETAILhttps://phabricator.wikimedia.org/T76706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tobi_WMDE_SW, Aklapper, daniel, Lahi, Gq86, Dfil7, Darkminds3113, Icedevil, GoranSMilovanovic, 45Jayjay1969

[Wikidata-bugs] [Maniphest] [Updated] T99088: [RFC] Evolving our content platform: Content adaptability, structured data and caching

2018-01-03 Thread Krinkle
Krinkle edited projects, added TechCom-RFC; removed RfC. TASK DETAILhttps://phabricator.wikimedia.org/T99088EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jmadler, Bianjiang, gpaumier, LikeLifer, Mholloway, MZMcBride, RobLa-WMF, StudiesWorld, Qgil

[Wikidata-bugs] [Maniphest] [Updated] T99088: [RFC] Evolving our content platform: Content adaptability, structured data and caching

2018-01-03 Thread Krinkle
Krinkle removed a project: Architecture. TASK DETAILhttps://phabricator.wikimedia.org/T99088EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jmadler, Bianjiang, gpaumier, LikeLifer, Mholloway, MZMcBride, RobLa-WMF, StudiesWorld, Qgil, Tgr

[Wikidata-bugs] [Maniphest] [Unblock] T124792: RFC: Service Locator for MediaWiki core

2018-01-03 Thread Krinkle
Krinkle closed subtask T132707: When resetting the global service locator, allow some resources to be "salvaged". as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T124792EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T114443: EventBus MVP

2018-01-03 Thread Krinkle
Krinkle moved this task from Under discussion to TechCom-Approved on the TechCom-RFC board.Krinkle edited projects, added TechCom-RFC (TechCom-Approved); removed TechCom-RFC. TASK DETAILhttps://phabricator.wikimedia.org/T114443WORKBOARDhttps://phabricator.wikimedia.org/project/board/52/EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T105845: Page components / content widgets

2017-12-21 Thread Krinkle
Krinkle removed projects: TechCom-Has-shepherd, RfC. TASK DETAILhttps://phabricator.wikimedia.org/T105845EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: leila, Reasno, SBisson, MZMcBride, Mholloway, RandomDSdevel, jmadler, Bianjiang, LikeLifer

[Wikidata-bugs] [Maniphest] [Updated] T107595: [RFC] Multi-Content Revisions

2017-12-21 Thread Krinkle
Krinkle removed projects: TechCom-Has-shepherd, RfC. TASK DETAILhttps://phabricator.wikimedia.org/T107595EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: brion, KrinkleCc: Nirmos, CCicalese_WMF, PokestarFan, Rical, Ayack, -jem-, Deskana, SBisson, Izno, Pppery

[Wikidata-bugs] [Maniphest] [Updated] T102476: RFC: Requirements for change propagation

2017-12-21 Thread Krinkle
Krinkle removed projects: TechCom-Has-shepherd, RfC. TASK DETAILhttps://phabricator.wikimedia.org/T102476EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MZMcBride, Mholloway, Liuxinyu970226, Scott_WUaS, Ottomata, Smalyshev, ArielGlenn, hoo

[Wikidata-bugs] [Maniphest] [Updated] T114251: [RFC] Magic Infobox implementation

2017-12-21 Thread Krinkle
Krinkle removed a project: RfC. TASK DETAILhttps://phabricator.wikimedia.org/T114251EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: PokestarFan, Edgars2007, RobLa-WMF, jeblad, Micru, FreedomFighterSparrow, jmadler, Trizek-WMF, Bianjiang

[Wikidata-bugs] [Maniphest] [Updated] T114454: [RFC] Visual Templates: Authoring templates with Visual Editor

2017-12-21 Thread Krinkle
Krinkle removed a project: RfC. TASK DETAILhttps://phabricator.wikimedia.org/T114454EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscott, KrinkleCc: srishakatux, Capt_Swing, Qgil, MZMcBride, jeblad, Physikerwelt, RobLa-WMF, StudiesWorld, Krenair

[Wikidata-bugs] [Maniphest] [Updated] T384: RfC: Dependency Injection for MediaWiki core

2017-12-21 Thread Krinkle
Krinkle removed a project: RfC. TASK DETAILhttps://phabricator.wikimedia.org/T384EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: He7d3r, ArielGlenn, Addshore, Izno, Glaisher, Ricordisamoa, RobLa-WMF, MZMcBride, Tgr, phuedx, GWicke

[Wikidata-bugs] [Maniphest] [Updated] T183101: Items missing from Wikidata index

2017-12-18 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aaron, Aklapper, EBernhardson, dcausse, Smalyshev, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-12-14 Thread Krinkle
Krinkle added a subscriber: Jeff_G.Krinkle merged a task: T178840: Commons category updates are very slow. Commons job queue very large.. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jeff_G

[Wikidata-bugs] [Maniphest] [Updated] T182322: ChronologyProtector breaks if two requests write different sets of databases

2017-12-11 Thread Krinkle
Krinkle edited projects, added MediaWiki-Database; removed MediaWiki-General-or-Unknown, Performance, Performance-Team-notice, Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T182322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore

[Wikidata-bugs] [Maniphest] [Updated] T178997: AddUsagesForPageJob doesn't really report execution status

2017-11-17 Thread Krinkle
Krinkle edited projects, added EventBus; removed MediaWiki-JobQueue.Herald added a project: Analytics. TASK DETAILhttps://phabricator.wikimedia.org/T178997EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, KrinkleCc: thiemowmde, gerritbot, daniel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T180727: WikibaseClient resources are broken in WMF

2017-11-16 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T180727WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes

2017-11-14 Thread Krinkle
Krinkle added a parent task: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7). TASK DETAILhttps://phabricator.wikimedia.org/T145819EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thcipriani, Anomie, aaron

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle added a commit: rEWBA081c1cd78f9d: Add cause action/agent tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house

[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/386636...TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-11-08 Thread Krinkle
Krinkle added a commit: rMW8f829de5f040: Add action/user tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt

[Wikidata-bugs] [Maniphest] [Changed Project Column] T89733: Allow ContentHandler to expose structured data to the search engine.

2017-11-03 Thread Krinkle
Krinkle moved this task from Backlog to Implemented on the TechCom-RfC (ArchCom-Approved) board.Krinkle removed projects: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), Patch

[Wikidata-bugs] [Maniphest] [Updated] T592: RfC: ChangesList formatting

2017-11-03 Thread Krinkle
Krinkle added projects: Wikidata, Edit-Review-Improvements-RC-Page.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T592EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, aude, daniel, Qgil

[Wikidata-bugs] [Maniphest] [Updated] T166703: [Architecture] reconsider wbeditentity

2017-10-26 Thread Krinkle
Krinkle removed a project: Architecture. TASK DETAILhttps://phabricator.wikimedia.org/T166703EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, daniel, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Closed] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-26 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a comment. Yep, this is resolved. It's no longer part of the trace for load.php. Thanks!. Before F10452052: Screen Shot 2017-10-26 at 17.30.04.pngF10452053: Screen Shot 2017-10-26 at 17.30.08.png After F10452054: Screen Shot

[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2017-10-23 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...We could reduce the number of HTMLCacheUpdateJobs posted by collecting pages to be notified over an entire batch of changes, such as the batch contained in a ChangeNotificationJob. This should be done in a way

[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2017-10-23 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONCurrently, we optimize for the case of a change triggering updates to many pages: we chop the set of pages into badgesbatches and push one HTMLCacheUpdateJob for each batchTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-11 Thread Krinkle
Krinkle added a comment. @thiemowmde The tests still fail with QUnit 2 at https://gerrit.wikimedia.org/r/#/c/367838/13. Failures come from data-values/value-view. In T177764#3674594, @gerritbot wrote: Change 383383 merged by jenkins-bot: [data-values/value-view@master] Remove QUnit.Parameterize

[Wikidata-bugs] [Maniphest] [Declined] T105638: RFC: Streamlining Composer usage

2017-10-11 Thread Krinkle
Krinkle closed this task as "Declined".Krinkle triaged this task as "Normal" priority.Krinkle added a comment. In T105638#3670708, @Addshore wrote: Personally I think out composer usage is rather streamlined right now Indeed. Our conventions around how Composer should

[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-10 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383363...TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot

[Wikidata-bugs] [Maniphest] [Updated] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-09 Thread Krinkle
Krinkle removed projects: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues

2017-10-09 Thread Krinkle
Krinkle removed a project: HHVM. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Edited] T173225: [Task] Tag releases of smaller Wikibase libraries significantly lagging behind

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] https://github.com/wmde/WikibaseSerializationJavaScript/pull/43 See also: * {T172916} * {T174922} * {T173818} * {T177087}TASK DETAILhttps://phabricator.wikimedia.org/T173225EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T177087: Make Wikibase-related JS libraries npm packages and include them as git submodules in Wikibase.git instead of installing as PHP libs using Composer

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION//This task executes the decision made at {T174922}// Libraries to consider:...TASK DETAILhttps://phabricator.wikimedia.org/T177087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible

2017-10-09 Thread Krinkle
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383117TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot

[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes

2017-10-06 Thread Krinkle
Krinkle removed a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**Change log statistics** || | ID | Timestamp |--|--|-- | Oldest | 373786394 | 19:45, 12 September 2016...| | Site | Position

[Wikidata-bugs] [Maniphest] [Commented On] T177414: Maintenance scripts exit with 0 when an (uncaught) exception is encountered

2017-10-06 Thread Krinkle
Krinkle added a comment. This explains why postgres was seemingly passing on Travis CI when in fact it was broken (again). BeforeAfter https://travis-ci.org/wikimedia/mediawiki/jobs/283426437https://travis-ci.org/wikimedia/mediawiki/jobs/283543802 F10039102: Screen Shot 2017-10-06 at 20.33.54

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-05 Thread Krinkle
Krinkle added a comment. @aude A week is fine. This isn't a regression from current week's branch.TASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, KrinkleCc: Lydia_Pintscher, gerritbot, hoo, aude

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-05 Thread Krinkle
Krinkle added a comment. In T177311#3659950, @gerritbot wrote: Change 382383 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Split Echo hook handlers based on services needed https://gerrit.wikimedia.org/r/382383 @aude Thanks for the quick patch! public static function

[Wikidata-bugs] [Maniphest] [Commented On] T177485: lost cursor focus in fields when adding property items

2017-10-05 Thread Krinkle
Krinkle added a comment. In T177485#3661914, @Sjoerddebruin wrote: Can this be some side-effect of T124742? The _javascript_ console is full of deprecated notices (pointing to the statement view as well). There were no official breaking changes in jQuery 3 that aren't covered by jQuery Migrate

[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-04 Thread Krinkle
Krinkle added a comment. The above flame graph is from HHVM profiling samples over 24 hours from production traffic. While useful to see the overall impact on average, it does not provide timings (due to being sampled). Here two profiles from XHGui for an individual request (including flamegraph

[Wikidata-bugs] [Maniphest] [Created] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase

2017-10-03 Thread Krinkle
Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTION/includes/WebStart.php EchoHooks::initEchoExtension (3.05%) Wikibase\Client\Hooks\EchoNotificationsHandlers

[Wikidata-bugs] [Maniphest] [Commented On] T175109: beta: Wikidata dispatchChanges.php causes a lot of "Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock"

2017-09-27 Thread Krinkle
Krinkle added a comment. Still happening. 750,000+ log entries in the last 30 days on Beta Cluster. Most are like: mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock '' or mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms

[Wikidata-bugs] [Maniphest] [Updated] T176312: Don’t check format constraint via SPARQL

2017-09-20 Thread Krinkle
Krinkle added a project: TechCom-RfC. TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lucas_Werkmeister_WMDE, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code

2017-09-19 Thread Krinkle
Krinkle added a comment. In T174922#3583384, @WMDE-leszek wrote: One concern with the Option 5 I could imagine is that the separation between those libs and the "core" Wikibase is drawn less strict than e.g. when those libs are only pulled in when "building" Wikibase &

[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment. In T163551#3612317, @Lydia_Pintscher wrote: That's definitely not how it should be. There should only ever be one description for a given item and language. Is this also caused by the duplicate rows? I'm not sure. I was gonna file a new task, but found this existing

[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms

2017-09-16 Thread Krinkle
Krinkle added a comment. When editing a page in VisualEditor, I sometimes notice that the description (from Wikidata's pageterms API) is duplicated. I results in the following rendering: F9586347: Screen Shot 2017-09-16 at 20.51.29.png The joining by a single comma also looks odd

[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop

2017-09-14 Thread Krinkle
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe

[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

2017-09-14 Thread Krinkle
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter

[Wikidata-bugs] [Maniphest] [Updated] T173696: Cache constraint check results

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173696#3584607, @Krinkle wrote: [..] why do we need to query an external service to execute a regular _expression_? In T173696#3584821, @Lucas_Werkmeister_WMDE wrote: Because checking arbitrary regexes on arbitrary input opens us up to DoS attacks via malicious

[Wikidata-bugs] [Maniphest] [Commented On] T173696: Cache constraint check results

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173696#3569491, @Ladsgroup wrote: Pinging @aaron and @Krinkle as they are the experts on this. I left a few minor points at https://gerrit.wikimedia.org/r/373918. I don't know much about the use of regular expressions in the particular context of Sparql

[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop

2017-09-06 Thread Krinkle
Krinkle added a comment. In T173710#3583445, @Joe wrote: As a side comment: this is one of the cases where I would've loved to have an elastic environment to run MediaWiki-related applications: I could've spun up 10 instances of jobrunner dedicated to refreshlinks (or, ideally, the system could

[Wikidata-bugs] [Maniphest] [Updated] T174422: Make dbBatchSize in WikiPageUpdater configurable

2017-09-04 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T174422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Aklapper, fgiunchedi, aaron, Krinkle, Jdforrester-WMF, WMDE-leszek, jcrespo, EBernhardson

[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code

2017-09-04 Thread Krinkle
Krinkle added a comment. Move all those libraries to Wikibase git repository pro: dependency problem goes away con: code provided by those libs is no longer versioned as now - all only work with current Wikibase master con: even more code in Wikibase.git con: no way for those libs to by used

<    4   5   6   7   8   9   10   11   12   >