Tarrow closed subtask T230896: Enable Termbox on wikidatawiki as
"Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T214899
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Lea_WMDE, darthmon_wmde, DannyS712, Nan
Tarrow added a project: Wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T231420
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Lydia_Pintscher, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana,
Lahi, Gq86
Tarrow added a comment.
> Tests that are not run by CI
Ah, that's the bit I was missing; I thought that Lexeme was in the gate.
From the patch:
>> @Jdforrester-WMF
>
> Lexeme's tests are too slow to add to the gate currently,
Tarrow added a comment.
I think I favour **option 1** assuming that the service we are planning to
implement is the Prometheus based one.
If we are actually planning on the SPARQL based on then I think **option 0**
could make more sense and defaulting to turned on with the option to
Tarrow lowered the priority of this task from "Unbreak Now!" to "Normal".
Tarrow added a comment.
Looks to me like this is no longer UBN.
Leaving the task open for investigation as to how we ended up with a broken
build. I'm still a little confused by the
Tarrow added a comment.
@Lea_Lacroix_WMDE @WMDE-leszek We have, after some delay (sorry), merged the
revert patch.
TASK DETAIL
https://phabricator.wikimedia.org/T230926
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: sarhan.alaa
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T230926
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: sarhan.alaa, Agusbou2015, Ladsgroup, Lea_Lacroix_WMDE, W
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
Tarrow added a comment.
Backport is now merged and testing on both test.wikidata.org and wikidata.org
seems to show this no longer happens.
TASK DETAIL
https://phabricator.wikimedia.org/T230937
EMAIL PREFERENC
Tarrow added a comment.
Looks like this bug always existed in our code but it became apparent with
the flipping on of termbox on Wikidata.
It appears to be caused when mobile users try to use Special:NewItem it
however isn't shown when testing mobile view on desktop with `usef
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T227459
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712, Nandana,
Tarrow closed subtask T227459: Config changes for test.wikidata.org deployment
as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T214902
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Aklapper, Lea_WMDE, dar
Tarrow created this task.
Tarrow added projects: Wikidata-Termbox, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
[ ] Latest version of the service deployed everywhere on k8s
[ ] Config change
[ ] Check working both CSR and SSR on mwdebug
[ ] Monitor load
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, WMDE-leszek, gerritbot,
Pablo-WMDE, Lydia_Pintscher
Tarrow added a comment.
Looks like that is partially true. I also missed that due to
extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:274
the language of the OutputPage is also always included even if it is not valid.
This is then used to generate the language for
Tarrow added a comment.
For the current desktop termbox it appears that we already check when
building the termbox with the user's language that all of those languages are
valid WikibaseContent languages:
Non-valid language are filtered out here:
extensions/Wikibase/repo/includes/
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, WMDE-leszek, gerritbot,
Pablo-WMDE, Lydia_Pintscher
Tarrow added a comment.
Great! That's what we thought in the room.
I guess there was and intention at task breakdown time of having other
subtasks of this? e.g. to remove invalid languages from all the places with can
think of if it doesn't come for free from what we do for te
Tarrow added a comment.
@WMDE-leszek just wanted to check that this story only applies to labels,
descriptions and aliases.
Or do we also need to do something for monolingual texts in invalid languages?
What about Lexemes or EntitySchemas?
TASK DETAIL
https
Tarrow claimed this task.
Tarrow added a comment.
Assigning this to myself. I'm just in the process of working out where we
should be making changes
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailprefer
Tarrow added a comment.
We just spoke in the office and it seems that the decision (as I heard it
from @WMDE-leszek and @Lea_WMDE) is to remove currently invalid language even
from historic revisions. We won't change the database but we will stop showing
any invalid language. e.g. fro
Tarrow added a comment.
This sounds like a good plan. To me we should be also running the php
linting/fixing at the same time in this case though.
TASK DETAIL
https://phabricator.wikimedia.org/T228734
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow added a project: Wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T224546
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Jdforrester-WMF, Liuxinyu970226, SBisson, Lucas_Werkmeister_WMDE,
Aklapper, alaa_wmde
Tarrow added a project: Lexicographical data.
TASK DETAIL
https://phabricator.wikimedia.org/T224546
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Jdforrester-WMF, Liuxinyu970226, SBisson, Lucas_Werkmeister_WMDE,
Aklapper
Tarrow claimed this task.
Tarrow added a comment.
Picking this up again. Will work on the existing patch;
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: WMDE-leszek, Addshore
Tarrow removed Tarrow as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T228634
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Aklapper, Jakob_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma,
0010318400, E.S.A
Tarrow removed Tarrow as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: WMDE-leszek, Addshore, Tarrow, Jakob_WMDE, Aklapper, Michael, Hook696,
Daryl-TTMG
Tarrow added a comment.
Had a call with @Addshore:
Conclusion is we should add it as a ParserOption because termbox being
enabled or not is an option that we set the affect the output of the parsed
page. We'd rather not just change the cache key because down the line we might
wa
Tarrow added a comment.
@Addshore: can you take a look at
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/526117/4 in
comparison to https://gerrit.wikimedia.org/r/526174
Do you have a preference? Specifically:
I was a little unsure of all the static calls to the
Tarrow added a comment.
In T228978#5375173 <https://phabricator.wikimedia.org/T228978#5375173>,
@Addshore wrote:
> Although #1 could en changed to register a new parser option called
wb-termbox for example, default value null, used in cache key and when termbox
is rendered se
Tarrow added a comment.
I think that would probably not work that well. We don't really want to
provide editors with a mixed old/new experience where they can edit some items
but not others.
I think we aren't too worried about the load from mobile pageviews so the
fact
Tarrow added a comment.
Just to clarify the two options we thoughts of are
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/526117/3 (not
2) and https://gerrit.wikimedia.org/r/526174
I.e
**1**
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/526117/3
Tarrow added a comment.
@Jakob_WMDE and I spent quite some time looking at it today. We came to the
following discoveries.
We attempted to add a new cache key:
We tried registering it in \Wikibase\RepoHooks::onParserOptionsRegister
and both adding the extra key to to ParserOptions
Tarrow created this task.
Tarrow added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Discovered when trying to debug the parsercache for termbox.
e.g.
default:pcache:idhash:2-0!userlang=en-gb!wb=3!responsiveimages=0
vs
Tarrow added a comment.
@Lea_WMDE It should be on beta now :)
TASK DETAIL
https://phabricator.wikimedia.org/T222890
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Pablo-WMDE, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hanna_Petruschat_WMDE
Tarrow added a comment.
I took the following extra details from figma:
- Height of the progress bar is always 20px
- From the two examples it appeared to be as close as possible to
horizontally and vertically centered so I did this
- box-shadow is added
- border colour is as
Tarrow added a comment.
This is now perfectly reproducible locally. ( We were caught out by
$wgInvalidateCacheOnLocalSettingsChange )
It appear to happen for the reasons we all expected. There is still an "old"
version of termbox in the ParserCache which ovbiously contains pl
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Jakob_WMDE, Aklapper, Michael, darthmon_wmde, DannyS712, Nandana,
Lahi, Gq86, GoranSMilovanovic
Tarrow added a comment.
> 2. When data load from the storage contains entries using a language code
that is not recognized by Wikibase, those entries must not be presented to the
user (e.g. for reason X there a label related to the invalid language code
stored in the DB,
I seem
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Jakob_WMDE, Aklapper, Michael, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic
Tarrow added a comment.
@Jakob_WMDE was unable to reproduce locally; toggling the UseSSR variable
always seemed to result in refreshing the cache
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Tarrow added a comment.
Copied information from the other task:
On page
[XTg6eQpAME0AAB7XveAC] 2019-07-24 11:01:13: Fatal exception of type
"RuntimeException"
From Logstash:
RuntimeException from line 62 of
/srv/mediawiki/php-1.34.0-wmf.15/extensions/Wikibase/rep
Tarrow added a comment.
Saw this suspiciously in the local logs:
(node:14471) UnhandledPromiseRejectionWarning: TypeError: err.getContext is
not a function
ssr_1| [1] at
termboxHandler.createTermboxRequest.then.then.then.catch
(/app/serverBuild/server/app.js:59:57
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T22
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Aklapper, Liuxinyu970226, Jakob_WMDE, darthmon_wmde, Nandana, Lahi,
Gq86, GoranSMilovanovic, QZanden
Tarrow renamed this task from "Attempt browser test" to "Attempt browser test
for error banner".
TASK DETAIL
https://phabricator.wikimedia.org/T228638
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Jakob
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
Tarrow added a comment.
This is now live
TASK DETAIL
https://phabricator.wikimedia.org/T214902
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Aklapper
Tarrow closed subtask T214902: Show mobile termbox on Wikidata test wiki as
"Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T214901
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Lea_WMDE, darthmon_wmd
Tarrow added a comment.
As far as I can see this is probably more a flapping test rather than a
failure due to lack of Vector.
Looks like the patch listed succeeded in being merged before the revert was
in place:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/524820
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T228634
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Jakob_WMDE, darthmon_wmde, Nandana, Sario528, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T222884
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Hanna_Petruschat_WMDE, Tarrow, Aklapper, Lea_WMDE, darthmon_wmde, Nandana,
Sario528, Lahi, Gq86
Tarrow edited projects, added Wikibase-Termbox-Iteration-20; removed
Wikidata-Termbox-Hike.
TASK DETAIL
https://phabricator.wikimedia.org/T222884
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Hanna_Petruschat_WMDE, Tarrow, Aklapper
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T222890
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, Hanna_Petruschat_WMDE, Tarrow,
Aklapper, Lea_WMDE, darthmon_wmde, Nandana
Tarrow added a comment.
Some debugging shows this also occurs in our blubber build step.
Normally not visible because the output is suppressed by npm. Can be seen by
manually altering the automatically added `npm install` to include `--loglevel
verbose`
This cannot be done in the
Tarrow edited projects, added Wikibase-Termbox-Iteration-20; removed
Wikidata-Termbox-Hike.
TASK DETAIL
https://phabricator.wikimedia.org/T227459
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Jakob_WMDE, darthmon_wmde, Nandana
Tarrow renamed this task from "Show progress/activity if a save request is
still being procesed" to "Show progress/activity if a save request is still
being processed".
Tarrow edited projects, added Wikibase-Termbox-Iteration-20; removed
Wikidata-Termbox-Hike.
Tarrow edited projects, added Wikibase-Termbox-Iteration-20; removed
Wikidata-Termbox-Hike.
TASK DETAIL
https://phabricator.wikimedia.org/T226081
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Matthias_Geisler_WMDE, Aklapper
Tarrow added a project: Wikibase-Termbox-Iteration-20.
TASK DETAIL
https://phabricator.wikimedia.org/T222886
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Tarrow
Cc: Hanna_Petruschat_WMDE, Tarrow, Aklapper, Lea_WMDE, darthmon_wmde
Tarrow closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T218081
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Tarrow
Cc: Jakob_WMDE, Lea_WMDE, Pablo-WMDE, Aklapper, Addshore, Tarrow,
Tarrow closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T226978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Tarrow
Cc: Pablo-WMDE, Aklapper, Jakob_WMDE, Daryl-TTMG, RomaAmorRoma, 0010318400,
E.
Tarrow closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T226627
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Tarrow
Cc: Tarrow, Aklapper, Jakob_WMDE, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSM
Tarrow closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T227069
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Tarrow
Cc: Aklapper, Jakob_WMDE, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovi
Tarrow added a comment.
@Hanna_Petruschat_WMDE On beta? I guess the easiest thing to do is probably:
1. Open a beta item on mobile and start editing.
2. (In chrome) Right click -> 'Inspect'
3. Select the 'Network' tab
4. Check 'offline' box
5. T
Tarrow added a comment.
We should check if this is needed in blubber or just in our local dev
environment.
See:
https://meet.google.com/linkredirect?authuser=0&dest=https%3A%2F%2Fgithub.com%2Fwikimedia%2Fservice-template-node%2Fblob%2Fmaster%2F.pipeline%2Fblubber.yaml
TASK DE
Tarrow closed subtask T221214: Change mediawiki container default password as
"Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T221213
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Tarrow, darthmon_wmd
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
Tarrow added a comment.
Done by:
https://github.com/wmde/wikibase-docker/commit/562e69bcd511d05ca8a96be4a2174a34eef64648
TASK DETAIL
https://phabricator.wikimedia.org/T221214
EMAIL PREFERENC
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
Tarrow added a comment.
Done by
https://github.com/wmde/wikibase-docker/commit/562e69bcd511d05ca8a96be4a2174a34eef64648
TASK DETAIL
https://phabricator.wikimedia.org/T221213
EMAIL PREFERENC
Tarrow added a comment.
@akosiaris Happy to say that were are now have code have sending out request
metrics form master.
In our investigation about going to test.wikidata.org it became apparent
there was a little more infrastructure stuff to do so I made: T226814
<ht
Tarrow added a subtask: T226814: Create termbox release for test.wikidata.org.
TASK DETAIL
https://phabricator.wikimedia.org/T212189
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Mholloway, RazShuty, sbassett, thcipriani, Tarrow
Tarrow moved this task from Peer Review to Done on the
Wikidata-Termbox-Iteration-19 board.
Tarrow added a comment.
looks done to me
TASK DETAIL
https://phabricator.wikimedia.org/T226627
WORKBOARD
https://phabricator.wikimedia.org/project/board/4150/
EMAIL PREFERENCES
https
Tarrow added a comment.
@akosiaris Yep; we've interpreted it as something we really need before
exposing it to real traffic. We've got a ticket open about it that we'll be
picking up real soon: T226625 <https://phabricator.wikimedia.org/T226625>
We're assu
Tarrow added a comment.
As per email from Lea to Jakob we should keep the external link sign present.
He says this is *probably* just adding a pad right to make it fit.
TASK DETAIL
https://phabricator.wikimedia.org/T221835
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
Tarrow added a comment.
@akosiaris Great! Thanks for that. We look forward to seeing how it all goes
forward post-offsite :)
TASK DETAIL
https://phabricator.wikimedia.org/T220402
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Krenair
Tarrow lowered the priority of this task from "Unbreak Now!" to "High".
Tarrow added a comment.
Downgraded to high since it seems the shared build is at least un-broken now
TASK DETAIL
https://phabricator.wikimedia.org/T224605
EMAIL PREFERENCES
https://phabricator.wi
Tarrow added a comment.
In T220402#5242902 <https://phabricator.wikimedia.org/T220402#5242902>,
@akosiaris wrote:
> Indeed this was fixed. However another regression has crept up it's head
This should now be fixed. Sadly this was due to a mismatch between the cod
Tarrow added a comment.
@akosiaris Thanks! Now
https://gerrit.wikimedia.org/r/c/wikibase/termbox/+/515040 is merged the
Healthcheck query should be correct :)
TASK DETAIL
https://phabricator.wikimedia.org/T220402
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T218081
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Lea_WMDE, Pablo-WMDE, Aklapper, Addshore, Tarrow, darthmon_wmde,
Premeditated, Nandana, Lahi, Gq86
Tarrow moved this task from Peer Review to Done on the
Wikidata-Termbox-Iteration-17 board.
Tarrow added a comment.
Looks like all the patches for this are already merged and thus done
TASK DETAIL
https://phabricator.wikimedia.org/T223542
WORKBOARD
https://phabricator.wikimedia.org
Tarrow closed subtask T215921: Configure helm chart as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T208381
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: WMDE-leszek, Addshore, Aklapper, Jakob_WMDE, Pablo-WMDE, dar
Tarrow closed this task as "Resolved".
Tarrow claimed this task.
Tarrow added a comment.
Looks like SRE did this for us as part of T220402
<https://phabricator.wikimedia.org/T220402> :)
TASK DETAIL
https://phabricator.wikimedia.org/T215921
EMAIL PRE
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T224489
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Tarrow, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden
Tarrow created this task.
Tarrow added projects: Wikidata-Termbox-Hike, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Change publish method to open license in all cases.
Proceed to save entity when save is clicked and hide modal.
Return to edit mode and
Tarrow created this task.
Tarrow added projects: Wikidata-Termbox-Hike, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Get all the messages that are required:
- Cancel
- Save
- Checkbox label text
Get "Pseudo Message" from `window.mw.
Tarrow added a comment.
@Lea_WMDE Just a heads up that in general this message is configurable on
mediawiki.
See for example: https://www.mediawiki.org/wiki/Manual:$wgRightsUrl. We
assume that we should take this into account. The most consistent way for us to
do this is to use the
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T221835
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE,
Matthias_Geisler_WMDE, Tarrow
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T221835
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE,
Matthias_Geisler_WMDE, Tarrow
Tarrow added a comment.
Moved to in prep in task breakdown because we decided it wasn't ready to
pick-up
TASK DETAIL
https://phabricator.wikimedia.org/T217770
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Add
Tarrow added a comment.
> In the worst case they change something else, the first edit went through,
and other people have edited the item in the meantime as well.
I understand the reasoning here. I was particularly thinking about the a
variant of this scenario: no one else has edi
Tarrow added a comment.
@mobrovac Thanks! I think we've now taken most of this onboard and merged it.
@akosiaris could you take a look at out new x-amples block and Host header?
Hopefully this meets our needs :).
You'll see there are now two new ENV variables: HEALTHCHECK
Tarrow added a comment.
@mobrovac and @akosiaris Sorry to drop in late to the conversation but I've
been on holiday and then at the hackathon. I wanted to check a couple of things:
In T220402#5186782 <https://phabricator.wikimedia.org/T220402#5186782>,
@mobrovac wrote:
Tarrow added a comment.
For the avoidance of confusion in order to make this work in the
Wikibase-Containers environment we'll need to add Scributo so that these kind
of templates work. For this there is a long standing task: T197649
<https://phabricator.wikimedia.org/T197649>
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T223959
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Aklapper, Tarrow, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden
Tarrow created this task.
Tarrow added a project: Wikibase-Containers.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
TASK DETAIL
https://phabricator.wikimedia.org/T223959
WORKBOARD
https://phabricator.wikimedia.org
Tarrow removed Tarrow as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T215913
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Tarrow, Danmichaelo, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde,
joker88john
Tarrow added a comment.
Thanks for digging into it so much. Seems perhaps somehow I wandered into a
very edge case set-up by mistake :(. As I mentioned I only found it by testing
our new termbox on a random item on beta; seems impossibly bad/good luck that I
ran into it with the first
Tarrow added a comment.
Sorry for the lack of explicit reproduction :/. The steps below use `httpie`
and the mediawiki-docker-dev setup.
> I didn't test anything in API, I tested everything in desktop GUI
I think in desktop GUI different endpoints are used (wb
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T218081
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Lea_WMDE, Pablo-WMDE, Aklapper, Addshore, Tarrow, darthmon_wmde, alaa_wmde,
Nandana, Lahi, Gq86
Tarrow added a comment.
From my side this is fine to leave. If the complexity were to change I would
expect it to be encapsulated in T221833
<https://phabricator.wikimedia.org/T221833>
TASK DETAIL
https://phabricator.wikimedia.org/T221831
EMAIL PREFERENCES
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T215913
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Danmichaelo, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, joker88john,
CucyNoiD, Nandana
Tarrow updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T217399
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Pablo-WMDE, Jakob_WMDE, Aklapper, Tarrow, darthmon_wmde, alaa_wmde,
Nandana, Lahi, Gq86
Tarrow removed a project: Wikidata-Termbox-Iteration-15.
Tarrow added a subscriber: Lea_WMDE.
Tarrow added a comment.
@Lea_WMDE : I think we agreed in the daily that the hike wouldn't instantly
pick this up and instead we'd maybe see if camp would be looking at it as an
API bug. In
Tarrow claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T215913
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Danmichaelo, Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi,
Gq86, GoranSMilovanovic, QZanden
501 - 600 of 1078 matches
Mail list logo
