Tarrow added a comment.
@Jakob_WMDE and I spent quite some time looking at it today. We came to the
following discoveries.
We attempted to add a new cache key:
We tried registering it in \Wikibase\RepoHooks::onParserOptionsRegister
and both adding the extra key to to ParserOptions (`$options->addExtraKey(
'wbNewTermbox' );`) and recording the option ParserOptions
(`$output->recordOption( 'wbNewTermbox' );`) in
extensions/Wikibase/repo/includes/Content/EntityContent.php
This was unsuccessful because the parser option we created ('wbNewTermbox')
was not used in generating the ParserCache key until after a new parser cache
entry was made:
This can be seen in \ParserCache::getKey (includes/parser/ParserCache.php:194
and includes/parser/ParserCache.php:216) where the options keys themselves are
read from the cache.
Perhaps this wouldn't be an issue if we recomputed the ParserCache options at
this point?
This can be seen in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/526117/2
It works as we intend in the case that you purge the parser cache first. Then
the key is taken into account and the cache is correctly split for any future
cache reads
TASK DETAIL
https://phabricator.wikimedia.org/T228978
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: Addshore, Tarrow, Jakob_WMDE, Aklapper, Michael, darthmon_wmde, DannyS712,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF,
Mbch331, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
