Hi,
On Mon, Apr 14, 2014 at 01:25:09PM -0700, James Forrester wrote:
It looks to me like we have rough consensus for doing this. Make it
so?
Done.
Thanks to hashar for providing the patch set!
Have fun,
Christian
--
quelltextlich e.U. \\ Christian Aistleitner
On Fri, Apr 11, 2014 at 4:08 PM, Daniel Friesen
dan...@nadir-seen-fire.com wrote:
I never liked this, over and over I point out a fatal issue with a
commit sometimes fundamental to the idea itself and impossible to fix,
so I -1 it, then when a new patchset comes out, completely ignores the
On Mon, 14 Apr 2014 18:02:43 +0200, C. Scott Ananian canan...@wikimedia.org
wrote:
I think this is a social issue: we need to
stop thinking of -2'ing a patch as a grave statement of disapproval.
Nope (or not only), most people don't even have the ability to give out a -2
(it currently comes
On Mon, Apr 14, 2014 at 9:07 AM, Bartosz Dziewoński matma@gmail.comwrote:
On Mon, 14 Apr 2014 18:02:43 +0200, C. Scott Ananian
canan...@wikimedia.org wrote:
I think this is a social issue: we need to
stop thinking of -2'ing a patch as a grave statement of disapproval.
Nope (or not
Le 11/04/2014 15:57, Christian Aistleitner a écrit :
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review “trivial” changes on patch sets.
Shall we turn that feature on?
snip
Thank you
On 14 April 2014 12:06, Antoine Musso hashar+...@free.fr wrote:
Le 11/04/2014 15:57, Christian Aistleitner a écrit :
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review “trivial”
Hi,
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review “trivial” changes on patch sets.
Shall we turn that feature on?
Longer version.
Currently,
On Friday, April 11, 2014, Christian Aistleitner christ...@quelltextlich.at
wrote:
Hi,
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review “trivial” changes on patch sets.
Shall we turn
What if someone -1's due to something in the summary? It's odd that fixing it
with a new commit would still show -1 on the reviewer's dashboard. I'm fine
with it for automatic rebases though.
--
View this message in context:
Amending a commit message really shouldn't remove existing votes. I
personally would like this on the MobileFrontend repository. I'm not
sure if this can be done on a per project basis if necessary but I
want this.
On Fri, Apr 11, 2014 at 9:29 AM, Aaron Schulz aschulz4...@gmail.com wrote:
What
On 11 April 2014 09:29, Aaron Schulz aschulz4...@gmail.com wrote:
What if someone -1's due to something in the summary? It's odd that fixing
it
with a new commit would still show -1 on the reviewer's dashboard.
Sure, but those are relatively rare for simple changes (normally you just
fix
Op 11 apr. 2014 om 15:57 heeft Christian Aistleitner
christ...@quelltextlich.at het volgende geschreven:
Hi,
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review “trivial” changes
On Fri, 11 Apr 2014 18:29:06 +0200, Aaron Schulz aschulz4...@gmail.com wrote:
What if someone -1's due to something in the summary? It's odd that fixing it
with a new commit would still show -1 on the reviewer's dashboard. I'm fine
with it for automatic rebases though.
I think cases of the -1
+1
I never liked this, over and over I point out a fatal issue with a
commit sometimes fundamental to the idea itself and impossible to fix,
so I -1 it, then when a new patchset comes out, completely ignores the
concerns I've pointed out, my -1 with the idea suddenly disappears as if
the
On Friday, April 11, 2014, Christian Aistleitner christ...@quelltextlich.at
wrote:
Hi,
TL;DR: Gerrit would allow to keep Code-Review votes across
* rebases and
* commit message modifications
of patch sets.
Thereby dropping need to re-review trivial changes on patch sets.
Shall we turn
15 matches
Mail list logo
