Re: [Wikitech-l] Bug 189

2011-10-24 Thread Magnus Manske
Or we do without any servers, at the expense of older browsers: http://0xfe.blogspot.com/2010/05/music-notation-with-html5-canvas.html Magnus ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r100533]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100533. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100533 Commit summary: Group shell-related functions ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Bug 189

2011-10-24 Thread Nikola Smolenski
On 24/10/11 09:49, Magnus Manske wrote: Or we do without any servers, at the expense of older browsers: http://0xfe.blogspot.com/2010/05/music-notation-with-html5-canvas.html A problem with that is that it is not a notation standard. It can't be imported or edited into specialized notation

[MediaWiki-CodeReview] [MediaWiki r100563]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100563. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100563 Commit summary: i18n files don't need defined( 'MEDIAWIKI' ) guards. ___

[MediaWiki-CodeReview] [MediaWiki r100583]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100583. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100583 Commit summary: Adding a translate-messagereview right. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r100582]: New comment added

2011-10-24 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r100582. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100582#c24742 Commit summary: Add a message that explains the new user right introduced in r100561 Comment: Ops, wrong qqq message fixed

Re: [Wikitech-l] Bug 189

2011-10-24 Thread Magnus Manske
On Mon, Oct 24, 2011 at 9:22 AM, Nikola Smolenski smole...@eunet.rs wrote: On 24/10/11 09:49, Magnus Manske wrote: Or we do without any servers, at the expense of older browsers: http://0xfe.blogspot.com/2010/05/music-notation-with-html5-canvas.html A problem with that is that it is not a

[MediaWiki-CodeReview] [MediaWiki r85856]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r85856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85856#c24743 Commit summary: Fix for bug 28450: escaped CSS comments Comment: Basic test added with r100584. ___ MediaWiki-CodeReview

Re: [Wikitech-l] migration to git: available and suggested Web viewers ?

2011-10-24 Thread Daniel Friesen
On Sun, 23 Oct 2011 23:55:13 -0700, Thomas Gries m...@tgries.de wrote: collecting previously mailed information and started a new section http://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces#Viewers_%28repository_web_browsers%29 browsers for git: My starting point was

[MediaWiki-CodeReview] [MediaWiki r100592]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r100592. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100592#c24744 Commit summary: test {{SERVERNAME}} with relative URLS bug 31176 mentionned an issue with {{SERVERNAME}} returning the full URL instead of servername when using

[MediaWiki-CodeReview] [MediaWiki r98193]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r98193. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98193#c24745 Commit summary: (bug 31176) {{SERVERNAME}} doesn't play nice with protocol-relative URLs Comment: removing 'needs-parsertests' keyword. Test added in PHPUnit with

[MediaWiki-CodeReview] [MediaWiki r81571]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r81571. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81571#c24746 Commit summary: Html::expandAttributes( array( 'foo' = null ) ); ' foo=' - '' Outputting ' foo= on `foo = null` promotes the writing of overly verbose code to avoid it,

[MediaWiki-CodeReview] [MediaWiki r100582]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100582. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100582 Commit summary: Add a message that explains the new user right introduced in r100561 ___

[MediaWiki-CodeReview] [MediaWiki r100431]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100431. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100431 Commit summary: Fix table does not exist issue. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100591]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100591. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100591 Commit summary: Ignore 2 keys per description. Spotted by McDutchie. Thanks. ___

[MediaWiki-CodeReview] [MediaWiki r100593]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r100593. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100593 Commit summary: Fix syntaxerror in r100591 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100579]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100579. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100579 Commit summary: Updated documentation of $wgMaxImageArea for r99911 etc. ___

[MediaWiki-CodeReview] [MediaWiki r100036]: New comment added

2011-10-24 Thread MediaWiki Mail
User SVG posted a comment on MediaWiki.r100036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100036#c24747 Commit summary: Fixing access bug and adding new permission and translation message, approved by Adam Comment: Ah, okay. Thanks.

[MediaWiki-CodeReview] [MediaWiki r100597]: New comment added

2011-10-24 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r100597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100597#c24748 Commit summary: -getText() → -getBaseText() Comment: Please change translation at translatewiki.net (twn) only. This avoids backwards synching for twn staff.

[MediaWiki-CodeReview] [MediaWiki r100598]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100598. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r100598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100598#c24749 Commit summary: Adding permission changeauthor to wgAvailableRights for

[MediaWiki-CodeReview] [MediaWiki r100111]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100111. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100111 Commit summary: New table anticipating further development :) Card i18n#125 ___

[MediaWiki-CodeReview] [MediaWiki r100243]: New comment added

2011-10-24 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r100243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100243#c24750 Commit summary: Api module for marking translations as reviewed. Internationalization/#128 Comment: Error message wording improved in r100585.

[MediaWiki-CodeReview] [MediaWiki r100243]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100243. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100243 Commit summary: Api module for marking translations as reviewed. Internationalization/#128

[MediaWiki-CodeReview] [MediaWiki r100598]: New comment added

2011-10-24 Thread MediaWiki Mail
User SVG posted a comment on MediaWiki.r100598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100598#c24751 Commit summary: Adding permission changeauthor to wgAvailableRights for special page basing user permissions management systems Comment: A description message does

[MediaWiki-CodeReview] [MediaWiki r100598]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100598. Old Status: fixme New Status: deferred User Raymond also posted a comment on MediaWiki.r100598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100598#c24752 Commit summary: Adding permission changeauthor to wgAvailableRights

[MediaWiki-CodeReview] [MediaWiki r100345]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100345. Old Status: new New Status: resolved User Amire80 also posted a comment on MediaWiki.r100345. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100345#c24753 Commit summary: Translation review interface

[MediaWiki-CodeReview] [MediaWiki r100587]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100587. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100587 Commit summary: setCaller exists since 1.17 so no need to check whether it exists, spotted by Amir

[MediaWiki-CodeReview] [MediaWiki r100413]: New comment added

2011-10-24 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r100413. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c24754 Commit summary: Added a forgotten file Followup r100345 and Internationalization/#129 Comment: unnecessary console.log removed in r100590.

[MediaWiki-CodeReview] [MediaWiki r100413]: New comment added

2011-10-24 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r100413. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c24755 Commit summary: Added a forgotten file Followup r100345 and Internationalization/#129 Comment: This should also be reviewed by someone who's better with JS than i

[MediaWiki-CodeReview] [MediaWiki r100590]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100590. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100590 Commit summary: console.log should not be in production code ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r100420]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100420. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100420 Commit summary: Followup r100345 - protect part of the code with configuration variable ___

[MediaWiki-CodeReview] [MediaWiki r100585]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100585. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100585 Commit summary: Better error messages and corrected param description ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100595]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100595. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100595 Commit summary: * Disallow reviewing own translations * Show disabled review button and the reason in a tooltip * Speak about fuzzy

[MediaWiki-CodeReview] [MediaWiki r82473]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r82473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82473#c24756 Commit summary: (Bug #27467) preload can leave UNIQ Patch to fix from P.Copp Comment: Removing tag 'needs-php-test'. Tests added with r100599

[MediaWiki-CodeReview] [MediaWiki r86623]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r86623. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86623#c24757 Commit summary: (bug 28643) Merge Serbian language variant conversion improvements to trunk (r85224, r85239, r85308) from Nikola's branch Comment: Removing

[MediaWiki-CodeReview] [MediaWiki r86623]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r86623. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86623#c24758 Commit summary: (bug 28643) Merge Serbian language variant conversion improvements to trunk (r85224, r85239, r85308) from Nikola's branch Comment: Well follow up was

[MediaWiki-CodeReview] [MediaWiki r100597]: New comment added

2011-10-24 Thread MediaWiki Mail
User SVG posted a comment on MediaWiki.r100597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100597#c24759 Commit summary: -getText() → -getBaseText() Comment: Okay, sorry. ___ MediaWiki-CodeReview mailing list

[Wikitech-l] lost in sites for coding challenge mobile

2011-10-24 Thread Simone
i am lost in sites, when i upload a picture where it must go? in *.wikipedia.org or in commons.wikimedia.org? i didn't understand... another thing is that to take the token the user must be logged, and i have seen that every country has got different logins, for examples: my login of

Re: [Wikitech-l] lost in sites for coding challenge mobile

2011-10-24 Thread Greg DeKoenigsberg
This is a good question. Simone sent it to me privately, and it occurred to me that the answer was sufficiently non-obvious that I asked him to report to wikitech-l. In looking at this page: http://en.wikipedia.org/wiki/Wikipedia:Files_for_upload ...it seems as though uploading to Commons is

Re: [Wikitech-l] wikipedia lacks a share' button

2011-10-24 Thread Liangent
There's already a gadget on zhwiki which adds a bunch of 'share' links if you want that. On Fri, Oct 21, 2011 at 11:54 AM, jida...@jidanni.org wrote: Gentlemen, where is the Share button? All other sites have them by now, but on Wikipedia one cannot even find its definition in

[MediaWiki-CodeReview] [MediaWiki r100509]: New comment added

2011-10-24 Thread MediaWiki Mail
User Liangent posted a comment on MediaWiki.r100509. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100509#c24761 Commit summary: (bug 31414) Skin specific gadgets Comment: I had known nothing about Gadgets 3.0 (and had a look at it just now). It's just because I wanted that

[MediaWiki-CodeReview] [MediaWiki r99517]: New comment added

2011-10-24 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r99517. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99517#c24763 Commit summary: Various fixes for Contest.php: * Fix doc comment typo * Fix version comparison * Change Contest_VERSION constant to all-caps (CONTEST_VERSION) and make

[MediaWiki-CodeReview] [MediaWiki r99582]: New comment added

2011-10-24 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r99582. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99582#c24764 Commit summary: Added skeleton special page for LastModified. Comment: You should take a look at Language::formatTimePeriod(), which does pretty much the same as what

Re: [Wikitech-l] lost in sites for coding challenge mobile

2011-10-24 Thread Diederik van Liere
I think that is true unless you want to upload a fair use image, that is not allowed on commons but is on some wikipedia sites like the English. Diederik Sent from my iPhone On 2011-10-24, at 8:23, Greg DeKoenigsberg greg.dekoenigsb...@gmail.com wrote: This is a good question. Simone sent it

Re: [Wikitech-l] Open positions with Wikimedia Germany

2011-10-24 Thread Brion Vibber
I just want to chime in with a yee-haw! on getting this project going! -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r96188]: New comment added

2011-10-24 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96188. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96188#c24766 Commit summary: Expand r96170's support for space separated attributes with support for boolean keys such as array( 'class' = array( 'selected' = true ) ) to match our

[MediaWiki-CodeReview] [MediaWiki r96256]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96256. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96256 Commit summary: Add documentation for r96170 and r96188. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100580]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100580. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100580 Commit summary: Added Thendral, Thenee, Vaigai fonts for Tamil. Fix Bug 31889 ___

[MediaWiki-CodeReview] [MediaWiki r99439]: New comment added

2011-10-24 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r99439. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99439#c24767 Commit summary: added contest end date field with jquery datetimepicker Comment: No, it's fine, it's just that TS_DB is an unfortunate and misleading name and people

[MediaWiki-CodeReview] [MediaWiki r100600]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100600. Old Status: new New Status: ok User Amire80 also posted a comment on MediaWiki.r100600. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100600#c24768 Commit summary: Change the negative preference Disable Webfonts to postive

[MediaWiki-CodeReview] [MediaWiki r99582]: New comment added

2011-10-24 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r99582. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99582#c24769 Commit summary: Added skeleton special page for LastModified. Comment: Thanks. It looks like it does not say time in weeks, months or years, but that might

[MediaWiki-CodeReview] [MediaWiki r100594]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Amire80 changed the status of MediaWiki.r100594. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100594 Commit summary: Define the global property $wgWebFontsEnabledByDefault as true by default. ___

Re: [Wikitech-l] Welcome, Antoine Musso! (hashar)

2011-10-24 Thread Brion Vibber
On Fri, Oct 21, 2011 at 3:24 PM, Platonides platoni...@gmail.com wrote: Rob Lanphier wrote: He has been working in our community for quite some time, going by the name Ashar Voultoiz on mailing lists, and by hashar on IRC.Now that he's working as a contractor for WMF, he's decided

[MediaWiki-CodeReview] [MediaWiki r96170]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r96170. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r96170. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96170#c24770 Commit summary: Html.php: The future[1] is here. Add features for

[MediaWiki-CodeReview] [MediaWiki r100408]: New comment added

2011-10-24 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100408#c24771 Commit summary: Documentation cleanup. Added public declarations to methods. Comment: This code is ready for review.

[MediaWiki-CodeReview] [MediaWiki r100025]: New comment added

2011-10-24 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r100025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100025#c24772 Commit summary: Adjustments to r99351 r99350 r99200 per code review: * Replace the show link with a spinner, and add error handling. * Use data() instead of attr()

[MediaWiki-CodeReview] [MediaWiki r100025]: New comment added, and revision status changed

2011-10-24 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r100025. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r100025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100025#c24773 Commit summary: Adjustments to r99351 r99350 r99200 per code review: *

[MediaWiki-CodeReview] [MediaWiki r99350]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r99350. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99350 Commit summary: MoodBar: Implement hiding and restoring of entries on the feedback dashboard. No AJAX for now, but everything is

[MediaWiki-CodeReview] [MediaWiki r99200]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r99200. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99200 Commit summary: MoodBar feedback dashboard: Implement a means to hide individual comments. For now, does *not* include actual

Re: [Wikitech-l] wikipedia lacks a share' button

2011-10-24 Thread Mark A. Hershberger
Carl (CBM) cbm.wikipe...@gmail.com writes: On Fri, Oct 21, 2011 at 12:15 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Posted this issue at http://hexm.de/8m. The above link is to :

[Wikitech-l] Announcing Fabrice Florin and Oliver Keyes

2011-10-24 Thread Howie Fung
Everyone, I am pleased to announce that we have two contractors joining the Technology team. Fabrice Florin will be joining us for the next six months as Product Consultant, leading the development of the next version of the Article Feedback Tool. Oliver Keyes (User: Ironholds on enwp) will be

Re: [Wikitech-l] Open positions with Wikimedia Germany

2011-10-24 Thread Alolita Sharma
Very excited to see this project happen :-) Alolita On Oct 24, 2011, at 7:39 AM, Brion Vibber br...@pobox.com wrote: I just want to chime in with a yee-haw! on getting this project going! -- brion ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r100560]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User RussNelson changed the status of MediaWiki.r100560. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100560 Commit summary: Follow-up r88390. PHP is not like C preprocessor. You don't need to mark a newline for continuing a string literal. The

[MediaWiki-CodeReview] [MediaWiki r100581]: New comment added

2011-10-24 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100581#c24774 Commit summary: Per r100564: Register Fundraiser Landing Page Alias file not added for translation. IIRC this special page is not visible for the user/reader.

[MediaWiki-CodeReview] [MediaWiki r100584]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r100584. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100584 Commit summary: Test handling of escaped CSS comments r85856 fixed a CSS injection issue but lacked testing. This test verify we

[MediaWiki-CodeReview] [MediaWiki r100581]: New comment added

2011-10-24 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r100581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100581#c24775 Commit summary: Per r100564: Register Fundraiser Landing Page Alias file not added for translation. IIRC this special page is not visible for the user/reader.

Re: [Wikitech-l] lost in sites for coding challenge mobile

2011-10-24 Thread Platonides
Simone wrote: i am lost in sites, when i upload a picture where it must go? in *.wikipedia.org or in commons.wikimedia.org? Images should go to Wikimedia Commons ( http://commons.wikimedia.org ) Remember to specify the license. i didn't understand... another thing is that to take the token

[MediaWiki-CodeReview] [MediaWiki r100604]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r100604. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100604 Commit summary: Fix comment typo in r99537 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99537]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r99537. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99537 Commit summary: [RL2] Fix version check in Gadgets too, see r99536 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100487]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100487. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100487 Commit summary: Trim trailing whitespace Flesh out authors ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r100489]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100489. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100489 Commit summary: Remove unuesd globals Fix a couple of undefined variables ___

Re: [Wikitech-l] migration to git: available and suggested Web viewers ?

2011-10-24 Thread Platonides
On 23/10/11 12:45, Daniel Friesen wrote: The general standard is GitWeb, it's even bundled with Gerrit so it will be the default available when git is setup: https://gerrit.wikimedia.org/r/gitweb?p=operations%2Fpuppet.git A problem with that kind of interface (not restricted to git) is how

[MediaWiki-CodeReview] [MediaWiki r100611]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100611. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100611 Commit summary: Removed unused and deprecated global declaration of $wgDeferredUpdateList

[MediaWiki-CodeReview] [MediaWiki r100613]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100613. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100613 Commit summary: Followup r100564 per r100581 CR: fundraising - fundraiser ___

[MediaWiki-CodeReview] [MediaWiki r100615]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r100615. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100615 Commit summary: Fixing path to CSS for TwoStepTwoColumnLetterForm css ___

[MediaWiki-CodeReview] [MediaWiki r99911]: New comment added

2011-10-24 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r99911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99911#c24776 Commit summary: Per bug 28135, disable $wgMaxImageArea check when transforming using a hook, and enable the check for non IM scalers. Comment: Hm. Then this would

[MediaWiki-CodeReview] [MediaWiki r100581]: New comment added

2011-10-24 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r100581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100581#c24777 Commit summary: Per r100564: Register Fundraiser Landing Page Alias file not added for translation. IIRC this special page is not visible for the user/reader.

Re: [Wikitech-l] Bug 189

2011-10-24 Thread Owen Davis
Magnus Manske magnusmanske at googlemail.com writes: Or we do without any servers, at the expense of older browsers: http://0xfe.blogspot.com/2010/05/music-notation-with-html5- canvas.html After reading this thread, I was going to suggest this library as well. :) I have played around

Re: [Wikitech-l] Bug 189

2011-10-24 Thread Neil Harris
On 24/10/11 18:23, Owen Davis wrote: After reading this thread, I was going to suggest this library as well. :) I have played around with it and I think it is quite nice for tablature, but it is probably not as good for traditional musicians? It's true that it has a non-standard notation

Re: [Wikitech-l] wikipedia lacks a share' button

2011-10-24 Thread bawolff
Carl (CBM) cbm.wikipedia at gmail.com writes: On Fri, Oct 21, 2011 at 12:15 PM, Mark A. Hershberger mhershberger at wikimedia.org wrote: Posted this issue at http://hexm.de/8m. The above link is to :

Re: [Wikitech-l] wikipedia lacks a share' button

2011-10-24 Thread Tomasz Finc
On Fri, Oct 21, 2011 at 6:18 AM, Jay Ashworth j...@baylink.com wrote: - Original Message - From: Tomasz Finc tf...@wikimedia.org Were already planning on having it in the Android app. https://bugzilla.wikimedia.org/show_bug.cgi?id=31481. There is a ready plugin to do it for anyone

Re: [Wikitech-l] Bug 189

2011-10-24 Thread Owen Davis
Neil Harris neil at tonal.clara.co.uk writes: If vexflow is simple, capable and safe, could it also be converted to run server-side as an image renderer, using something like node- canvas? If so, then that's potentially a solution for everyone. - Neil Oh, that's an interesting idea.

[MediaWiki-CodeReview] [MediaWiki r100621]: New comment added

2011-10-24 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r100621. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100621#c24778 Commit summary: Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and

[MediaWiki-CodeReview] [MediaWiki r100600]: New comment added

2011-10-24 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100600. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100600#c24779 Commit summary: Change the negative preference Disable Webfonts to postive preference Enable Webfonts. Comment: +1

[MediaWiki-CodeReview] [MediaWiki r100621]: New comment added

2011-10-24 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r100621. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100621#c24780 Commit summary: Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and OutputPage::setHTMLTitle()

[MediaWiki-CodeReview] [MediaWiki r96188]: New comment added

2011-10-24 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r96188. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96188#c24781 Commit summary: Expand r96170's support for space separated attributes with support for boolean keys such as array( 'class' = array( 'selected' = true ) ) to match our

[MediaWiki-CodeReview] [MediaWiki r100621]: New comment added

2011-10-24 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r100621. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100621#c24782 Commit summary: Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and

[MediaWiki-CodeReview] [MediaWiki r100632]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r100632. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100632 Commit summary: Review - accept + tooltip ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100327]: New comment added

2011-10-24 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r100327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100327#c24783 Commit summary: * (bug 31441) Allow sysops to add/remove user group autoreview (as they can with editor already) * Doc comment tweaks Comment: Going to tag r100635 to

[MediaWiki-CodeReview] [MediaWiki r100635]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r100635. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100635 Commit summary: 1.18wmf1: Half manually merge r100327 ___ MediaWiki-CodeReview mailing

[Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-24 Thread Brion Vibber
Hey all -- I've got a stack of issues discussed during the last couple months' conferences and hackathons to raise, so there may be a few more manifestos on the way. But don't worry, this one will be short! I had a great chat at the New Orleans hackathon with D J Bauch who's been working on

Re: [Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-24 Thread Chad
On Mon, Oct 24, 2011 at 3:04 PM, Brion Vibber br...@wikimedia.org wrote: I'd like for everybody who's working on MediaWiki on non-MySQL databases to make sure that the phpunit test suite can run on your favorite platform, so we can see about getting them set up in our regular reports on

Re: [Wikitech-l] MediaWiki unit testing and non-MySQL databases

2011-10-24 Thread Russell Nelson
Is there a way to tell Sqlite to be pickier about what it will accept? If it bombs out on anything that falls outside the union of (all supported database SQL), then just passing our tests should be sufficient, right? On Mon, Oct 24, 2011 at 3:15 PM, Chad innocentkil...@gmail.com wrote: On Mon,

[MediaWiki-CodeReview] [MediaWiki r100638]: New comment added

2011-10-24 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r100638. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100638#c24784 Commit summary: Removing unused global from RapidHtml-set_html_file_path Comment: Just keeping in mind: $g::getGlobal( 'HtmlFormDir' ); Will not work unless you're

[MediaWiki-CodeReview] [MediaWiki r100636]: New comment added

2011-10-24 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r100636. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100636#c24785 Commit summary: Removed 'reviewer' from bureaucrat addgroups/removegroups. Redundant on stock configs and adds config clutter. Comment: wmf config updated to

[MediaWiki-CodeReview] [MediaWiki r100621]: New comment added

2011-10-24 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r100621. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100621#c24786 Commit summary: Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and OutputPage::setHTMLTitle()

[MediaWiki-CodeReview] [MediaWiki r100462]: New comment added

2011-10-24 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100462. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100462#c24787 Commit summary: Changed $transactionType to $payment_method. Added $result parameter to executeiFrameForCreditCard(). Comment: Parts of this broke CC in

[MediaWiki-CodeReview] [MediaWiki r100461]: New comment added

2011-10-24 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100461#c24788 Commit summary: Changed $transaction_groups to $payment_methods. Changed $transaction_types to $payment_submethods. Added get methods for access to

[MediaWiki-CodeReview] [MediaWiki r100461]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100461. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100461 Commit summary: Changed $transaction_groups to $payment_methods. Changed $transaction_types to $payment_submethods. Added get

[MediaWiki-CodeReview] [MediaWiki r100462]: Revision status changed

2011-10-24 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r100462. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100462 Commit summary: Changed $transactionType to $payment_method. Added $result parameter to executeiFrameForCreditCard().

  1   2   >