[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2012-01-24 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107669. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c29972 Commit summary for MediaWiki.r107669: * more specific selectors for wikitable - don't inherit properties to nested tables which causes various rendering issues ** (bug 30485)

[MediaWiki-CodeReview] [MediaWiki r109834]: New comment added

2012-01-24 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r109834. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109834#c29973 Commit summary for MediaWiki.r109834: Redoing r108960 with history If it was a 3rd party library, there probably wouldn't have been any use doing this Hashar's comment:

[MediaWiki-CodeReview] [MediaWiki r109161]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r109161 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29974 Old Status: fixme New Status: new Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that

[MediaWiki-CodeReview] [MediaWiki r109161]: New comment added

2012-01-24 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r109161. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29975 Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that deprecated, the recommanded way is to use an array as a first

[Wikitech-l] online labs conference on irc

2012-01-24 Thread Petr Bena
Hi, Since we have more and more users with access to wikimedia labs, I think it would be great to make online conference on irc to discuss, especially with new users and people interested in getting access there how labs work, and what all is needed to do. I would be interested in getting a

[Wikitech-l] Qunit tests for extensions

2012-01-24 Thread Santhosh Thottingal
Hi, For javascript unit testing of Mediawiki extensions, qunit can be used and it is documented at https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#QUnit We also documented(thanks to Krinkle) some guidelines on writing qunit test cases at

[MediaWiki-CodeReview] [MediaWiki r109736]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r109736 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109736 Old status: new New status: ok Commit summary for MediaWiki.r109736: Removed unneeded method, moved unsupported methods down

[MediaWiki-CodeReview] [MediaWiki r109911]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r109911 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109911#c29976 Old Status: new New Status: ok Commit summary for MediaWiki.r109911: replaced *TOKENIZED -- ANALYZED *UN_TOKENIZED -- NOT_ANALYZED *NO_NORMS --

[MediaWiki-CodeReview] [MediaWiki r109914]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r109914 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109914 Old status: new New status: ok Commit summary for MediaWiki.r109914: fixed a typo... ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109916]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r109916 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109916 Old status: new New status: ok Commit summary for MediaWiki.r109916: removed unneeded suppress warnings ___

[MediaWiki-CodeReview] [MediaWiki r109917]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r109917 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109917 Old status: new New status: ok Commit summary for MediaWiki.r109917: * took out explicit Java sdk version * removed commons-logging dependency

[MediaWiki-CodeReview] [MediaWiki r109881]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109881 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109881 Old status: new New status: ok Commit summary for MediaWiki.r109881: propset svn:keywords Id ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109881]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109881 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109881 Old status: ok New status: resolved Commit summary for MediaWiki.r109881: propset svn:keywords Id ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r109882]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109882 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109882 Old status: new New status: ok Commit summary for MediaWiki.r109882: propset svn:keywords Id ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Escaping messages

2012-01-24 Thread Tei
On 24 January 2012 06:59, Daniel Friesen li...@nadir-seen-fire.com wrote: .. Don't delude yourself into thinking that you can easily blacklist the elements that would run a script. http://ha.ckers.org/xss.html What about using textNodes?

[MediaWiki-CodeReview] [MediaWiki r109879]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109879 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109879 Old status: new New status: ok Commit summary for MediaWiki.r109879: stylize.php ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109921]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109921 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109921 Old status: new New status: deferred Commit summary for MediaWiki.r109921: Fixed: Error in findField ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r109877]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109877 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109877 Old status: new New status: ok Commit summary for MediaWiki.r109877: [MoodBar] whitespace ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109905]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109905 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109905 Old status: new New status: ok Commit summary for MediaWiki.r109905: r108762: Removed unused cruft parameters to updater functions

[MediaWiki-CodeReview] [MediaWiki r109886]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109886 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109886 Old status: new New status: ok Commit summary for MediaWiki.r109886: propset svn:keywords Id ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109880]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109880 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109880 Old status: new New status: ok Commit summary for MediaWiki.r109880: spacing fix ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Escaping messages

2012-01-24 Thread Daniel Friesen
On Tue, 24 Jan 2012 06:16:48 -0800, Tei oscar.vi...@gmail.com wrote: On 24 January 2012 06:59, Daniel Friesen li...@nadir-seen-fire.com wrote: .. Don't delude yourself into thinking that you can easily blacklist the elements that would run a script. http://ha.ckers.org/xss.html What about

Re: [Wikitech-l] WikiEditor crashes due to bad preferences?

2012-01-24 Thread Daniel Barrett
Since nobody responded, this is now bug 33926, https://bugzilla.wikimedia.org/show_bug.cgi?id=33926. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] online labs conference on irc

2012-01-24 Thread Petr Bena
Sumana suggested to use this cool feature so that other users can pick a best time, so please if you are interested in wikimedia labs, vote for a best time for a meeting on this link http://www.doodle.com/72hr93qs4c64sfz7 On Tue, Jan 24, 2012 at 11:20 AM, Petr Bena benap...@gmail.com wrote:

Re: [Wikitech-l] New committer: Thibaut Horel (zaran)

2012-01-24 Thread Antoine Musso
Rob Lanphier: Please welcome new committer Thibaut Horel (username: zaran), who plans to help maintain the Proofread Page extension. Thibaut is an active contributor on fr.wikisource.org and is here at the San Francisco Hackathon this weekend. J'invite tout le monde à apprendre le français

Re: [Wikitech-l] how did spammers spam only some pretty links?

2012-01-24 Thread Antoine Musso
Platonides wrote: There was a similar case reported for http://www.octave.org on #mediawiki on Friday. The user (and google) saw spam but pages were intact. Which was caused by index.php getting hacked. A different was served depending upon the client IP, so google was served spam but most

[MediaWiki-CodeReview] [MediaWiki r109828]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109828 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109828 Old status: new New status: ok Commit summary for MediaWiki.r109828: Adding the jquery cycle plugin. This is being used by the UnitTest extension. See r109762.

[MediaWiki-CodeReview] [MediaWiki r109888]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109888 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109888 Old status: new New status: ok Commit summary for MediaWiki.r109888: stylize.php ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109889]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109889 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109889 Old status: new New status: ok Commit summary for MediaWiki.r109889: Added the following three items: * (bug 27775) Namespace has it's own XML tag in the XML dump

[MediaWiki-CodeReview] [MediaWiki r109923]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109923 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109923 Old status: new New status: ok Commit summary for MediaWiki.r109923: Comment not relevant with resource loader ___

[MediaWiki-CodeReview] [MediaWiki r109884]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109884 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109884 Old status: new New status: reverted Commit summary for MediaWiki.r109884: move Mobile Frontend class to separate body file

[MediaWiki-CodeReview] [MediaWiki r109927]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109927 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109927 Old status: new New status: ok Commit summary for MediaWiki.r109927: Redoing r109884 using svn copy ___

[MediaWiki-CodeReview] [MediaWiki r109928]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109928 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109928 Old status: new New status: ok Commit summary for MediaWiki.r109928: Fix borked characters from r109927 ___

[MediaWiki-CodeReview] [MediaWiki r108577]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r108577. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108577#c29977 Commit summary for MediaWiki.r108577: Remove use of deprecated LanguageGetMagic hook. Johnduhart's comment: I've been trying to get your attention on this for several days

[MediaWiki-CodeReview] [MediaWiki r109904]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Platonides changed the status of MediaWiki.r109904 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109904#c29978 Old Status: new New Status: fixme Commit summary for MediaWiki.r109904: Made FileOp classes enforce required params. Also reverts r109823.

[MediaWiki-CodeReview] [MediaWiki r108577]: New comment added

2012-01-24 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r108577. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108577#c29979 Commit summary for MediaWiki.r108577: Remove use of deprecated LanguageGetMagic hook. Siebrand's comment: Hey John. I haven't noticed previous attempts, so I'm glad you tried

[MediaWiki-CodeReview] [MediaWiki r106025]: New comment added

2012-01-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106025. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106025#c29980 Commit summary for MediaWiki.r106025: Bug 16794 - $wgSharedDB PostgreSQL support Updated fix from Luca Fulchir Aaron Schulz's comment: Can you just revert this if it

[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added

2012-01-24 Thread MediaWiki Mail
TheDJ posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c29981 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register TheDJ's comment: Tested Navigation Popups icw Cite popup:

[MediaWiki-CodeReview] [MediaWiki r109830]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r109830 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109830 Old status: new New status: ok Commit summary for MediaWiki.r109830: Cleanup to statistics: * Removed 'pcache_miss_invalid' from stats.php and clear_stats.php, no longer

[MediaWiki-CodeReview] [MediaWiki r109731]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r109731 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109731 Old status: new New status: resolved Commit summary for MediaWiki.r109731: Fix first part of fixme from r109711, getting rid of the static variable

[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added

2012-01-24 Thread MediaWiki Mail
TheDJ posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c29982 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register TheDJ's comment: Can you link an example ? Much easier if anyone wants to

[MediaWiki-CodeReview] [MediaWiki r109904]: New comment added

2012-01-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r109904. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109904#c29983 Commit summary for MediaWiki.r109904: Made FileOp classes enforce required params. Also reverts r109823. Aaron Schulz's comment: Heh, I was using that too avoid static::

[MediaWiki-CodeReview] [MediaWiki r103467]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r103467 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103467#c29984 Old Status: fixme New Status: new Commit summary for MediaWiki.r103467: Adapt and re-apply Michael Newton's patch from Bug 24464 - Execute

[MediaWiki-CodeReview] [MediaWiki r109904]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r109904 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109904 Old status: fixme New status: new Commit summary for MediaWiki.r109904: Made FileOp classes enforce required params. Also reverts r109823.

[MediaWiki-CodeReview] [MediaWiki r109924]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r109924 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109924 Old status: new New status: ok Commit summary for MediaWiki.r109924: Moving API modules to their own subdirectory in preparation to adding more

[MediaWiki-CodeReview] [MediaWiki r109935]: Revision status changed

2012-01-24 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r109935 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109935 Old status: new New status: ok Commit summary for MediaWiki.r109935: AFT5 - add missing translation message. ___

[MediaWiki-CodeReview] [MediaWiki r109906]: New comment added

2012-01-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r109906. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109906#c29985 Commit summary for MediaWiki.r109906: fixed feature request Bug 9892 as suggested by LY Meng Jeroen De Dauw's comment: It's bug 33901 :)

[MediaWiki-CodeReview] [MediaWiki r109906]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r109906 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109906 Old status: deferred New status: ok Commit summary for MediaWiki.r109906: fixed feature request Bug 9892 as suggested by LY Meng

[MediaWiki-CodeReview] [MediaWiki r109505]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Drdee changed the status of MediaWiki.r109505 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109505 Old status: fixme New status: new Commit summary for MediaWiki.r109505: Update ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] online labs conference on irc

2012-01-24 Thread Ryan Lane
So, I voted for Saturday at 2pm, but I'm thinking it's unlikely I'll be able to make it this Saturday. We'll likely need to wait till after I get back from FOSDEM, which is some time after Feb 11th. On Tue, Jan 24, 2012 at 7:05 AM, Petr Bena benap...@gmail.com wrote: Sumana suggested to use this

[MediaWiki-CodeReview] [MediaWiki r109892]: New comment added

2012-01-24 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r109892. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109892#c29986 Commit summary for MediaWiki.r109892: Added handling for new parameter for 'calendar' format - 'colors' Raymond's comment: {{messagedocumentation}} I assume that codeStart

[MediaWiki-CodeReview] [MediaWiki r109892]: New comment added

2012-01-24 Thread MediaWiki Mail
Yaron Koren posted a comment on MediaWiki.r109892. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109892#c29987 Commit summary for MediaWiki.r109892: Added handling for new parameter for 'calendar' format - 'colors' Yaron Koren's comment: Sorry, I should have documented this. Start

[MediaWiki-CodeReview] [MediaWiki r109588]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109588 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109588 Old status: new New status: ok Commit summary for MediaWiki.r109588: Bring ApiSandbox upto trunk version ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r109948]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r109948. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109948#c29988 Commit summary for MediaWiki.r109948: Smoothed a hack out of the special page js, and fixed a blocker Ubuntu/Firefox bug in the process: -

[MediaWiki-CodeReview] [MediaWiki r109933]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r109933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109933#c29989 Commit summary for MediaWiki.r109933: Updated survey CTA to use different links for options 1, 2, and 3: -

Re: [Wikitech-l] online labs conference on irc

2012-01-24 Thread Petr Bena
ok, so let's postpone it? since you are crucial for this. I will be available this saturday for all who already voted and wanted to discuss rather some basics and let's make a big one later? On Tue, Jan 24, 2012 at 8:20 PM, Ryan Lane rlan...@gmail.com wrote: So, I voted for Saturday at 2pm, but

[MediaWiki-CodeReview] [MediaWiki r109947]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r109947. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109947#c29990 Commit summary for MediaWiki.r109947: Follow-up r109940: instead of overriding core modules, add the extended modules under different names Johnduhart's comment: Thanks

[MediaWiki-CodeReview] [MediaWiki r109941]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r109941 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109941 Old status: new New status: ok Commit summary for MediaWiki.r109941: svn:keywords Id ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98430]: New comment added

2012-01-24 Thread MediaWiki Mail
MarkAHershberger posted a comment on MediaWiki.r98430. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98430#c29991 Commit summary for MediaWiki.r98430: (bug 30202) Restrict file names on upload to 240 bytes, because wfTimestamp( TS_MW ) . '!' . $fileName should fit in

[MediaWiki-CodeReview] [MediaWiki r101387]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r101387. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101387#c29992 Commit summary for MediaWiki.r101387: Added code that contains a function to handle the LocalFilePurgeThumbnails hook by purging swift-stored thumbnails. Johnduhart's

[MediaWiki-CodeReview] [MediaWiki r109951]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r109951 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109951 Old status: new New status: ok Commit summary for MediaWiki.r109951: Updating PHPDoc on $wgFilterCallback so PHPStorm stops complaining

[MediaWiki-CodeReview] [MediaWiki r109932]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109932 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109932 Old status: new New status: ok Commit summary for MediaWiki.r109932: diff: align cell content to the top This is needed when both sides are unbalanced. For example when a

[MediaWiki-CodeReview] [MediaWiki r100667]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r100667 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100667 Old status: new New status: deferred Commit summary for MediaWiki.r100667: Add some quick dirty fake cloudfiles classes for local testing. Objects are just

[MediaWiki-CodeReview] [MediaWiki r109698]: New comment added

2012-01-24 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r109698. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109698#c29993 Commit summary for MediaWiki.r109698: [Unit testing] Add unit tests for Xml::namespaceSelector * Making Language::namespaceNames explicitly public. It already was but since is

[MediaWiki-CodeReview] [MediaWiki r109950]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r109950 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109950 Old status: new New status: ok Commit summary for MediaWiki.r109950: Upated thumbnail purge script to account for latest file backend code changes. Also made it handle

[MediaWiki-CodeReview] [MediaWiki r108896]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r108896 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108896 Old status: new New status: reverted Commit summary for MediaWiki.r108896: Added check if MEDIAWIKI is definied to avoid execution outside of mw, inserted some comments

[MediaWiki-CodeReview] [MediaWiki r109953]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109953 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109953 Old status: new New status: ok Commit summary for MediaWiki.r109953: Revert r108896 -- we don't check for MEDIAWIKI being defined in class-only files anywhere else, let's not

[MediaWiki-CodeReview] [MediaWiki r99892]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r99892 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99892 Old status: new New status: ok Commit summary for MediaWiki.r99892: Refactored cleanupDeletedBatch() by splitting out the file usage check functions

[MediaWiki-CodeReview] [MediaWiki r109909]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109909 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109909 Old status: new New status: ok Commit summary for MediaWiki.r109909: * Oracle schema update to latest (tested with phpunit) * Fixed a message typo in DatabaseUpdater

[MediaWiki-CodeReview] [MediaWiki r102073]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r102073 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102073 Old status: new New status: ok Commit summary for MediaWiki.r102073: * Added File::normalizeTitle() function and used it to consolidate file title validity checks and

[MediaWiki-CodeReview] [MediaWiki r109957]: New comment added

2012-01-24 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r109957. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109957#c29994 Commit summary for MediaWiki.r109957: Add HTMLFormFields for namespaces and restriction levels. This is not a 1.19 feature and should be reverted post-branch. ^demon's comment:

[MediaWiki-CodeReview] [MediaWiki r109007]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109007 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109007 Old status: new New status: ok Commit summary for MediaWiki.r109007: * Killed an RTT in SwiftFileBackend::doStreamFile(). We already check existence in

[MediaWiki-CodeReview] [MediaWiki r109007]: New comment added

2012-01-24 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r109007. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109007#c29995 Commit summary for MediaWiki.r109007: * Killed an RTT in SwiftFileBackend::doStreamFile(). We already check existence in FileBackend::streamFile() * A few minor code cleanups

[MediaWiki-CodeReview] [MediaWiki r109957]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r109957. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109957#c29996 Commit summary for MediaWiki.r109957: Add HTMLFormFields for namespaces and restriction levels. This is not a 1.19 feature and should be reverted post-branch. Johnduhart's

[MediaWiki-CodeReview] [MediaWiki r109305]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109305 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109305 Old status: new New status: ok Commit summary for MediaWiki.r109305: Consolidated fake php-cloudfiles code a bit ___

[MediaWiki-CodeReview] [MediaWiki r109938]: Revision status changed

2012-01-24 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109938 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109938 Old status: new New status: ok Commit summary for MediaWiki.r109938: r109904: worked around PHP 5.3 suckage to keep this compatible

[MediaWiki-CodeReview] [MediaWiki r109235]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r109235 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109235 Old status: new New status: ok Commit summary for MediaWiki.r109235: Support custom headers for HEAD operations, e.g. (X-Newest: true); read() and stream() already

[MediaWiki-CodeReview] [MediaWiki r109875]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r109875 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109875 Old status: new New status: ok Commit summary for MediaWiki.r109875: Added survey CTA: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r109227 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c29997 Old Status: new New Status: fixme Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension

[MediaWiki-CodeReview] [MediaWiki r109933]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r109933 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109933 Old status: new New status: ok Commit summary for MediaWiki.r109933: Updated survey CTA to use different links for options 1, 2, and 3: -

[MediaWiki-CodeReview] [MediaWiki r109933]: New comment added

2012-01-24 Thread MediaWiki Mail
Catrope posted a comment on MediaWiki.r109933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109933#c29998 Commit summary for MediaWiki.r109933: Updated survey CTA to use different links for options 1, 2, and 3: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:

[MediaWiki-CodeReview] [MediaWiki r109582]: New comment added

2012-01-24 Thread MediaWiki Mail
Gregchiasson posted a comment on MediaWiki.r109582. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109582#c2 Commit summary for MediaWiki.r109582: AFT5 - Add permissions/roll checks to AFT5 feedback page and API calls. Requirements call for additional permissions on features that

[MediaWiki-CodeReview] [MediaWiki r109943]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r109943 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109943 Old status: new New status: ok Commit summary for MediaWiki.r109943: Swapped the dimensions of the survey window and made it close the CTA as soon as you start the survey

[MediaWiki-CodeReview] [MediaWiki r109961]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r109961 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109961 Old status: new New status: ok Commit summary for MediaWiki.r109961: Improve documentation for content type choice ___

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Tim Starling posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c3 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r108776]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r108776 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108776 Old status: new New status: ok Commit summary for MediaWiki.r108776: Bug fix: make the target: _blank passed in to buildLink() actually add that as an attribute

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Tim Starling posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30001 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r109964]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r109964 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109964#c30002 Old Status: new New Status: fixme Commit summary for MediaWiki.r109964: AFT5 - Add some qqq translation explanation, as a followup to r109075

[MediaWiki-CodeReview] [MediaWiki r109965]: New comment added

2012-01-24 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r109965. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109965#c30003 Commit summary for MediaWiki.r109965: AFT5 - add mediawiki.util dependency for Special page, per r105471. Not sure if that fixes anything at this point, since the page is

[MediaWiki-CodeReview] [Wikimedia r1204]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1204 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1204#c30004 Old Status: new New Status: ok Commit summary for Wikimedia.r1204: Fixing the recurring part of queue2civicrm to reflect changes made in common while

[MediaWiki-CodeReview] [MediaWiki r109964]: New comment added

2012-01-24 Thread MediaWiki Mail
Gregchiasson posted a comment on MediaWiki.r109964. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109964#c30005 Commit summary for MediaWiki.r109964: AFT5 - Add some qqq translation explanation, as a followup to r109075 Gregchiasson's comment: Fair enough - I also removed a couple

[MediaWiki-CodeReview] [MediaWiki r109965]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r109965 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109965#c30006 Old Status: new New Status: ok Commit summary for MediaWiki.r109965: AFT5 - add mediawiki.util dependency for Special page, per r105471. Not sure if

[MediaWiki-CodeReview] [MediaWiki r109964]: New comment added, and revision status changed

2012-01-24 Thread MediaWiki Mail
Johnduhart changed the status of MediaWiki.r109964 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109964#c30007 Old Status: fixme New Status: new Commit summary for MediaWiki.r109964: AFT5 - Add some qqq translation explanation, as a followup to r109075

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30008 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30009 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30010 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r109227]: New comment added

2012-01-24 Thread MediaWiki Mail
Tim Starling posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30011 Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here.

[MediaWiki-CodeReview] [MediaWiki r107980]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r107980 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107980 Old status: new New status: ok Commit summary for MediaWiki.r107980: * Added supported for container sharding via existing FileRepo-style hash paths. For sharded

[MediaWiki-CodeReview] [MediaWiki r108116]: Revision status changed

2012-01-24 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r108116 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108116 Old status: new New status: ok Commit summary for MediaWiki.r108116: * Made use of FileBackend function 'latest' param in FileOp. * Added FileBackend process cache for

[MediaWiki-CodeReview] [MediaWiki r109933]: New comment added

2012-01-24 Thread MediaWiki Mail
Peachey88 posted a comment on MediaWiki.r109933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109933#c30012 Commit summary for MediaWiki.r109933: Updated survey CTA to use different links for options 1, 2, and 3: -

  1   2   >