Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Bartosz Dziewoński]

On 2016-07-25 16:25, Ed Sanders wrote:

Will it show multiple children (split trees?)


Yes, unless something changed from how the "new change screen" option 
behaved on 2.8. But it'll just shove all the ancestors and all the 
descendants into a single list.


--
Bartosz Dziewoński

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Ed Sanders]

Where do I find links to the parent commit and child commit(s)? All I can
see currently is a link to the parent's diffusion commit(?!).

As someone who often commits a stack of 5+ dependent commits, these are
very useful to my workflow (or anyone reviewing my code).

On 22 July 2016 at 19:18, Bartosz Dziewoński  wrote:

> On 2016-07-21 01:02, Marcin Cieslak wrote:
>
>> my userid and a part of the search box are extending past right margin
>> off the screen, so I have to scroll to login (old version has this problem
>> too).
>>
>
> This is made worse by the new Gerrit by including more items in the
> default "My" menu. Luckily, it's customizable now, so after you log in, you
> can go to Settings → Preferences and remove some of them.
>
> --
> Bartosz Dziewoński
>
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Ed Sanders]

Will it show multiple children (split trees?)

On 25 July 2016 at 15:23, Bartosz Dziewoński  wrote:

> On 2016-07-25 16:20, Ed Sanders wrote:
>
>> Where do I find links to the parent commit and child commit(s)? All I can
>> see currently is a link to the parent's diffusion commit(?!).
>>
>> As someone who often commits a stack of 5+ dependent commits, these are
>> very useful to my workflow (or anyone reviewing my code).
>>
>
> They are under the dropdowns on the right, on the "Related Changes" tab.
> New Gerrit actually shows the whole stack there, rather than only direct
> children and parent.
>
>
> --
> Bartosz Dziewoński
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Bartosz Dziewoński]

On 2016-07-25 16:20, Ed Sanders wrote:

Where do I find links to the parent commit and child commit(s)? All I can
see currently is a link to the parent's diffusion commit(?!).

As someone who often commits a stack of 5+ dependent commits, these are
very useful to my workflow (or anyone reviewing my code).


They are under the dropdowns on the right, on the "Related Changes" tab. 
New Gerrit actually shows the whole stack there, rather than only direct 
children and parent.


--
Bartosz Dziewoński

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Marcin Cieslak]

Dnia 15.07.2016 Isarra Yos  napisał/a:
>
>   * Diffs - using icons for back to change, previous file, next file is
> very unclear and hard to find; new users will not see them and have
> any idea what to do with them. The current textual 'up to change',
> previous/next file is immediately clear and would be great to
> maintain. (The side-by-side and unified diff icons are also very
> strange, like fuzzy rgb blobs, but at least they're a bit clearer.
> Sort of.)

Those icons are extremely ugly and unreadable. Just plain black
arrows would be much better.

>   * Diff preferences - white text on black background is very bad,
> especially when it suddenly appears on top of an interface that uses
> black text on white.

In general, diff screen looks like taken from some completely different
app.

>   * The very narrow scrollbars are weird and unnecessary, and hard to
> use. 

Those wimpy scrollbars are barely visible and very hard to click on.

In short, the new diff screen is a disaster, but I never really use
it (only for comments if ever) - I prefer reviewing on the commandline
anyway.

Also I suffer badly (because of my outdated browser, maybe) from
the horizontal scrollitis:

my userid and a part of the search box are extending past right margin
off the screen, so I have to scroll to login (old version has this problem
too). 

This is strange, since generally interface tries very hard to adjust
to the current screen width.

The "Same Topic" gadget is also scrolling off the screen.
Actually after clicking a few changes it seems that it comes delivered
later to the screen, so suddenly the change metadata box resizes
to make a bit more room for the "Same Topic" feature.

"Same Topic" thing is potentially great but feels like a bolt on
right now (not so bad as the new diff screen though). (it's a plugin,
right?)

good things:

"Conflicts With" is GREAT!!! Barely noticed it's there
(scrolled off) but this is very much needed.
This should be an invitation for a completely new
collaboration scenarios.

patchlist/downloads removed from the main screen - good
- I was looking for it for a moment (as others already complained) 
but after giving it a bit of thought I am happy they are hidden.
Finally I can copy the URL easily with a simple X11 PRIMARY
selection.

Generally it feels more compact, unlike Isarra I am not sure we need
more padding.

Since it seems we have lost the contributors anyway after
the Gerrit migration I think we should upgrade anyway - things
seem to be a bit better this time.

Saper



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Gergo Tisza]

On the whole it is a huge improvement (thanks for all your work on this,
Chad & Daniel):
- finally one can navigate from the global comment to the inline comments
(although I wish they would stand out more in the history list)
- the super annoying bug where clicking anywhere on an old page with
no/different CSRF token would log you out is gone
- related commit list is nice (although it would be more useful if the
topic could be changed after the commit was merged, but I suppose it is
stored inside the commit itself so that's not possible)
- the personalisable "My" menu is very handy
- including the commit hook setup in the clone command is a nice convenience
- as others said before, merge status and inline editing are cool
- some of the new search options look very interesting (conflicts:,
is:mergeable, project prefix, commit size). And file search just works (
https://phabricator.wikimedia.org/T63463 is not needed), yay!

Some of the navigation changes are for the worse (hiding PS lists/download
links, new diff header) but not a big deal. Lack of wrapping is going to be
a major pain point though, as others have noted.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Isarra Yos]

On 13/07/16 06:50, Niklas Laxström wrote:

Many good and bad changes I can live with. One thing I will miss:
* Columns setting no longer wraps the diff lines. Horizontal scroll is
now unavoidable and cumbersome due to having to use either the mouse
or the arrow keys to move the cursor on the line.


Yeah, if it's possible to make these wrap instead of horizontal 
scrolling, that would be great. There is way too much scrolling 
everywhere, even on large displays.


Here's a bunch of other design things I'm hoping we can fix, since 
they're all a bit glaring:


 * Diffs - using icons for back to change, previous file, next file is
   very unclear and hard to find; new users will not see them and have
   any idea what to do with them. The current textual 'up to change',
   previous/next file is immediately clear and would be great to
   maintain. (The side-by-side and unified diff icons are also very
   strange, like fuzzy rgb blobs, but at least they're a bit clearer.
   Sort of.)
 * Commit message - limiting the height doesn't really help anything
   since if there's a long commit message, presumably it's long for a
   reason and we still want to see it. And it really makes it worse on
   small screens where we need to scroll through everything anyway, so
   the fewer separate things we need to scroll through, the better.
 * Diff preferences - white text on black background is very bad,
   especially when it suddenly appears on top of an interface that uses
   black text on white.

 * Padding - please more. Things should not be shoved up against other
   things. It makes them hard to pick out and read things at a glance,
   and the entire thing looks a lot messier and overly busy than it
   actually is; there should be padding around each bit of content (esp
   the commit message stuff), and at the end of blocks in order to
   distinguish them from the blocks that come after.
 * The very narrow scrollbars are weird and unnecessary, and hard to
   use. Considering most people are probably either on a system that
   already has similar by default (and hides them when not in use), or
   have large system scrollbars for a reason (hi), would it be possible
   to just remove that?

 * hrs probably need styles
 * Solid black lines are generally bad

 * Is there any way we can put the different file opening options back
   on the main change page? The view side-by-side diff, view unified
   diff, and now the edit file option too, instead of only having the
   filename as a link? It opening up to whatever mode was last open is
   really weird behaviour, especially with edit, since closing the edit
   mode always dumps the user back onto the main change page instead of
   going back to viewing the diff, and then when they click on the file
   again it takes them back into edit mode, which they don't want, and
   the obvious path at that point is 'close', even though the only way
   back to the diffs for anything at that point is the rather ambiguous
   icons in the corner of the edit thing.


Assuming it's at least pretty trivial to append css, here's a quick fix 
for the commit message box:


.com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-collapsed 
.com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-scroll {

padding: 1em;
height: auto;
}
.com-google-gerrit-client-change-CommitBox_BinderImpl_GenCss_style-header {
padding: 1em;
}

Quick fix for the diff preferences:

.com-google-gerrit-client-diff-PreferencesBox_BinderImpl_GenCss_style-dialog 
{

background: rgba( 240, 240, 240, .9 );
color: #000;
border: solid 1px #ccc;
text-shadow: none;
}
.com-google-gerrit-client-diff-PreferencesBox_BinderImpl_GenCss_style-table 
td,
.com-google-gerrit-client-diff-PreferencesBox_BinderImpl_GenCss_style-table 
th {

color: #000;
}

Maybe?

hr {
border: solid 1px #ccc;
}

Note that all colours are made up on the spot, I don't know anything 
about how gerrit actually comes up with these crazy class names, so 
nothing is really guaranteed with these snippets, etc etc. But please, 
if we can make this better, that would be great. Some of the new 
features are already great. Also the other things.


-I
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Markus Glaser]

This update will definitely improve our experience with git. As others have 
said before, the inline editing will greatly speed up the review process and 
improve code quality. This is especially true for the extensions, as you now do 
not have to clone a repo or reject the commit just to fix a typo or some coding 
conventions. Thanks for making this happen! 

I found that the behavior of my old search filters has changed. I used to look 
for bluespice status:open to get all open commits in all bluespice repos. This 
however does not work in the test instance, I only get a small subset of the 
commits I need to see. There are ways around this, e.g. ownerin:bluespice 
status:open, so I am not too concerned about it. Am not sure whether it affects 
other extension writers, though.

Cheers,

Markus
(mglaser)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Legoktm]

On 07/12/2016 07:45 PM, Bartosz Dziewoński wrote:
> I have tested it and I love it. It is all I was hoping it would be and
> more. The inline commit editing is quite nice, the lists of related
> commits are useful, but the warnings about merge conflicts are the best
> thing ever. The sooner it's live, the better!

This. Thanks to everyone who is making this upgrade happen <3

-- Legoktm

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Paladox]

I really like that you can now edit in browser without needing to clone the 
repo now making mobile editing possible now.
But one thing there is no testing? 

On Wednesday, 13 July 2016, 8:08, John Mark Vandenberg  
wrote:
 

 On Wed, Jul 13, 2016 at 10:03 AM, Chad  wrote:
> On Tue, Jul 12, 2016 at 7:39 PM Danny B.  wrote:
>> I assume that the slowness is just because it is testing environment and
>> production will be faster, but just in case, I'm mentioning that too (ask
>> for details should you need any).
>>
>>
> I'm not seeing slowness myself, but I have heard this complaint from a
> few others. For what it's worth, this *is* running on production hardware
> with higher specs than the old machine, so if anything it should be faster!
> There's some new features and other things we're not quite making use
> of yet, so we might need to do some further fine-tuning.

My laptop (Intel i3-2310M CPU @ 2.10GHz × 4) with Firefox on Ubuntu
isn't liking the extra client side workload being asked of it.

I'll survive.

-- 
John Vandenberg

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

  
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[John Mark Vandenberg]

On Wed, Jul 13, 2016 at 10:03 AM, Chad  wrote:
> On Tue, Jul 12, 2016 at 7:39 PM Danny B.  wrote:
>> I assume that the slowness is just because it is testing environment and
>> production will be faster, but just in case, I'm mentioning that too (ask
>> for details should you need any).
>>
>>
> I'm not seeing slowness myself, but I have heard this complaint from a
> few others. For what it's worth, this *is* running on production hardware
> with higher specs than the old machine, so if anything it should be faster!
> There's some new features and other things we're not quite making use
> of yet, so we might need to do some further fine-tuning.

My laptop (Intel i3-2310M CPU @ 2.10GHz × 4) with Firefox on Ubuntu
isn't liking the extra client side workload being asked of it.

I'll survive.

-- 
John Vandenberg

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Niklas Laxström]

Many good and bad changes I can live with. One thing I will miss:
* Columns setting no longer wraps the diff lines. Horizontal scroll is
now unavoidable and cumbersome due to having to use either the mouse
or the arrow keys to move the cursor on the line.

Tips for others:
* I previously used 'r' to go straight to publishing my comments. This
shortcut is now 'a'.
* 'x' expands all history – the preference for having it always
expanded seems to be gone.

  -Niklas

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Bahodir Mansurov]

Great! I especially like how scrolling works when comparing old and new  
versions of files.


Thanks for upgrading.


On Wed, 13 Jul 2016 06:17:58 +0500, Chad Horohoe   
wrote:



Hi,

Daniel and I have been spending a lot of time in the last week preparing  
a

smooth upgrade
path for Gerrit to a new (and supported version). The migration will be
coming soon but I could
use your help testing things in the meantime.

https://gerrit-new.wikimedia.org/r/

The database is a snapshot from last week and the git data is up to date  
as

of a few hours
ago. Please use this opportunity to test the new installation and make  
sure

it works for you.
Make a change. Do some reviews. Do the things you usually would.

Again, this is snapshot data so: A) Don't worry about messing up the real
install, and B) Don't
expect any changes to persist after the migration.

If nobody identifies any major blockers, we'll go ahead and set an  
upgrade

time for the
immediate future.

Thanks so much!

-Chad & Daniel
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l



--
Baha

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Chad]

On Tue, Jul 12, 2016 at 7:39 PM Danny B.  wrote:

> First of all - thanks for putting the effort to upgrade!
>
> Unfortunately that is the last positive sentence I'll have here. However,
> it
> is not your fault at all. It is all about expectations. And my expectations
> were that the UI/UX will be much more mature than the current version we
> use. However, my biggest expectation turned into biggest disappointment.
>
>
I'm sorry that you had this expectation. Gerrit has always been a tool
written by engineers for engineers and has never benefited from a
dedicated design team working on it (to my knowledge). While I think
some things have improved, it's definitely still got rough edges and a
learning curve.


> Things are yet more unintuitive and crazy than in the current version.
> Three
> outstanding examples on behalf of others:
> 1) It took me quite a long time to find a way, how to switch between
> patchsets. Not even mentioning I can't compare them.
>

You can still compare them, it's with the "Diff against" dropdown that
defaults to "Base." It's right above the filename listing.


> 2) It took me also quite a long time to find a way, how to add new comment.
>

That reply button could be a little bigger, but yeah, the thing I'll mainly
point out is that the various action buttons have been moved closer to
the top.


> 3) The commit message is in width limited box, which causes most of the
> messages to be partially invisible and necessity to scroll.
> [I'm not going to say the solutions here, everybody should experience on
> their own...]
>
>
I see what you mean here. Maybe a CSS tweak to make it wider by default?


> I assume that the slowness is just because it is testing environment and
> production will be faster, but just in case, I'm mentioning that too (ask
> for details should you need any).
>
>
I'm not seeing slowness myself, but I have heard this complaint from a
few others. For what it's worth, this *is* running on production hardware
with higher specs than the old machine, so if anything it should be faster!
There's some new features and other things we're not quite making use
of yet, so we might need to do some further fine-tuning.


> I apologize for not being positive, I can imagine that being discouraging.
> On the other hand I can see one promise behind that: I believe this will be
> another kicker for faster migration to Differential & co.


I'm not discouraged. Thank you for the feedback!


> For the time being
> - do any skins exist? If yes, wouldn't it be worth it to investigate them
> and possibly install any instead of the default one?
>
>
No, there are no such things as skins in Gerrit. We can adjust a few things
here and there with some CSS and header files, but there's no real support
for a UI other than what Gerrit ships.

-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Bartosz Dziewoński]

I have tested it and I love it. It is all I was hoping it would be and 
more. The inline commit editing is quite nice, the lists of related 
commits are useful, but the warnings about merge conflicts are the best 
thing ever. The sooner it's live, the better!


--
Bartosz Dziewoński

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

[Danny B.]

First of all - thanks for putting the effort to upgrade!

Unfortunately that is the last positive sentence I'll have here. However, it
is not your fault at all. It is all about expectations. And my expectations 
were that the UI/UX will be much more mature than the current version we 
use. However, my biggest expectation turned into biggest disappointment.

Things are yet more unintuitive and crazy than in the current version. Three
outstanding examples on behalf of others:
1) It took me quite a long time to find a way, how to switch between 
patchsets. Not even mentioning I can't compare them.
2) It took me also quite a long time to find a way, how to add new comment.
3) The commit message is in width limited box, which causes most of the 
messages to be partially invisible and necessity to scroll.
[I'm not going to say the solutions here, everybody should experience on 
their own...]

I assume that the slowness is just because it is testing environment and 
production will be faster, but just in case, I'm mentioning that too (ask 
for details should you need any).

I apologize for not being positive, I can imagine that being discouraging. 
On the other hand I can see one promise behind that: I believe this will be 
another kicker for faster migration to Differential & co. For the time being
- do any skins exist? If yes, wouldn't it be worth it to investigate them 
and possibly install any instead of the default one?


Kind regards


Danny B.


-- Původní zpráva --
Od: Chad Horohoe 
Komu: wikitech-l@lists.wikimedia.org, Development and Operations engineers 
(WMF only) 
Datum: 13. 7. 2016 3:19:16
Předmět: [Wikitech-l] Gerrit 2.12.2 test instance - PLEASE TEST

"Hi,

Daniel and I have been spending a lot of time in the last week preparing a
smooth upgrade
path for Gerrit to a new (and supported version). The migration will be
coming soon but I could
use your help testing things in the meantime.

https://gerrit-new.wikimedia.org/r/

The database is a snapshot from last week and the git data is up to date as
of a few hours
ago. Please use this opportunity to test the new installation and make sure
it works for you.
Make a change. Do some reviews. Do the things you usually would.

Again, this is snapshot data so: A) Don't worry about messing up the real
install, and B) Don't
expect any changes to persist after the migration.

If nobody identifies any major blockers, we'll go ahead and set an upgrade
time for the
immediate future.

Thanks so much!

-Chad & Daniel
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l;
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l