Re: [Wireshark-dev] RPM generation

2018-04-23 Thread Joakim Karlsson
Hi, >From what I notice when trying create rpm on RHEL7, is that CMake utilize pkg-config, which is nice. But when ninja/make rpm-package is executed, that part seems to stop. Instead we rely on rpm instead. which cmake /app/vbuild/RHEL7-x86_64/cmake/3.7.2-1/bin/cmake cmake -G Ninja

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Peter Wu
Hi Anders, On Thu, Apr 19, 2018 at 06:40:27PM +, Anders Broman wrote: > Hi, > Running cmake and make works > Cmake and make rpm-package fails on the make rpm-package part. > Included log from make rpm-package. I cannot see an obvious error, is it possible that you ran out of memory or disk

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Peter Wu
Hey Anders, On Thu, Apr 19, 2018 at 05:59:18PM +, Anders Broman wrote: > Hi, > Logs included. Could you include the normal CMake output? (Not the output or error log file.) -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Peter Wu
On Thu, Apr 19, 2018 at 10:46:19AM -0700, Guy Harris wrote: > On Apr 19, 2018, at 9:44 AM, Peter Wu wrote: > > > Look for errors early in the process. For instance, without gcc-c++ > > installed on CentOS, I would get a very cryptic error down the road. > > I.e., if you

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Guy Harris
On Apr 19, 2018, at 9:44 AM, Peter Wu wrote: > Look for errors early in the process. For instance, without gcc-c++ > installed on CentOS, I would get a very cryptic error down the road. I.e., if you don't have C and C++ compilers installed, you get a very cryptic error

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Peter Wu
On Thu, Apr 19, 2018 at 03:12:33PM +, Anders Broman wrote: > Hi, > I’m struggling with my local build now which is a SVN checkout. I have > managed to get the tarball built and the build continues from there but stops > with: > > -- Found Subversion: /usr/bin/svn (found version "1.8.19") >

Re: [Wireshark-dev] RPM generation

2018-04-19 Thread Anders Broman
ark-dev-boun...@wireshark.org] On Behalf Of Dario Lombardo Sent: den 11 april 2018 11:06 To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Subject: Re: [Wireshark-dev] RPM generation With the last changes I submitted, this is the current situation: Centos: ninja: w

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Dario Lombardo
On Mon, Apr 16, 2018 at 12:53 PM, Peter Wu wrote: > > This seems to limit the rpm-package target to git trees, source tarballs > seems unsupported, is that intentional? The autotools config did not > have this limitation from what I can tell. > It _was_ limiting. Anders

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Peter Wu
On Mon, Apr 16, 2018 at 12:13:09PM +0200, Dario Lombardo wrote: > I was just pointing out that sometimes (like the openSUSE %cmake > macro) there is the general assumption that the build dir is under the > source dir. This assumption can be found in wireshark/CMakeLists.txt, > under the

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Dario Lombardo
On Mon, Apr 16, 2018 at 10:22 AM, Peter Wu wrote: > > Which instructions? I looked for "cmake -" in the source tree, and all > documentation in docbook/ suggest a build dir next to the source dir. > The only example that creates a build dir in the source tree is the > Gitlab

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Dario Lombardo
-- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On > Behalf Of Peter Wu > Sent: den 16 april 2018 10:22 > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > Subject: Re: [Wireshark-dev] RPM generation > > On Mon, Apr 16, 2018 at 09:02:1

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Anders Broman
ubject: Re: [Wireshark-dev] RPM generation On Mon, Apr 16, 2018 at 09:02:18AM +0200, Dario Lombardo wrote: > On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman <a.broma...@gmail.com> wrote: > > > > > I followed the way I do it on Windows, which I think is the > > recommend

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Peter Wu
On Mon, Apr 16, 2018 at 09:02:18AM +0200, Dario Lombardo wrote: > On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman wrote: > > > > > I followed the way I do it on Windows, which I think is the recommended > > way there :-) > > > > > The cmake instructions I found always

Re: [Wireshark-dev] RPM generation

2018-04-16 Thread Dario Lombardo
On Mon, Apr 16, 2018 at 5:32 AM, Anders Broman wrote: > > I followed the way I do it on Windows, which I think is the recommended > way there :-) > > The cmake instructions I found always suggest to have the build dir under the source. For instance the openSUSE %cmake macro

Re: [Wireshark-dev] RPM generation

2018-04-15 Thread Anders Broman
Den sön 15 apr. 2018 23:05Dario Lombardo skrev: > Ok, I got the point. I always built the rpm from a build dir under the > source dir. > With your approach, the rpm-package target fails because of the lack of a > parent git directory. It expects to retrieve the

Re: [Wireshark-dev] RPM generation

2018-04-15 Thread Dario Lombardo
Ok, I got the point. I always built the rpm from a build dir under the source dir. With your approach, the rpm-package target fails because of the lack of a parent git directory. It expects to retrieve the current version using 'git describe', and it can't because it has no clue on where the

Re: [Wireshark-dev] RPM generation

2018-04-15 Thread Anders Broman
z4_frame. Change-Id: I25619260572163872915c56bcf242e8ff8190b47 lines 18-40 From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Dario Lombardo Sent: den 14 april 2018 09:36 To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Subject: Re: [Wireshark-dev] RPM genera

Re: [Wireshark-dev] RPM generation

2018-04-14 Thread Dario Lombardo
e.org/technical-corner/bcg729/overview> >>>>> >>>>>Support for G.729 codec in RTP player >>>>> >>>>> * DOXYGEN >>>>> >>>>> * MaxMindDB >>>>> >>>>> >>>>> >>&g

Re: [Wireshark-dev] RPM generation

2018-04-14 Thread Dario Lombardo
of the parent directories): .git >>> >>> CMake Error at CMakeLists.txt:2934 (string): >>> >>> string begin index: 1 is out of range 0 - 0 >>> >>> >>> >>> >>> >>> -- Configuring incomplete, errors occurred!

Re: [Wireshark-dev] RPM generation

2018-04-14 Thread Dario Lombardo
e.org/technical-corner/bcg729/overview> >>>>> >>>>>Support for G.729 codec in RTP player >>>>> >>>>> * DOXYGEN >>>>> >>>>> * MaxMindDB >>>>> >>>>> >>>>> >>&g

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Anders Broman
> * DOXYGEN >>>> >>>> * MaxMindDB >>>> >>>> >>>> >>>> fatal: Not a git repository (or any of the parent directories): .git >>>> >>>> CMake Error at CMakeLists.txt:2934 (string): >>>> >>>

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Dario Lombardo
of the parent directories): .git >>> >>> CMake Error at CMakeLists.txt:2934 (string): >>> >>> string begin index: 1 is out of range 0 - 0 >>> >>> >>> >>> >>> >>> -- Configuring incomplete, errors occurred!

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Anders Broman
xt:2934 (string): >> >> string begin index: 1 is out of range 0 - 0 >> >> >> >> >> >> -- Configuring incomplete, errors occurred! >> >> >> >> >> >> Regards >> >> Anders >> >> >&g

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Dario Lombardo
e, errors occurred! > > > > > > Regards > > Anders > > > > *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On > Behalf Of *Dario Lombardo > *Sent:* den 13 april 2018 13:37 > *To:* Developer support list for Wireshark <wireshark-dev@w

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Anders Broman
d! Regards Anders From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Dario Lombardo Sent: den 13 april 2018 13:37 To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Subject: Re: [Wireshark-dev] RPM generation With the last changes pushed, I'm abl

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Dario Lombardo
With the last changes pushed, I'm able to make openSUSE work. Since this was pointed out as blocking for autotools removal, we can proceed, as soon as Anders confirms. Anyone already working on autotools removal? On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo

Re: [Wireshark-dev] RPM generation

2018-04-13 Thread Dario Lombardo
Perfect. Centos, Fedora and openSUSE are the three under testing. openSUSE is rather different from the others, and I'm pushing some changes specific for that, trying not to break the others :). On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss wrote: > On 04/10/2018

Re: [Wireshark-dev] RPM generation

2018-04-12 Thread Jeff Morriss
On 04/10/2018 09:14 AM, Dario Lombardo wrote: Is the rpm build platform expected to be one? If yes, which one? If no, do we want to support all the flavors? It seems that different flavors require different package names (link in asciidoctor). I can be hard to be portable in this way. The

Re: [Wireshark-dev] RPM generation

2018-04-11 Thread Dario Lombardo
With the last changes I submitted, this is the current situation: Centos: ninja: works make: works openSUSE: ninja/make: build now starts, but the compilation fails (cc: error: unrecognized command line option '-Wheader-guard'). This switch doesn't show up when running the straight 'ninja'

Re: [Wireshark-dev] RPM generation

2018-04-10 Thread Anders Broman
Den tis 10 apr. 2018 23:11Dario Lombardo skrev: > > > On Tue, Apr 10, 2018 at 4:53 PM, Anders Broman > wrote: > >> >> >> Den tis 10 apr. 2018 21:15Dario Lombardo >> skrev: >> >>> Update on building the RPM on

Re: [Wireshark-dev] RPM generation

2018-04-10 Thread Dario Lombardo
On Tue, Apr 10, 2018 at 4:53 PM, Anders Broman wrote: > > > Den tis 10 apr. 2018 21:15Dario Lombardo > skrev: > >> Update on building the RPM on centos: >> >> - asciidoctor pkg is called rubygem-asciidoctor.noarch >> > > I think we should add

Re: [Wireshark-dev] RPM generation

2018-04-10 Thread Dario Lombardo
The target is actually called rpm-package. https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html On Tue, Apr 10, 2018 at 2:20 PM, Dario Lombardo wrote: > > > On Tue, Apr 10, 2018 at 11:46 AM, Anders Broman < > anders.bro...@ericsson.com> wrote: > >>

Re: [Wireshark-dev] RPM generation

2018-04-10 Thread Dario Lombardo
On Tue, Apr 10, 2018 at 11:46 AM, Anders Broman wrote: > Hi, > > What I did: > > On SuSe 12.2 git clone Wireshark > > Create a build dir > > In the Build dir run: > > cmake -G "Unix Makefiles" ../wireshark > > > > run: > > make rpm-build > > > I'm trying on centos 7,