RE: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-30 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > Hi Henry, > > > +{ > > +paddr_t bank_start = INVALID_PADDR, bank_end = 0; > > +paddr_t region_end = region_start + region_size; >

[PATCH v2 4/4] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()

2023-01-29 Thread Henry Wang
the code and the above in-code comment mentioning it. Signed-off-by: Henry Wang Reviewed-by: Michal Orzel --- I am not entirely sure if I should also drop the "TODO" on top of the p2m_set_entry(). Because although we are sure there is no p2m pages populated in domain_create() stage n

[PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-29 Thread Henry Wang
://lore.kernel.org/xen-devel/e6643bfc-5bdf-f685-1b68-b28d34107...@xen.org/ Signed-off-by: Henry Wang --- v1 -> v2: 1. Correct style in in-code comment. 2. Avoid open-coding gfn_eq() and gaddr_to_gfn(d->arch.vgic.cbase). 3. Apply same changes for the new vGICv2 implementation, update the commit m

[PATCH v2 2/4] xen/arm: Rename vgic_cpu_base and vgic_dist_base for new vGIC

2023-01-29 Thread Henry Wang
names in struct vgic_dist for these two implementations. Therefore, this commit renames the vgic_cpu_base and vgic_dist_base for new vGIC to cbase and dbase. So we can use the same code in the data abort trap handling code for both vGIC implementations. Signed-off-by: Henry Wang --- v1 -> v2

[PATCH v2 1/4] xen/arm: Reduce redundant clear root pages when teardown p2m

2023-01-29 Thread Henry Wang
(). With this movement, the `page_list_empty(>pages)` check can be dropped. Signed-off-by: Henry Wang Reviewed-by: Michal Orzel Acked-by: Julien Grall --- v1 -> v2: 1. Move in-code comment for p2m_force_tlb_flush_sync() on top of p2m_clear_root_pages(). 2. Add Reviewed-by tag from Michal and

[PATCH v2 0/4] P2M improvements for Arm

2023-01-29 Thread Henry Wang
entation, update the commit message accordingly. 6. Add in-code comment in old GICv2's vgic_v2_domain_init() and new GICv2's vgic_v2_map_resources() to mention the mapping of the virtual CPU interface is deferred until first access. 7. Add reviewed-by and acked-by tags accordingly. Henry Wan

[PATCH v3 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory

2023-01-29 Thread Henry Wang
-by: Henry Wang Reviewed-by: Stefano Stabellini --- v2 -> v3: 1. Rebase on top of patch #1 and #2. 2. Add Stefano's Reviewed-by tag. v1 -> v2: 1. Rebase on top of patch #1 and #2. --- xen/arch/arm/efi/efi-boot.h | 10 -- xen/arch/arm/setup.c| 6 ++ 2 files changed, 14 insertions

[PATCH v3 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2023-01-29 Thread Henry Wang
()` and uses this helper to extend the check in function `check_reserved_regions_overlap()` so that memory regions in bootinfo.modules are included. Use `check_reserved_regions_overlap()` in `add_boot_module()` to return early if any error occurs. Signed-off-by: Henry Wang --- v2 -> v3: 1. Use &quo

[PATCH v3 0/3] Memory region overlap check in device tree

2023-01-29 Thread Henry Wang
e return type of helper functions to bool. 3. Use 'start' and 'size' in helper functions to describe a region. v1 -> v2: - Split original `overlap_check()` to `meminfo_overlap_check()` and `bootmodules_overlap_check()`. - Rework commit message. Henry Wang (3): xen/arm: Add memo

[PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-29 Thread Henry Wang
defined in bootinfo. After that, use `check_reserved_regions_overlap()` in `device_tree_get_meminfo()` to do the overlap check of (1) and (2) and replace the original overlap check of (3) with `check_reserved_regions_overlap()`. Signed-off-by: Henry Wang --- v2 -> v3: 1. Use "[start, end]

RE: [PATCH v5 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping

2023-01-27 Thread Henry Wang
ables so it is > easy to create the mapping afterwards. > - update_identity_mapping() will create/remove the identity mapping > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang With some nits below that can definitely be fixed on commit. Tested on FVP in Arm64 mode, so: Tested-b

RE: [PATCH v5 1/5] xen/arm32: head: Widen the use of the temporary mapping

2023-01-27 Thread Henry Wang
is not overlapping with the temporary mapping. > > This also has the advantage to simplify the logic to identity map > Xen. > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested on FVP in Arm32 mode, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn

2023-01-27 Thread Henry Wang
gt; > Take the opportunity to solve some coding style issues around the > code modified. > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested the build: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH] xen/common: Constify the parameter of _spin_is_locked()

2023-01-27 Thread Henry Wang
cked is taken when the Nit: s/locked/lock/ This definitely can be fixed on commit. > underlying structure is const. > > Signed-off-by: Julien Grall I tried to test this patch on FVP (both Arm32 and Arm64) to play safe. This patch is good (as expected of course :)), so: Reviewed-b

RE: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()

2023-01-27 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > Subject: Re: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and > p2m_final_teardown() > > Hi Henry, > > On 27/01/2023 12:15, Henry Wang wrote: > > > > > > Hi Michal, > > > >

RE: [PATCH v2 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-27 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH v2 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > +printk("Region %#"PRIpaddr" - %#"PRIpaddr" overlapping with > bank[%u] %#"PRIpaddr" - %#"PRIpaddr"\n", > > AFAICT, in messages, the end would be

RE: [PATCH v2 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-27 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH v2 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > Hi Henry, > > On 14/12/2022 03:16, Henry Wang wrote: > > > > +static int __init meminfo_over

RE: [PATCH] Changelog: Add details about new features for SPR

2023-01-27 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: [PATCH] Changelog: Add details about new features for SPR > > Signed-off-by: Andrew Cooper Thanks for remembering this :) Acked-by: Henry Wang > --- > A reminder to everyone, write the changelog

RE: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-27 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until > the first access > > @@ -153,6 +153,8 @@ struct vgic_dist { > >/* Base address for guest GIC */ > >paddr_t dbase; /* Distributor

RE: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-27 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until > the first access > > Hi, > > >>> @@ -153,6 +153,8 @@ struct vgic_dist { > >>> /* Base address for guest GIC */ > >>> paddr_t dbase; /*

RE: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()

2023-01-27 Thread Henry Wang
Hi Michal, > -Original Message- > >> > >> -BUG_ON(p2m_teardown(d, false)); > > Because you remove this, > >> ASSERT(page_list_empty(>pages)); > > you no longer need this assert, right? > I think the ASSERT() is still useful as it at least show that the pages > should have been

RE: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-27 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > Subject: Re: [PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until > the first access > > Hi Henry, > > On 16/01/2023 02:58, Henry Wang wrote: > > Note that GICv2 changes introduce

RE: [PATCH 1/3] xen/arm: Reduce redundant clear root pages when teardown p2m

2023-01-27 Thread Henry Wang
Hi Michal and Julien, Apologies for the late response. > -Original Message- > >> +PROGRESS(p2m_root): > >> +/* > >> + * We are about to free the intermediate page-tables, so clear the > >> + * root to prevent any walk to use them. > > The comment from here...

RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation

2023-01-17 Thread Henry Wang
Hi Michal, > -Original Message- > Subject: RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation > > >> -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) > > >> +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (266 - 256)) > > > > > > From the commit message "L0

RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation

2023-01-17 Thread Henry Wang
it the way it is because at least it matches > how x86 defines the DIRECTMAP_SIZE and it also matches the usual way of > calculating the size > which is subtracting the start address of that region from the start address > of > the next region > (e.g. VMAP_VIRT_SIZE calculation on

RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation

2023-01-16 Thread Henry Wang
am open to discussion if you or maintainers have other opinions. Maybe we can also putting a comment on top of the macro to explain this calculation. I did test this patch on FVP using XTP in both arm32 and arm64 execution mode, and this patch is good, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH] xen/arm: Harden setup_frametable_mappings

2023-01-16 Thread Henry Wang
fined by FRAMETABLE_SIZE macro. > > Update the comments regarding the frametable in asm/config.h and take > the opportunity to remove unused macro FRAMETABLE_VIRT_END on arm32. > > Signed-off-by: Michal Orzel Reviewed-by: Henry Wang I've also used XTP to test this patch on FVP in both a

[PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()

2023-01-15 Thread Henry Wang
the code and the above in-code comment mentioning it. Signed-off-by: Henry Wang --- I am not entirely sure if I should also drop the "TODO" on top of the p2m_set_entry(). Because although we are sure there is no p2m pages populated in domain_create() stage now, but we are not sure if anyon

[PATCH 2/3] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-15 Thread Henry Wang
-f685-1b68-b28d34107...@xen.org/ Signed-off-by: Henry Wang --- xen/arch/arm/include/asm/vgic.h | 2 ++ xen/arch/arm/traps.c| 19 --- xen/arch/arm/vgic-v2.c | 25 ++--- 3 files changed, 24 insertions(+), 22 deletions(-) diff --git a/xen/arch/ar

[PATCH 1/3] xen/arm: Reduce redundant clear root pages when teardown p2m

2023-01-15 Thread Henry Wang
(). With this movement, the `page_list_empty(>pages)` check can be dropped. Signed-off-by: Henry Wang --- Was: [PATCH v2] xen/arm: Reduce redundant clear root pages when teardown p2m. Picked to this series with changes in original v1: 1. Introduce a new PROGRESS for p2m_clear_root_pages() to av

[PATCH 0/3] P2M improvements for Arm

2023-01-15 Thread Henry Wang
-cea6-893f-abf30ff95...@xen.org/ [2] https://lore.kernel.org/xen-devel/e6643bfc-5bdf-f685-1b68-b28d34107...@xen.org/ Henry Wang (3): xen/arm: Reduce redundant clear root pages when teardown p2m xen/arm: Defer GICv2 CPU interface mapping until the first access xen/arm: Clean-up i

RE: [PATCH v4 08/14] xen/arm32: head: Introduce an helper to flush the TLBs

2023-01-13 Thread Henry Wang
are only supporting IVIPT cache on arm32, so the instruction > cache flush is only necessary when executable code is modified. > None of the boot code is doing that. > * The instruction cache is not invalidated and misprediction is not > a problem at boot. > > Si

RE: [PATCH v4 07/14] xen/arm32: head: Jump to the runtime mapping in enable_mmu()

2023-01-13 Thread Henry Wang
> mov_w. > > Signed-off-by: Julien Grall > Reviewed-by: Stefano Stabellini I've tested this patch on FVP in arm32 execution mode, and this patch is good, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =" with "mov_w rX, "

2023-01-13 Thread Henry Wang
d-by: Stefano Stabellini I've tested this patch on FVP in arm32 execution mode, and this patch is good, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 05/14] xen/arm: Clean-up the memory layout

2023-01-13 Thread Henry Wang
ry mapping in the common region from the previous one. > > Take the opportunity to: > * add missing *_SIZE for FIXMAP_VIRT_* and XEN_VIRT_* > * switch to MB()/GB() to avoid hexadecimal (easier to read) > > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 04/14] xen/arm: flushtlb: Reduce scope of barrier for the TLB range flush

2023-01-13 Thread Henry Wang
ee asm/arm{32,64}/flushtlb.h. > > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 03/14] xen/arm32: flushtlb: Reduce scope of barrier for local TLB flush

2023-01-13 Thread Henry Wang
s barrier after local TLB flushes could be reduced to > non-shareable. > > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel I've tested this patch on FVP in arm32 execution mode using the same testing approach for patch#1, and this patch is good, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 02/14] xen/arm64: flushtlb: Implement the TLBI repeat workaround for TLB flush by VA

2023-01-13 Thread Henry Wang
h#1 on every board that I can find, including some Neoverse N1 boards, and this patch looks good, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH v4 01/14] xen/arm64: flushtlb: Reduce scope of barrier for local TLB flush

2023-01-13 Thread Henry Wang
I've tested this patch on FVP. The dom0 boots fine, linux & zephyr guests can be started and destroyed without issue, so: Tested-by: Henry Wang Kind regards, Henry

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2023-01-08 Thread Henry Wang
; > Sorry for the delay but I have very limited access to my mails right now. > > > >> On 9 Dec 2022, at 23:11, Stefano Stabellini >> <mailto:sstabell...@kernel.org>> wrote: > >> > >> On Fri, 9 Dec 2022, Julien Grall wrote: > >>> Hi

RE: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables

2023-01-06 Thread Henry Wang
ew attribute that will be match __init > if hotplug is supported otherwirse it would be a NOP. But I don't think > this is related to this series (most of the function used for bringup > are not in __init). Agreed. > > >> +static inline bool init_domheap_mappings(unsigned int cp

RE: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the directmap

2023-01-06 Thread Henry Wang
d > long base_mfn, > directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; > } > #else /* CONFIG_ARM_64 */ > -/* Map the region in the directmap area. */ > +/* > + * This either populate a valid fdirect map, or allocates empty L1 tables I guess this is a typo: s/fdirect/direct/ ? Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH 21/22] xen/arm64: Implement a mapcache for arm64

2023-01-06 Thread Henry Wang
on the command line). > > Take the opportunity to replace first_table_offset(...) with offsets[...]. > > Note that, so far, arch_mfns_in_directmap() always return true on Nit: s/return/returns/ > arm64. So the mapcache is not yet used. This will change in a > follow-up patch. > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables

2023-01-06 Thread Henry Wang
t" anyway so this is not a strong argument. > +#else > +static inline bool init_domheap_mappings(unsigned int cpu) (and also here) Either you agree with above "__init" comment or not: Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH 19/22] xen/arm32: mm: Rename 'first' to 'root' in init_secondary_pagetables()

2023-01-06 Thread Henry Wang
t table start at level 0 rather than level 1. Nit: s/start at/starts at/ > > So rename 'first' to 'root'. > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry

RE: [PATCH 12/22] xen/arm: fixmap: Rename the fixmap slots to follow the x86 convention

2023-01-06 Thread Henry Wang
an > FIXMAP. > > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry

[ANNOUNCEMENT] Xen 4.17 is released

2022-12-14 Thread Henry Wang
everyone who contributed to this release. This release would not have happened without all the awesome contributions from around the globe. Kind regards, Henry Wang (on behalf of the Xen Project Hypervisor team)

[PATCH v2] xen/arm: Reduce redundant clear root pages when teardown p2m

2022-12-13 Thread Henry Wang
(). With this movement, the `page_list_empty(>pages)` check can be dropped. Signed-off-by: Henry Wang --- v1 -> v2: 1. Introduce a new PROGRESS for p2m_clear_root_pages() to avoid multiple calling when p2m_teardown() is preempted. 2. Move p2m_force_tlb_flush_sync() to p2m_clear_root_pages(). --

[PATCH v2 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory

2022-12-13 Thread Henry Wang
-by: Henry Wang --- v1 -> v2: 1. Rebase on top of patch #1 and #2. --- xen/arch/arm/efi/efi-boot.h | 10 -- xen/arch/arm/setup.c| 6 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 43a836c3a7..6121ba1

[PATCH v2 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2022-12-13 Thread Henry Wang
()` and uses this helper to extend the check in function `check_reserved_regions_overlap()` so that memory regions in bootinfo.modules are included. Use `check_reserved_regions_overlap()` in `add_boot_module()` to return early if any error occurs. Signed-off-by: Henry Wang --- v1 -> v2: 1. Split origi

[PATCH v2 0/3] Memory region overlap check in device tree

2022-12-13 Thread Henry Wang
eck()` and `bootmodules_overlap_check()`. - Rework commit message. Henry Wang (3): xen/arm: Add memory overlap check for bootinfo.reserved_mem xen/arm: Extend the memory overlap check to include bootmodules xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory xen/arch/arm/bootfd

[PATCH v2 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-13 Thread Henry Wang
defined in bootinfo. After that, use `check_reserved_regions_overlap()` in `device_tree_get_meminfo()` to do the overlap check of (1) and (2) and replace the original overlap check of (3) with `check_reserved_regions_overlap()`. Signed-off-by: Henry Wang --- v1 -> v2: 1. Split original `overlap_ch

RE: [PATCH] xen/arm: Reduce redundant clear root pages when teardown p2m

2022-12-12 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH] xen/arm: Reduce redundant clear root pages when > teardown p2m > > Hi Henry, > > > PROGRESS(p2m): > > +/* > > + * We are about to free the intermediate page-tables, so clear the > > +

RE: [PATCH 0/8] docs/process: branching-checklist: Update it

2022-12-12 Thread Henry Wang
the whole series: Reviewed-by: Henry Wang Kind regards, Henry > > Cheers, > > Julien Grall (8): > docs/process: branching-checklist: Use consistent indentation > docs/process: branching-checklist: Remove reference to qemu-ijw.git > docs/process: branching-chec

[PATCH] xen/arm: Reduce redundant clear root pages when teardown p2m

2022-12-11 Thread Henry Wang
(). With this movement, the `page_list_empty(>pages)` check can be dropped. Signed-off-by: Henry Wang --- xen/arch/arm/domain.c | 5 + xen/arch/arm/include/asm/p2m.h | 1 + xen/arch/arm/p2m.c | 23 --- 3 files changed, 18 insertions(+), 11 deletions(-) d

RE: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-09 Thread Henry Wang
Hi both, I was lurking around to see how the discussion would go. Thanks for the discussions/inputs in this thread :) > -Original Message- > From: Stefano Stabellini > Subject: Re: [PATCH 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > > It cannot be a single

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-09 Thread Henry Wang
Hi, > -Original Message- > From: Demi Marie Obenour > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > On Fri, Dec 09, 2022 at 07:37:53AM +0000, Henry Wang wrote: > > Hi Julien, > > > > > -Original Message- > > > From: Ju

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Henry Wang
; Should this be included in 4.17? It is a bug fix for a feature new to > >>> 4.17, so I suspect yes, but it is ultimately up to Henry Wang. The code > >>> is identical to v2, but I have improved the commit message. > >> > >> It may be too late now, looking

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Henry Wang
Should this be included in 4.17? It is a bug fix for a feature new to > > 4.17, so I suspect yes, but it is ultimately up to Henry Wang. The code > > is identical to v2, but I have improved the commit message. > > It may be too late now, looking at the state of the tree. Henry, Julien?

RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-07 Thread Henry Wang
Hi Julien, Stefano, Bertrand, I am trying to work on the follow-up improvements about the Arm P2M code, and while trying to address the comment below, I noticed there was an unfinished discussion between me and Julien which I would like to continue and here opinions from all of you (if possible).

RE: [PATCH for-4.17] SUPPORT.md: Define support lifetime

2022-12-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: [PATCH for-4.17] SUPPORT.md: Define support lifetime > > Signed-off-by: Julien Grall Release-acked-by: Henry Wang Kind regards, Henry

RE: [PATCH v6 0/2] Final changelog changes for 4.17

2022-12-07 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH v6 0/2] Final changelog changes for 4.17 > > Hi, > > On 01/12/2022 11:39, Henry Wang wrote: > > Hi all, > > > > These two patches should be the final changelog changes for 4.17. > > > &g

RE: [PATCH v2] Use EfiACPIReclaimMemory for ESRT

2022-12-06 Thread Henry Wang
e new to > 4.17, so I suspect yes, but it is ultimately up to Henry Wang. I am planning to start the process of tagging the 4.17 so we can catch the release date next Monday before the holiday season in Europe. That said, if the EFI maintainer (Jan) is happy about including this in 4.17, I don't obje

RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Henry Wang
Hi Julien, > > Speaking of the checklist and maybe it is slightly off topic: Will it bother > > you or other maintainers if I send a patch to remove the "qemu-iwj" > > section in the branch list? According to the discussion with Ian [1], I > > think > > this can be safely dropped, and I am

RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-05 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the > banner in README is generated > >> Acked-by: Jan Beulich > > > > Release-acked-by: Henry Wang > > Thanks fo

[PATCH 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2022-12-04 Thread Henry Wang
`check_reserved_regions_overlap()` to include memory regions in bootinfo.modules, and use `check_reserved_regions_overlap()` in `add_boot_module()` to return early if any error occurs. Signed-off-by: Henry Wang --- xen/arch/arm/setup.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/xen/arch/arm

[PATCH 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory

2022-12-04 Thread Henry Wang
in function `check_reserved_regions_overlap()` to include memory regions in bootinfo.acpi, and use the extended `check_reserved_regions_overlap()` in `meminfo_add_bank()` defined in `efi-boot.h` to return early if any error occurs. Signed-off-by: Henry Wang --- xen/arch/arm/efi/efi-boot.h | 10

[PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-04 Thread Henry Wang
check of (1) and (2) and replace the original overlap check of (3) with this new helper. Signed-off-by: Henry Wang --- xen/arch/arm/bootfdt.c | 13 xen/arch/arm/include/asm/setup.h | 2 ++ xen/arch/arm/setup.c | 52 3 files changed, 60

[PATCH 0/3] Memory region overlap check in device tree

2022-12-04 Thread Henry Wang
introduces the basic memory overlap check mechanism, and does the memory check for memory regions in bootinfo.reserved_mem. Following patches extend the overlap check to include bootmodules and EfiACPIReclaimMemory. Henry Wang (3): xen/arm: Add memory overlap check for bootinfo.reserved_mem xen/arm

RE: Release checklist and qemu-xen-traditional

2022-12-02 Thread Henry Wang
Hi Ian, > -Original Message- > From: Ian Jackson > Subject: Release checklist and qemu-xen-traditional > > (Adding xen-devel to the CC list.) Thank you for doing this, it would be great to have the answer below logged in the mailing list. > > Hi, Henry. Pleased to "meet" you. To

Xen 4.17 rc4

2022-12-02 Thread Henry Wang
Hi all, Xen 4.17 rc4 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.17.0-rc4 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.17.0-rc4/xen-4.17.0-rc4.tar.gz And the signature is at:

RE: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE

2022-12-01 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: Re: [4.17?] Re: [PATCH] x86/HVM+shim: fix build > when !CONFIG_GRANT_TABLE > > On 01/12/2022 16:14, Henry Wang wrote: > >>> Thanks for investigating. > >>> > >>> Ack

RE: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE

2022-12-01 Thread Henry Wang
> > Thanks. > > > Thoughts about inclusion into 4.17?  This is a build time regression vs > > 4.16. > > I thought this was odd enough a configuration, but since you ask, let me > forward the question to Henry. I think a build time regression should be fixed. We

RE: Commit moratorium

2022-12-01 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: Commit moratorium > > On 01.12.2022 15:32, Julien Grall wrote: > > I have finally managed to branch 4.17. The tree is now re-opened. > > Does this extend to the 4.17 branch as well? I've committed Anthony's > build fix to

[PATCH v6 2/2] CHANGELOG: Start new "unstable" section

2022-12-01 Thread Henry Wang
Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- I think this patch should be a master/staging patch only. v5 -> v6: - This is the leftover patch from [1]. Rebase on top of Patch #1. [1] https://lore.kernel.org/xen-devel/20221124025041.1540079-1-henry.w...@arm.com/ --- CHANGELOG.md

[PATCH v6 0/2] Final changelog changes for 4.17

2022-12-01 Thread Henry Wang
y. Thanks. Henry Henry Wang (2): CHANGELOG: Set 4.17 release date and tag CHANGELOG: Start new "unstable" section CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1

[PATCH for-4.17 v6 1/2] CHANGELOG: Set 4.17 release date and tag

2022-12-01 Thread Henry Wang
Signed-off-by: Henry Wang --- This is the patch we want to "backport" to staging/stable-4.17. v5 -> v6: - New patch. --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d686a4258..7f4d0f25e9 100644 --- a/CHANG

RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

2022-12-01 Thread Henry Wang
enerated and take the opportunity > > to mention what it should look like for RC. > > > > Signed-off-by: Julien Grall > > Acked-by: Jan Beulich Release-acked-by: Henry Wang With probably Jan's comment in ... > albeit with a couple of nits: > > > --- a/docs/pr

RE: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header

2022-12-01 Thread Henry Wang
e. > > > > Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due > to several licences") > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich Release-acked-by: Henry Wang Kind regards, Henry

[PATCH v5 3/3] CHANGELOG: Start new "unstable" section

2022-11-23 Thread Henry Wang
Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- v4 -> v5: - Add Julien's Reviewed-by. v3 -> v4: - No change. v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's acked-b

[PATCH v5 2/3] Changelog: Add __ro_after_init and CET

2022-11-23 Thread Henry Wang
From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Henry Wang Reviewed-by: Roger Pau Monné Reviewed-by: Julien Grall --- v4 -> v5: - Add Julien's reviewed-by. v3 -> v4: - Add my own sign-off because I changed the original wording. v2 -> v3: - Remove th

[PATCH v5 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-23 Thread Henry Wang
Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- v4 -> v5: - Add gitlab CI improvement following Michal's suggestion. - Add Julien's reviewed-by. v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only cr

[PATCH v5 0/3] Populate entries for 4.17

2022-11-23 Thread Henry Wang
fano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) -- 2.25.1

RE: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-23 Thread Henry Wang
Hi Michal, > -Original Message- > Subject: Re: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during > the 4.17 release > Hi Henry, > Looking at the "Added" section for the previous releases, we seem to > mention the changes to CI (automation/) as well. > Because there were quite

RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-23 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during > the 4.17 release > >> I was under the impression that the code that was merged is enough to > >> support the platform. Do you have any pointer where it says

[PATCH v4 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v3 -> v4: - No change. v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's acked-by because of the content change. v1 -> v2: - Add Julie

[PATCH v4 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Henry Wang Reviewed-by: Roger Pau Monné --- v3 -> v4: - Add my own sign-off because I changed the original wording. v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_afte

[PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. v2 -> v3: - Move the uncertain release date to pa

[PATCH v4 0/3] Populate entries for 4.17

2022-11-22 Thread Henry Wang
- Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2):

RE: [PATCH] docs/misc/arm: Update references to Linux kernel docs

2022-11-22 Thread Henry Wang
t; > This could potentially be a candidate for 4.17 as this is correcting the > links in the docs. So risk free. Agreed. > > If we have no new bug fixed queued for 4.17, then I could add the patch > after branching. Sounds good to me, if you want to do that: Release-acked-by: Henry Wang Kind regards, Henry > > Cheers, > > -- > Julien Grall

RE: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Hi Julien, (+George since this is about the release date) > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section > On 22/11/2022 11:26, Henry Wang wrote: > > Signed-off-by: Henry Wang >

RE: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET > > Hi Henry, > > On 22/11/2022 11:26, Henry Wang wrote: > > From: Andrew Cooper > > > > Signed-off-by: Andrew Cooper >

RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
> > On 22/11/2022 11:26, Henry Wang wrote: > > Signed-off-by: Henry Wang > > - - Support VIRT_SSBD feature for HVM guests on AMD. > > + - Support VIRT_SSBD feature for HVM guests on AMD and > MSR_SPEC_CTRL feature for > > + SVM guests. > > Did you really i

[PATCH v3 3/3] CHANGELOG: Start new "unstable" section

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's Acked-by because of the change of the patch. v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.

[PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

2022-11-22 Thread Henry Wang
Signed-off-by: Henry Wang --- v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry

[PATCH v3 2/3] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
From: Andrew Cooper Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné --- v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 1 file changed, 4 insertions(+) diff

[PATCH v3 0/3] Populate entries for 4.17

2022-11-22 Thread Henry Wang
i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 36 +++- 1 fil

RE: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-11-22 Thread Henry Wang
Hi Both, > -Original Message- > Subject: Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET > > On 22/11/2022 08:49, Julien Grall wrote: > > Hi Andrew, > > > > On 09/03/2022 12:39, Andrew Cooper wrote: > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Jan Beulich > >> CC: Roger

RE: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass

2022-11-21 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [xen-unstable test] 174896: regressions - trouble: > broken/fail/pass > > On 22.11.2022 05:40, Henry Wang wrote: > > Hi, > > > >> -Original Message- > >> Subject: [

RE: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass

2022-11-21 Thread Henry Wang
Hi, > -Original Message- > Subject: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass > > flight 174896 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174896/ > > Regressions :-( > > Tests which did not succeed and are blocking, >

<    3   4   5   6   7   8   9   10   11   12   >