Re: [PATCH] xkb: Suppress autorepeat for Set and Lock of Mods, Groups, and Controls

2014-03-23 Thread Daniel Stone
Hi, On 23 March 2014 16:57, wettstein...@solnet.ch wrote: This patch has not been reviewed yet. Can someone please have a look? It is fairly small. This is definitely something we want. If you add the same for latches: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel Thank

Re: [PATCH] xkb: Keyboard mouse button emulation should not suppress other keyboard events

2014-03-23 Thread Daniel Stone
of ISOLock. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

Re: [PATCH] xkb: Fix ISOLock

2014-03-23 Thread Daniel Stone
Hi, On 23 March 2014 17:00, wettstein...@solnet.ch wrote: This patch has not been reviewed yet. It is not completely trivial, unfortunately. Can someone please have a look? This is complex enough that I can't say off the top of my head it's exactingly correct. Probably the best thing to do

Re: [PATCH 07/20] glamor: Add simple upload/download functions in glamor_transfer

2014-03-21 Thread Daniel Stone
Hi, On 20 March 2014 20:27, Eric Anholt e...@anholt.net wrote: Daniel Stone dan...@fooishbar.org writes: This isn't natively supported on GLES; it requires GL_EXT_unpack_subimage, which isn't available on the vast majority of shipping GLES GPUs. (Yes, I know it's lame: it's seriously my #1

Re: [PATCH 1/3] os: Always compile ListenOnOpenFD() and export it

2014-03-19 Thread Daniel Stone
Hi, These three are: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel On 19 March 2014 05:05, Kristian Høgsberg k...@bitplanet.net wrote: This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though

Re: [PATCH 07/20] glamor: Add simple upload/download functions in glamor_transfer

2014-03-19 Thread Daniel Stone
Hi, On 19 March 2014 05:09, Keith Packard kei...@keithp.com wrote: +glPixelStorei(GL_UNPACK_ROW_LENGTH, byte_stride / bytes_per_pixel); This isn't natively supported on GLES; it requires GL_EXT_unpack_subimage, which isn't available on the vast majority of shipping GLES GPUs. (Yes, I know

Re: [RFC] Automatic modifier update of slave devices

2014-03-11 Thread Daniel Stone
Hi, On 11 March 2014 06:44, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Mar 10, 2014 at 10:10:40PM +0100, Daniel Stone wrote: Ack from me - either 3 (mirror locks) or 4 (mirror all state). The main downside is that people listening for XKB state change events on slaves might see

Re: [PATCH:xkbcomp 1/4] Remove useless checks for NULL before free in OverlayKeyCreate()

2014-03-11 Thread Daniel Stone
Hi, On 11 March 2014 06:31, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Mar 08, 2014 at 07:10:25PM -0800, Alan Coopersmith wrote: There is no need to ensure the pointers passed to free are not NULL, especially right after passing them to strncpy without checking for NULL. Flagged

Re: [RFC] Automatic modifier update of slave devices

2014-03-10 Thread Daniel Stone
Hi, On 10 March 2014 17:54, Keith Packard kei...@keithp.com wrote: Peter Hutterer peter.hutte...@who-t.net writes: tbh, at this point I'm in preference of 3 (i.e. mirroring locking modifiers), mainly because it seems the most obvious and intuitive solution. I concur -- the locking modifier

Re: [PATCH v2 1/4] xkb: factor out the StateNotify flag check

2014-03-03 Thread Daniel Stone
Hi, On 3 March 2014 05:44, Peter Hutterer peter.hutte...@who-t.net wrote: +static int +_XkbWantStateNotify(XkbSrvInfoPtr xkbi) +{ +Bool genStateNotify; + +/* The state may change, so if we're not in the middle of sending a state + * notify, prepare for it */ +if

Re: [PATCH libxtrans] configure: under glibc define _GNU_SOURCE rather then _BSD_SOURCE

2014-03-03 Thread Daniel Stone
Hi, On 3 March 2014 07:56, Hans de Goede hdego...@redhat.com wrote: The latest glibc considers _BSD_SOURCE deprecated, leading to the following warning being issued for pretty much every C-file in the xserver: In file included from /usr/include/stdint.h:25:0, from

Re: [PATCH v2 4/4] xkb: push locked modifier state down to attached slave devices

2014-03-03 Thread Daniel Stone
Hi, On 3 March 2014 05:44, Peter Hutterer peter.hutte...@who-t.net wrote: Whenever the master changes, push the locked modifier state to the attached slave devices, then update the indicators. This way, when NumLock or CapsLock are hit on any device, the LED will light up on all devices.

Re: [PATCH xserver] test: create a link to the generated hw/xfree86/sdksyms.c at build time

2014-02-24 Thread Daniel Stone
Hi, On 24 February 2014 15:28, Gaetan Nadon mems...@videotron.ca wrote: There are those three other cases to handle: nodist_libxservertest_la_SOURCES = \ ddxstubs.c \ $(top_srcdir)/mi/miinitext.c \ $(top_srcdir)/Xext/dpmsstubs.c \

Re: [RFC] Automatic modifier update of slave devices

2014-02-24 Thread Daniel Stone
Hi, Overall, I think it's close to the best we can make of a bad situation (in hindsight, I think we both would've done things differently ...), but Keith's pretty on the money: On 24 February 2014 06:57, Keith Packard kei...@keithp.com wrote: Peter Hutterer peter.hutte...@who-t.net writes:

Re: [RFC] Automatic modifier update of slave devices

2014-02-24 Thread Daniel Stone
Hi, On 24 February 2014 21:28, Keith Packard kei...@keithp.com wrote: Daniel Stone dan...@fooishbar.org writes: whilst not doing anything surprising like having a base modifier down which was never pressed on that device. Are you saying that we should only mirror the locking modifier state

Re: [RFC] Automatic modifier update of slave devices

2014-02-24 Thread Daniel Stone
Hi, On 24 February 2014 22:28, Keith Packard kei...@keithp.com wrote: Peter Hutterer peter.hutte...@who-t.net writes: the less-intrusive alternative would be to force only the indicator state down to the slaves. won't change keyboard behaviour as seen by the client and still has the effect

Re: [RFC] Automatic modifier update of slave devices

2014-02-24 Thread Daniel Stone
Hi, On 24 February 2014 22:56, James Cloos cl...@jhcloos.com wrote: So hitting compose on one keyboard would light the compose led on all associated keyboards but only intitiate a compose sequence on the one? Or caps-lock? Or level shifts? Or group toggles? If I read that right, that

Re: Would anybody mind the Drop circular pad support patch being reverted?

2014-02-13 Thread Daniel Stone
Hi, On 12 February 2014 16:26, Bart Massey b...@cs.pdx.edu wrote: Please revert. Keithp has a laptop like this that I've used for a while: works great. I don't understand why this patch was committed? It was removed to make the totally-nightmarish Synaptics driver slightly easier to reason

Re: [PATCH synaptics] Revert Drop circular pad support

2014-02-13 Thread Daniel Stone
On 13 February 2014 04:59, Peter Hutterer peter.hutte...@who-t.net wrote: This reverts commit 3b02e7fd81da4b100fb9ac32378f6d50f54cf0e2. Apparently these devices still exist after all. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH v2] Xi: fix modifier offset in XIPassiveGrab swapping function

2014-01-24 Thread Daniel Stone
Hi, On 24 January 2014 23:14, Peter Hutterer peter.hutte...@who-t.net wrote: On 25/01/2014 08:48 , Alan Coopersmith wrote: On 01/24/14 12:05 AM, Peter Hutterer wrote: The request is followed by mask_len 4-byte units, then followed by the actual modifiers. Also fix up the swapping test,

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-23 Thread Daniel Stone
InputDriverRec with an equivalent flag which must be set. With those fixed, those four look good to me, and: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-19 Thread Daniel Stone
Hi, On 18 January 2014 16:27, Hans de Goede hdego...@redhat.com wrote: On 01/17/2014 02:08 PM, Daniel Stone wrote: On 15 January 2014 14:32, Hans de Goede hdego...@redhat.com wrote: With systemd-logind the dbus-core will be used for more then just config. This patch also makes the building

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-17 Thread Daniel Stone
© 2006-2007 Daniel Stone - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the Software), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify

Re: [PATCH synaptics] Fix ABI detection for in-driver scaling

2014-01-03 Thread Daniel Stone
Hi, On 3 January 2014 01:30, Peter Hutterer peter.hutte...@who-t.net wrote: -#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) = 19 -#if GET_ABI_MINOR(ABI_XINPUT_VERSION) = 2 +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) 19 +#define NO_DRIVER_SCALING 1 +#elif GET_ABI_MAJOR(ABI_XINPUT_VERSION) == 19

Re: [PATCH:libFS] Add AC_SYSTEM_EXTENSIONS to expose non-standard extensions

2013-12-30 Thread Daniel Stone
All Reviewed-by: Daniel Stone dan...@fooishbar.org On 27 December 2013 19:11, Alan Coopersmith alan.coopersm...@oracle.com wrote: Required on Solaris to expose fd_mask in sys/select.h now that xtrans 1.3 defines _XOPEN_SOURCE to 600 on Solaris, since fd_mask is not defined in that version

Re: [PATCH:xhost] Add AC_USE_SYSTEM_EXTENSIONS to expose non-standard extensions

2013-12-30 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org On 27 December 2013 20:11, Alan Coopersmith alan.coopersm...@oracle.com wrote: Required on Solaris to expose definitions in system headers that are not defined in the XPG standards now that xtrans 1.3 defines _XOPEN_SOURCE to 600 on Solaris

Re: [PATCH] miext: Move SyncShm FDs out of the way of clients

2013-11-22 Thread Daniel Stone
Hi, On 22 November 2013 06:19, Keith Packard kei...@keithp.com wrote: Applications may end up allocating a bunch of shmfence objects, each of which uses a file descriptor, which must be kept open lest some other client ask for a copy of it later on. Lacking an API that can turn a memory

Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)

2013-11-17 Thread Daniel Stone
Hi, On 17 November 2013 08:01, Keith Packard kei...@keithp.com wrote: The only warning I removed from xorg-macros was -Wcast-qual as that makes it impossible to free a const char * pointer. Casts exist to work around limitations of the C type system, having it warn when we're doing that is

Re: [PATCH 2/2] Enable XTRANS_SEND_FDS on Solaris too.

2013-11-12 Thread Daniel Stone
Hi, On 11 November 2013 23:38, Keith Packard kei...@keithp.com wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: +/* Enable general extensions on Solaris. */ +#ifndef __EXTENSIONS__ +# undef __EXTENSIONS__ +#endif This doesn't make sense to me -- if __EXTENSIONS__ isn't

Re: [PATCH] Disable DRI3 and sync fence FD functions if xshmfence isn't available

2013-11-04 Thread Daniel Stone
Hi, On 4 November 2013 21:30, Matthieu Herrb matthieu.he...@laas.fr wrote: +if DRI3 +DRI3_SUBDIR = dri3 +DRI3_LIB = dri2/libdri3.la +endif ITYM dri3/libdri3.la. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xwayland] xwayland: Just send the bounding box of the damage

2013-10-30 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [RFC] X.Org minimum requirements for Autotools policy review

2013-10-24 Thread Daniel Stone
Hi, On 24 October 2013 22:17, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 10/24/13 11:17 AM, Gaetan Nadon wrote: GPLv3 Autoconf licensing still an issue? A couple of years ago, some platforms declared they were unable to ship any software package if it was licensed under

Re: [PATCH 08/10] Add redirect window for input device feature

2013-10-21 Thread Daniel Stone
Hi, On 17 October 2013 17:36, Adam Jackson a...@redhat.com wrote: From: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Adam Jackson a...@redhat.com The last review (by Peter) pointed out that this was missing a destruction handler to unset, similar to WindowGone() for touch. Cheers,

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Daniel Stone
Hi, On 8 October 2013 19:22, Mouse mo...@rodents-montreal.org wrote: Good catch. It's just luck that False is #defined as 0. :) It should, of course, be NULL. Well, I'd actually disagree; I think NULL should never be used - see my blah post of 2009-10-09

Re: [PATCH] Remove XAA

2013-09-23 Thread Daniel Stone
On 23 September 2013 15:04, Mark Kettenis mark.kette...@xs4all.nl wrote: But as Matthieu's list shows, quite a few drivers are simply broken without XAA, so they *don't* run without XAA. After a year and a half. After four years of having either broken rendering, or no acceleration at all.

Re: [PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

2013-09-12 Thread Daniel Stone
Hi, On 12 September 2013 07:37, Chris Wilson ch...@chris-wilson.co.uk wrote: The approach taken in this patch is to first only enable VGA arbitration for drivers that require VGA resources. This is detected by moving the initialisation from the common xf86 code to the vgaHW module. This is

Re: Remove declaration-after-statement C warning

2013-09-11 Thread Daniel Stone
Hi, On 11 September 2013 17:31, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Pushing the patch is easy - determining if it's our consensus to change the X.Org coding style to allow this is the hard part. Does anyone object to allowing this

Re: [PATCH:xf86-input-mouse 2/4] Add support for absolute positioning (tablets).

2013-08-19 Thread Daniel Stone
Hi, On 19 August 2013 10:14, Thomas Klausner w...@netbsd.org wrote: + case WSCONS_EVENT_MOUSE_ABSOLUTE_X: + miPointerGetPosition (pInfo-dev, x, y); + x = event-value; + miPointerSetPosition (pInfo-dev, Absolute, (double *)x, (double *)y); +

Re: [PATCH V2] xnest: Ignore GetImage() error in xnestGetImage()

2013-08-13 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org On 13 August 2013 07:45, Egbert Eich e...@freedesktop.org wrote: From: Radek Doulik r...@novell.com When an Xnest instance is not viewable it will crash when a client in that instance calls GetImage. This is because the Xnest server will itself

Re: [PATCH evdev] Write a SYN_REPORT after the last LED

2013-08-13 Thread Daniel Stone
arrives. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org src/evdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index ba2a98c..456c7aa 100644 --- a/src/evdev.c +++ b/src/evdev.c

Re: [PATCH] DDX/Events: Distinguish between Input- and GeneralHandlers in xf86VTSwitch()

2013-08-12 Thread Daniel Stone
Good catch! This actually explains quite a bit ... Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel On 12 August 2013 17:20, Egbert Eich e...@freedesktop.org wrote: When enabling/disabling input handlers in xf86VTSwitch() we treat Input- and GeneralHandlers equally. The result

Re: [PATCH] xnest: Ignore GetImage() error in xnestGetImage()

2013-08-12 Thread Daniel Stone
Hi, This will be a bit too broad, ignoring errors generated before the XGetImage but only posted then. To avoid that, you need to call XSync(dpy, False) before changing the error handler. Cheers, Daniel On 12 August 2013 17:23, Egbert Eich e...@freedesktop.org wrote: From: Radek Doulik

Re: [PATCH driver/input/synaptics] For serial devices try reconnecting if device is wedged.

2013-07-29 Thread Daniel Stone
On 29 July 2013 12:31, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Egbert Eich e...@freedesktop.org Date: Mon, 29 Jul 2013 13:15:13 +0200 From: Takashi Iwai ti...@suse.de Under some circumstances the synaptics device may be wedged when coming back from a sleep state. Add some magic

Re: [PATCH driver/input/synaptics] For serial devices try reconnecting if device is wedged.

2013-07-29 Thread Daniel Stone
Hi, On 29 July 2013 14:55, Mark Kettenis mark.kette...@xs4all.nl wrote: C99, 7.1.3 Reserved identifiers: -- All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use. -- All identifiers that begin with

Re: [PATCH] Allow disabling XFree86-DGA, DRI, VidModeExtension extensions

2013-07-27 Thread Daniel Stone
it before another year passed. ;) Reviewed-by: Daniel Stone dan...@fooishbar.org mi/miinitext.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Found while helping a user on #xorg IRC. Tested by running Xorg -config xorg.conf.no-dga, with this in xorg.conf.no-dga: Section

Re: [PATCH libX11] Always initialise thread support

2013-07-14 Thread Daniel Stone
interesting. Or just have those performance-critical programs use XCB, since Xlib sucks for performance anyway. Cheers, Daniel Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/OpenDis.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/OpenDis.c b/src/OpenDis.c index fc67d1a..2104845

Re: [PATCH:xorg-docs] List libxkbui as Obsolete in MAINTAINERS file

2013-07-13 Thread Daniel Stone
On 13 July 2013 18:33, Alan Coopersmith alan.coopersm...@oracle.com wrote: -xkbfile, xkbui +xkbfile P: Daniel Stone M: dan...@fooishbar.org L: xorg-devel@lists.x.org @@ -240,6 +240,9 @@ S: Maintained S: XKB being overhauled S: Please contact Daniel if you're

[PATCH libX11] Always initialise thread support

2013-07-12 Thread Daniel Stone
seen just this week. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/OpenDis.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/OpenDis.c b/src/OpenDis.c index fc67d1a..2104845 100644 --- a/src/OpenDis.c +++ b/src/OpenDis.c @@ -87,6 +87,8 @@ XOpenDisplay ( long int

Re: [PATCH libX11] Always initialise thread support

2013-07-12 Thread Daniel Stone
somewhere; so if you ever use that specific implementation, every app has to call XInitThreads first to ensure it doesn't die horribly. Cheers, Daniel Jamey On Fri, Jul 12, 2013 at 10:25:38PM +0100, Daniel Stone wrote: Make XOpenDisplay always call XInitThreads when opening a display, thus

Re: [PATCH setxkbmap] -I syntax wrong in manpage

2013-06-30 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org On 29 June 2013 00:04, Stéphane Aulery lk...@free.fr wrote: cf. syntax in source code file : http://cgit.freedesktop.org/xorg/app/setxkbmap/tree/setxkbmap.c#n248 Fix Debian report Bug #524510 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug

Re: managing patches with git

2013-06-25 Thread Daniel Stone
Hi, On 25 June 2013 23:13, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 06/25/13 02:31 PM, Thomas Klausner wrote: Btw, what's the appropriate method to create a patch that's a merged version of previous patches, which are separate commits in my local copy of the repository? Just

Re: [PATCH] ephyr: restore GLX support

2013-06-08 Thread Daniel Stone
Please merge. On 7 June 2013 18:43, Laurent Carlier lordhea...@gmail.com wrote: It was removed since version 1.13 Signed-off-by: Sebastien Bacher seb...@ubuntu.com Acked-by: Daniel Stone dan...@fooishbar.org --- hw/kdrive/ephyr/ephyrinit.c | 20 1 file changed, 20

Re: Current DRI3 specification

2013-06-08 Thread Daniel Stone
Hi, On 7 June 2013 13:30, James Jones jajo...@nvidia.com wrote: We do need more than the 'make it pretty' requirement above though. What you describe is what interactive rendering apps want, when you're translating some sort of input into graphics with as little latency as possible.

Re: glx support in Xephyr

2013-06-07 Thread Daniel Stone
Hi, On 5 June 2013 12:23, Laurent Carlier lordhea...@gmail.com wrote: Any plans to apply the patch provided in https://bugs.freedesktop.org/show_bug.cgi?id=62346 ? Indentation is totally broken, but with that fixed (and sent to the mailing list): Acked-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH evdev 1/3] Switch default model to pc104.

2013-05-30 Thread Daniel Stone
) but it would be the wrong layout for the default. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Daniel Stone dan...@fooishbar.org (See? I'm still here!) -d src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index aec1447

Re: Xv and alignment requirements

2013-05-30 Thread Daniel Stone
Hi, On 30 May 2013 18:26, Daniel Drake d...@laptop.org wrote: However, we are finding that the gco2D_FilterBlit() call that makes this happen requires that each plane of the I420 image is aligned to a 512 byte boundary. And in these problematic videos, that requirement is not met (it is

Re: [ANNOUNCE] X.Org Security Advisory: Protocol handling issues in X Window System client libraries

2013-05-24 Thread Daniel Stone
Hi, On 23 May 2013 23:36, Alan Coopersmith alan.coopersm...@oracle.com wrote: I still agree with most of my quotes that got captured there, including the one blaming daniels for not saving us from all manner of XKB woes. (I know, XKB2 would fix it all, if only the laptop was returned by

Re: [ANNOUNCE] X.Org Security Advisory: Protocol handling issues in X Window System client libraries

2013-05-24 Thread Daniel Stone
Hi, On 23 May 2013 23:36, Alan Coopersmith alan.coopersm...@oracle.com wrote: I still agree with most of my quotes that got captured there, including the one blaming daniels for not saving us from all manner of XKB woes. (I know, XKB2 would fix it all, if only the laptop was returned by

Re: followup for libX11 XKB security fixes

2013-05-23 Thread Daniel Stone
guess I missed those two. Sorry about that. Seems right to me too. Acked-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com On 05/23/13 10:26 AM, Julien Cristau wrote: Hi, I noticed some inconsistencies in the XKB security changes in Xlib

Re: EXA composite ops don't report damage

2013-05-13 Thread Daniel Stone
Hi, On 13 May 2013 15:40, Daniel Drake d...@laptop.org wrote: On Mon, May 13, 2013 at 3:15 AM, Michel Dänzer mic...@daenzer.net wrote: The wrapping order is supposed to be the other way around, i.e. the Damage layer is supposed to call down to EXA. I suspect you may need to switch the order

[ANNOUNCE] xkbcommon 0.3.0

2013-04-01 Thread Daniel Stone
Hi, It gives me great pleasure etc to announce xkbcommon 0.3.0. This is mostly a bugfix and consolidation release, with no fun new features (and no API/ABI breaks), aside from: * a new xkb_keymap_new_from_buffer entrypoint, to support non-NULL-terminated strings courtesy of David Herrmann,

Re: Initial DRI3000 protocol specs available

2013-03-08 Thread Daniel Stone
Hi, On 7 March 2013 17:17, Keith Packard kei...@keithp.com wrote: James Jones jajo...@nvidia.com writes: There didn't seem to be much interest outside of NVIDIA, so besides fence sync, the ideas are tabled internally ATM. This shouldn't surprise you though -- no-one else needs this kind

Re: [PATCH 1/4] xkb: LockMods can lock another group on key release #865

2013-01-10 Thread Daniel Stone
Hi, On 10 January 2013 10:35, wettstein...@solnet.ch wrote: ok. unfortunately, source isn't quite enough here, unless the protocol explicitly specifies the bytes must be zero we cannot rely on this. The protocol specification just says unused, and I also did not see any note that unused

Re: [PATCH 1/2] xfree86: set event-detail for DGA pointer events

2013-01-10 Thread Daniel Stone
Hi, On 7 January 2013 17:51, Peter Hutterer peter.hutte...@who-t.net wrote: @@ -1074,6 +1074,7 @@ DGAProcessPointerEvent(ScreenPtr pScreen, DGAEvent * event, DeviceIntPtr mouse) DeviceEvent ev = { .header = ET_Internal, .length = sizeof(ev), +.detail.key =

[PATCH synaptics] Free mtdev device as well as closing it

2012-12-28 Thread Daniel Stone
/resume cycles. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/eventcomm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index b1d5460..8508e6a 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -122,7 +122,7 @@ UninitializeTouch

Re: Adding rotation to xf86-video-omapfb

2012-12-27 Thread Daniel Stone
Hi, On 28 December 2012 01:08, Maarten Maathuis madman2...@gmail.com wrote: As far as i remember you typically allocate a shadow (there are some driver hooks for that, check existing drivers like intel, radeon or nouveau). This will become the new scanout buffer and this has the rotated

Re: 1.14 feature window closes ... today?

2012-12-06 Thread Daniel Stone
Hi, On 6 December 2012 14:02, Keith Packard kei...@keithp.com wrote: I just discovered that a note I sent out a couple of days ago about the feature window never made it off my machine... In any case, we're supposed to be at RC1 today, but I'm going to hold off for a day or so until I hear

[PULL] Xephyr, Xvfb and extmod fixes

2012-11-20 Thread Daniel Stone
this). Daniel Stone (3): Constify argument to LoadExtension Constify extensions in LoadExtension users DMX: Add DMX and GLX extensions Raphael Kubo da Costa (1): vfb: Initialize the GLX extension again. Sjoerd Simons (1

Re: any more nominations for xserver 1.13.1 ?

2012-11-20 Thread Daniel Stone
Hi, On 21 November 2012 06:45, Raphael Kubo da Costa raphael.kubo.da.co...@intel.com wrote: Matt Dew mar...@osource.org writes: RC1 is one week from today. I have pulled, tested and pushed to origin the ones I know about. But, if you sent me an email and I haven't replied, please

Re: [PATCH XIT] Provide and explain a udev rule and config snippet to ignore devices

2012-11-20 Thread Daniel Stone
Hi, On 21 November 2012 10:52, Peter Hutterer peter.hutte...@who-t.net wrote: Still a sledgehammer, but should make it easier for those that are just running the tests and don't need to worry about evemu in their normal day-to-day usage. It is, a bit - it also makes it impossible to run

Re: [PATCH] dix: FakeClientID for implicit passive grabs

2012-11-19 Thread Daniel Stone
freed while still in use. This causes random crashes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [REMINDER] LockMods can lock another group on key release #865

2012-11-19 Thread Daniel Stone
Hi Andreas, On 20 November 2012 06:06, Andreas Wettstein wettstein...@solnet.ch wrote: Saturday last week, I sent a four-part xkb-related patch to address issue #865. The patch has not been reviewed yet. Can someone have a look please? I've been hoping to review this but haven't had the

Re: [PATCH] vfb: Initialize the GLX extension again.

2012-11-18 Thread Daniel Stone
aad428b8e21c77397c623b78706eb64b1fea77c9, adopt an approach similar to xwin's and xquartz's and initialize the extension from vfb's `InitOutput'. Signed-off-by: Raphael Kubo da Costa raphael.kubo.da.co...@intel.com Reviewed-by: Daniel Stone dan...@fooishbar.org I'll take this into my tree and send a pull request

[PATCH 3/3] DMX: Add DMX and GLX extensions

2012-11-18 Thread Daniel Stone
Unfortunately this also got lost in the extmod fallout, leaving the DMX server not exposing the DMX or GLX extensions. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/dmx/dmx.h |2 ++ hw/dmx/dmxinit.c | 22 +- include/extinit.h |4 3 files changed

[PATCH 0/3] More extmod fallout

2012-11-18 Thread Daniel Stone
Hi, These three patches fix some fallout from extmod; the first two are just cleanup, whereas the second two restore the DMX extensions which are pretty vital to it actually running. Unfortunately, I couldn't really test DMX too much, as every single mouse click warps the pointer back to (0,0).

[PATCH 1/3] Constify argument to LoadExtension

2012-11-18 Thread Daniel Stone
Since we never modify it. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/extension.h |2 +- mi/miinitext.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/extension.h b/include/extension.h index 0f55d90..acc6add 100644 --- a/include

Re: [PATCH xorg-gtest 01/11] Drop .gz tarballs, bz2 is enough

2012-11-08 Thread Daniel Stone
On 30 October 2012 12:38, Peter Hutterer peter.hutte...@who-t.net wrote: --- a/configure.ac +++ b/configure.ac @@ -8,7 +8,7 @@ AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_MACRO_DIR([m4]) # Initialize Automake -AM_INIT_AUTOMAKE([foreign dist-bzip2]) +AM_INIT_AUTOMAKE([foreign dist-bzip2

[PATCH 3/6] Export CompRedirectSubWindows and friends

2012-11-06 Thread Daniel Stone
From: Kristian Høgsberg k...@redhat.com Needed for use in the XWayland submodule, as well as presumably most other things doing rootless or capture. Signed-off-by: Kristian Høgsberg k...@redhat.com --- composite/compalloc.c| 16 composite/compositeext.h |4 2

[PATCH 1/6] Add SetDeviceRedirectWindow

2012-11-06 Thread Daniel Stone
From: Kristian Høgsberg k...@redhat.com SetDeviceRedirectWindow confines the sprite and the focus for a given device to a given window tree, for use in rootless servers. Signed-off-by: Kristian Høgsberg k...@redhat.com --- Xi/exevents.c | 13 + dix/events.c | 11

[PATCH 4/6] Factor out AddSelection and export it

2012-11-06 Thread Daniel Stone
From: Kristian Høgsberg k...@redhat.com Useful for XWayland and other hosted compositors. Signed-off-by: Kristian Høgsberg k...@redhat.com --- dix/selection.c | 44 include/selection.h |3 +++ 2 files changed, 31 insertions(+), 16

[PATCH 2/6] dbe: Cleanup in CloseScreen hook not ext CloseDown

2012-11-06 Thread Daniel Stone
From: Robert Bragg rob...@linux.intel.com Instead of registering an extension CloseDownProc when adding the dbe extension this patch hooks into pScreen-CloseScreen so that the chain of pScreen-DestroyWindow hooks remains valid until all windows have been destroyed. Previously it was possible for

[RFC 0/6] XWayland support

2012-11-06 Thread Daniel Stone
Hi, I've been updating XWayland to work with Wayland 1.0. I've got three branches at the moment here: git://git.collabora.com/git/users/daniels/xserver xwayland-1.12 is a continuation of the fd.o xwayland-1.12 branch with incremental changes to bring it up to 1.0 support and fix a few bugs.

[PATCH 5/6] Add NoListenAll to disable listening on all sockets

2012-11-06 Thread Daniel Stone
From: Kristian Høgsberg k...@redhat.com Useful for fd passing, including under XWayland where we receive our listening socket from the compositor. Signed-off-by: Kristian Høgsberg k...@redhat.com --- include/opaque.h |1 + os/connection.c |7 ++- os/utils.c |6 +- 3

Re: [RFC 0/6] XWayland support

2012-11-06 Thread Daniel Stone
Hi, On 7 November 2012 17:58, Daniel Stone dan...@fooishbar.org wrote: 've been updating XWayland to work with Wayland 1.0. I've got three branches at the moment here: git://git.collabora.com/git/users/daniels/xserver I forgot to mention the other salient parts ... Weston: git

Re: [PATCH xorg-gtest] Expand on the default 'failed to open connection to display' error

2012-11-05 Thread Daniel Stone
Well, I've never used stringstream, so: Acked-by: Daniel Stone dan...@fooishbar.org On 6 November 2012 12:28, Peter Hutterer peter.hutte...@who-t.net wrote: Virtually everyone trying the tests the first time will run into this issue since we cannot check if the ABI for dummy and whatever

Re: [PATCH] XKB: Remove component listing support

2012-11-04 Thread Daniel Stone
Hi, On 2 November 2012 14:37, Peter Hutterer peter.hutte...@who-t.net wrote: can you covert your test to a XIT test and add it to (a newly created) tests/server/xkb? http://cgit.freedesktop.org/~whot/xorg-integration-tests/ Are these tests ever supposed to work with anything other than

[PATCH 2/2] XKB: Add two tests around XkbListComponents

2012-11-04 Thread Daniel Stone
These require patches which aren't even in git master yet. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |1 + tests/Makefile.am |2 +- tests/xkb/Makefile.am |7 tests/xkb/list.cpp| 107 + 4

[PATCH v2] XKB: Remove component listing support

2012-11-04 Thread Daniel Stone
(released two years ago) and later have been catastrophically broken and nearly empty. So I think that's reasonable proof that no-one uses them. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- include/xkbsrv.h | 17 --- xkb/Makefile.am

[PATCH 1/2] helpers: Save a copy to the trapped error, not pointer

2012-11-04 Thread Daniel Stone
SetErrorTrap/ReleaseErrorTrap were storing a pointer to the error, rather than a copy of it. It was pretty liable to getting trashed, so instead store a copy of our error. Signed-off-by: Daniel Stone dan...@fooishbar.org --- tests/common/helpers.cpp | 10 +- 1 file changed, 5

[PATCH] XKB: Remove component listing support

2012-11-01 Thread Daniel Stone
(released two years ago) and later have been catastrophically broken and nearly empty. So I think that's reasonable proof that no-one uses them. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/xkbsrv.h | 17 --- xkb/Makefile.am |3 +- xkb/ddxList.c| 304

Re: [PATCH] XKB: Remove component listing support

2012-11-01 Thread Daniel Stone
FWIW, here's the test I used: http://people.freedesktop.org/~daniels/xkb-list-components.c On 1 November 2012 16:45, Daniel Stone dan...@fooishbar.org wrote: No-one uses this - not xkbcomp, not GNOME, not KDE. The preferred way to deal with component listing (which gives you RMLVO rather

[PATCH xkbcomp] Reset scan state when opening a new file

2012-11-01 Thread Daniel Stone
/to/xkeyboard-config.git/symbols/* The Makefiles in that tree would cause parse errors, the resulting directory file is incomplete (down from ~12000 to ~230 lines). Reported-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Daniel Stone dan...@fooishbar.org --- parseutils.c |2 +- parseutils.h

[ANNOUNCE] libxkbcommon 0.2.0

2012-10-23 Thread Daniel Stone
Hi, After three and a half years, I'm proud to announce the first grown-up release of xkbcommon. xkbcommon is a keymap handling library, which can parse XKB descriptions (e.g. from xkeyboard-config), and use this to help its users make sense of their keyboard input. Unfortunately X11's

Re: [PATCH] Touch: Fix duplicate TouchBegin selection with virtual devices

2012-10-06 Thread Daniel Stone
Hi, On 7 October 2012 01:58, Chase Douglas chase.doug...@ubuntu.com wrote: Sorry for the delay, I've been trying to think about this to come up with a cogent argument. I don't like the idea of overlapping selections being allowed. There are two ways to handle an overlapping selection: *

Re: [PATCH] Fix compilation of Xorg DDX without XF86VIDMODE

2012-09-27 Thread Daniel Stone
. CCed to Daniel as the author of 6e74fdda Sorry, my bad. Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PULL] Xephyr GLX touch selection fixes

2012-09-25 Thread Daniel Stone
to 3d2b768efae9936c6929c2bc13c7a1acc074ecd3: Touch: Fix duplicate TouchBegin selection with virtual devices (2012-09-25 17:16:52 +1000) Daniel Stone (2): Xephyr: GLX: Support MakeContextCurrent and MakeCurrentReadSGI Touch

Re: [PATCH] Xephyr: GLX: Support MakeContextCurrent and MakeCurrentReadSGI

2012-09-13 Thread Daniel Stone
Hi, On 13 September 2012 15:11, Ian Romanick i...@freedesktop.org wrote: On 09/07/2012 08:30 PM, Daniel Stone wrote: We need to pass these requests through to the host server in the same way we do glXMakeCurrent. Generalise the existing MakeCurrent submission into once that will send

Re: Does Xorg'x XRender implementation support better-than-bilinear interpolation?

2012-09-11 Thread Daniel Stone
Hi, On 11 September 2012 03:17, Pierre-Loup A. Griffais pgriff...@nvidia.com wrote: On 09/10/2012 06:08 PM, Daniel Stone wrote: 'Best' might be bicubic. It might be nearest. It might be anything, it's just whatever the driver thinks will offer the best quality. Bicubic is not required

[PATCH] Touch: Fix duplicate TouchBegin selection with virtual devices

2012-09-07 Thread Daniel Stone
XIAllDevices or XIAllMasterDevices with dixLookupDevices doesn't work. This should succeed (or, if it was selecting for device D, fail with BadAccess as it would be a duplicate selection). Fix this by performing the appropriate lookup for virtual devices. Signed-off-by: Daniel Stone dan

[PATCH] Xephyr: GLX: Support MakeContextCurrent and MakeCurrentReadSGI

2012-09-07 Thread Daniel Stone
decoding/hijack support for incoming MakeContextCurrent and MakeCurrentReadSGI requests. Fixes Clutter → Xephyr → VirtualBox. Signed-off-by: Daniel Stone dan...@fooishbar.org Cc: Ian Romanick ian.d.roman...@intel.com Cc: Dave Airlie airl...@gmail.com --- hw/kdrive/ephyr/ephyrglxext.c | 116

<    1   2   3   4   5   6   7   8   9   10   >