Bug#910846: No packages.

2018-10-15 Thread Michel Dänzer
e name of the suite you're using in your main repository entry. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer signature.asc Description: OpenPGP digital signature _

Bug#910846: X server "Segmentation fault at address 0x0" when using about:support in Firefox-based browsers.

2018-10-12 Thread Michel Dänzer
address 0x0 Please make sure the xserver-xorg-video-radeon-dbgsym and xserver-xorg-core-dbgsym packages are installed, and either get a backtrace with gdb or another log file. Does the problem also happen without Option "AccelMethod" "EXA"? That's the default and recommended configur

Re: modesetting TearFree / VSYNC aware rotation pageflipping

2018-10-03 Thread Michel Dänzer
;> sync-to-vblank). > > Couldn't we extend modesetting in addition to Martin's TearFree patch the > same way you did here for Radeon?: > > https://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=798c4fd16d339b1ad5fd729cc884be084c60e38b Yeah, something like that would be

Re: DRM leases + X = SW only OpenGL acceleration on child X server

2018-09-24 Thread Michel Dänzer
On 2018-09-24 12:04 p.m., Raimonds Cicans wrote: > On 24.09.2018 12:17, Michel Dänzer wrote: >> On 2018-09-23 11:18 p.m., Raimonds Cicans wrote: >>> Hi! >>> >>> I am playing with new "DRM leases" feature. >>> I am trying to implement sin

Re: DRM leases + X = SW only OpenGL acceleration on child X server

2018-09-24 Thread Michel Dänzer
ror: failed to load driver: radeonsi Please attach both Xorg log files and the output of LIBGL_DEBUG=verbose DISPLAY=:101 glxgears -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

Re: xorg crash

2018-09-18 Thread Michel Dänzer
335] (II) Server terminated successfully (0). Closing log file. Looks like Xorg shut down cleanly. Either this was the wrong log file, or you have to look for the problem on the client side. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[ANNOUNCE] xf86-video-ati 18.1.0

2018-09-14 Thread Michel Dänzer
drmmode_crtc_scanout_free Keith Packard (3): modesetting: Record non-desktop kernel property at PreInit time modesetting: Create CONNECTOR_ID properties for outputs [v2] Add RandR leases support Michel Dänzer (55): Bail from dri2_create_buffer2 if we can't get a pixmap glamor: Bail

[ANNOUNCE] xf86-video-amdgpu 18.1.0

2018-09-14 Thread Michel Dänzer
on output_get_property Enable setting of color properties via RandR Compose non-legacy with legacy regamma LUT Also compose LUT when setting legacy gamma Michel Dänzer (48): Post-release version bump Ignore AMDGPU_DRM_QUEUE_ERROR (0) in amdgpu_drm_abort_entry Track DRM event

[ANNOUNCE] xf86-video-ati 18.1.0

2018-09-14 Thread Michel Dänzer
drmmode_crtc_scanout_free Keith Packard (3): modesetting: Record non-desktop kernel property at PreInit time modesetting: Create CONNECTOR_ID properties for outputs [v2] Add RandR leases support Michel Dänzer (55): Bail from dri2_create_buffer2 if we can't get a pixmap glamor: Bail

[ANNOUNCE] xf86-video-amdgpu 18.1.0

2018-09-14 Thread Michel Dänzer
on output_get_property Enable setting of color properties via RandR Compose non-legacy with legacy regamma LUT Also compose LUT when setting legacy gamma Michel Dänzer (48): Post-release version bump Ignore AMDGPU_DRM_QUEUE_ERROR (0) in amdgpu_drm_abort_entry Track DRM event

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-09-10 Thread Michel Dänzer
On 2018-09-10 12:01 p.m., Frédéric Fauberteau wrote: > Le 2018-09-10 09:26, Michel Dänzer a écrit : >> On 2018-09-10 8:22 a.m., Frédéric Fauberteau wrote: >>> Le 2018-09-01 15:16, Michel Dänzer a écrit : >>>> On 2018-09-01 9:22 a.m., Frédéric Fauberteau wrote: >&g

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-09-10 Thread Michel Dänzer
On 2018-09-10 8:22 a.m., Frédéric Fauberteau wrote: > Le 2018-09-01 15:16, Michel Dänzer a écrit : >> On 2018-09-01 9:22 a.m., Frédéric Fauberteau wrote: >>> >>> [  5770.134] (EE) RADEON(0): Failed to make prime FD for handle: 22 >>> [  5770.134] (EE) RADEON(

Re: When starting Evolution /usr/lib/gdm3/gdm-x-session[2309]: (II) modeset information is printed to syslog

2018-09-06 Thread Michel Dänzer
ent() and relying on hotplug events to > trigger re-polling. Now, maybe the X server shouldn't print the modes > in the log when that happens, [...] FWIW, it probably shouldn't indeed, at least not at the default log verbosity. -- Earthling Michel Dänzer |

Re: [PATCH xserver v2] xwayland: Remove xwl_present_window from privates on cleanup

2018-09-05 Thread Michel Dänzer
er `DestroyWindow()` so that > `xwl_present_abort_vblank()` can still access valid memory before it's > freed. This last paragraph doesn't seem to match the rest of the patch. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [PATCH xserver] glamor: Add support for exporting depth 16 pixmaps.

2018-09-05 Thread Michel Dänzer
return FALSE; > } > > -if (pixmap->drawable.depth == 30) > - format = GBM_FORMAT_ARGB2101010; > -else > - format = GBM_FORMAT_ARGB8888; > - > #ifdef GBM_BO_WITH_MODIFIERS > if (modifiers_ok && glamor_egl->dmabuf_capable) { &

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-09-01 Thread Michel Dänzer
lly https://gitlab.freedesktop.org/xorg/driver/xf86-video-ati/commit/db28d35ce9fd07a2a4703f3df0633d4c8291ff9b could help for this. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X

Re: [Pixman] [BUG] SIGSEGV in sse2_fill

2018-08-30 Thread Michel Dänzer
On 2018-08-29 9:14 p.m., Adam Jackson wrote: > continued from pixman@, original thread here: > > https://lists.freedesktop.org/archives/pixman/2018-August/004759.html Frédéric, can you attach the full corresponding Xorg log file? -- Earthling Michel Dänzer |

Re: Question about hotplugging

2018-08-29 Thread Michel Dänzer
not 4480x1440 It's up to your desktop environment. Xorg merely sends hotplug events to interested clients, it doesn't automatically change the configuration in any way. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | M

Re: [V2] modesetting: code refactor for PRIME sync

2018-08-29 Thread Michel Dänzer
nter the same issue? > > BTW, could you do me a favor to help me push the patch to the master or > other proper branch? I do not familiar with the processes that push the > patch to Xorg. Pushed to master, thanks guys. To ssh://gitlab.freedesktop.org/xorg/xserver 8a3ae555e..f79e53685 master -

Re: [PATCH xserver] randr: rrCheckPixmapBounding should only increase screen size

2018-08-24 Thread Michel Dänzer
On 2018-08-24 1:34 a.m., Alex Goins wrote: > Hi Adam, > > Can this be merged? Pushed, thanks. To ssh://gitlab.freedesktop.org/xorg/xserver 1fc20b985..a90f33721 master -> master -- Earthling Michel Dänzer | http://www.amd.com Libre softwar

Re: how do I build xf86-video-ati

2018-08-24 Thread Michel Dänzer
anything outside of your system(s). I'm looking for a general solution, hence the patch. Anyway, thanks for providing the information needed for diagnosing and addressing this issue. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusias

Re: how do I build xf86-video-ati

2018-08-23 Thread Michel Dänzer
y 'm4': No such file or directory The plot thickens. Looks like aclocal only warns if the first directory passed via -I doesn't exist, but errors out if the second one doesn't. Does https://patchwork.freedesktop.org/patch/245782/ help for this issue? -- Earthling Michel Dänzer |

Re: how do I build xf86-video-ati

2018-08-23 Thread Michel Dänzer
'm4': No such file or directory This is just a warning. > configure.ac:41: error: must install xorg-macros 1.8 or later before running > autoconf/autogen > configure.ac:41: the top level This looks like your problem. -- Earthling Michel Dänzer | http:/

Re: how do I build xf86-video-ati

2018-08-23 Thread Michel Dänzer
the full terminal output of running ./autogen.sh . -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Archives: htt

Re: [PATCH xserver] randr: rrCheckPixmapBounding should only increase screen size

2018-08-15 Thread Michel Dänzer
ht == screen_pixmap->drawable.height) { > +if (new_width <= screen_pixmap->drawable.width && > + new_height <= screen_pixmap->drawable.height) { > } else { > pScrPriv->rrScreenSetSize(pScreen, new_width, new_height, 0, 0); > } > Rev

Bug#905395: xserver-xorg-video-ati: only mouse cursor is visible and movable, distorted screen, restarting monitor on RV630

2018-08-06 Thread Michel Dänzer
ation from menu seem not influented by the transparent layer > > The problem occur after recent actualization of xserver-xorg. This should be fixed in upstream xf86-video-ati Git master. In the meantime, you should be able to avoid the problem with Option "Acce

Re: [PATCH] modesetting: Fix X crash in ms_dirty_update()

2018-08-03 Thread Michel Dänzer
if (!screen->isGPU) { msPixmapPrivPtr ppriv = msGetPixmapPriv(>drmmode, ent->slave_dst->master_pixmap); and msStartFlippingPixmapTracking and msStopFlippingPixmapTracking also need to use ->master_pixmap instead of the slave pixmaps. Not sure

Re: xserver: Changes to 'server-1.20-branch'

2018-08-02 Thread Michel Dänzer
tps://bugs.freedesktop.org/101998#c37 . I was about to get fed up with it enough to do it myself, but I might not get around to it for a couple of weeks. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa an

Re: [PATCH xserver] xwayland: Enable DRI3 for glamor

2018-07-20 Thread Michel Dänzer
r_ctx->display = xwl_screen->egl_display; > > With the above fixed, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

Re: modesetting: HWCursor and rotation

2018-07-09 Thread Michel Dänzer
be fixed?: > > a) Should my DRM driver allow to move the HW cursor buffer partially > outside the frambuffer? Yes. That's how this is working with other drivers. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [PATCH xf86-video-amdgpu 3/3] Add RandR leases with modesetting driver support [v7]

2018-07-09 Thread Michel Dänzer
against overflow of the addition and multiplication). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Arch

Re: [PATCH xf86-video-amdgpu 0/3] Add RandR lease support [v2]

2018-07-09 Thread Michel Dänzer
e amd-gfx mailing list. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/arch

Re: Revisiting the issue of obtaining Xorg commit privilege

2018-07-07 Thread Michel Dänzer
an. The r128 repository will soon be migrated to gitlab.freedesktop.org, then it will be easier to give you write access. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [PATCHv3] modesetting: Update fb_id from shadow allocate and destroy if not set

2018-07-06 Thread Michel Dänzer
On 2018-07-05 05:42 PM, Tony Lindgren wrote: > Hi, > > * Michel Dänzer [180705 14:21]: >> >> This uses the same damage region for all framebuffers, which is >> generally not correct for drmmode_crtc->rotate_fb_id. The coordinate >> offset, rotation and refl

Bug#902555: radeon.4: Some fixes in the manual

2018-07-05 Thread Michel Dänzer
On 2018-07-05 02:04 AM, Bjarni Ingi Gislason wrote: > On Fri, Jun 29, 2018 at 10:56:39AM +0200, Michel Dänzer wrote: >> >> Every item listed in Bjarni's report is logically a separate change. >> Mixing up logically separate changes (especially such a large number) >>

Re: [PATCHv3] modesetting: Update fb_id from shadow allocate and destroy if not set

2018-07-05 Thread Michel Dänzer
Screen, fb_id); > + > +skip: > +mask &= ~(1 << i); > } > } > > This uses the same damage region for all framebuffers, which is generally not correct for drmmode_crtc->rotate_fb_id. The coordinate offset, rotation and reflection need to be taken

Re: 4K@60 YCbCr420 missing mode in usermode

2018-07-02 Thread Michel Dänzer
On 2018-06-27 11:39 AM, Emil Velikov wrote: > On 27 June 2018 at 09:40, Michel Dänzer wrote: >> On 2018-06-26 07:11 PM, Emil Velikov wrote: >>> On 26 June 2018 at 17:23, Michel Dänzer wrote: >>>> On 2018-06-26 05:43 PM, Emil Velikov wrote: >>>>>

Bug#902555: radeon.4: Some fixes in the manual

2018-06-29 Thread Michel Dänzer
On 2018-06-28 03:58 PM, G. Branden Robinson wrote: > At 2018-06-28T11:31:30+0200, Michel Dänzer wrote: >> >> Please send this kind of change directly upstream to the >> amd-...@lists.freedesktop.org list for review, split up into one patch >> per logical change. >

Bug#902555: radeon.4: Some fixes in the manual

2018-06-28 Thread Michel Dänzer
> Add a comma after "e.g.". That looks odd to me. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-dri

Re: 4K@60 YCbCr420 missing mode in usermode

2018-06-27 Thread Michel Dänzer
On 2018-06-26 07:11 PM, Emil Velikov wrote: > On 26 June 2018 at 17:23, Michel Dänzer wrote: >> On 2018-06-26 05:43 PM, Emil Velikov wrote: >>> On 25 June 2018 at 22:45, Zuo, Jerry wrote: >>>> Hello all: >>>> >>>> >>>> >>&g

Re: 4K@60 YCbCr420 missing mode in usermode

2018-06-26 Thread Michel Dänzer
and mouse. > IMHO a much better approach is to not use edid codepaths for KMS > drivers (where AMDGPU is one). > On those, the supported modes is advertised by the kernel module via > drmModeGetConnector. We are getting the modes from the kernel; the issue is they are then pruned (presumab

Re: gitlab migration

2018-06-12 Thread Michel Dänzer
On 2018-06-12 01:35 PM, Daniel Stone wrote: > On 11 June 2018 at 11:33, Michel Dänzer wrote: >> On 2018-06-08 08:08 PM, Adam Jackson wrote: >>> I'd like us to start moving repos and bug tracking into gitlab. >>> Hopefully everyone's aware that gitlab exists and why fdo

Re: [PATCH xserver v3] xwayland: use pixmap size on present flip

2018-06-11 Thread Michel Dänzer
oman Gilg Pushed with this and a Fixes: tag added, thanks Olivier and Roman! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org:

Re: gitlab migration

2018-06-11 Thread Michel Dänzer
have moved to GitLab for issue tracking, to hopefully allow moving such misfiled issues. Adding the amd-gfx list, in cases somebody there has concerns or other feedback. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [PATCH xserver 1/2] xwayland: simplify xwl_glamor_pixmap_get_wl_buffer()

2018-06-11 Thread Michel Dänzer
ther, there is really no point in passing the > width/height around. > > Simplify the xwl_glamor_pixmap_get_wl_buffer() and EGL backends API by > removing the pixmap size, and use the drawable size instead. > > Signed-off-by: Olivier Fourdan Reviewed-by: Michel Dänzer

Re: [PATCH xserver] xwayland: use pixmap size on present flip

2018-06-08 Thread Michel Dänzer
gt; _created); > > event->event_id = event_id; > Please remove the present_box local, it's unused now. With that, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software

Re: [PATCH] xwayland: fix typo in non-modifier fallback path

2018-06-08 Thread Michel Dänzer
D_INVALID; > -strides[0] = gbm_go_get_stride(xwl_pixmap->bo); > +strides[0] = gbm_bo_get_stride(xwl_pixmap->bo); > offsets[0] = 0; > #endif > > Pushed, thanks! -- Earthling Michel Dänzer | http://www.amd.com

[PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Michel Dänzer
From: Michel Dänzer The incorrect values could result in the new pixmap's contents getting corrupted down the line. Bugzilla: https://bugs.freedesktop.org/106841 Fixes: 029608dd8020 "present: Add window flip mode" Signed-off-by: Michel Dänzer --- present/present_wnmd.c | 2 ++ 1 fi

Re: [PATCH xserver] exa: Use PictureMatchFormat for source-only picture format description

2018-06-07 Thread Michel Dänzer
On 2018-06-06 10:26 PM, Adam Jackson wrote: > On Fri, 2018-06-01 at 11:58 +0200, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Their pFormat member is NULL, which resulted in a crash in >> miRenderColorToPixel. >> >> Fixes: 8171d4c2d67b "

Re: Obtaining Xorg DDX commit privilege

2018-06-05 Thread Michel Dänzer
Behan has been looking after xf86-video-r128. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Archives: htt

[PATCH xserver] exa: Use PictureMatchFormat for source-only picture format description

2018-06-01 Thread Michel Dänzer
From: Michel Dänzer Their pFormat member is NULL, which resulted in a crash in miRenderColorToPixel. Fixes: 8171d4c2d67b "render: Store and use all 16bpc of precision for solid pixels (v2.1)" Signed-off-by: Michel Dänzer --- exa/exa_render.c | 3 ++- 1 file

Re: [PATCH xserver 2/2] glamor: Propagate glamor_fds_from_pixmap error in glamor_fd_from_pixmap

2018-05-28 Thread Michel Dänzer
On 2018-05-23 05:57 PM, Emil Velikov wrote: > On 23 May 2018 at 10:43, Michel Dänzer <mic...@daenzer.net> wrote: >> From: Michel Dänzer <michel.daen...@amd.com> >> >> glamor_fds_from_pixmap returns 0 on error, but we were treating that as >> success, cont

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-24 Thread Michel Dänzer
this path just go >> away? > > I guess it's needed for dri2? If all drivers using glamor are OK with > dropping dri2, then that should be OK. FWIW, our drivers don't use glamor_name_from_pixmap, so they can support DRI2 regardless. -- Earthling Michel Dänzer

[PATCH xserver 2/2] glamor: Propagate glamor_fds_from_pixmap error in glamor_fd_from_pixmap

2018-05-23 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> glamor_fds_from_pixmap returns 0 on error, but we were treating that as success, continuing with uninitialized stride and fd values. Also bail if the offset isn't 0, same as in dri3_fd_from_pixmap. Fixes: c8c276c9569b "glamor

[PATCH xserver 1/2] glamor: Always return 0 from glamor_fds_from_pixmap on error

2018-05-23 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> This matches what glamor_egl_fds_from_pixmap and dri3_fds_from_pixmap do and what proc_dri3_buffers_from_pixmap expects. Fixes: c8c276c9569b "glamor: Implement PixmapFromBuffers and BuffersFromPixmap" Signed-off-b

[PATCH xserver 2/2] modesetting: Pass O_CLOEXEC when opening a DRM device

2018-05-18 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> We don't want DRM file descriptors to leak to child processes. Signed-off-by: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/drivers/modesetting/driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH xserver 1/2] xfree86: Fix O_CLOEXEC usage in lnx_platform

2018-05-18 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> It was passing O_CLOEXEC as permission bits instead of as a flag. Signed-off-by: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/os-support/linux/lnx_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

Re: Stepping back

2018-05-15 Thread Michel Dänzer
to stop using X altogether, but it's getting harder and > harder for us to keep X alive. FWIW, since all major Linux distros are now using Wayland by default, I do think it's a good time to transition the Xorg DDX to more of a maintenance mode. Any significant new functionality should be deve

Re: Stepping back

2018-05-15 Thread Michel Dänzer
tinue to be held by the same few people. That's certainly true. > And, personally, I've been more or less focused on xserver for well > over a decade, and I badly need a change of scenery. I can relate to that feeling. :) -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-11 Thread Michel Dänzer
On 2018-05-09 07:32 PM, Adam Jackson wrote: > On Tue, 2018-05-08 at 11:42 +0200, Michel Dänzer wrote: > >> Idle notify events shouldn't need special treatment, since the pixmap >> XIDs of the buffers will be different between loader_dri3_drawable >> incarnations,

Re: Re: [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

2018-05-08 Thread Michel Dänzer
onously, but such is life. I had an idea, at least for SBC: In dri3_destroy_drawable, store the drawable's send_sbc value in a hash table (keyed on the XID) in struct dri3_screen. Then in dri3_create_drawable, if there's an entry for the drawable's XID in the hash table, initialize send_sbc and recv_

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-08 Thread Michel Dänzer
When moving from flip to copy, we assume that we can allocate in * a more optimal way if we don't need to cater for the display -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

Re: [ANNOUNCE] xorg-server 1.19.99.905

2018-04-25 Thread Michel Dänzer
On 2018-04-24 11:17 PM, Adam Jackson wrote: > More bugfixes, and streams support for Xwayland. This will almost > certainly be the last RC. What about the Xwayland Present issue with unmapped windows (affecting e.g. skypeforlinux)? -- Earthling Michel Dänzer |

Re: [PATCH xserver] present: fix msc offset calculation in window mode

2018-04-20 Thread Michel Dänzer
eturns consistent MSC values for them. That said, maybe this is the best that can be done to address the immediate issue, but it might be good to at least add a comment saying this is a kludge which should be revisited after 1.20. -- Earthling Michel Dänzer | http://ww

Re: [PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

2018-04-05 Thread Michel Dänzer
*y) > *y = crtc->y; > } > > -if (fb_id == 0) { > +if (*fb_id == 0) { > ret = drmmode_bo_import(drmmode, >front_bo, > >fb_id); > if (ret < 0) { > Reviewed-and-Tested-by: Michel Dänzer <michel.daen.

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Michel Dänzer
On 2018-04-05 03:58 PM, Daniel Stone wrote: > drmmode_crtc_set_mode has a loop nested inside another loop, where both > of them were using 'i' as the loop iterator. Rename it to avoid an > infinite loop. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Re

[ANNOUNCE] xf86-video-amdgpu 18.0.1

2018-03-15 Thread Michel Dänzer
the last client disconnects) * The Xorg process could crash when multiple primary screens are configured in xorg.conf. * TearFree could trigger debugging messages in the pixman library Michel Dänzer (4): Only change Set/MoveCursor hooks from what we expect Wrap the whole

[ANNOUNCE] xf86-video-ati 18.0.1

2018-03-15 Thread Michel Dänzer
messages in the pixman library Michel Dänzer (3): Wrap the whole miPointerScreenFuncRec, instead of only Set/MoveCursor Pass extents to radeon_scanout_do_update by value Bump version for 18.0.1 release git tag: xf86-video-ati-18.0.1 https://xorg.freedesktop.org/archive

Re: [PATCH xserver] build: Bump Mesa requirement to 17.1

2018-03-15 Thread Michel Dänzer
ncy('glproto', version: '>= 1.4.17'), > -dependency('gl', version: '>= 9.2.0'), > +dependency('gl', version: '>= 17.1.0'), > ], > ) > endif > Reviewed-by: Michel Dänzer <michel.daen...@amd.com> -- Earthling Michel Dänzer

[PATCH xserver] randr: Initialize RROuptutRec::nonDesktop

2018-03-14 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> Flagged by valgrind: ==13695== Conditional jump or move depends on uninitialised value(s) ==13695==at 0x22461C: RRNoticePropertyChange (rrproperty.c:150) ==13695==by 0x22461C: RRChangeOutputProperty (rrproperty.c:263) ==13695==by 0x

Re: [PATCH xserver v3 23/24] xwayland: Cut off upper 32bit of queued vblank delay

2018-03-14 Thread Michel Dänzer
wever, since I've been unable to reproduce the issue you described with Steam, despite kind of going out of my way to do so, I'm really reluctant to add this workaround without getting more information about the problem from someone who can reproduce it. Without understanding the problem, the workaround mi

Re: [PATCH xserver] dix: don't free() stack memory

2018-03-13 Thread Michel Dänzer
local_closure->data = data; > +local_closure->xorg = xorg; > +local_closure->yorg = yorg; > +local_closure->reqType = reqType; > +local_closure->did = did; > > -(void) doImageText(client, _closure); > +(void) doImageText(cli

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

2018-03-07 Thread Michel Dänzer
On 2018-02-28 07:00 PM, Roman Gilg wrote: > On Wed, Feb 28, 2018 at 6:43 PM, Michel Dänzer <mic...@daenzer.net> wrote: >> I'm unable to reproduce the issue you described with Steam (without this >> patch series applied). I'd really like to know where the bogus target >&g

[ANNOUNCE] xf86-video-ati 18.0.0

2018-03-06 Thread Michel Dänzer
Skip xf86HandleColormaps() at color depth 30. (v2) Support exa screen color depth 30 on Linux 3.16 and later. (v2) Add missing depth 30 -> cpp=4 handling for DRI2. Make XvMC extension initialize at depth 30. Michel Dänzer (23): Fix VT switching with ShadowFB P

[ANNOUNCE] xf86-video-ati 18.0.0

2018-03-06 Thread Michel Dänzer
Skip xf86HandleColormaps() at color depth 30. (v2) Support exa screen color depth 30 on Linux 3.16 and later. (v2) Add missing depth 30 -> cpp=4 handling for DRI2. Make XvMC extension initialize at depth 30. Michel Dänzer (23): Fix VT switching with ShadowFB P

[PATCH xserver] glamor: Restore glamor_fd_from_pixmap and glamor_pixmap_from_fd

2018-03-06 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> They're part of the 1.20 RC1 ABI, and actually used by external drivers. Also, requiring drivers which don't support the new functionality in DRI3 1.2 to switch to the new interfaces seems unreasonable. Signed-off-by: Michel Dänzer <mi

[ANNOUNCE] xf86-video-amdgpu 18.0.0

2018-03-02 Thread Michel Dänzer
Packard (2): modesetting: Skip no-longer-present connectors when resetting BAD links modesetting: Update property values at detect and uevent time Mario Kleiner (1): Define per x-screen individual drmmode_crtc_funcs Michel Dänzer (20): Post-release version bump Fix VT

Re: [PATCH xserver v2 00/22] Per window flips in Present with support for them in Xwayland

2018-02-28 Thread Michel Dänzer
On 2018-02-28 05:36 PM, Roman Gilg wrote: > This revision provides changes requested by Michel Dänzer. In particular > flips without copies in window flip mode are now possible and clients can > queue flips on Xwayland. Thanks for that. It would be even better if queuing flips wo

Re: [PATCH xserver v2 22/22] xwayland: Guard against very late vblanks

2018-02-28 Thread Michel Dänzer
ErrorF("Client queued frame too far in the future: %lu -> %lu\n", > xwl_window->present_msc, msc); > +return BadRequest; > +} If we're going this route, let's not use an arbitrary threshold like 100, but the actual one corresponding t

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

2018-02-28 Thread Michel Dänzer
On 2018-02-28 05:27 PM, Adam Jackson wrote: > On Wed, 2018-02-28 at 16:35 +0100, Michel Dänzer wrote: >> On 2018-02-12 10:51 PM, Keith Packard wrote: >>> Tracks changes to the non-desktop property so that when non-zero, >>> outputs will always appear to be disco

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

2018-02-28 Thread Michel Dänzer
output->connection, > .connection = output->connection, BTW, I don't think this was intended to leave the existing connection initializer line, clobbering the new one? -- Earthling Michel Dänzer | http://www.amd.com

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

2018-02-28 Thread Michel Dänzer
p=) at ../../dix/main.c:193 #13 0x758a3f2a in __libc_start_main (main=0x5559a3f0 , argc=4, argv=0x7fffeb08, init=, fini=, rtld_fini=, stack_end=0x7fffeaf8) at ../csu/libc-start.c:310 #14 0x00005559a42a in _start () -- Earthling Michel Dänzer |

[PATCH xserver] glx: Don't pass NULL to glxGetClient

2018-02-26 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> These guards were dropped by the commit below, but it turns out they're needed. Fixes crash on VT switch. Fixes: d8ec33fe0542 ("glx: Use vnd layer for dispatch (v4)") Bugzilla: https://bugs.freedesktop.org/105233 Signed-off-b

Re: [PATCH xserver] render: Store and use all 16bpc of precision for solid pixels (v2)

2018-02-26 Thread Michel Dänzer
On 2018-02-26 04:33 PM, Adam Jackson wrote: > This plumbs the full width color for solid pictures through to fb, exa, > and glamor. External drivers and acceleration code may wish to make a > similar change for sufficiently new servers. > > v2: Don't break ABI (Michel Dänzer)

Re: [PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

2018-02-26 Thread Michel Dänzer
-video-ati's EXA code (and other drivers maybe?) needs to be adapted for this. Do you have patches for that? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

2018-02-26 Thread Michel Dänzer
On 2018-02-24 12:58 AM, Keith Packard wrote: > Michel Dänzer <mic...@daenzer.net> writes: > >> On 2018-02-22 10:53 PM, Adam Jackson wrote: >>> "depth" for a picture format is the sum of bits of a/r/g/b, and not x. >>> The default format list was crea

Bug#891442: xserver-xorg-video-radeon: unable to load radeon module with HD 8400E

2018-02-26 Thread Michel Dänzer
loaded, so the system use > vesa > instead. The bug above only happens when using Wayland, in which case Xorg isn't used. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer __

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

2018-02-23 Thread Michel Dänzer
mat at depth 30, which is nonsense. Actually, the former isn't wrong, and the latter might not be either, I think. These are the constraints: * The sizes of a/x+r+g+b must equal bpp * The sizes of a+r+g+b must be <= depth (or == ?) -- Earthling Michel Dänzer | http://w

Re: [PATCH xserver 6/7] modesetting: Adapt xf86HandleColorMaps() for > 24 color depth.

2018-02-21 Thread Michel Dänzer
BTW, drmmode_load_palette is never called, since xf86CrtcFuncsRec::gamma_set is always non-NULL; it can be removed. Doesn't have to be done by this patch, of course. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mes

Re: All-black X windows with etnaviv/xwayland/glamor

2018-02-14 Thread Michel Dänzer
On 2018-02-13 07:34 PM, Lukas F. Hartmann wrote: > Michel Dänzer <mic...@daenzer.net> writes: >> On 2018-02-13 04:23 PM, Lukas F. Hartmann wrote: >>> >>> - Xwayland/glamor registers its gbm buffer with wl_drm_create_prime_buffer >>> (passing a fd

Re: All-black X windows with etnaviv/xwayland/glamor

2018-02-13 Thread Michel Dänzer
he same BO. Can you test Xorg with DRI3? Do OpenGL apps work correctly with that? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.o

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

2018-02-09 Thread Michel Dänzer
On 2018-02-09 07:24 AM, Mario Kleiner wrote: > On 02/08/2018 03:55 PM, Michel Dänzer wrote: >> On 2018-02-08 12:14 PM, Mario Kleiner wrote: >>> As it turns out, doing so will make any gamma table updates >>> silently fail, because xf86HandleColorMaps() hooks th

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

2018-02-08 Thread Michel Dänzer
nto the driver to set their LUTs, with no coordination between them, so whichever calls into the driver last wins and clobbers the HW LUT. It would be better to fix xf86RandR12CrtcComputeGamma instead. -- Earthling Michel Dänzer | http

Re: [PATCH 14/19] present: Add window flip mode

2018-02-07 Thread Michel Dänzer
On 2018-02-07 12:35 AM, Roman Gilg wrote: > On Fri, Feb 2, 2018 at 5:11 PM, Michel Dänzer <mic...@daenzer.net> wrote: >> Taking a step back, do we even need to keep around the original pixmap >> and unflip to it at all? I had a chat on IRC about this with Keith a >> whil

Re: [PATCH 14/19] present: Add window flip mode

2018-02-06 Thread Michel Dänzer
On 2018-02-05 09:08 PM, Adam Jackson wrote: > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > >>>> The inability to queue a presentation to the next MSC is more of a step >>>> back compared to the status quo. >>> >>> I'm about to go w

Re: [PATCH 14/19] present: Add window flip mode

2018-02-06 Thread Michel Dänzer
On 2018-02-05 08:09 PM, Keith Packard wrote: > Michel Dänzer <mic...@daenzer.net> writes: > >> Ignoring the Security extension, the client has the same control over >> the contents of another application's window *using* the X protocol, >> doesn't it? > > Yeah

Re: [PATCH 14/19] present: Add window flip mode

2018-02-05 Thread Michel Dänzer
On 2018-02-02 11:11 PM, Keith Packard wrote: > Michel Dänzer <mic...@daenzer.net> writes: > >> But this seems irrelevant for per-window flips. In this case, the window >> pixmap isn't used for anything else after flipping, so having direct >> access to the pixmap

Re: [PATCH 14/19] present: Add window flip mode

2018-02-05 Thread Michel Dänzer
On 2018-02-02 09:56 PM, Keith Packard wrote: > Michel Dänzer <mic...@daenzer.net> writes: > >> On 2018-02-02 10:42 AM, Roman Gilg wrote: >>> It's because of what you made me aware of in the previous patch set: >>> the window original pixmap needs to have t

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Michel Dänzer
On 2018-02-02 12:08 PM, Michel Dänzer wrote: > On 2018-02-02 10:42 AM, Roman Gilg wrote: > >> I also tried to not copy, but set the window pixmap to the flip >> pixmap. The problem I encountered here, is that the window original >> pixmap can be controlled

Re: [PATCH 14/19] present: Add window flip mode

2018-02-02 Thread Michel Dänzer
to queue a presentation to the next MSC is more of a step back compared to the status quo. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@

<    1   2   3   4   5   6   7   8   9   10   >