[PATCH 17/31] XFree86: Loader: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions not used by any drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/xf86Module.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86/common/xf86Module.h index

[PATCH 00/31] _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Hi, As the name implies, go through and remove the _X_EXPORT tag from anything in the server which was completely unused by any clients. The follow-up commits also cull any code which was completely dead and discarded by the linker, as well as a couple of fixes (e.g. Xinerama regeneration and

[PATCH 09/31] miext/damage: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from symbols which aren't used by, and are useless to, drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- miext/damage/damage.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/miext/damage/damage.h b/miext/damage/damage.h index

[PATCH 13/31] XFree86: Parser: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from symbols which were never used by drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/parser/configProcs.h |6 +++--- hw/xfree86/parser/xf86Optrec.h | 31 +++ hw/xfree86/parser/xf86Parser.h | 30

[PATCH 12/31] XFree86: RandR: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove useless _X_EXPORT tags from functions which are not supposed to be exported to drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/modes/xf86Crtc.h| 20 ++-- hw/xfree86/modes/xf86Modes.h | 22 +++--- hw/xfree86/modes

[PATCH 05/31] XFixes: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove unnecessary _X_EXPORT tags. Signed-off-by: Daniel Stone dan...@fooishbar.org --- xfixes/xfixes.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xfixes/xfixes.h b/xfixes/xfixes.h index 5765e64..0793f08 100644 --- a/xfixes/xfixes.h +++ b/xfixes/xfixes.h

[PATCH 11/31] mi: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove unnecessary _X_EXPORT tags from mi headers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- mi/mi.h| 44 ++-- mi/micmap.h|2 +- mi/mifpoly.h |2 +- mi/mipointer.h | 20 ++-- mi/mipoly.h| 10

[PATCH 14/31] XFree86: DRI2: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove unnecessary _X_EXPORT tags from functions not meant to be exported to drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/dri2/dri2.h | 23 +++ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/hw/xfree86/dri2/dri2.h b/hw/xfree86

[PATCH 18/31] XFree86: os-support: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove the _X_EXPORT tag from functions unused by any drivers. Sadly, i810 still exists, so we can't bin AGP support. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/os-support/bus/xf86Pci.h |6 ++-- hw/xfree86/os-support/xf86_OSproc.h | 44

[PATCH 04/31] config: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions which are only called in dix/main.c. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/hotplug.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hotplug.h b/include/hotplug.h index d074df3..229913a 100644

[PATCH 08/31] os: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from symbols which aren't and shouldn't be used by drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/client.h|7 +- include/dixstruct.h | 30 +- include/os.h| 162 +- 3 files

[PATCH 01/31] XKB: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove needless exporting of pretty much every symbol in XKB, but leave just enough so that drivers can build their own keymaps if necessary. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/xkbfile.h | 60 ++-- include/xkbrules.h | 10 ++-- include/xkbsrv.h

[PATCH 10/31] miext/sync: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions not useful to drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- miext/sync/misync.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/miext/sync/misync.h b/miext/sync/misync.h index 1c82ea5..8479137 100644 --- a/miext

[PATCH 07/31] RandR: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove unnecessary _X_EXPORT tags from symbols not used by any driver. Signed-off-by: Daniel Stone dan...@fooishbar.org --- randr/randrstr.h| 186 +- randr/rrtransform.h | 12 ++-- 2 files changed, 99 insertions(+), 99 deletions(-) diff

[PATCH 03/31] Input: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tag from needlessly exported symbols. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include/XIstubs.h |6 +++--- include/cursor.h | 26 +- include/dix.h | 28 ++-- include/dixevents.h| 38

[PATCH 31/31] GE: Remove unused RT_GECLIENT

2011-12-02 Thread Daniel Stone
Remove remnants of an earlier experiment which had the GE extension handling event delivery directly. Nothing's used the resource since, so purge it. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/geext.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/Xext

[PATCH 24/31] GLX: Remove unused noGlxVisualInit

2011-12-02 Thread Daniel Stone
No-one ever did anything with this variable except assign its default value to it. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/kdrive/ephyr/ephyr.c | 12 hw/kdrive/ephyr/ephyrinit.c |2 -- os/utils.c |1 - 3 files changed, 0 insertions

[PATCH 25/31] Xi: Remove dead Device{Enter,Leave}WindowMask

2011-12-02 Thread Daniel Stone
These were an unused remnant of earlier MPX work; their only users got cleared out in dc153271, but the mask declarations remained. Remove them, and move DevicePropertyNotify's mask up to be contiguous with the rest of the range. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xi/extinit.c

[PATCH 22/31] DIX: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions not used by any drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/dispatch.c |2 +- include/callback.h |4 +- include/dix.h| 54 +- include/dixevents.h |4 +- include/dixfont.h

[PATCH 26/31] Render: Remove unused glyphDepths

2011-12-02 Thread Daniel Stone
No-one has used this since 0a71e154. Signed-off-by: Daniel Stone dan...@fooishbar.org --- render/glyph.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/render/glyph.c b/render/glyph.c index 7193d47..2f8b424 100644 --- a/render/glyph.c +++ b/render/glyph.c @@ -80,8

[PATCH 29/31] XFree86: os-support: Remove unused xf86MakeNewMapping

2011-12-02 Thread Daniel Stone
No drivers used this, so it got unexported, and now it's so unused it got culled during the link. Take the poor function out behind the shed and put it out of its misery. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/os-support/shared/vidmem.c | 12 hw/xfree86

[PATCH 28/31] Xinerama: Reset Composite request vector on close

2011-12-02 Thread Daniel Stone
Similar (identical) to how it interacts with Render and XFixes, also call PanoramiXCompositeReset() to restore the Composite dispatch table to how it was when it started, on reset. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/panoramiX.c |3 +++ 1 files changed, 3 insertions

[PATCH 27/31] XvMC: Remove unused XvMCGeneration

2011-12-02 Thread Daniel Stone
I wonder if this even works across multiple generations. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/xvmc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/Xext/xvmc.c b/Xext/xvmc.c index 5f6574f..a3cf67e 100644 --- a/Xext/xvmc.c +++ b/Xext/xvmc.c @@ -38,8

[PATCH 23/31] XKB: Geom: Remove unused code

2011-12-02 Thread Daniel Stone
These codepaths were never called by anyone. Shame there weren't more of them. Signed-off-by: Daniel Stone dan...@fooishbar.org --- xkb/XKBGAlloc.c | 128 --- xkb/xkbgeom.h | 17 --- 2 files changed, 0 insertions(+), 145 deletions

[PATCH 20/31] XFree86: Extensions: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions not used by any drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/dgaproc.h | 54 ++-- hw/xfree86/common/vidmodeproc.h | 58 +++--- hw/xfree86/common/xf86.h

[PATCH 19/31] XFree86: DDC: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Remove _X_EXPORT tags from functions not used by any drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/ddc/xf86DDC.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/ddc/xf86DDC.h b/hw/xfree86/ddc/xf86DDC.h index 16a8641..60fc227

[PATCH 15/42] Move XRes from extmod to built-in

2011-12-02 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build XRes support into the core server, rather than letting it languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Peter

[PATCH 27/42] DRI2: Remove prototype for DRI2DestroyDrawable

2011-12-02 Thread Daniel Stone
DRI2DestroyDrawable() was still being _X_EXPORTed, but hasn't existed since 1da1f33f last year. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off

[PATCH 30/31] Sync: Destroy system counters on reset

2011-12-02 Thread Daniel Stone
When resetting the extension, make sure we also destroy the system counters we created at ExtensionInit time as well. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/sync.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/Xext/sync.c b/Xext

[PATCH v2 29/42] Add static extensions before those in modules

2011-12-02 Thread Daniel Stone
Make sure we add static extensions before anything in a module. This is more or less a no-op at the moment, but will come in handy later when extension dependency sorting is removed. Signed-off-by: Daniel Stone dan...@fooishbar.org --- v2: New, fixes GLX vs. Composite visual creation. hw

Re: [PATCH 0/37] Extension handling cleanup, death to extmod

2011-12-02 Thread Daniel Stone
Hi Jamey, On Thu, Jun 30, 2011 at 04:06:02PM -0700, Jamey Sharp wrote: I sure like the results of this series. I've reviewed the patches as I found them on your personal branch. The abbreviated commit hashes that I reviewed are listed together with their commit summaries below. Thanks a heap

Re: [PATCH 00/31] _X_UNEXPORT

2011-12-02 Thread Daniel Stone
Hi, On 2 December 2011 12:19, Keith Packard kei...@keithp.com wrote: On Fri,  2 Dec 2011 11:31:06 +, Daniel Stone dan...@fooishbar.org wrote: As the name implies, go through and remove the _X_EXPORT tag from anything in the server which was completely unused by any clients.  The follow-up

Re: [PATCH 10/31] miext/sync: _X_UNEXPORT

2011-12-02 Thread Daniel Stone
On 2 December 2011 16:13, James Jones jajo...@nvidia.com wrote: Reviewed-by: James Jones jajo...@nvidia.com Thanks. :) Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] pkgconfig files should be installed to $(libdir)

2011-11-17 Thread Daniel Stone
Hi, On 17 November 2011 11:10, Dmitry Shatrov shat...@gmail.com wrote: --- a/Makefile.am +++ b/Makefile.am @@ -14,7 +14,7 @@ Xtransinclude_HEADERS = \  aclocaldir = $(datadir)/aclocal  aclocal_DATA = xtrans.m4 -pkgconfigdir = $(datadir)/pkgconfig +pkgconfigdir = $(libdir)/pkgconfig  

Re: [PATCH 01/12] include: fix mask size calculation

2011-11-09 Thread Daniel Stone
Hi, On 9 November 2011 02:27, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 08, 2011 at 02:00:53PM +, Daniel Stone wrote: On 7 November 2011 21:39, Peter Hutterer peter.hutte...@who-t.net wrote:  * this number here is bumped.  */  #define XI2LASTEVENT    17

Re: [PATCH] Xi: allow passive keygrabs on the XIAll(Master)Devices fake devices

2011-11-08 Thread Daniel Stone
Hi, On 27 October 2011 02:51, Peter Hutterer peter.hutte...@who-t.net wrote: They don't have a KeyClassRec, but we must still allow passive grabs on them. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH 01/12] include: fix mask size calculation

2011-11-08 Thread Daniel Stone
Hi, On 7 November 2011 21:39, Peter Hutterer peter.hutte...@who-t.net wrote: Same bug as inputproto-2.0.1-9-gb1149ab, if the XI2LASTEVENT was a multiple of 8, the mask was one bit too short. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  include/inputstr.h |    2 +-  1 files

Re: [PATCH - RESEND] Don't fallback to wsfb or fbdev on Solaris

2011-11-04 Thread Daniel Stone
On 4 November 2011 04:51, Alan Coopersmith alan.coopersm...@oracle.com wrote: We don't ship either one, so don't waste time and make confusing log entries trying to load them. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH 06/11] Move DoShowOptions to xf86Configure.c, delete xf86ShowOpts.c

2011-11-04 Thread Daniel Stone
the copyright statement from xf86ShowOpts.c as well, but with that fixed: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] xfree86: Fix powerpc build with -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast

2011-11-01 Thread Daniel Stone
Hi, On 1 November 2011 22:05, Jeremy Huddleston jerem...@apple.com wrote: While this does fix the build failure, I'd much rather change memType to be a uintptr_t everywhere, but it was explicitly set to uint64_t for 32bit powerpc by Ian in the commit referenced below.  Ian, can you explain

Re: [PATCH 5/7] xf86ShowOpts.c: Remove bad code from DoShowOptions

2011-11-01 Thread Daniel Stone
optionTypeToSting, now that it's unused. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH 7/7] Remove unnecessary variable rtrn in XkbKeysymText

2011-11-01 Thread Daniel Stone
On 1 November 2011 22:42, Alan Coopersmith alan.coopersm...@oracle.com wrote: Also removes even more unnecessary use of variable assignment inside function arguments. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH 5/7] xf86ShowOpts.c: Remove bad code from DoShowOptions

2011-11-01 Thread Daniel Stone
Hi, On 2 November 2011 01:14, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 11/01/11 17:50, Daniel Stone wrote: On 1 November 2011 22:42, Alan Coopersmithalan.coopersm...@oracle.com  wrote: When we want to print a string, it's okay to just print it. We don't need to first allocate

Re: [PATCH xinput 2/2] We support XI 2.1 now

2011-10-26 Thread Daniel Stone
Hi, On 25 October 2011 23:14, Peter Hutterer peter.hutte...@who-t.net wrote: @@ -28,7 +28,12 @@  int xi_opcode;  #if HAVE_XI2  int xi2_supported_major = 2; -int xi2_supported_minor = 0; +int xi2_supported_minor = +#if HAVE_XI21 +                        1; +#else +                        

Re: [PATCH 2/6] dix: drop unused argument from XISendDeviceChangedEvent

2011-10-22 Thread Daniel Stone
Hi, On 22 October 2011 00:18, Jeremy Huddleston jerem...@apple.com wrote: I'm confused by the comment, and just using master ... because the prototype changes: -XISendDeviceChangedEvent(DeviceIntPtr device, DeviceIntPtr master, DeviceChangedEvent *dce)

Re: [PATCH 1/6] dix: add ScrollInfo to DeviceChangedEvents

2011-10-20 Thread Daniel Stone
double_to_fp3232, no? Other than that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/6] dix: drop unused argument from XISendDeviceChangedEvent

2011-10-20 Thread Daniel Stone
...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 5/6] dix: accept a NULL master for CreateClassesChangedEvent

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 04:25:45PM +1000, Peter Hutterer wrote: If a floating device changes, the master is NULL but we must still create a DCE for it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH 6/6] Xi: send DeviceChangedEvents when the scroll valuators change value

2011-10-20 Thread Daniel Stone
master event if the device was the last slave -- is probably something we can centralise for great justice. Still: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH 3/6] dix: pass the flags into the CreateClassesChangedEvent

2011-10-20 Thread Daniel Stone
On Thu, Oct 20, 2011 at 04:25:43PM +1000, Peter Hutterer wrote: No effective functional changes, prep work for future patches. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel

Re: [PATCH RESEND 1/5] input: switch InputOption to use XF86OptionRec storage.

2011-10-20 Thread Daniel Stone
...@gmail.com @@ -670,8 +671,8 @@ point_on_screen(ScreenPtr pScreen, int x, int y) static void input_option_free(InputOption *o) { -free(o-key); -free(o-value); +free(o-opt_name); +free(o-opt_val); free(o); } + free(o-opt_comment); With that: Reviewed-by: Daniel

Re: [PATCH RESEND 2/5] xfree86: use xf86AddNewOption instead of xf86addNewOption

2011-10-20 Thread Daniel Stone
peter.hutte...@who-t.net Unbelievable. Perhaps we could deprecate one of these APIs? Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH RESEND 5/5] xfree86: use NewInputDeviceRequest for xorg.conf devices too

2011-10-20 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH RESEND 3/5] xfree86: Fix a comment, the old function doesn't exist anymore

2011-10-20 Thread Daniel Stone
On 20 October 2011 04:05, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH RESEND 4/5] dix: move #if statement to stop compiler warning

2011-10-20 Thread Daniel Stone
to ignore that warning. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 4/6] Xi: ensure the deviceid for DeviceChangedEvents is always the right one

2011-10-20 Thread Daniel Stone
-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] dix: mark motion events as emulated if we're scrolling from button press

2011-10-14 Thread Daniel Stone
Hmm, my original review got lost. It was along the lines of 'it's not pretty, but ... Reviewed-by: Daniel Stone dan...@fooishbar.org'. Cheers, Daniel On 14 October 2011 00:07, Peter Hutterer peter.hutte...@who-t.net wrote: ping? On Wed, Oct 05, 2011 at 12:14:47PM +1000, Peter Hutterer wrote

Re: [PATCH-V4] xserver: Optional backtrace handler

2011-10-13 Thread Daniel Stone
Hi, On 13 October 2011 17:53, Keith Packard kei...@keithp.com wrote: On Thu, 13 Oct 2011 14:49:42 +0100, Simon Farnsworth simon.farnswo...@onelan.co.uk wrote: A question - what is it about preforking a backtrace handler that you think will put people off using it? It's an ugly hack to work

Re: [PATCH] test: fix input test

2011-10-12 Thread Daniel Stone
, 0, sizeof(vcp_sprite)); et al would be even better ... With that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCHv2] makekeys: Fix build/target word size mismatch when cross-compiling

2011-10-12 Thread Daniel Stone
mismatches upon running X, and some LSB test failures (xts5). Use an unsigned 32-bit integer on all platforms. Also, eliminate the redundant multiple typedefs for the Signature type. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PULL] XI 2.1 - raw events and smooth scrolling

2011-10-04 Thread Daniel Stone
Hi, On 3 October 2011 11:50, Max Schwarz m...@x-quadraht.de wrote:       Input: Add smooth-scrolling support to GetPointerEvents There's a subtle bug on that one: Old-style scroll button presses create inverted emulated presses (and maybe inverted valuator events, but I don't know which

Re: [PATCH 00/12] Multihead screen crossing fixes

2011-10-04 Thread Daniel Stone
into a wall.) For patches 1-11: Reviewed-by: Daniel Stone dan...@fooishbar.org although returning a screen from miPointerSetPosition seems a bit weird. Oh well. I'm not sure I'm feeling up to 12 right now, as I just ate breakfast. Cheers, Daniel ___ xorg

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Daniel Stone
Hi, On 4 October 2011 16:00, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011

Re: [PATCH xserver] Fix FP3232 related issues.

2011-10-04 Thread Daniel Stone
Hi, 2011/10/4 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com Make check has been broken since commit f32c827d513c44f07e1d0fbcc0c96cef18c9a4d9 ('Input: Fix frac calculation on [Raw]DeviceEvent conversion'). * Use floor() instead of trunc() in order to achieve

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-10-03 Thread Daniel Stone
Hi, On 3 October 2011 06:06, Jeremy Huddleston jerem...@apple.com wrote: On Oct 2, 2011, at 16:30, Peter Hutterer wrote: On Sun, Oct 02, 2011 at 10:52:03AM -0700, Jamey Sharp wrote: And I think ldexp is a much better idea than either. :-) It's more clear, and as an added bonus, probably

Re: Last chance: FOSDEM2012 speakers due today.

2011-10-02 Thread Daniel Stone
Hi, On 2 October 2011 08:17, Matthieu Herrb matthieu.he...@laas.fr wrote: On Sat, Oct 01, 2011 at 03:14:12PM +0200, Luc Verhaegen wrote: If you know that you are coming to FOSDEM, but for some reason think that someone else should step up instead, then think again, and reply ASAP. Luc, I

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-10-02 Thread Daniel Stone
Hi, On 2 October 2011 09:19, Jeremy Huddleston jerem...@apple.com wrote: Peter, any thoughts on this? I think using * (1 16) * (1 16) is a better idea than (1ULL 32). Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Daniel Stone
Hi, On 30 September 2011 17:18, Chase Douglas chase.doug...@canonical.com wrote: On 09/29/2011 09:29 PM, Peter Hutterer wrote: Using this call simplifies callers that don't know if the mask bit is set. Before:   if (valuator_mask_isset(mask, valnum))     value =

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Daniel Stone
Hi, On 1 October 2011 00:32, Chase Douglas chase.doug...@canonical.com wrote: On 09/30/2011 04:07 PM, Daniel Stone wrote: e.g.: double valuator_mask_fetch_double(struct valuator_mask *mask, int index) {     if (valuator_mask_isset(mask, index)         return valuator_mask_get_double(mask

Re: [PATCH] edid: Add quirk for Acer Aspire One 110

2011-09-28 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org Anyone got a more-or-less-impending pull request they want to pick this one up for? Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: Building DRI-disabled drivers with DRI-enabled xserver

2011-09-27 Thread Daniel Stone
Hi, On 27 September 2011 19:05, Julien Cristau jcris...@debian.org wrote: On Mon, Sep 26, 2011 at 19:22:31 -0400, Matt Turner wrote: It seems impossible currently to build DDXs with --disable-dri against an X server built with DRI. The X server's xorg-server.h file defines XF86DRI, which is

Re: [PATCH v2] Input: Add smooth-scrolling support

2011-09-27 Thread Daniel Stone
and the conditional as well, and have emulate_scroll_button_events catch max_events = 0 and just do nothing. (I think the comment in emulate_scroll_button_events about fill_pointer_events wants revisiting too, strictly speaking.) Other than that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH evdev 1/1] Support smooth scrolling on REL_WHEEL, REL_HWHEEL and REL_DIAL

2011-09-27 Thread Daniel Stone
Hi, On 23 September 2011 00:14, Peter Hutterer peter.hutte...@who-t.net wrote: [general reassurance] Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH libXi] Use a separate nclasses variable in XIQueryDevice

2011-09-27 Thread Daniel Stone
Hi, On 23 September 2011 00:08, Peter Hutterer peter.hutte...@who-t.net wrote:         lib-classes = Xmalloc(size_classes((xXIAnyInfo*)ptr, lib-num_classes)); I think this should be nclasses instead of lib-num_classes, no? With that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers

Re: [PATCH v2 1/2] input: switch InitValuatorAxisStruct to return Bool

2011-09-27 Thread Daniel Stone
Hi, On 23 September 2011 03:12, Peter Hutterer peter.hutte...@who-t.net wrote: Return errors instead of silently ignoring them. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH v2 2/2] input: allow for max min for relative axes on InitValuatorAxisStruct

2011-09-27 Thread Daniel Stone
-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Daniel Stone
Hi, On 24 September 2011 13:26, Mark Kettenis mark.kette...@xs4all.nl wrote: It's still work.  And it probably inflicts pain on people like Micahel Daenzer who maintain drivers for older xserver releases.  And it also inflicts pain on people who maintain drivers out of the git repositories on

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Daniel Stone
Hi, On 23 September 2011 15:10, Mark Kettenis mark.kette...@xs4all.nl wrote: Unlike Tiago's origional changes this looks like it is actually going somewhere, and generally this looks like a good idea, even if it breaks some stuff temporarily.  But I'd like to check that not too many

Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection

2011-09-23 Thread Daniel Stone
Hi, On 23 September 2011 15:58, Michal Suchanek hramr...@centrum.cz wrote: There are obviously people sabotaging X already since the change went in more than two years ago and stayed in spite of being pointed out as bogus. I think that your emails are bogus, and if you keep on sending them

Re: [PATCH evdev 1/1] Support smooth scrolling on REL_WHEEL, REL_HWHEEL and REL_DIAL

2011-09-22 Thread Daniel Stone
Hi, On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote: +#ifdef HAVE_SMOOTH_SCROLLING +if (axis == REL_WHEEL) +SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0, SCROLL_FLAG_PREFERRED); +else if (axis == REL_DIAL) +

Re: [PATCH inputproto 2/2] Move scroll information into a new class.

2011-09-22 Thread Daniel Stone
Hi, On Mon, Aug 22, 2011 at 03:35:17PM +1000, Peter Hutterer wrote: +If more than one scroll valuator of the same type is present on a device, +the valuator marked with Preferred is used to convert legacy button events +into scroll valuator events. If no valuator is marked Preferred or more

Re: [PATCH libXi 4/5] Support XI 2.1 internally

2011-09-22 Thread Daniel Stone
Huddleston jerem...@apple.com Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/a few] smooth scrolling support

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:14PM +1000, Peter Hutterer wrote: This is the patchset for the revised smooth scrolling support. The basic principle stays the same (valuator information instead of button clicks), the protocol itself chanages a bit. Instead of a dedicated virtual axis, mark those

Re: [PATCH xinput] Only try to print XIPointerEmulated flag if it is defined.

2011-09-22 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libXi 5/5] Support XI 2.1 XIScrollClass

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:22PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH 2/8] dix: fill out root_x/y for keyboard events

2011-09-22 Thread Daniel Stone
if needed). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org but ... @@ -953,6 +962,11 @@ GetKeyboardEvents(InternalEvent *events, DeviceIntPtr pDev, int type, set_valuators(pDev, event, mask); +if (!IsFloating(pDev

Re: [PATCH 3/8] dix: warn about keyboard events with valuator masks

2011-09-22 Thread Daniel Stone
-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/4] Announce XI 2.1 support

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:24PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org But shouldn't this come last in the series, when we actually have scroll support in place, rather than first? Cheers, Daniel

Re: [PATCH xserver 2/4] input: allow for max min for relative axes on InitValuatorAxisStruct

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:25PM +1000, Peter Hutterer wrote: And use this occasion to switch InitValuatorAxisStruct to return Bool instead of just silently ignoring issues. Relative axes are initialized with 0, -1 but so far this never had any effect as all users of this function (for

Re: [PATCH xinput] Only try to print XIPointerEmulated flag if it is defined.

2011-09-22 Thread Daniel Stone
On Wed, Aug 24, 2011 at 07:51:44AM +1000, Peter Hutterer wrote: This flag is part of the future (currently unreleased) XI 2.1 protocol. Introduced in 2c5187d0099e6c7588828ba9931d27f5c64bbaec You can change this to HAVE_XI21 now. Either way: Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH xinput 1/1] Support the new Scroll class

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:23PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org However ... +# XI2.1 support +PKG_CHECK_MODULES(XI21, [xi = 1.4.99.1] [inputproto = 2.0.99.1], + HAVE_XI21

Re: [PATCH 4/8] dix: NewCurrentScreen must work on pointers where possible

2011-09-22 Thread Daniel Stone
through the XTest device attached to this device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org I wonder if it's time to rename the XTest devices too ... Cheers, Daniel ___ xorg-devel@lists.x.org

Re: [PATCH 5/8] Move pointOnScreen to inpututils.c

2011-09-22 Thread Daniel Stone
On Fri, Sep 09, 2011 at 02:20:50PM +1000, Peter Hutterer wrote: We need this from other files too. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 7/8] Store desktop dimensions in screenInfo.

2011-09-22 Thread Daniel Stone
...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org s/desktop/screen/ might be sensible though. I don't think we need much more confusing nomenclature. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH libXi 1/5] Handle unknown device classes.

2011-09-22 Thread Daniel Stone
On Mon, Aug 22, 2011 at 03:35:18PM +1000, Peter Hutterer wrote: @@ -1564,13 +1576,13 @@ wireToDeviceChangedEvent(xXIDeviceChangedEvent *in, XGenericEventCookie *cookie) out-deviceid = in-deviceid; out-sourceid = in-sourceid; out-reason = in-reason; -out-num_classes =

Re: [PATCH xserver 4/4] input: support the new XIScrollClass to mark axes as scrolling axes

2011-09-22 Thread Daniel Stone
Hi, On Mon, Aug 22, 2011 at 03:35:27PM +1000, Peter Hutterer wrote: +if (*current_ax != -1 axnum != *current_ax) +{ +ax = dev-valuator-axes[*current_ax]; +if (ax-scroll.type == type (flags SCROLL_FLAG_PREFERRED) == (ax-scroll.flags SCROLL_FLAG_PREFERRED)) +

Re: X/Graphics DevRoom at FOSDEM 2012? (4-5 February)

2011-09-20 Thread Daniel Stone
Hi, On Tuesday, 20 September 2011, Luc Verhaegen l...@skynet.be wrote: This sound like a rather redhat specific topic. How certain are you that redhat is going to send you to FOSDEM, and if they don't, are you coming regardless? In much the same way that every RadeonHD talk was completely

Re: X/Graphics DevRoom at FOSDEM 2012? (4-5 February)

2011-09-20 Thread Daniel Stone
Hi, On Tuesday, 20 September 2011, Chris Wilson ch...@chris-wilson.co.uk wrote: Daniel, think you might pop over for the weekend and teach us a thing or two about the DRM infrastructure and what it might look like in a year or two as more SoC gradually become mainline? Perhaps. FOSDEM is a

Re: Xserver driver merging pros cons

2011-09-17 Thread Daniel Stone
Hi, On 17 September 2011 12:04, Matthieu Herrb matthieu.he...@laas.fr wrote: On Thu, Sep 15, 2011 at 10:45:17AM -0500, Jesse Barnes wrote: Cons:  [...]   3) makes it harder to maintain out of tree drivers, since API      breaks are not going to be documented anymore.      If old pre-kms

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

2011-09-17 Thread Daniel Stone
Hi, On 17 September 2011 02:36, Michael macallan1...@gmail.com wrote: On Fri, 16 Sep 2011 21:13:10 -0400 Matt Turner matts...@gmail.com wrote: I think we should simply maintain the drivers we care about. I'll try to keep -glint going. For other drivers without any sort of maintainer, I don't

<    2   3   4   5   6   7   8   9   10   11   >