Josh and I sorted out a bunch of Xlib bugs this week, especially in
support for multi-threaded applications. I'm embarrassed that I hadn't
realized the thread support was so bad--but there are so few threaded
Xlib apps, and even fewer that are open source.
One important fix is in libxcb master.
On Sat, Apr 17, 2010 at 09:20:45PM -0700, Keith Packard wrote:
On Fri, 16 Apr 2010 22:45:02 +0200, olafbuddenha...@gmx.net wrote:
On Tue, Apr 06, 2010 at 06:43:22PM -0700, Keith Packard wrote:
This isn't a git super-module,
Well, why not?
I don't think the wire protocol is a place
On Fri, Apr 16, 2010 at 11:00:50AM -0700, Dan Nicholson wrote:
On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote:
On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote:
It might be nicer, but could get messy when you consider all the corner
cases.
True, and the
On Fri, Apr 16, 2010 at 04:35:22PM +1000, Peter Hutterer wrote:
GetPairedDevice() may not always return the keyboard, resulting in a
null-pointer derefernce when accessing the XKB state.
X.Org Bug 27573 http://bugs.freedesktop.org/show_bug.cgi?id=27573
Signed-off-by: Peter Hutterer
On Fri, Apr 16, 2010 at 03:10:19PM +0300, Tiago Vignatti wrote:
Some Linux systems might not want to link against rt and pthread libraries
simply to implement monotonic clock (GetTimeInMillis). For those, use a direct
syscall instead. This is discouraged if someone doesn't know what's doing.
On Sat, Apr 17, 2010 at 08:45:38AM -0700, Dan Nicholson wrote:
It seems it would be better to check ps unless you're pretty sure
pScreen always has a PictureScreen.
Looking at this code showed me another bug.
#ifdef RENDER
PictureScreenPtrps = GetPictureScreenIfSet(pScreen);
On Sat, Apr 17, 2010 at 09:36:23PM +0200, Dirk Wallenstein wrote:
_XkbCopyGeom did not copy all of the data from the source geometry. This
resulted in failures when trying to obtain the keymap from a server
where the default geometry has not been replaced by a custom
configuration.
On Mon, Apr 19, 2010 at 05:30:48PM +1000, Daniel Stone wrote:
On Mon, Apr 19, 2010 at 10:17:08AM +1000, Peter Hutterer wrote:
Keith, please pull from my repo below. It contains Benjamin's overflow fix
and the xkb cleanup for PointerKeys.
Might be good to get Dirk's _XkbCopyGeom fix in with
On Fri, Apr 16, 2010 at 16:35:22 +1000, Peter Hutterer wrote:
GetPairedDevice() may not always return the keyboard, resulting in a
null-pointer derefernce when accessing the XKB state.
X.Org Bug 27573 http://bugs.freedesktop.org/show_bug.cgi?id=27573
Ben followed up on the bug and
On Mon, Apr 19, 2010 at 11:26:23AM +0200, Julien Cristau wrote:
On Fri, Apr 16, 2010 at 16:35:22 +1000, Peter Hutterer wrote:
GetPairedDevice() may not always return the keyboard, resulting in a
null-pointer derefernce when accessing the XKB state.
X.Org Bug 27573
On Sun, 18 Apr 2010 19:30:31 +0200
Dirk Wallenstein hals...@t-online.de wrote:
A full-fledged meta-git repo management tool suite would be nice. Such
an application would, for example, be able to:
- inform about the state of the modules (dirty, ahead of origin/master,
not on master, etc)
-
On Fre, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote:
The main motivation here is to have the resource system clean up the
DRI2 drawable automatically so glx doesn't have to. Right now, the
glx drawable resource must be destroyed before the X drawable, so that
calling
Am 19.04.2010 08:33, schrieb Jamey Sharp:
Hoping to be Done With Xlib any day now,
Jamey
I could follow your reasoning and the changes make sense to me. But I
don't know the overall system enough to pretend that's a review.
Maybe a good gsoc/student project would be to model Xlib/xcb
Does you guys have any flowcharts/diagrams/etc of any of the
blocks/functions/pieces? I'm trying to round up any and all useful
information for any/all of X.
thanks,
Matt
On Mon, Apr 19, 2010 at 7:49 PM, Simon Thum simon.t...@gmx.de wrote:
Am 19.04.2010 08:33, schrieb Jamey Sharp:
Hoping to
On Mon, Apr 19, 2010 at 12:05 AM, Daniel Stone dan...@fooishbar.org wrote:
On Fri, Apr 16, 2010 at 11:00:50AM -0700, Dan Nicholson wrote:
On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote:
On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote:
It might be nicer, but
Jamey Sharp wrote:
Josh and I sorted out a bunch of Xlib bugs this week, especially in
support for multi-threaded applications. I'm embarrassed that I hadn't
realized the thread support was so bad--but there are so few threaded
Xlib apps, and even fewer that are open source.
This sounds great.
On Mon, 2010-04-19 at 09:58 +1000, Peter Hutterer wrote:
On Sat, Apr 17, 2010 at 07:28:00PM -0400, Gaetan Nadon wrote:
Patch #1 concept has been reviewed but code is different
Patch #7 is a change that has not been reviewed in other patches yet.
Other changes have been reviewed in other
It looks like the udev rule was matched against two devices which caused
the driver to be loaded twice. We shouldn't match against the other
device because it will very seldom send bogus events. Some of the bug
this caused was buttons getting stuck.
---
tools/69-xorg-vmmouse.rules.in |2 +-
1
On Mon, 2010-04-19 at 15:37 +0100, Jakob Bornecrantz wrote:
It looks like the udev rule was matched against two devices which caused
the driver to be loaded twice. We shouldn't match against the other
device because it will very seldom send bogus events. Some of the bug
this caused was
Peter Hutterer wrote:
Why not have the slave inherit the volume level of the master when it is
attached?
Careful here - a client may change the bell on just one device and detach it
(or implicitly detach with a grab). In this case, the device shouldn't
inherit the bell volume from the
(I've cc'ed xorg-devel, since this is really much more of a developer topic than
a user topic.)
Zhang, Xing Z wrote:
Hi experts:
I am looking into code of tigervnc, the Xvnc contains a vnc X server
which seems a X driver or extension ( it locates at
This patch was created with:
git ls-files '*.[ch]' | while read f; do unifdef -B -DRENDER -o $f $f; done
Signed-off-by: Keith Packard kei...@keithp.com
---
Xext/panoramiX.c |6 --
Xext/panoramiX.h |2 --
exa/exa.c
On Mon, 19 Apr 2010 09:53:32 -0700, Keith Packard kei...@keithp.com wrote:
This patch was created with:
git ls-files '*.[ch]' | while read f; do unifdef -B -DRENDER -o $f $f;
done
This is not an actual proposal to apply this patch, I just wanted to
start discussion on what we could do if
Hi,
I had check all commentaries people gave and reworked accordingly. Let's see
if now looks better for you.
Besides, the last two patches here no one commented, so I'm resending. Both
concern a not reached very old code (so gray hair people are very welcome to
comment on :).
Thanks,
Tiago
Seems to be harmless. Meh.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/parser/scan.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c
index 8aab0cf..06710d5 100644
---
the alternative would be to check ps in the beginning of the function.
---
exa/exa.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/exa/exa.c b/exa/exa.c
index 590d9a5..b2bd1c5 100644
--- a/exa/exa.c
+++ b/exa/exa.c
@@ -779,14 +779,12 @@ exaCloseScreen(int
---
xkb/xkbEvents.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c
index 33741e9..9755f98 100644
--- a/xkb/xkbEvents.c
+++ b/xkb/xkbEvents.c
@@ -1041,8 +1041,7 @@ XkbInterestPtrinterest;
return
Both dev and dev-button are already used before their checking were being
performed. So check on the beginning.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
Xi/xiquerydevice.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/Xi/xiquerydevice.c
just moved the srv assignment to before it's being used.
---
xkb/xkbout.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xkb/xkbout.c b/xkb/xkbout.c
index 68ede90..9daac9a 100644
--- a/xkb/xkbout.c
+++ b/xkb/xkbout.c
@@ -354,7 +354,6 @@ XkbServerMapPtr srv;
This issue was introduced in the first dump of the code in 2004. I haven't
check what's the correct fix for it so I simply kept the behaviour of someone
calling this and removed the unreachable code.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/i2c/fi1236.c |4
CLEARRTS_SUPPORT cannot be triggered at all.
Both commit logs and google don't show any clear reference about it, so I'd
vote to just delete.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/os-support/shared/posix_tty.c | 13 -
1 files changed, 0
On Mon, Apr 19, 2010 at 4:49 AM, Simon Thum simon.t...@gmx.de wrote:
I could follow your reasoning and the changes make sense to me. But I
don't know the overall system enough to pretend that's a review.
It's a good data point, anyway. Thanks!
Am 19.04.2010 08:33, schrieb Jamey Sharp:
Hoping
On Sat, Apr 17, 2010 at 4:28 PM, Gaetan Nadon mems...@videotron.ca wrote:
Patch #1 concept has been reviewed but code is different
Patch #7 is a change that has not been reviewed in other patches yet.
Other changes have been reviewed in other patches
Gaetan Nadon (10):
config: remove AH_TOP
Generates the git module version according to the git describe HEAD
If the git module has pending changes, it appends -dirty to the version tag
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
xorg-macros.m4.in | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
On Mon, 2010-04-19 at 11:48 -0700, Dan Nicholson wrote:
On Sat, Apr 17, 2010 at 4:28 PM, Gaetan Nadon mems...@videotron.ca wrote:
Patch #1 concept has been reviewed but code is different
Patch #7 is a change that has not been reviewed in other patches yet.
Other changes have been reviewed
On Mon, Apr 19, 2010 at 11:52 AM, Gaetan Nadon mems...@videotron.ca wrote:
Generates the git module version according to the git describe HEAD
If the git module has pending changes, it appends -dirty to the version tag
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
xorg-macros.m4.in |
On Mon, Apr 19, 2010 at 14:52:55 -0400, Gaetan Nadon wrote:
Generates the git module version according to the git describe HEAD
If the git module has pending changes, it appends -dirty to the version tag
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
xorg-macros.m4.in | 18
Keith Packard wrote:
On Mon, 19 Apr 2010 09:53:32 -0700, Keith Packard kei...@keithp.com wrote:
This patch was created with:
git ls-files '*.[ch]' | while read f; do unifdef -B -DRENDER -o $f $f;
done
This is not an actual proposal to apply this patch, I just wanted to
start discussion on
I almost asked about why we still had #ifdef RENDER when seeing the discussion
on Tiago's patches last week, I'm not sure if there's any point in keeping the
#ifdefs any more.
diff --git a/hw/vfb/InitOutput.c b/hw/vfb/InitOutput.c
index e7dd1d9..0428f0a 100644
--- a/hw/vfb/InitOutput.c
+++
Date: Mon, 19 Apr 2010 14:27:11 -0700
From: Alan Coopersmith alan.coopersm...@oracle.com
I almost asked about why we still had #ifdef RENDER when seeing the
discussion on Tiago's patches last week, I'm not sure if there's any
point in keeping the #ifdefs any more.
I believe almost no
On Thu, Feb 18, 2010 at 06:07:14AM -0800, Dan Nicholson wrote:
A while back Peter asked me about helping him add autotools support
after he pulled xtest out of cvs into git. We got that handled pretty
quickly, but I decided to spend some time making it actually easy to
use. So, I give you the
On Mon, Apr 19, 2010 at 2:42 PM, Aaron Plattner aplatt...@nvidia.com wrote:
On Thu, Feb 18, 2010 at 06:07:14AM -0800, Dan Nicholson wrote:
A while back Peter asked me about helping him add autotools support
after he pulled xtest out of cvs into git. We got that handled pretty
quickly, but I
On Tue, 20 Apr 2010 00:00:39 +0300, Tiago Vignatti vigna...@freedesktop.org
wrote:
But if we go for it, we're going have an implementation that exceeds
the protocol. Is that valid?
Sure, there's nothing saying that we have to be able to not provide
certain extensions in the sample
On Mon, 19 Apr 2010 14:27:11 -0700, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
Not really part of the unifdef patch, but a second patch to do s/of/off/ in
that
message would be good.
Yeah, as you can imagine, any patch that changes as much as the RENDER
stuff should be entirely
Keith Packard wrote:
On Tue, 20 Apr 2010 00:00:39 +0300, Tiago Vignatti vigna...@freedesktop.org
wrote:
But if we go for it, we're going have an implementation that exceeds
the protocol. Is that valid?
Sure, there's nothing saying that we have to be able to not provide
certain
While I'm not interested in writing a manual, I am trying to round up
and organize existing docs and info. and I am really interested in any
diagrams and such that people might have/know of for Xserver internals
or how different pieces interact.
If anyone has any docs/diagrams/handscanned
Tiago Vignatti wrote:
just moved the srv assignment to before it's being used.
---
xkb/xkbout.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xkb/xkbout.c b/xkb/xkbout.c
index 68ede90..9daac9a 100644
--- a/xkb/xkbout.c
+++ b/xkb/xkbout.c
@@ -354,7 +354,6 @@
On Mon, Apr 19, 2010 at 08:58:02PM +0300, Tiago Vignatti wrote:
Seems to be harmless. Meh.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/parser/scan.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/parser/scan.c
On Mon, Apr 19, 2010 at 08:58:03PM +0300, Tiago Vignatti wrote:
Both dev and dev-button are already used before their checking were being
performed. So check on the beginning.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
Xi/xiquerydevice.c |5 -
1 files changed, 4
On Mon, Apr 19, 2010 at 08:58:04PM +0300, Tiago Vignatti wrote:
mouse is already used before its checking should be performed. So check on the
beginning instead.
---
dix/events.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/dix/events.c b/dix/events.c
On Mon, Apr 19, 2010 at 08:58:07PM +0300, Tiago Vignatti wrote:
---
xkb/xkbEvents.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c
index 33741e9..9755f98 100644
--- a/xkb/xkbEvents.c
+++ b/xkb/xkbEvents.c
@@ -1041,8 +1041,7 @@
On Mon, Apr 19, 2010 at 08:58:08PM +0300, Tiago Vignatti wrote:
CLEARRTS_SUPPORT cannot be triggered at all.
Both commit logs and google don't show any clear reference about it, so I'd
vote to just delete.
man mousedrv
I'd leave the else branch there.
Signed-off-by: Tiago Vignatti
On Mon, Apr 19, 2010 at 11:00:08PM +0200, Julien Cristau wrote:
On Mon, Apr 19, 2010 at 14:52:55 -0400, Gaetan Nadon wrote:
Generates the git module version according to the git describe HEAD
If the git module has pending changes, it appends -dirty to the version
tag
Signed-off-by:
On Mon, 2010-04-19 at 12:14 -0700, Dan Nicholson wrote:
On Mon, Apr 19, 2010 at 11:52 AM, Gaetan Nadon mems...@videotron.ca wrote:
Generates the git module version according to the git describe HEAD
If the git module has pending changes, it appends -dirty to the version
tag
On Mon, Apr 19, 2010 at 09:28:24AM -0400, Gaetan Nadon wrote:
On Mon, 2010-04-19 at 09:58 +1000, Peter Hutterer wrote:
On Sat, Apr 17, 2010 at 07:28:00PM -0400, Gaetan Nadon wrote:
Patch #1 concept has been reviewed but code is different
Patch #7 is a change that has not been reviewed
Generates the git module version according to the git describe HEAD
The module version number may be appended with-uncommitted-changes
If not building under git, #undef XORG_GIT_VERSION is written
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
xorg-macros.m4.in | 20
On Tue, 2010-04-20 at 10:54 +1000, Peter Hutterer wrote:
On Mon, Apr 19, 2010 at 11:00:08PM +0200, Julien Cristau wrote:
On Mon, Apr 19, 2010 at 14:52:55 -0400, Gaetan Nadon wrote:
Generates the git module version according to the git describe HEAD
If the git module has pending
Hi Peter,
Most of these fixes are quite minor and related to memory leaks from
xf86...StrOption. They fix all Coverity errors in evdev apart from one dead-code
error in EvdevUtilButtonEventToButtonNumber which I have intentionally left
unmodified (in case that code changes in the future.)
Event
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/evdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index c3b44bb..aae9b23 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1235,6 +1235,7 @@ EvdevAddAbsClass(DeviceIntPtr device)
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/draglock.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/draglock.c b/src/draglock.c
index 6157cae..a7ad974 100644
--- a/src/draglock.c
+++ b/src/draglock.c
@@ -145,6 +145,8 @@
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/evdev.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 9fe952e..6992c68 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1371,15 +1371,16 @@
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/evdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index d133870..c3b44bb 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -2071,6 +2071,7 @@ EvdevPreInit(InputDriverPtr drv,
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/evdev.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index aae9b23..9fe952e 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1631,8 +1631,7 @@ static int
Called function ioctl whose return value should be checked (checked 10
out of 11 times)
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/evdev.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index 6992c68..ccea90d 100644
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com
---
src/emuWheel.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/emuWheel.c b/src/emuWheel.c
index 3f0dfd4..afafff7 100644
--- a/src/emuWheel.c
+++ b/src/emuWheel.c
@@ -232,8 +232,8 @@
On Mon, Apr 19, 2010 at 10:58 AM, Tiago Vignatti
tiago.vigna...@nokia.com wrote:
Seems to be harmless. Meh.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/parser/scan.c | 7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git
On Tue, Apr 20, 2010 at 07:11:15AM +0300, Oliver McFadden wrote:
Hi Peter,
Most of these fixes are quite minor and related to memory leaks from
xf86...StrOption. They fix all Coverity errors in evdev apart from one
dead-code
error in EvdevUtilButtonEventToButtonNumber which I have
67 matches
Mail list logo
