Re: [PULL] XWarpPointer revert and XQuartz changes

2012-02-22 Thread Keith Packard
#part sign=pgpmime On Wed, 22 Feb 2012 22:08:59 -0800, Jeremy Huddleston jerem...@apple.com wrote: It's just API used by the DIX/DDX boundary, right, not something that should be exported to drivers. If it is something exported to the drivers, just merge up to the commit before it (which was

Re: [PATCH xserver 1/2] man: s/__xconfigfile__/xorg.conf/g - no longer required

2012-02-27 Thread Keith Packard
#part sign=pgpmime On Sun, 26 Feb 2012 12:15:30 -0500, Gaetan Nadon mems...@videotron.ca wrote: This will fix inconsistencies and prevent the creation of new unneeded sed patterns. Are things broken in some way? Or is this just a cleanup patch? If this is just cleanup, I'll pend it until after

Re: [PATCH xserver 1/2] man: s/__xconfigfile__/xorg.conf/g - no longer required

2012-02-27 Thread Keith Packard
#part sign=pgpmime On Mon, 27 Feb 2012 12:32:10 -0500, Gaetan Nadon mems...@videotron.ca wrote: Yes, just a clean-up patch. No change in the final man page output. No dependencies. Let's leave this until after 1.12 then. -- keith.pack...@intel.com

Re: [PULL] fix for 38313 - 1.12 blocker

2012-02-27 Thread Keith Packard
#part sign=pgpmime On Tue, 28 Feb 2012 12:51:14 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Peter Hutterer (1): dix: avoid NULL-pointer dereference on button-only devices (#38313) Merged. 38000e7..2416ee4 master - master -- keith.pack...@intel.com

[PATCH] Cannot wait for user lock in sync_while_locked

2012-03-03 Thread Keith Packard
sync_while_locked grabs the user lock before performing the sync operation. Telling InternalLockDisplay to wait for the user lock will thus deadlock, so don't do that. Signed-off-by: Keith Packard kei...@keithp.com --- I don't know how this could ever have failed to deadlock -- sync_while_locked

Re: [PATCH] Cannot wait for user lock in sync_while_locked

2012-03-04 Thread Keith Packard
#part sign=pgpmime On Sat, 03 Mar 2012 23:44:27 -0800, Keith Packard kei...@keithp.com wrote: I've managed to create a short test case for this problem. It uses two threads, one allocating IDs and the other calling XPending. Both threads run as fast as possible, each checking to make sure

Re: [PATCH xserver] test: add new test cases to .gitignore

2012-03-04 Thread Keith Packard
#part sign=pgpmime On Sun, 26 Feb 2012 17:51:50 -0500, Gaetan Nadon mems...@videotron.ca wrote: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca Merged. 2416ee4..e08ed0b master - master -- keith.pack...@intel.com

Re: hotplug plans - issue 1 (ideas welcome)

2012-03-06 Thread Keith Packard
#part sign=pgpmime On Tue, 6 Mar 2012 12:27:36 +, Dave Airlie airl...@gmail.com wrote: This is of course only one of the issues I face, but I would need to get some ideas on merging and keeping the tree in some ways stable. I'd prefer a); either of the other choices means having piles of

Re: hotplug plans - issue 1 (ideas welcome)

2012-03-09 Thread Keith Packard
#part sign=pgpmime On Fri, 9 Mar 2012 07:46:35 +, Dave Airlie airl...@gmail.com wrote: I just can't see a nice way to do this incrementally and meet the requirement of the X release process. If we'd merged the drivers it would be much easier to just evolve things, but since some people

Re: server-1.12-branch

2012-03-09 Thread Keith Packard
#part sign=pgpmime On Fri, 09 Mar 2012 10:47:23 -0800, Jeremy Huddleston jerem...@apple.com wrote: It's been about a week since xorg-server-1.12.0 was shoved out our doors, and you may have noticed that I created a branch for the stable 1.12 releases. I've also updated the X.org Google

Re: server-1.12-branch

2012-03-09 Thread Keith Packard
#part sign=pgpmime On Fri, 09 Mar 2012 12:56:52 -0800, Alan Coopersmith alan.coopersm...@oracle.com wrote: Are you going to pull in Daniel's code style change now? Of all the -next candidates from the last few months, that was the biggest I remember. Yes, that needs to happen now or not at

Re: [PATCH] Cannot wait for user lock in sync_while_locked

2012-03-09 Thread Keith Packard
#part sign=pgpmime On Sun, 04 Mar 2012 02:04:27 -0800, Keith Packard kei...@keithp.com wrote: diff --git a/src/locking.c b/src/locking.c index 4f9a40f..b3dfb3b 100644 --- a/src/locking.c +++ b/src/locking.c @@ -486,6 +486,8 @@ static void _XInternalLockDisplay( static void

Re: [PATCH] Cannot wait for user lock in sync_while_locked

2012-03-10 Thread Keith Packard
#part sign=pgpmime On Sat, 10 Mar 2012 14:31:52 -0800, Jamey Sharp ja...@minilop.net wrote: Reviewed-by: Jamey Sharp ja...@minilop.net Thanks! Although, in Restore Xlib semantics, it would be nice if you'd fix up the It appears that classic Xlib respected user locks comment. I think it

Re: server-1.12-branch

2012-03-13 Thread Keith Packard
#part sign=pgpmime On Wed, 14 Mar 2012 01:45:47 +, Daniel Stone dan...@fooishbar.org wrote: I can definitely see the argument here. Keith, do you want me to send you an automated whole-tree changeset, followed by a series of cleanups? To be honest, I've only got Xext totally cleaned up

Re: server-1.12-branch

2012-03-13 Thread Keith Packard
#part sign=pgpmime On Tue, 13 Mar 2012 22:56:55 +, Daniel Stone dan...@fooishbar.org wrote: Ooh right, I'll do that too. Have you got the exact commands you used? I can't find anything remaining from that, but I used objdump -d :-) -- keith.pack...@intel.com

Re: [PATCH] Cannot wait for user lock in sync_while_locked

2012-03-14 Thread Keith Packard
#part sign=pgpmime On Sat, 10 Mar 2012 21:05:21 -0800, Jamey Sharp ja...@minilop.net wrote: Looks great; just insert let the thread [that] got in first and push. :-) With a bit of additional testing (I rebooted my laptop...), I discovered that this second patch breaks gdm3 very badly, so I

Re: [PATCH] dix: put warning in for scroll increments of 0

2012-03-15 Thread Keith Packard
be able to reproduce later. (an ugly hack, but better than spinning forever) Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: server-1.12-branch

2012-03-15 Thread Keith Packard
#part sign=pgpmime On Thu, 15 Mar 2012 15:20:58 +, Daniel Stone dan...@fooishbar.org wrote: OK, it's on people.fd.o/~daniels/xserver:coding-style now (d2949a1), plus one small fixup for a really obnoxiously-formatted block in, surprise surprise, Xinerama. Although it was pretty

X server source code re-indented

2012-03-21 Thread Keith Packard
I've taken Daniel's indent recipe, fixed it up a bit and applied it to the master branch in the X server. To help get other branches cleaned up in a compatible fashion, I've stuck the scripts I used in the util/modular repository. They're called x-indent-all.sh and x-indent.sh. Patches going

Re: [PATCH synaptics] conf: the bcm5974 doesn't have Apple in the product name

2012-03-23 Thread Keith Packard
#part sign=pgpmime On Fri, 23 Mar 2012 15:49:39 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: But it's still a single-button device from the known fruit manufacturer. This definitely helps with my machine -- it gets rid of a frequently annoying habit where the driver generated button

Re: [RFC] server-private and public header separation

2012-03-23 Thread Keith Packard
#part sign=pgpmime On Fri, 23 Mar 2012 14:25:44 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Is that something we want? Should we should be splitting the files apart instead? -- keith.pack...@intel.com ___ xorg-devel@lists.x.org: X.Org

Re: [RFC] server-private and public header separation

2012-03-23 Thread Keith Packard
#part sign=pgpmime On Fri, 23 Mar 2012 18:30:30 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Good point, but that would only get us half-way. We currently export things like the GrabRec as well, just because they are in the same header. These could be moved into a private header.

Re: indent quirks

2012-03-23 Thread Keith Packard
#part sign=pgpmime On Fri, 23 Mar 2012 15:45:42 +, Daniel Stone dan...@fooishbar.org wrote: Hi, On 23 March 2012 15:13, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 02:44:41 23.03.2012 UTC-07 when jerem...@apple.com did gyre and gimble:  JH Is there a way we can

Re: [PATCH] xrandr: move transform limit checking after scaling

2012-03-23 Thread Keith Packard
|| vector[j] -32767) +return False; +} Yeah, that looks right - transform from homogeneous back to pixel coordinates before doing the range check. Reviewed-by: Keith Packard kei...@keithp.com (sorry I didn't see this on Tuesday, thanks for the ping!) -- keith.pack...@intel.com

Re: [PULL to discuss] Remove kdrive, Xnest, and Xvfb

2012-03-26 Thread Keith Packard
#part sign=pgpmime On Mon, 26 Mar 2012 16:13:46 -0700, Jeremy Huddleston jerem...@apple.com wrote: Most functionality of these servers can be provide by Xorg with either the nested or dummy video driver. I'm all for deleting the code. I would like to have some idea of what you mean by 'most'

Re: [PATCH xserver 2/2] man: s/__xservername__/Xorg/g - no longer required

2012-03-26 Thread Keith Packard
#part sign=pgpmime On Sun, 26 Feb 2012 12:15:31 -0500, Gaetan Nadon mems...@videotron.ca wrote: Excerpt from http://lists.x.org/archives/xorg-devel/2011-March/020481.html: The Xorg xorg.conf substitutions are leftover from the transitional period where some distros were building our

Re: [PULL updated] XQuartz pending formatting cleanup

2012-03-26 Thread Keith Packard
#part sign=pgpmime On Sat, 24 Mar 2012 01:17:06 -0700, Jeremy Huddleston jerem...@apple.com wrote: Jeremy Huddleston (8): test: Fix 'make dist' for configurations that build the Xorg DDX XQuartz: Move our logs into an X11 subdirectory XQuartz: Xi: darwinPointer is now

Re: [PULL] input ABI bump, unit test fixes

2012-03-28 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 08:16:10 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Peter Hutterer (3): Bump input ABI to 17 for per-device idlecounters test: init the sync extensions for tests to pass again test: reset the client before checking the

Re: [PATCH 7/8] xf86Config: load DIX libraries before drivers on Cygwin

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 03:22:40 -0500, Yaakov (Cygwin/X) yselkow...@users.sourceforge.net wrote: From: Yaakov Selkowitz yselkow...@users.sourceforge.net Cygwin doesn't have ELF rpath capabilities, so these libraries need to be loaded before the drivers (namely dummy and

Re: [RFC PATCH] damageproto: Explicitly document Damage lifetimes

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 12:02:28 -0400, Adam Jackson a...@redhat.com wrote: One possibility would be to have a 1.2 version of the protocol that simply doesn't generate BadDamage in any event; or, that tracks client timestamps and suppresses BadDamage if the drawable has been

Re: [RFC PATCH] damageproto: Explicitly document Damage lifetimes

2012-03-29 Thread Keith Packard
#part sign=pgpmime On Thu, 29 Mar 2012 16:39:13 -0400, Adam Jackson a...@redhat.com wrote: Changing the lifetime would mean needing to change the extension major number, since otherwise currently legal 1.x clients would leak themselves to death, and that's not nice. My thought was that we'd

Re: [PULL updated] Fix a few regressions and a crash on exit

2012-04-05 Thread Keith Packard
#part sign=pgpmime On Thu, 05 Apr 2012 14:06:38 -0700, Jeremy Huddleston jerem...@apple.com wrote: Jeremy Huddleston (3): os: Fix regression with FatalError not calling va_start XQuartz: Tiger build fix XQuartz: Automatically start our virtual tablet devices Michal

Re: Xorg segfaults on i915gm during intel_drv.so init

2012-04-08 Thread Keith Packard
#part sign=pgpmime On Sat, 07 Apr 2012 23:05:47 -0700, Jeremy Huddleston jerem...@apple.com wrote: Ok, well let's just revert 55f552adb651715d2620db7248cd5b9b8187654a, and we can look into this in more detail in the bug report (https://bugs.freedesktop.org/show_bug.cgi?id=41653). Keith,

Re: [PULL] misc input fixes

2012-04-15 Thread Keith Packard
#part sign=pgpmime On Mon, 16 Apr 2012 11:31:32 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Chase Douglas (4): Don't update listener after deactivating implicit pointer grab Update event type when delivering end event to a pointer listener Ensure sequential

Re: xserver: Branch 'master' - 9 commits

2012-04-19 Thread Keith Packard
On Thu, 19 Apr 2012 22:29:48 -0700, Jeremy Huddleston jerem...@apple.com wrote: I'm terribly sorry for pushing. I'll go hide in a corner now. No worries. I've pushed a replacement for master and it's all been fixed now. Thanks for letting us know; I was simultaneously having git adventures

Re: xserver: Branch 'master' - 9 commits

2012-04-20 Thread Keith Packard
On Thu, 19 Apr 2012 22:29:48 -0700, Jeremy Huddleston jerem...@apple.com wrote: I just noticed that the machine I was on was tracking the wrong master, and this was pushed to origin instead of ~jeremyhu/master. btw, if anyone else does this, it's easy to fix if you've got the 'correct' master

Re: [PULL] XQuartz and a couple other corner cases

2012-04-28 Thread Keith Packard
On Mon, 23 Apr 2012 20:23:41 -0700, Jeremy Huddleston jerem...@apple.com wrote: Jeremy Huddleston (9): xres: Fix build without composite os: Annotate OsVendorFatalError as _X_ATTRIBUTE_PRINTF test: Fix make dist XQuartz: Fix a deadlock in pre-dispatch code

Re: [PULL UPDATED] input fixes

2012-04-30 Thread Keith Packard
On Tue, 1 May 2012 11:43:33 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Chase Douglas (2): os: Add -displayfd option TouchListenerAcceptReject: Warn and return early on bad listener index Michal Suchanek (2): xserver: Fix out-of-tree build dmx: Annotate

Re: [PULL UPDATED] input fixes

2012-05-01 Thread Keith Packard
On Tue, 1 May 2012 14:45:47 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: if it's still the suspend bug, that should be fixed with this merge plus the last two synaptics patches on the list. Yeah, I saw that in the pull request. Also seems to have fixed the problem where I couldn't

Re: [PULL] Configure fixes for Windows MinGW target

2012-05-01 Thread Keith Packard
On Tue, 01 May 2012 20:23:38 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Ryan Pavlik (3): configure.ac: auto-disable MITSHM if we lack IPC This patch is broken, HAVE_SYSV_IPC is a config.h entry, not a configure.ac variable. This seems to fix it for me: diff --git

Re: [PULL] Configure fixes for Windows MinGW target

2012-05-02 Thread Keith Packard
On Wed, 02 May 2012 13:37:06 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Thanks very much for spotting that. No problem; just keeping my machine running. Jon TURNEY (1): configure.ac: Make default configuration for MinGW disable unsupported extensions and DDXs Ryan Pavlik

Re: [PULL] XIQueryPointer fixes

2012-05-02 Thread Keith Packard
On Thu, 3 May 2012 11:21:32 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Chase Douglas (2): Report logical button state in ProcXIQueryPointer Report touch emulated buttons in XIQueryPointer for XI 2.1 and earlier 1908272..9704136 master - master --

Re: [PULL] CryptoAPI, build fixes

2012-05-07 Thread Keith Packard
On Fri, 04 May 2012 13:17:06 -0500, Yaakov (Cygwin/X) yselkow...@users.sourceforge.net wrote: Yaakov Selkowitz (4): os: Add CryptoAPI as a choice of SHA1 implementation xfree86: respect EXEEXT in relink target xfree86: use silent rules with sdksyms generation

Re: [PATCH 0/1] Fix RANDR’s gamma_to_ramp()

2012-05-09 Thread Keith Packard
On Tue, 08 May 2012 18:21:36 -0400, James Cloos cl...@jhcloos.com wrote: James Cloos (1): Fix RANDR’s gamma_to_ramp(). e501c34..afc153a master - master -- keith.pack...@intel.com pgp2erbL1DwpC.pgp Description: PGP signature ___

Re: [PULL] logging cleanups

2012-05-09 Thread Keith Packard
On Thu, 10 May 2012 12:51:15 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Daniel Kurtz (4): os/log: trivial cleanups os/xprintf: add Xvscnprintf and Xscnprintf os/log: only write timestamp if a message is actually written to logfile os/log: refactor logging

Re: [PATCH] include: add BUG_RETURN_* macros

2012-05-09 Thread Keith Packard
On Thu, 10 May 2012 14:25:25 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: +#define BUG_RETURN(cond) \ +do { __BUG_WARN_MSG(cond, 0, NULL); return; } while(0) I'm not a huge fan of macros hiding control flow... -- keith.pack...@intel.com pgpKUGgs25PmH.pgp Description: PGP

Re: pull request for airlied/redunant-cleanups-1

2012-05-14 Thread Keith Packard
On Mon, 14 May 2012 13:39:00 +0100, Dave Airlie airl...@gmail.com wrote: Michal Suchanek (14): xfixes: remove redundant declaration. xkb: Remove redundant declarations. randr: Remove redundant declaration. exa: Remove redundant declaration. mi: Remove redundant

Re: lack of reviewers (Re: first set of new APIs + convert server to use them)

2012-05-14 Thread Keith Packard
On Mon, 14 May 2012 19:22:48 +0100, Dave Airlie airl...@gmail.com wrote: I've pretty much no idea how to deal with it sanely. We've moved to larger scale development model without a larger set of developers. The kernel isn't even as stringent wrt to reviews as xorg-devel is. Small changes

Re: [PATCH 1/2] rotate: Unregister damage across modesetting

2012-05-15 Thread Keith Packard
On Tue, 15 May 2012 11:41:23 +0200, Michal Suchanek hramr...@gmail.com wrote: How are you going to change screen resolution without changing the pixmap? The pixmap structure gets rewritten with new contents. -- keith.pack...@intel.com pgpVuLmwldtKY.pgp Description: PGP signature

Re: [PATCH 1/4] xf86/modes: drop two uses of screenInfo

2012-05-15 Thread Keith Packard
On Mon, 14 May 2012 13:00:20 +0100, Dave Airlie airl...@gmail.com wrote: -/* if this is called during ScreenInit() we don't have pScrn-pScreen yet */ -ScreenPtr pScreen = screenInfo.screens[pScrn-scrnIndex]; +ScreenPtr pScreen = xf86ScrnToScreen(pScrn); I assume your fine new

Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-15 Thread Keith Packard
On Mon, 14 May 2012 13:00:23 +0100, Dave Airlie airl...@gmail.com wrote: - -/* This can get called before the ScrnInfoRec is installed so we - can't rely on getting it with XF86SCRNINFO() */ int scrnIndex = pmap-pScreen-myNum; ScrnInfoPtr scrninfp =

Re: [PATCH 1/4] xf86/modes: drop two uses of screenInfo

2012-05-15 Thread Keith Packard
On Tue, 15 May 2012 17:56:33 +0100, Dave Airlie airl...@gmail.com wrote: On Tue, May 15, 2012 at 4:16 PM, Keith Packard kei...@keithp.com wrote: On Mon, 14 May 2012 13:00:20 +0100, Dave Airlie airl...@gmail.com wrote: -    /* if this is called during ScreenInit() we don't have pScrn-pScreen

Re: randr provider object

2012-05-17 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On 5/15/12 3:04 PM, Dave Airlie wrote: My concern is how you're going to build this programmatically if you keep with a poke-one-thing model, I just envision intermediate states that don't make a ton of sense on their own but that we'd end up needing to

Re: [PATCH 1/4] xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr

2012-05-17 Thread Keith Packard
. I'd suggest that you might add an assert that pScrn-scrnIndex screenInfo.numScreens -- screenInfo.numScreens is very carefully managed during init and reset to make this a valuable test, I think. It would definitely catch code trying to get an X screen before it was allocated. Reviewed-by: Keith

Re: [PATCH 2/4] xf86: migrate to using xf86ScreenToScrn wrapper

2012-05-17 Thread Keith Packard
-pScreen-myNum]-vtSema || pScreenPriv-isDGAmode)) + xf86ScreenToScrn(pmap-pScreen)-vtSema || pScreenPriv-isDGAmode)) (I note that a bunch of these are just checking for vtSema; might be nice to have a helper function for that?) Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack

Re: [PATCH 3/4] render: add GetGlyphPicture accessor.

2012-05-17 Thread Keith Packard
an obvious place to stick a lazy computation of the per-screen glyphs. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpc0OA1MdYOU.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 4/4] render/exa: use glyph picture accessors

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com use the glyph picture accessors in the X server, render and EXA code. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpI9TGlydR02.pgp Description: PGP signature

Re: convert some more users to the screen conversion functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: These are just some more simple patches to move to using the Screen-Scrn and Scrn-Screen conversion functions in various parts of the server. I'm wondering if you've tested these to see if the server builds without publishing the two global arrays any

Re: [PATCH 1/4] xf86/modes: drop two uses of screenInfo

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Just use new macros to access scrn-screen. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpJObmdpv6FZ.pgp Description: PGP signature

Re: [PATCH 2/4] xaa: convert pScrn-pScreen to use accessor.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: This uses a standard conversion function to do the conversion. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgplwrY6u9tKJ.pgp Description: PGP signature ___ xorg-devel@lists.x.org

Re: [PATCH 3/4] xf86/modes: drop more pScrn-pScreen usages

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Just simple conversion to use the lookup function. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpw4Jz2mq8p8.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: This patch drops all in-server uses, we should drop the macro later, once drivers have been converted to not use it. There aren't many drivers using it at least... Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei

Re: [PULL] Implement GLX_ARB_create_context

2012-05-17 Thread Keith Packard
Ian Romanick i...@freedesktop.org writes: glx: Extend __GLXscreen::createContext to take attributes This doesn't even compile - a missing comma: __glXDRIscreenCreateContext(__GLXscreen * baseScreen, __GLXconfig * glxConfig,

Re: [PULL] build fix, bug fix, warning fixes

2012-05-17 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Peter Hutterer (9): test: fix redundant declaration of devices warning test: fix userdata shadows global declaration warnings test: fix redundant declaration of BadDevice test: don't shadow parameter 'len'

Re: [PULL] XQuartz

2012-05-17 Thread Keith Packard
Jeremy Huddleston jerem...@apple.com writes: Jeremy Huddleston (5): XQuartz: Workaround an SDK bug on Leopard/x86_64 XQuartz: Tiger build fix XQuartz: Provide fls implementation for Tiger XQuartz: Declare noPseudoramiXExtension for miinitext.c XQuartz: Avoid a

Re: [pull] fixes and first set of new API changes

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr I sent some comments about this one today; please take a look and let me know what you think. I'll wait for your reply before merging any of these patches. --

Re: [PATCH 1/4] xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr

2012-05-17 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: Are you talking about xf86DeleteScreen? It does that if PreInit fails, before it has called AddScreen. Yeah, good point. ... not that having your screen renumbered between PreInit and ScreenInit is something people test a lot... Given that

Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: On Fri, May 18, 2012 at 12:09 AM, Keith Packard kei...@keithp.com wrote: Well these + all the ABI changes + some other misc bits, I could remove xf86Screens from being exported, screenInfo is required for protocol extensions, but we can probably work

Re: convert some more users to the screen conversion functions.

2012-05-18 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Not really, xf86Screens yes, but screenInfo.screens will still represent protocol screens going forward, yeah, there are over 500 references to screenInfo.screens in the server source code. and people adding extensions in their drivers will still need

Re: randr provider object

2012-05-18 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: I think the only way to do it and keep it extensible, it to make everything a property of an object. Not sure it has to be 'properties', but surely something where you can set a bunch of 'pending' values, and then push the 'go' button and have the whole

Re: [git pull] new apis and fixes

2012-05-22 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Dave Airlie (11): xfree86: add modesetting driver to fallback list on Linux config/udev: add pre_init stage to config and udev. xf86/pci: fix slot claiming counting. xf86: add helper functions to convert to from

Re: [PULL: xserver master] SPARC build fix, documentation fixes

2012-05-22 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Alan Coopersmith (4): Convert sbusPaletteKey to latest DevPrivate API cvt man page should use Hz, not kHz, for vertical refresh rate Undocument mandatory loadable modules Undocument Font Module loading Merged.

Re: Keith? Re: [PATCH] Actually send the reply in SProcDRI2Connect()

2012-05-22 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Keith - are you behind on individual patches vs. pulls or is there something else wrong with this one? Sorry; something went awry with my fancy automatic patch queue and I didn't catch it. I'm tracking patches closely at this point,

Re: [PATCH] dri2: SProcDRI2Connect - send the response.

2012-05-22 Thread Keith Packard
Michal Srb m...@suse.com writes: The swapped implementation of DRI2Connect is always responding with empty device and driver values. However the response was only prepared and never sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting for response when started

Re: [PATCH 2/6] xf86: fix xf86IsScreenPrimary interface to take a pScrn (API/ABI)

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: -xf86IsScreenPrimary(int scrnIndex); +xf86IsScreenPrimary(ScrnInfoPtr pScrn); Reviewed-by: Keith Packard kei...@keithp.com (Are there still drivers using this API?) -- keith.pack...@intel.com pgpzc7215aFkv.pgp Description: PGP signature

Re: [PATCH 1/6] xserver: convert block/wakeup handlers to passing ScreenPtr (ABI/API) (v2)

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Instead of passing an index, pass the actual ScreenPtr. This allows more moving towards not abusing xf86Screens + screenInfo. v2: drop the blockData/wakeupData args as per ajax's suggestion. Reviewed-by: Keith Packard kei...@keithp.com (I wonder if we

Re: [PATCH 3/6] xf86: make xf86DeleteScreen take a ScrnInfoPtr

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com stop passing indices into this function. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgp9A4oqSvDvg.pgp Description: PGP signature

Re: [PATCH 4/6] xf86/xv: remove scrnIndexfrom xf86FindXvOptions.

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Move this interface to taking an ScrnInfoPtr. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgphoe920Ym5Q.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 5/6] dix: make Create/Free scratch pixmaps take a ScreenPtr

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com While technically an API/ABI change I doubt anyone uses it, but it helps in splitting screens up. Reviewed-by: Keith Packard kei...@keithp.com Bool -CreateScratchPixmapsForScreen(int scrnum

Re: [PATCH 6/6] xf86: add a define to denote the new non-index interfaces are being used

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This can be used by drivers to provide compatible APIs. (bikeshed -- the name isn't very descriptive, but meh) Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpHSFq8Ai7XX.pgp Description

Re: [PATCH] dix/gc: consolidate GC object creation in one place

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: The standard GC create and scratch GC create were 90% the same really, and I have a need in the future for creating GC objects without the other bits, so wanted to avoid a third copy. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack

Re: [PULL] Fix signal-unsafe logging

2012-05-25 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Keith: I'll pull this into my tree, this needs an input API bump and I need to check if the input drivers can be updated easily for this first. When I tried yesterday, I got logspam to no end. Ok, thanks. -- keith.pack...@intel.com

Re: [PULL] Xvfb leaks, DGA mouse wheel support

2012-05-25 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Julien Cristau (2): Xi: make stub DeleteInputDeviceRequest call RemoveDevice Xvfb: destroy the screen pixmap in CloseScreen Marcin Slusarz (1): xfree86: fix mouse wheel support for DGA clients Peter Hutterer (1):

Re: don't pull yet, but read: pull request for abi/api changes

2012-05-29 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: But first I want to make sure you aren't going to pull a late review on things first, and I spend time doing pointless changes to drivers. Will do. I'm sick today though, so I won't be able to think clearly enough until tomorrow. -keith --

Re: [PULL: xserver] dri2: Add DRI2GetParam request

2012-05-29 Thread Keith Packard
Chad Versace chad.vers...@linux.intel.com writes: dri2: Add DRI2GetParam request (2012-05-21 14:38:05 -0700) I don't see any default setting for ds-GetParam; it looks like older drivers will just crash? -- keith.pack...@intel.com pgpP2eK71UJ0s.pgp Description: PGP signature

Re: [PULL: xserver] dri2: Add DRI2GetParam request

2012-05-29 Thread Keith Packard
Chad Versace chad.vers...@linux.intel.com writes: What is the correct next action? Do I need to resubmit patches or pull request? I'd rather just see the patch on the list and add my reviewed-by if it looks good. -- keith.pack...@intel.com pgpe0q3LJhEQ2.pgp Description: PGP signature

Re: [PATCH] dix/render: consolidate window format matching code.

2012-05-30 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com There was 3 copies of this code, make one. The code looks fine. This commit message must be some kind of Irish comedy though? Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com

Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-30 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: +extern _X_EXPORT void +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very descriptive to me -- what is 'Intern' supposed to mean? /** + * Fills in a copy of mode, removing all stale pointer

Re: [PATCH] [rfc] push don't render sw cursor/sigio avoidance hack down

2012-05-30 Thread Keith Packard
-static void +static Bool xf86CursorMoveCursor(DeviceIntPtr pDev, ScreenPtr pScreen, int x, int y) { xf86CursorScreenPtr ScreenPriv = (xf86CursorScreenPtr) dixLookupPrivate(pScreen-devPrivates, xf86CursorScreenKey); - +

Re: don't pull yet, but read: pull request for abi/api changes

2012-05-30 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: (the fact that this change ends with a net loss of code is a definite bonus...) xf86: change EnterVT/LeaveVT to take a ScrnInfoPtr (ABI/API break) xf86: modify FreeScreen callback to take pScrn instead of index. (ABI/API) xf86: move

Re: [PATCH] dri2: Add DRI2GetParam request (v2)

2012-05-30 Thread Keith Packard
Chad Versace chad.vers...@linux.intel.com writes: v2: If driver doesn't define ds-GetParam, dont' crash. Fall back to default behavior, per keithp. Looks good to me. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgp5I7EwSfwfx.pgp Description: PGP signature

Re: Use pixman glyph API

2012-05-30 Thread Keith Packard
Søren Sandmann sandm...@cs.au.dk writes: I verified that the cairo test suite has the number of failures as without the patch. Any performance comparisons? -- keith.pack...@intel.com pgpsuCDB3FGn7.pgp Description: PGP signature ___

Re: Use pixman glyph API

2012-05-30 Thread Keith Packard
Søren Sandmann sandm...@cs.au.dk writes: Yeah, in the commit message for the patch itself. I wrote too soon; the commit hadn't landed in my inbox yet. Nice speedups! Are you duplicating the glyph image data in pixman? Or just saving the pointer? -- keith.pack...@intel.com pgptsJnbSVohD.pgp

Re: don't pull yet, but read: pull request for abi/api changes

2012-05-31 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Cool I'll fixup the stuff here and send another do-not-pull yet request. Thanks! -- keith.pack...@intel.com pgpRJlMt80TCy.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-31 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: On Wed, 30 May 2012 14:25:40 -0700, Keith Packard kei...@keithp.com wrote: Chris Wilson ch...@chris-wilson.co.uk writes: +extern _X_EXPORT void +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very

Re: [PULL: xserver master] dri2: Add DRI2GetParam request (v2)

2012-05-31 Thread Keith Packard
Chad Versace chad.vers...@linux.intel.com writes: Chad Versace (1): dri2: Add DRI2GetParam request (v2) I've cherry-picked this patch to master: 594b4a4..78f0d9c master - master -- keith.pack...@intel.com pgpeHRQ0dmbEb.pgp Description: PGP signature

Re: do-not-pull-yet request: api/abi changes

2012-06-01 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Hi Keith, Okay another api/abi set of changes for you to ack, so I can start Looks good; I think these are ready to merge. Let me know when you want them pulled in. -- keith.pack...@intel.com pgpXBDg1ipmp9.pgp Description: PGP signature

Re: [PULL] XKB realloc fix, multimedia key press crasher fix

2012-06-03 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Michal Suchanek (1): Fix crash for motion events from devices without valuators Siddhesh Poyarekar (1): xkb: Allocate size_syms correctly when width of a type increases Merged. 78f0d9c..3476eb3 master - master --

1.13 schedule

2012-06-05 Thread Keith Packard
I realized yesterday that we hadn't ever discussed a release schedule for the 1.13 X server. The big blocker for this has been Dave Airlie's massive API/ABI rework to try and clear the decks for hot-plug GPUs and other new stuff. That's landing today, and so it seems like a good time to figure

Re: git pull api break - squashed

2012-06-05 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Dave Airlie (1): api: rework the X server driver API to avoid global arrays. Merged. 3476eb3..1f0e8bd master - master -- keith.pack...@intel.com pgp7Ohi7cN5da.pgp Description: PGP signature ___

<    4   5   6   7   8   9   10   11   12   13   >