[jira] [Comment Edited] (YARN-6435) [ATSv2] Can't retrieve more than 1000 versions of metrics in time series

2017-04-04 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954922#comment-15954922 ] Varun Saxena edited comment on YARN-6435 at 4/4/17 9:42 AM: bq. sorry did not

[jira] [Commented] (YARN-6435) [ATSv2] Can't retrieve more than 1000 versions of metrics in time series

2017-04-04 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954922#comment-15954922 ] Varun Saxena commented on YARN-6435: bq. sorry did not get this. I meant with current value of 1000 we

[jira] [Commented] (YARN-6435) [ATSv2] Can't retrieve more than 1000 versions of metrics in time series

2017-04-04 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954779#comment-15954779 ] Varun Saxena commented on YARN-6435: Thanks [~rohithsharma] for raising the issue. A similar limit

[jira] [Commented] (YARN-6428) Queue AM limit is not honored in CS always

2017-04-03 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953360#comment-15953360 ] Varun Saxena commented on YARN-6428: Thanks [~bibinchundatt] for the patch. The said issue due to

[jira] [Commented] (YARN-6420) RM startup failure due to wrong order in nodelabel editlog

2017-04-03 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953267#comment-15953267 ] Varun Saxena commented on YARN-6420: Thanks [~bibinchundatt] for the patch. You have added write locks

[jira] [Commented] (YARN-5548) Use MockRMMemoryStateStore to reduce test failures

2017-04-03 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953258#comment-15953258 ] Varun Saxena commented on YARN-5548: Thanks [~bibinchundatt] for the patch. Can you have a look at the

[jira] [Updated] (YARN-2962) ZKRMStateStore: Limit the number of znodes under a znode

2017-04-02 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-2962: --- Attachment: YARN-2962.010.patch > ZKRMStateStore: Limit the number of znodes under a znode >

[jira] [Updated] (YARN-6414) ATSv2 HBase related tests fail due to guava version upgrade

2017-04-01 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6414: --- Summary: ATSv2 HBase related tests fail due to guava version upgrade (was: ATSv2 tests fail due to

[jira] [Commented] (YARN-6414) ATSv2 tests fail due to guava version upgrade

2017-04-01 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952435#comment-15952435 ] Varun Saxena commented on YARN-6414: Whenever a JAR is upgraded, ideally all the tests should be run.

[jira] [Commented] (YARN-6424) TimelineCollector is not stopped when an app finishes in RM

2017-04-01 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952389#comment-15952389 ] Varun Saxena commented on YARN-6424: [~vrushalic], ApplicationFinishPublishEvent is what existing

[jira] [Updated] (YARN-6424) TimelineCollector is not stopped when an app finishes in RM

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6424: --- Attachment: YARN-6424.01.patch > TimelineCollector is not stopped when an app finishes in RM >

[jira] [Created] (YARN-6424) TimelineCollector is not stopped when an app finishes in RM

2017-03-31 Thread Varun Saxena (JIRA)
Varun Saxena created YARN-6424: -- Summary: TimelineCollector is not stopped when an app finishes in RM Key: YARN-6424 URL: https://issues.apache.org/jira/browse/YARN-6424 Project: Hadoop YARN

[jira] [Commented] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951434#comment-15951434 ] Varun Saxena commented on YARN-6377: By the way, if I am reading the code correctly, we do not stop

[jira] [Commented] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951430#comment-15951430 ] Varun Saxena commented on YARN-6377: Sorry for repeating. Had missed Haibo's comment. >

[jira] [Commented] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951377#comment-15951377 ] Varun Saxena commented on YARN-6377: [~vrushalic] bq. I am looking through the code and trying to

[jira] [Comment Edited] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951228#comment-15951228 ] Varun Saxena edited comment on YARN-6375 at 3/31/17 4:37 PM: - Thanks

[jira] [Commented] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951229#comment-15951229 ] Varun Saxena commented on YARN-6377: +1 Will commit it later today > NMTimelinePublisher#serviceStop

[jira] [Commented] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951228#comment-15951228 ] Varun Saxena commented on YARN-6375: Thanks [~vrushalic] for the comments. I was primarily going by the

[jira] [Comment Edited] (YARN-6420) RM startup failure due to wrong order of editlog

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950547#comment-15950547 ] Varun Saxena edited comment on YARN-6420 at 3/31/17 8:54 AM: - So this can only

[jira] [Commented] (YARN-6420) RM startup failure due to wrong order of editlog

2017-03-31 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950547#comment-15950547 ] Varun Saxena commented on YARN-6420: So this can only happen if replace labels on node and adding of

[jira] [Commented] (YARN-6376) Exceptions caused by synchronous putEntities requests can be swallowed

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949818#comment-15949818 ] Varun Saxena commented on YARN-6376: Committed to trunk, YARN-5355, YARN-5355-branch-2. Thanks

[jira] [Commented] (YARN-6342) Make TimelineV2Client's drain timeout after stop configurable

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949779#comment-15949779 ] Varun Saxena commented on YARN-6342: Committed to trunk, YARN-5355 and YARN-5355-branch-2. Thanks

[jira] [Commented] (YARN-6342) Make TimelineV2Client's drain timeout after stop configurable

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949736#comment-15949736 ] Varun Saxena commented on YARN-6342: +1. Will commit it shortly. > Make TimelineV2Client's drain

[jira] [Commented] (YARN-6376) Exceptions caused by synchronous putEntities requests can be swallowed

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949054#comment-15949054 ] Varun Saxena commented on YARN-6376: +1 Will commit it today > Exceptions caused by synchronous

[jira] [Updated] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6375: --- Attachment: YARN-6375-YARN-5355.01.patch > App level aggregation should not consider metric values

[jira] [Updated] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6375: --- Attachment: (was: YARN-6375-YARN-5355.01.patch) > App level aggregation should not consider metric

[jira] [Updated] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6375: --- Attachment: YARN-6375-YARN-5355.01.patch > App level aggregation should not consider metric values

[jira] [Commented] (YARN-6342) Make TimelineV2Client's drain timeout after stop configurable

2017-03-30 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948462#comment-15948462 ] Varun Saxena commented on YARN-6342: Sorry for nitpicking. I would gives spaces in between

[jira] [Commented] (YARN-6342) Make TimelineV2Client's drain period after stop configurable

2017-03-29 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947892#comment-15947892 ] Varun Saxena commented on YARN-6342: Thanks [~haibochen] for the patch. It looks good to me in

[jira] [Comment Edited] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946097#comment-15946097 ] Varun Saxena edited comment on YARN-6357 at 3/28/17 10:37 PM: -- Committed to

[jira] [Commented] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946068#comment-15946068 ] Varun Saxena commented on YARN-6357: +1. Will commit it shortly. > Implement putEntitiesAsync API in

[jira] [Updated] (YARN-6352) Header injections are possible in application proxy servlet

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6352: --- Summary: Header injections are possible in application proxy servlet (was: Header injections are

[jira] [Commented] (YARN-5368) Memory leak in timeline server

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945906#comment-15945906 ] Varun Saxena commented on YARN-5368: Committed to trunk, branch-2 and branch-2.8 Thanks [~jeagles] for

[jira] [Commented] (YARN-5368) Memory leak in timeline server

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945899#comment-15945899 ] Varun Saxena commented on YARN-5368: Yeah will get this in branch-2.8 too. > Memory leak in timeline

[jira] [Updated] (YARN-5368) Memory leak in timeline server

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-5368: --- Priority: Critical (was: Major) > Memory leak in timeline server > -- > >

[jira] [Updated] (YARN-5368) Memory leak in timeline server

2017-03-28 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-5368: --- Summary: Memory leak in timeline server (was: memory leak at timeline server) > Memory leak in

[jira] [Commented] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944227#comment-15944227 ] Varun Saxena commented on YARN-6352: Thanks [~Naganarasimha] for the patch. LGTM. I will wait for a day

[jira] [Comment Edited] (YARN-5368) memory leak at timeline server

2017-03-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944202#comment-15944202 ] Varun Saxena edited comment on YARN-5368 at 3/27/17 11:13 PM: -- Thanks

[jira] [Commented] (YARN-5368) memory leak at timeline server

2017-03-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944202#comment-15944202 ] Varun Saxena commented on YARN-5368: Thanks [~jeagles] for the updated patch fixing the comments. The

[jira] [Commented] (YARN-3053) [Security] Review and implement authentication in ATS v.2

2017-03-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944103#comment-15944103 ] Varun Saxena commented on YARN-3053: Sorry I missed updating the doc. Give me a couple of days. Will

[jira] [Commented] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-26 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942263#comment-15942263 ] Varun Saxena commented on YARN-6352: Will have a look today. > Header injections are possible in the

[jira] [Commented] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-26 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942262#comment-15942262 ] Varun Saxena commented on YARN-6357: [~haibochen], in TimelineCollectorWebServices, shouldn't the code

[jira] [Commented] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941236#comment-15941236 ] Varun Saxena commented on YARN-6357: Thanks Haibo. Will commit it in a day. > Implement

[jira] [Commented] (YARN-6389) [ATSv2] metricslimit query parameter do not work

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940870#comment-15940870 ] Varun Saxena commented on YARN-6389: Probably something has broken either due to change in HBase

[jira] [Assigned] (YARN-6389) [ATSv2] metricslimit query parameter do not work

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena reassigned YARN-6389: -- Assignee: Varun Saxena > [ATSv2] metricslimit query parameter do not work >

[jira] [Commented] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940821#comment-15940821 ] Varun Saxena commented on YARN-6357: Thanks [~haibochen] for the latest patch. A nit in the javadoc

[jira] [Commented] (YARN-6388) Add YARN_TIMELINEREADER_OPTS into yarn-env.sh

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940806#comment-15940806 ] Varun Saxena commented on YARN-6388: [~rohithsharma], we added this in YARN-5431. Am I missing

[jira] [Commented] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940510#comment-15940510 ] Varun Saxena commented on YARN-6352: Thanks [~Naganarasimha] for the patch. Couple of nits. # There is

[jira] [Updated] (YARN-6357) Implement putEntitiesAsync API in TimelineCollector

2017-03-24 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6357: --- Summary: Implement putEntitiesAsync API in TimelineCollector (was: Implement

[jira] [Commented] (YARN-6376) Exceptions caused by synchronous putEntities requests can be swallowed in TimelineCollector

2017-03-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938859#comment-15938859 ] Varun Saxena commented on YARN-6376: As discussed in the call, let's just synchronize on writer object.

[jira] [Commented] (YARN-6146) Add Builder methods for TimelineEntityFilters

2017-03-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938182#comment-15938182 ] Varun Saxena commented on YARN-6146: Committed to YARN-5355 and YARN-5355-branch-2. Thanks Rohith for

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937850#comment-15937850 ] Varun Saxena commented on YARN-6357: bq. I propose, we replace TimelineResponse with void as the return

[jira] [Commented] (YARN-6342) Issues in async API of TimelineClient

2017-03-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937839#comment-15937839 ] Varun Saxena commented on YARN-6342: bq. I'll leave this jira open to make the wait period configurable

[jira] [Assigned] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena reassigned YARN-6375: -- Assignee: Varun Saxena > App level aggregation should not consider metric values reported in

[jira] [Comment Edited] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937752#comment-15937752 ] Varun Saxena edited comment on YARN-6377 at 3/23/17 5:27 AM: - Thanks

[jira] [Commented] (YARN-6377) NMTimelinePublisher#serviceStop does not stop timeline clients

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937752#comment-15937752 ] Varun Saxena commented on YARN-6377: Thanks [~haibochen], the test failure is related. >

[jira] [Updated] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6375: --- Description: Currently app level aggregation is done every 15 seconds. And we consider last reported

[jira] [Commented] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937266#comment-15937266 ] Varun Saxena commented on YARN-6375: Assume in the first 15 second period, entities reported with

[jira] [Commented] (YARN-5269) Bubble exceptions and errors all the way up the calls, including to clients.

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937257#comment-15937257 ] Varun Saxena commented on YARN-5269: The reason for asking this question is that I want to see if

[jira] [Updated] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6375: --- Description: Currently app level aggregation is done every 15 seconds. And we consider last reported

[jira] [Commented] (YARN-6376) Exceptions caused by synchronous putEntities requests can be swallowed in TimelineCollector

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937246#comment-15937246 ] Varun Saxena commented on YARN-6376: Thanks [~haibochen]. Makes sense. We should synchronize these two

[jira] [Comment Edited] (YARN-5269) Bubble exceptions and errors all the way up the calls, including to clients.

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937223#comment-15937223 ] Varun Saxena edited comment on YARN-5269 at 3/22/17 9:54 PM: - We had actually

[jira] [Commented] (YARN-5269) Bubble exceptions and errors all the way up the calls, including to clients.

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937223#comment-15937223 ] Varun Saxena commented on YARN-5269: We had actually discussed about TimelinePutResponse long before. I

[jira] [Commented] (YARN-6376) Exceptions caused by synchronous putEntities requests can be swallowed in TimelineCollector

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937195#comment-15937195 ] Varun Saxena commented on YARN-6376: [~haibochen] can you elaborate upon it. write failure would lead

[jira] [Created] (YARN-6375) App level aggregation should not consider metric values reported in the previous aggregation cycle

2017-03-22 Thread Varun Saxena (JIRA)
Varun Saxena created YARN-6375: -- Summary: App level aggregation should not consider metric values reported in the previous aggregation cycle Key: YARN-6375 URL: https://issues.apache.org/jira/browse/YARN-6375

[jira] [Comment Edited] (YARN-4455) Support fetching metrics by time range

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936814#comment-15936814 ] Varun Saxena edited comment on YARN-4455 at 3/22/17 6:05 PM: - Thanks

[jira] [Commented] (YARN-4455) Support fetching metrics by time range

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936814#comment-15936814 ] Varun Saxena commented on YARN-4455: Thanks [~vrushalic] for the comments. bq. If we know the metric

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936804#comment-15936804 ] Varun Saxena commented on YARN-6357: Seems exact same thing has been discussed in YARN-3949 before. >

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936770#comment-15936770 ] Varun Saxena commented on YARN-6357: The way current code is structured, the responsibility of the

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936763#comment-15936763 ] Varun Saxena commented on YARN-6357: bq. Also, I am wondering if there is any way for the

[jira] [Updated] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6357: --- Target Version/s: YARN-5355 Fix Version/s: (was: YARN-5355) > Implement

[jira] [Updated] (YARN-4455) Support fetching metrics by time range

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-4455: --- Target Version/s: YARN-5355 (was: YARN-2928) > Support fetching metrics by time range >

[jira] [Commented] (YARN-6146) Add Builder methods for TimelineEntityFilters

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936670#comment-15936670 ] Varun Saxena commented on YARN-6146: LGTM. Will commit it later today. > Add Builder methods for

[jira] [Commented] (YARN-4455) Support fetching metrics by time range

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936415#comment-15936415 ] Varun Saxena commented on YARN-4455: Marked it as merge blocker. > Support fetching metrics by time

[jira] [Updated] (YARN-4455) Support fetching metrics by time range

2017-03-22 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-4455: --- Labels: YARN-5355 yarn-5355-merge-blocker (was: YARN-5355) > Support fetching metrics by time range >

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935524#comment-15935524 ] Varun Saxena commented on YARN-6357: By the way, coming to the patch, although almost all the writer

[jira] [Commented] (YARN-5934) Fix TestTimelineWebServices.testPrimaryFilterNumericString

2017-03-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935443#comment-15935443 ] Varun Saxena commented on YARN-5934: bq. It looks like Jackson1 parses 123abc to 123, on the other

[jira] [Comment Edited] (YARN-6342) Issues in async API of TimelineClient

2017-03-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935313#comment-15935313 ] Varun Saxena edited comment on YARN-6342 at 3/21/17 8:53 PM: - [~haibochen],

[jira] [Commented] (YARN-6342) Issues in async API of TimelineClient

2017-03-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935313#comment-15935313 ] Varun Saxena commented on YARN-6342: [~haibochen], correct. FutureTask#run won't throw any exception.

[jira] [Commented] (YARN-5368) memory leak at timeline server

2017-03-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935302#comment-15935302 ] Varun Saxena commented on YARN-5368: [~jeagles], nice catch. Closing of only the last iterator in the

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933141#comment-15933141 ] Varun Saxena commented on YARN-6357: Thanks [~haibochen] for the patch. # TODO comment in

[jira] [Commented] (YARN-6353) Clean up OrderingPolicy javadoc

2017-03-20 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932492#comment-15932492 ] Varun Saxena commented on YARN-6353: +1. Will commit it later today > Clean up OrderingPolicy javadoc

[jira] [Commented] (YARN-5548) Use MockRMMemoryStateStore to reduce test failures

2017-03-19 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932016#comment-15932016 ] Varun Saxena commented on YARN-5548: Few comments. # Can we set state store as Memory RM state store in

[jira] [Updated] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6352: --- Target Version/s: 2.9.0, 2.8.1 (was: 2.9.0, 2.8.1, 3.0.0-alpha2) > Header injections are possible in

[jira] [Commented] (YARN-6146) Add Builder methods for TimelineEntityFilters

2017-03-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929649#comment-15929649 ] Varun Saxena commented on YARN-6146: bq. This is due to the method call in

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929048#comment-15929048 ] Varun Saxena commented on YARN-6357: bq. We have two separate methods on our API putEntities and

[jira] [Commented] (YARN-6357) Implement TimelineCollector#putEntitiesAsync

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929037#comment-15929037 ] Varun Saxena commented on YARN-6357: Correct. This is what I was suspecting in the previous call. In

[jira] [Commented] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929026#comment-15929026 ] Varun Saxena commented on YARN-6352: [~Naganarasimha], did you try with latest trunk code? This issue

[jira] [Commented] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928695#comment-15928695 ] Varun Saxena commented on YARN-6352: Apps#toAppId looks like a generic enough method which may not be

[jira] [Comment Edited] (YARN-6352) Header injections are possible in the application proxy servlet

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928695#comment-15928695 ] Varun Saxena edited comment on YARN-6352 at 3/16/17 7:31 PM: - Apps#toAppId

[jira] [Commented] (YARN-6146) Add Builder methods for TimelineEntityFilters

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928452#comment-15928452 ] Varun Saxena commented on YARN-6146: Thanks [~haibochen] for the patch. Looks straightforward. Couple

[jira] [Updated] (YARN-2962) ZKRMStateStore: Limit the number of znodes under a znode

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-2962: --- Attachment: (was: YARN-2962.009.patch) > ZKRMStateStore: Limit the number of znodes under a znode

[jira] [Updated] (YARN-2962) ZKRMStateStore: Limit the number of znodes under a znode

2017-03-16 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-2962: --- Attachment: YARN-2962.009.patch > ZKRMStateStore: Limit the number of znodes under a znode >

[jira] [Updated] (YARN-2962) ZKRMStateStore: Limit the number of znodes under a znode

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-2962: --- Attachment: YARN-2962.009.patch > ZKRMStateStore: Limit the number of znodes under a znode >

[jira] [Updated] (YARN-6342) Issues in async API of TimelineClient

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6342: --- Issue Type: Sub-task (was: Bug) Parent: YARN-5355 > Issues in async API of TimelineClient >

[jira] [Commented] (YARN-6342) Issues in async API of TimelineClient

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926764#comment-15926764 ] Varun Saxena commented on YARN-6342: Yes, it was a conscious decision to wait for upto 2 seconds. The

[jira] [Comment Edited] (YARN-6342) Issues in async API of TimelineClient

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925913#comment-15925913 ] Varun Saxena edited comment on YARN-6342 at 3/15/17 11:10 AM: -- bq. In stop: it

[jira] [Commented] (YARN-6342) Issues in async API of TimelineClient

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925913#comment-15925913 ] Varun Saxena commented on YARN-6342: bq. In stop: it calls shutdownNow which doens't wait for pending

[jira] [Comment Edited] (YARN-3884) App History status not updated when RMContainer transitions from RESERVED to KILLED

2017-03-15 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924805#comment-15924805 ] Varun Saxena edited comment on YARN-3884 at 3/15/17 8:26 AM: - bq. If only

[jira] [Comment Edited] (YARN-3884) App History status not updated when RMContainer transitions from RESERVED to KILLED

2017-03-14 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924805#comment-15924805 ] Varun Saxena edited comment on YARN-3884 at 3/14/17 7:05 PM: - bq. If only

<    3   4   5   6   7   8   9   10   11   12   >