[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026360#comment-17026360 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026289#comment-17026289 ] Eric Badger commented on YARN-10084: +1 on the branch-3.1 patch. I just committed that to branch-3.1.

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026280#comment-17026280 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026121#comment-17026121 ] Hadoop QA commented on YARN-10084: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025561#comment-17025561 ] Hudson commented on YARN-10084: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17914 (See

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025559#comment-17025559 ] Eric Badger commented on YARN-10084: +1 lgtm. Thanks, [~epayne] for the patch and [~Jim_Brennan] for

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025504#comment-17025504 ] Hadoop QA commented on YARN-10084: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025420#comment-17025420 ] Hadoop QA commented on YARN-10084: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025320#comment-17025320 ] Eric Payne commented on YARN-10084: --- [~Jim_Brennan] and [~ebadger], thanks for your review so far!

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023309#comment-17023309 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023225#comment-17023225 ] Eric Payne commented on YARN-10084: --- All patches are uploaded. Here is the breakdown of the

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023204#comment-17023204 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023105#comment-17023105 ] Eric Payne commented on YARN-10084: --- I attached patch for branch-3.1 > Allow inheritance of max app

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023103#comment-17023103 ] Eric Payne commented on YARN-10084: --- Unit test failures for TestCombinedSystemMetricsPublisher and

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022668#comment-17022668 ] Hadoop QA commented on YARN-10084: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022608#comment-17022608 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022516#comment-17022516 ] Eric Payne commented on YARN-10084: --- Thanks [~ebadger]. I uploaded patch 005 that includes new and

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021659#comment-17021659 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021613#comment-17021613 ] Eric Badger commented on YARN-10084: Hey [~epayne], the patch looks good, but I have a comment about

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021579#comment-17021579 ] Jim Brennan commented on YARN-10084: +1 (non-binding) on patch 004.  I built it locally and ran the

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021554#comment-17021554 ] Eric Payne commented on YARN-10084: --- I clicked on the "compile" link above and it says: {noformat}

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021463#comment-17021463 ] Hadoop QA commented on YARN-10084: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021445#comment-17021445 ] Jim Brennan commented on YARN-10084: Thanks [~epayne]!   I am +1 (non-binding) on patch 003. cc:

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021440#comment-17021440 ] Eric Payne commented on YARN-10084: --- Thanks [~Jim_Brennan]. I uploaded version 003. > Allow

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021401#comment-17021401 ] Jim Brennan commented on YARN-10084: Thanks for the update [~epayne]!  The code looks good to me. 

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021294#comment-17021294 ] Eric Payne commented on YARN-10084: --- Version 002 attached. I did not change the logic since it already

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021287#comment-17021287 ] Eric Payne commented on YARN-10084: --- Okay. Thanks for your further analysis, [~Jim_Brennan]. bq. a

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020612#comment-17020612 ] Jim Brennan commented on YARN-10084: {quote}Should we be inheriting the parent queue's max if the

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020605#comment-17020605 ] Eric Payne commented on YARN-10084: --- {quote} For some reason, I was under the impression that < 0 meant

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020602#comment-17020602 ] Eric Payne commented on YARN-10084: --- bq. should you be checking for >= 0 instead of >0 Good catch,

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020435#comment-17020435 ] Jim Brennan commented on YARN-10084: (responding to my own comment) Actually, I think the question

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020416#comment-17020416 ] Jim Brennan commented on YARN-10084: Thanks for the patch [~epayne]!  I've built and run the tests

[jira] [Commented] (YARN-10084) Allow inheritance of max app lifetime / default app lifetime

[ https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018338#comment-17018338 ] Hadoop QA commented on YARN-10084: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem