[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369713#comment-15369713
]
Hudson commented on YARN-4074:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903246#comment-14903246
]
Vrushali C commented on YARN-4074:
--
Chatted with Li offline and decided to file
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903284#comment-14903284
]
Li Lu commented on YARN-4074:
-
Sure, please go ahead with the current patch. Thanks for the work folks!
>
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903158#comment-14903158
]
Li Lu commented on YARN-4074:
-
Sorry I missed your message yesterday... I was thinking about putting those
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903411#comment-14903411
]
Vrushali C commented on YARN-4074:
--
Committed patch v8. Thanks [~sjlee0] for the contribution and everyone
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901019#comment-14901019
]
Vrushali C commented on YARN-4074:
--
Thanks everyone for the review, I will commit this patch in today.
>
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901067#comment-14901067
]
Li Lu commented on YARN-4074:
-
Hi [~sjlee0] [~vrushalic], thanks for the work and sorry I could not get back
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901299#comment-14901299
]
Vrushali C commented on YARN-4074:
--
Hi [~gtCarrera9]
To confirm my understanding, did you mean putting
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876931#comment-14876931
]
Varun Saxena commented on YARN-4074:
LGTM.
> [timeline reader] implement support for querying for
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876185#comment-14876185
]
Vrushali C commented on YARN-4074:
--
Patch v8 looks good too me. Thanks for updating the test cases to use
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875864#comment-14875864
]
Sangjin Lee commented on YARN-4074:
---
I would greatly appreciate your review. Thanks!
> [timeline reader]
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803384#comment-14803384
]
Sangjin Lee commented on YARN-4074:
---
{quote}
In TimelineEntityReader#readMetrics it seems safe to assume
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804328#comment-14804328
]
Hadoop QA commented on YARN-4074:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804597#comment-14804597
]
Hadoop QA commented on YARN-4074:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803340#comment-14803340
]
Sangjin Lee commented on YARN-4074:
---
That's correct. In other words, those are used to do
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790830#comment-14790830
]
Varun Saxena commented on YARN-4074:
The patch looks fine to me. I tested some parts related to flow as
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790948#comment-14790948
]
Sangjin Lee commented on YARN-4074:
---
Thanks for your comments [~varun_saxena]!
bq. This I guess is to
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791493#comment-14791493
]
Joep Rottinghuis commented on YARN-4074:
Wrt. javadoc comment and method names: "Instantiates a
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791504#comment-14791504
]
Joep Rottinghuis commented on YARN-4074:
In TimelineEntityReader#readMetrics it seems safe to
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745672#comment-14745672
]
Varun Saxena commented on YARN-4074:
Thanks [~sjlee0] for updating the patch. Will have a look at it.
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735545#comment-14735545
]
Sangjin Lee commented on YARN-4074:
---
It'd be great if you could take a look at the latest patch and let
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729556#comment-14729556
]
Sangjin Lee commented on YARN-4074:
---
Just to be clear, the current POC patch already handles the null
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729515#comment-14729515
]
Varun Saxena commented on YARN-4074:
The 2nd point I guess even I can handle even in YARN-4075. I can
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729558#comment-14729558
]
Varun Saxena commented on YARN-4074:
[~sjlee0], yeah it handles null case. I meant we can handle
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729560#comment-14729560
]
Varun Saxena commented on YARN-4074:
Its fine though if you are handling negatives as part of
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727402#comment-14727402
]
Varun Saxena commented on YARN-4074:
Few more comments.
* {{Scan#setMaxResultSize}} only limits the
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725914#comment-14725914
]
Varun Saxena commented on YARN-4074:
Few comments :
# As TreeSet has been used to sort
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725918#comment-14725918
]
Varun Saxena commented on YARN-4074:
Correction to point 1 :
As TreeSet has been used to sort
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724856#comment-14724856
]
Varun Saxena commented on YARN-4074:
Agree...+1 to changing the name.
> [timeline reader] implement
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726295#comment-14726295
]
Sangjin Lee commented on YARN-4074:
---
I'm addressing [~varun_saxena]'s latest comments. Thanks for those.
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723646#comment-14723646
]
Varun Saxena commented on YARN-4074:
Moreover, do we return metrics at all times for a flow run ? Or
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723678#comment-14723678
]
Vrushali C commented on YARN-4074:
--
bq. Should we support filtering on the basis of flow start time and
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723733#comment-14723733
]
Varun Saxena commented on YARN-4074:
Ok...For PoC, this should be fine.
> [timeline reader] implement
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723773#comment-14723773
]
Sangjin Lee commented on YARN-4074:
---
Just to clarify on the flow run "end time". Note that there is no
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723790#comment-14723790
]
Sangjin Lee commented on YARN-4074:
---
Also, while we're at it, I find the name {{FlowEntity}} quite
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724393#comment-14724393
]
Li Lu commented on YARN-4074:
-
bq. Would there be an appetite for renaming this class to FlowRunEntity as part
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724534#comment-14724534
]
Li Lu commented on YARN-4074:
-
bq. As a general question, since we're returning our timeline entities as jsons
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723307#comment-14723307
]
Varun Saxena commented on YARN-4074:
Just had a cursory glance at the patch. A couple of points.
# We
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718120#comment-14718120
]
Varun Saxena commented on YARN-4074:
bq. So improving the API would be taken up by
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720246#comment-14720246
]
Li Lu commented on YARN-4074:
-
bq. One thing I forgot to mention is that the current POC patch
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717073#comment-14717073
]
Varun Saxena commented on YARN-4074:
Ok..will have a look. We dont need to support a
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717146#comment-14717146
]
Sangjin Lee commented on YARN-4074:
---
cc [~gtCarrera9] and [~vrushalic] also for their
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717257#comment-14717257
]
Junping Du commented on YARN-4074:
--
Thanks for uploading a patch, [~sjlee0]! Sorry for
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717758#comment-14717758
]
Li Lu commented on YARN-4074:
-
Thank [~sjlee0]! I looked at the current POC patch and have some
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717681#comment-14717681
]
Li Lu commented on YARN-4074:
-
Hi [~sjlee0], so far the first option looks good to me. The
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717721#comment-14717721
]
Junping Du commented on YARN-4074:
--
Ok. Have a separated JIRA to track this refactor work
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717855#comment-14717855
]
Sangjin Lee commented on YARN-4074:
---
Thanks [~gtCarrera9] for your comments.
{quote}
As
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715208#comment-14715208
]
Vrushali C commented on YARN-4074:
--
My take is that we can make things as generic as
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715765#comment-14715765
]
Sangjin Lee commented on YARN-4074:
---
I am about 90% done with the POC patch for this. I'm
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709839#comment-14709839
]
Sangjin Lee commented on YARN-4074:
---
The queries we will need to support are as follows
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710102#comment-14710102
]
Li Lu commented on YARN-4074:
-
I'd incline to use the latter approach to retrieve flows and
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710142#comment-14710142
]
Li Lu commented on YARN-4074:
-
bq. This also implies that the canonical stores for the flows
[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710133#comment-14710133
]
Sangjin Lee commented on YARN-4074:
---
Actually the backend will need to differentiate the
53 matches
Mail list logo
