[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682616#comment-15682616
]
Rohith Sharma K S commented on YARN-4205:
-
You can set timeout for any job.
> Add a service for
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682384#comment-15682384
]
stefanlee commented on YARN-4205:
-
I have a doubt that if it is suitable fo long time job ,e.g spark
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535013#comment-15535013
]
Jian He commented on YARN-4205:
---
[~cnauroth], [~gtCarrera9], thanks for helping on this ! my bad.
> Add a
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534852#comment-15534852
]
Rohith Sharma K S commented on YARN-4205:
-
+1 for addendum patch.. Thanks [~gtCarrera9] for quick
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534307#comment-15534307
]
Li Lu commented on YARN-4205:
-
I committed the addendum patch to branch-2. Thanks [~cnauroth] for the review.
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534288#comment-15534288
]
Li Lu commented on YARN-4205:
-
OK, I'll commit it shortly then.
> Add a service for monitoring application
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534277#comment-15534277
]
Chris Nauroth commented on YARN-4205:
-
[~gtCarrera9], we are all clear to use JDK 8 features in trunk,
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534247#comment-15534247
]
Li Lu commented on YARN-4205:
-
[~cnauroth] shall we put this patch to branch-2 only, or to trunk as well?
>
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534232#comment-15534232
]
Chris Nauroth commented on YARN-4205:
-
+1 for the addendum patch. [~gtCarrera9], thank you.
> Add a
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534056#comment-15534056
]
Chris Nauroth commented on YARN-4205:
-
I think this patch broke compilation on branch-2.
{code}
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533072#comment-15533072
]
Rohith Sharma K S commented on YARN-4205:
-
thank Jian He for review and committing patch.. thanks
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532917#comment-15532917
]
Hudson commented on YARN-4205:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10512 (See
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530187#comment-15530187
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529649#comment-15529649
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529513#comment-15529513
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529380#comment-15529380
]
Jian He commented on YARN-4205:
---
latest patch looks good to me
> Add a service for monitoring application
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528290#comment-15528290
]
Rohith Sharma K S commented on YARN-4205:
-
After I revisited the patch with discussion points,
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528289#comment-15528289
]
Rohith Sharma K S commented on YARN-4205:
-
We ( [~jianhe] [~gsaha] [~vinodkv] and me ) had offline
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525545#comment-15525545
]
Jian He commented on YARN-4205:
---
Or, we could also change the ApplicationTimeouts class to a map data
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525507#comment-15525507
]
Jian He commented on YARN-4205:
---
[~gsaha],
Current ApplicationTimeout has getLifetime which indicates the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525225#comment-15525225
]
Gour Saha commented on YARN-4205:
-
YARN-4692 also needs total execution timeout of application. It does not
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522077#comment-15522077
]
Rohith Sharma K S commented on YARN-4205:
-
Thanks [~gsaha] for the suggestion. Some clarifications
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512388#comment-15512388
]
Sunil G commented on YARN-4205:
---
Hi [~gsaha]
Generally this comment makes sense for me.
If we are passing
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510869#comment-15510869
]
Gour Saha commented on YARN-4205:
-
{quote}
Basically this point got discussed in earlier comments also,
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508769#comment-15508769
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508541#comment-15508541
]
Rohith Sharma K S commented on YARN-4205:
-
bq. Shouldn't it be counted from the time YARN allocates
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507403#comment-15507403
]
Gour Saha commented on YARN-4205:
-
Thanks [~rohithsharma]. A few minor cosmetic follow-up comments, and 2
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507237#comment-15507237
]
Rohith Sharma K S commented on YARN-4205:
-
It looks 3 java doc warnings are related, I will upload
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506046#comment-15506046
]
Rohith Sharma K S commented on YARN-4205:
-
Many checkstyle and javadoc errors are reported at
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505803#comment-15505803
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505522#comment-15505522
]
Rohith Sharma K S commented on YARN-4205:
-
Thanks [~gsaha] for review.
bq. For the second
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505337#comment-15505337
]
Gour Saha commented on YARN-4205:
-
Few comments:
h6. \[ApplicationTimeouts.java\]
This class already has
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489769#comment-15489769
]
Jian He commented on YARN-4205:
---
latest patch looks good to me.
> Add a service for monitoring application
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487307#comment-15487307
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485470#comment-15485470
]
Vinod Kumar Vavilapalli commented on YARN-4205:
---
bq. Added ApplicationTimeouts class that
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484242#comment-15484242
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472732#comment-15472732
]
Vinod Kumar Vavilapalli commented on YARN-4205:
---
bq. And I believe monitoring interval should
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1544#comment-1544
]
Rohith Sharma K S commented on YARN-4205:
-
bq. can you clarify the definition of lifetime in the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466519#comment-15466519
]
Jian He commented on YARN-4205:
---
Thanks Rohith, looks good overall, few comments:
- can you clarify the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463398#comment-15463398
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463327#comment-15463327
]
Rohith Sharma K S commented on YARN-4205:
-
bq. I agree with this above sentiment - we don't need
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459472#comment-15459472
]
Vinod Kumar Vavilapalli commented on YARN-4205:
---
This looks good in general.
As discussed on
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456100#comment-15456100
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455929#comment-15455929
]
Rohith Sharma K S commented on YARN-4205:
-
[~sunilg] [~jianhe] [~leftnoteasy] requesting your
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448855#comment-15448855
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448840#comment-15448840
]
Rohith Sharma K S commented on YARN-4205:
-
Its been long time rebasing the patch. I will rebase the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143996#comment-15143996
]
Rohith Sharma K S commented on YARN-4205:
-
Hi [~nijel] the patch appears to be required to rebase
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144003#comment-15144003
]
Hadoop QA commented on YARN-4205:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933513#comment-14933513
]
nijel commented on YARN-4205:
-
Thanks [~rohithsharma] for the comments
Updated the patch.
> Add a service for
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14910062#comment-14910062
]
Rohith Sharma K S commented on YARN-4205:
-
It seems build machine has issue. I will kick off the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909121#comment-14909121
]
nijel commented on YARN-4205:
-
Test cases failing as "method not found" for the method added in api project.
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908204#comment-14908204
]
nijel commented on YARN-4205:
-
Thanks [~leftnoteasy] for the comments
Sorry for the small mistakes
Updated the
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908575#comment-14908575
]
Hadoop QA commented on YARN-4205:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906972#comment-14906972
]
Hadoop QA commented on YARN-4205:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907305#comment-14907305
]
Wangda Tan commented on YARN-4205:
--
Comments:
- Could you add a short desc of this JIRA?
-
55 matches
Mail list logo
