[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146724#comment-16146724 ] Hudson commented on YARN-5739: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733189#comment-15733189 ] Sangjin Lee commented on YARN-5739: --- Oops sorry for the oversight. Closing. > Provide timeline reader

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732863#comment-15732863 ] Varun Saxena commented on YARN-5739: This needs to be marked as "Resolved" > Provide timeline reader

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726187#comment-15726187 ] Sangjin Lee commented on YARN-5739: --- I have committed the patch to YARN-5355 and YARN-5355-branch-2. I

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726060#comment-15726060 ] Varun Saxena commented on YARN-5739: [~sjlee0], should I go ahead and commit it or do you want to

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724916#comment-15724916 ] Varun Saxena commented on YARN-5739: Checkstyle is unrelated. +1 LGTM. > Provide timeline reader API

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723699#comment-15723699 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723688#comment-15723688 ] Sangjin Lee commented on YARN-5739: --- The latest patch LGTM. [~varun_saxena], let me know what you think.

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15720290#comment-15720290 ] Varun Saxena commented on YARN-5739: Sorry could not look at it earlier as I was away. Patch LGTM too

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716038#comment-15716038 ] Varun Saxena commented on YARN-5739: Thanks Li for the patch and Sangjin for the review. Will look at

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713829#comment-15713829 ] Sangjin Lee commented on YARN-5739: --- The latest patch LGTM. Thanks [~gtCarrera9] for the update! I'll

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713412#comment-15713412 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713294#comment-15713294 ] Hadoop QA commented on YARN-5739: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710480#comment-15710480 ] Sangjin Lee commented on YARN-5739: --- I think the {{if (singleEntityRead())}} check in

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710429#comment-15710429 ] Sangjin Lee commented on YARN-5739: --- I'm more of -0 on the name. If alternatives are not any better, I'm

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710412#comment-15710412 ] Li Lu commented on YARN-5739: - Also, the two augmentParams in GenericEntityReader and in

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710400#comment-15710400 ] Li Lu commented on YARN-5739: - But I'd certainly appreciate if there are better names! > Provide timeline

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710357#comment-15710357 ] Li Lu commented on YARN-5739: - bq. I hate to nitpick on the name, but AbstractTimelineStorageReader sounds a

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710323#comment-15710323 ] Sangjin Lee commented on YARN-5739: --- Thanks for the update [~gtCarrera9]. I have some feedback specific

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709830#comment-15709830 ] Li Lu commented on YARN-5739: - Any more comments folks? Thanks! > Provide timeline reader API to list

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707008#comment-15707008 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706169#comment-15706169 ] Li Lu commented on YARN-5739: - Kick Jenkins again for the new patch. > Provide timeline reader API to list

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703452#comment-15703452 ] Li Lu commented on YARN-5739: - Sure. Let me try with some refactoring... > Provide timeline reader API to list

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694139#comment-15694139 ] Varun Saxena commented on YARN-5739: I was wondering if we can refactor this code. As I said when I

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691293#comment-15691293 ] Varun Saxena commented on YARN-5739: Ok...Will wait. > Provide timeline reader API to list available

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691232#comment-15691232 ] Sangjin Lee commented on YARN-5739: --- Can we wait until next week? Most of us are for the holiday this

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691199#comment-15691199 ] Varun Saxena commented on YARN-5739: I think this patch can be committed before YARN-5585 as its

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688477#comment-15688477 ] Sangjin Lee commented on YARN-5739: --- As long as hyphens do not cause issues with REST, I'm fine with

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688118#comment-15688118 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688032#comment-15688032 ] Li Lu commented on YARN-5739: - Sure. Let's wait for more comments on this. > Provide timeline reader API to

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688023#comment-15688023 ] Varun Saxena commented on YARN-5739: Yeah I was referring to node label REST endpoints only when I said

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687692#comment-15687692 ] Varun Saxena commented on YARN-5739: Thanks [~gtCarrera9] for the patch. Few comments. # In

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687644#comment-15687644 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687564#comment-15687564 ] Sangjin Lee commented on YARN-5739: --- For some reason, the CI build didn't kick in. I started one just

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675728#comment-15675728 ] Varun Saxena commented on YARN-5739: Well, found a link of HBase book which recommends using both

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675693#comment-15675693 ] Varun Saxena commented on YARN-5739: [~vrushalic], FirstKeyOnlyFilter will return the first KV from

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675199#comment-15675199 ] Vrushali C commented on YARN-5739: -- Thanks [~gtCarrera9] for the patch. [~varun_saxena] I think we do

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665004#comment-15665004 ] Varun Saxena commented on YARN-5739: Thanks [~gtCarrera9] for the patch. Couple of comments. # I dont

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658618#comment-15658618 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650551#comment-15650551 ] Varun Saxena commented on YARN-5739: bq. WRT caching, I am wondering, if there might be a query coming

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649249#comment-15649249 ] Sangjin Lee commented on YARN-5739: --- I'd like to add to Varun's and Vrushali's comments.

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649236#comment-15649236 ] Li Lu commented on YARN-5739: - Thanks [~vrushalic]! I'll add a KeyOnlyFilter in the filter list. Got confused

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649165#comment-15649165 ] Vrushali C commented on YARN-5739: -- Thanks [~gtCarrera9] for the patch. I wish to add to [~varun_saxena]'s

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648473#comment-15648473 ] Varun Saxena commented on YARN-5739: Thanks [~gtCarrera9] for the patch. Few comments. # REST endpoint

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648429#comment-15648429 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648321#comment-15648321 ] Sangjin Lee commented on YARN-5739: --- Kicked off jenkins again after the rebase. > Provide timeline

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631098#comment-15631098 ] Hadoop QA commented on YARN-5739: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606332#comment-15606332 ] Vrushali C commented on YARN-5739: -- So if we need only some entity types, then it's even easier I think.

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606313#comment-15606313 ] Li Lu commented on YARN-5739: - Thanks [~vrushalic]! Yes. One concern we had was the scan may need to go

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606036#comment-15606036 ] Vrushali C commented on YARN-5739: -- Actually, this is not that hard to do. It requires making two queries:

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592927#comment-15592927 ] Li Lu commented on YARN-5739: - We may not want to introduce another table for storing entity types for each

[jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application

[ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15577111#comment-15577111 ] Rohith Sharma K S commented on YARN-5739: - Thanks Li Lu for raising a JIRA. This is one of the many