[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907355#comment-16907355
]
Hudson commented on YARN-9133:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17121 (See
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907350#comment-16907350
]
Szilard Nemeth commented on YARN-9133:
--
Hi [~pbacsko]!
+1 on latest patch for trunk and branch-3.2,
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907074#comment-16907074
]
Peter Bacsko commented on YARN-9133:
ASF license issue can be ignored.
> Make tests more easy to
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906330#comment-16906330
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906266#comment-16906266
]
Peter Bacsko commented on YARN-9133:
Uploaded patch for branch-3.2. Again, patch for branch-3.1 is not
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906170#comment-16906170
]
Hadoop QA commented on YARN-9133:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905143#comment-16905143
]
Szilard Nemeth commented on YARN-9133:
--
Hi [~pbacsko]!
I do agree to not bother with backports, then.
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903805#comment-16903805
]
Peter Bacsko commented on YARN-9133:
[~snemeth] similarly to YARN-9140, conflict resolution might not
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883924#comment-16883924
]
Szilard Nemeth commented on YARN-9133:
--
Hi [~pbacsko]!
Could you please provide patches for
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883728#comment-16883728
]
Peter Bacsko commented on YARN-9133:
Unit test failure seems to be unrelated.
> Make tests more easy
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883669#comment-16883669
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810912#comment-16810912
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767279#comment-16767279
]
Peter Bacsko commented on YARN-9133:
+1 (non-binding)
> Make tests more easy to comprehend in
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760893#comment-16760893
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760776#comment-16760776
]
Szilard Nemeth commented on YARN-9133:
--
Patch004 corrects the javac warning about deprecated method.
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757525#comment-16757525
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757381#comment-16757381
]
Szilard Nemeth commented on YARN-9133:
--
Thanks [~pbacsko] for your review comments!
I fixed all the
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750035#comment-16750035
]
Peter Bacsko commented on YARN-9133:
Thanks for the update [~snemeth].
Minor things:
1. What's the
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723877#comment-16723877
]
Szilard Nemeth commented on YARN-9133:
--
[~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723074#comment-16723074
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723035#comment-16723035
]
Peter Bacsko commented on YARN-9133:
Thanks [~snemeth]. I'm OK with the changes then.
[~leftnoteasy]
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723003#comment-16723003
]
Szilard Nemeth commented on YARN-9133:
--
Thanks [~pbacsko] for your review comments!
1. No it's not a
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722930#comment-16722930
]
Peter Bacsko commented on YARN-9133:
Thanks for the patch [~snemeth]. I have some comments:
* Is it
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722917#comment-16722917
]
Hadoop QA commented on YARN-9133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722868#comment-16722868
]
Szilard Nemeth commented on YARN-9133:
--
Re-uploading the patch as build haven't kicked off.
> Make
25 matches
Mail list logo