[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369743#comment-15369743
]
Hudson commented on YARN-3863:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239001#comment-15239001
]
Varun Saxena commented on YARN-3863:
Thanks [~sjlee0] for the commit and thanks [~djp] and
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235697#comment-15235697
]
Sangjin Lee commented on YARN-3863:
---
The latest patch LGTM. I'd like to wait until the end of day today
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209001#comment-15209001
]
Varun Saxena commented on YARN-3863:
[~sjlee0], kindly review.
I had replaced the patch after rebasing
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208216#comment-15208216
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207549#comment-15207549
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189579#comment-15189579
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189532#comment-15189532
]
Varun Saxena commented on YARN-3863:
Fixed them.
Were leftovers from previous code.
The checks in
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188389#comment-15188389
]
Sangjin Lee commented on YARN-3863:
---
The latest patch looks good. Just one remaining question that I'd
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187168#comment-15187168
]
Varun Saxena commented on YARN-3863:
[~sjlee0], [~djp], kindly review.
> Support complex filters in
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187132#comment-15187132
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187038#comment-15187038
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186298#comment-15186298
]
Sangjin Lee commented on YARN-3863:
---
{quote}
Maybe we support both and let user specify if he wants to
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185424#comment-15185424
]
Varun Saxena commented on YARN-3863:
[~sjlee0],
bq. But I think the behavior hasn't changed regarding
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181321#comment-15181321
]
Sangjin Lee commented on YARN-3863:
---
We spoke offline, but I wanted to mention that we resolved the
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181317#comment-15181317
]
Sangjin Lee commented on YARN-3863:
---
I was specifically referring to a case like the following. In
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181309#comment-15181309
]
Sangjin Lee commented on YARN-3863:
---
I think the question is, should it be the behavior? If the user used
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180274#comment-15180274
]
Varun Saxena commented on YARN-3863:
[~sjlee0], wanted to know what you mean by this comment.
bq. I'm
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180122#comment-15180122
]
Varun Saxena commented on YARN-3863:
[~sjlee0], [~jrottinghuis],
You had asked for a clarification
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177526#comment-15177526
]
Varun Saxena commented on YARN-3863:
Furthermore, in ATSv1 we had something called secondary filters
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177521#comment-15177521
]
Varun Saxena commented on YARN-3863:
Moreover, info also has associated info as well.
- Sorry, meant
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177509#comment-15177509
]
Varun Saxena commented on YARN-3863:
Thanks [~sjlee0] for the review.
bq. One high level question: am
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176999#comment-15176999
]
Sangjin Lee commented on YARN-3863:
---
I did another pass at the latest patch.
One high level question: am
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173112#comment-15173112
]
Sangjin Lee commented on YARN-3863:
---
Thanks for the detailed explanation of the changes [~varun_saxena]!
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172011#comment-15172011
]
Varun Saxena commented on YARN-3863:
Checkstyle issues are related to imports made due to javadoc.
>
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172005#comment-15172005
]
Varun Saxena commented on YARN-3863:
Latest patch fixes the comments given by Sangjin.
# I have split
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171910#comment-15171910
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171734#comment-15171734
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169930#comment-15169930
]
Varun Saxena commented on YARN-3863:
Coming to review comments,
bq. I know this is happening deep
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169845#comment-15169845
]
Varun Saxena commented on YARN-3863:
I missed *TimelineStorageUtils.java*. Changes here are to apply
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169833#comment-15169833
]
Varun Saxena commented on YARN-3863:
As the patch is quite large, to aid in review, I will jot down
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167716#comment-15167716
]
Varun Saxena commented on YARN-3863:
Sorry, added the comment by mistake.
> Support complex filters in
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167712#comment-15167712
]
Varun Saxena commented on YARN-3863:
To aid in review, I will jot down what has been done in this JIRA.
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167556#comment-15167556
]
Varun Saxena commented on YARN-3863:
bq. l.532: This is an interesting point. Should we categorically
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166487#comment-15166487
]
Sangjin Lee commented on YARN-3863:
---
I completed one full pass over the patch (it's large!), and I
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166456#comment-15166456
]
Sangjin Lee commented on YARN-3863:
---
{quote}
Yes, code is similar. We are looping over a filter list and
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160053#comment-15160053
]
Sangjin Lee commented on YARN-3863:
---
Just to clarify my mental model, I am trying to view the logic as
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160034#comment-15160034
]
Sangjin Lee commented on YARN-3863:
---
If I'm reading this right, the key changes seem to be in
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159986#comment-15159986
]
Sangjin Lee commented on YARN-3863:
---
Sorry for taking a long time to review this [~varun_saxena]. I've
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139807#comment-15139807
]
Varun Saxena commented on YARN-3863:
Updated a new patch after fixing javadoc and whitespace issues.
>
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139808#comment-15139808
]
Hadoop QA commented on YARN-3863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139824#comment-15139824
]
Varun Saxena commented on YARN-3863:
[~sjlee0] / [~vrushalic] / [~jrottinghuis], kindly review.
The
42 matches
Mail list logo
