[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709921#comment-15709921
]
Hudson commented on YARN-5761:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10920 (See
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709840#comment-15709840
]
Li Lu commented on YARN-5761:
-
Will commit this patch shortly.
> Separate QueueManager from Scheduler
>
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708628#comment-15708628
]
Sunil G commented on YARN-5761:
---
+1 from my end. Apologies for the delay in the review.
> Separate
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706732#comment-15706732
]
Li Lu commented on YARN-5761:
-
+1 LGTM. Will wait for ~24 hrs before committing this.
> Separate QueueManager
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703489#comment-15703489
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703319#comment-15703319
]
Xuan Gong commented on YARN-5761:
-
rebase and fix the javadoc
> Separate QueueManager from Scheduler
>
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702756#comment-15702756
]
Daniel Templeton commented on YARN-5761:
I would really rather that we add the description for the
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702740#comment-15702740
]
Xuan Gong commented on YARN-5761:
-
bq. I think there are some java doc issues. Could u pls help to update
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690870#comment-15690870
]
Sunil G commented on YARN-5761:
---
Thanks [~xgong]. I think there are some java doc issues. Could u pls help to
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685281#comment-15685281
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684433#comment-15684433
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684234#comment-15684234
]
Xuan Gong commented on YARN-5761:
-
Thanks for the comments. [~sunilg]
Uploaded a new patch to address the
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678549#comment-15678549
]
Sunil G commented on YARN-5761:
---
Thanks [~xgong]. Sorry jumping in late.
Few comments
1.
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678425#comment-15678425
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678317#comment-15678317
]
Xuan Gong commented on YARN-5761:
-
Thanks for the review. [~templedf]
Uploaded a new patch to address all
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673900#comment-15673900
]
Daniel Templeton commented on YARN-5761:
Couple of comments
*
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672167#comment-15672167
]
Wangda Tan commented on YARN-5761:
--
Thanks [~xgong], +1 to latest patch.
UT failure is not related, it
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672118#comment-15672118
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671896#comment-15671896
]
Xuan Gong commented on YARN-5761:
-
Several testcase failures are related. Uploaded a new patch to fix the
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665630#comment-15665630
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665457#comment-15665457
]
Xuan Gong commented on YARN-5761:
-
Thanks for the review. [~jonathan_huang]. Uploaded a new patch to
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655868#comment-15655868
]
Jonathan Hung commented on YARN-5761:
-
This looks good, a few comments:
# We can probably put the
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652728#comment-15652728
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652664#comment-15652664
]
Xuan Gong commented on YARN-5761:
-
Uploaded a new patch to address all the previous comments.
[~mshen]
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648944#comment-15648944
]
Subru Krishnan commented on YARN-5761:
--
First up, +1 on the proposal but shouldn't we first close the
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645844#comment-15645844
]
Wangda Tan commented on YARN-5761:
--
Thanks [~xgong], overall approach looks good, some comments:
1)
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623112#comment-15623112
]
Hadoop QA commented on YARN-5761:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622973#comment-15622973
]
Xuan Gong commented on YARN-5761:
-
Fix the checkstyle issue
> Separate QueueManager from Scheduler
>
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593507#comment-15593507
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593349#comment-15593349
]
Xuan Gong commented on YARN-5761:
-
This patch applies for branch-2.
> Separate QueueManager from Scheduler
[
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592976#comment-15592976
]
Hadoop QA commented on YARN-5761:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
31 matches
Mail list logo
