[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-19 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054513#comment-16054513 ] Haibo Chen commented on YARN-6670: -- Yep, filed and linked YARN-6723 for further discussion of

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-19 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054487#comment-16054487 ] Karthik Kambatla commented on YARN-6670: I like the idea of making a decision based on the usage

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-12 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046882#comment-16046882 ] Haibo Chen commented on YARN-6670: -- IIUC, this effectively turns the overallocation threshold from being

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-12 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046813#comment-16046813 ] Miklos Szegedi commented on YARN-6670: -- It applies to both CPU and memory. Let's say we have a

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045614#comment-16045614 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045611#comment-16045611 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-10 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045571#comment-16045571 ] Haibo Chen commented on YARN-6670: -- To move things forward, maybe we could continue the discussion of your

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-10 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045570#comment-16045570 ] Haibo Chen commented on YARN-6670: -- [~miklos.szeg...@cloudera.com] NM_OVERALLOCATION_GENERAL_THRESHOLD

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-10 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045568#comment-16045568 ] Haibo Chen commented on YARN-6670: -- Thanks [~kkaranasos] for the review! I will update the patch to

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045359#comment-16045359 ] Miklos Szegedi commented on YARN-6670: -- Thanks for the patch [~haibochen]. Quick question. Usually the

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045272#comment-16045272 ] Konstantinos Karanasos commented on YARN-6670: -- Thanks for the patch, [~haibochen]. Two nits:

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045137#comment-16045137 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045041#comment-16045041 ] Karthik Kambatla commented on YARN-6670: +1, pending Jenkins. [~ kkaranasos] - do you want to take

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045024#comment-16045024 ] Haibo Chen commented on YARN-6670: -- Thanks [~kasha] for your review! I have updated the patch to address

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-09 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044961#comment-16044961 ] Karthik Kambatla commented on YARN-6670: Thanks for updating the patch, Haibo. Looks mostly good.

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041388#comment-16041388 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-07 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041240#comment-16041240 ] Haibo Chen commented on YARN-6670: -- Compilation failed because of web ui. Will retrigger the jenkins job.

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039910#comment-16039910 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-06 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039831#comment-16039831 ] Haibo Chen commented on YARN-6670: -- The patch is updated to address 1) and 2). In cases where the

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-06 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039597#comment-16039597 ] Haibo Chen commented on YARN-6670: -- Thanks [~kkaranasos] for your review! bq. The parameter names that

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037814#comment-16037814 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-05 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037812#comment-16037812 ] Konstantinos Karanasos commented on YARN-6670: -- Thanks for the patch, [~haibochen]. A couple

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-05 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037632#comment-16037632 ] Haibo Chen commented on YARN-6670: -- Filed YARN-6690 to consolidate the configs with ResourceTypes, and

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-05 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037483#comment-16037483 ] Haibo Chen commented on YARN-6670: -- Thanks [~kasha] for your review ! In ResourceTypes, a new class,

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-02 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035468#comment-16035468 ] Karthik Kambatla commented on YARN-6670: Couple of comments: # I think there is value in keeping

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-01 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033932#comment-16033932 ] Haibo Chen commented on YARN-6670: -- Findbug warnings are unrelated. Will update the patch to fix the

[jira] [Commented] (YARN-6670) Add separate NM overallocation thresholds for cpu and memory

2017-06-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033930#comment-16033930 ] Hadoop QA commented on YARN-6670: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||