[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054513#comment-16054513
]
Haibo Chen commented on YARN-6670:
--
Yep, filed and linked YARN-6723 for further discussion of
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054487#comment-16054487
]
Karthik Kambatla commented on YARN-6670:
I like the idea of making a decision based on the usage
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046882#comment-16046882
]
Haibo Chen commented on YARN-6670:
--
IIUC, this effectively turns the overallocation threshold from being
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046813#comment-16046813
]
Miklos Szegedi commented on YARN-6670:
--
It applies to both CPU and memory. Let's say we have a
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045614#comment-16045614
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045611#comment-16045611
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045571#comment-16045571
]
Haibo Chen commented on YARN-6670:
--
To move things forward, maybe we could continue the discussion of your
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045570#comment-16045570
]
Haibo Chen commented on YARN-6670:
--
[~miklos.szeg...@cloudera.com] NM_OVERALLOCATION_GENERAL_THRESHOLD
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045568#comment-16045568
]
Haibo Chen commented on YARN-6670:
--
Thanks [~kkaranasos] for the review! I will update the patch to
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045359#comment-16045359
]
Miklos Szegedi commented on YARN-6670:
--
Thanks for the patch [~haibochen]. Quick question. Usually the
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045272#comment-16045272
]
Konstantinos Karanasos commented on YARN-6670:
--
Thanks for the patch, [~haibochen].
Two nits:
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045137#comment-16045137
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045041#comment-16045041
]
Karthik Kambatla commented on YARN-6670:
+1, pending Jenkins. [~ kkaranasos] - do you want to take
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045024#comment-16045024
]
Haibo Chen commented on YARN-6670:
--
Thanks [~kasha] for your review! I have updated the patch to address
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044961#comment-16044961
]
Karthik Kambatla commented on YARN-6670:
Thanks for updating the patch, Haibo. Looks mostly good.
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041388#comment-16041388
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041240#comment-16041240
]
Haibo Chen commented on YARN-6670:
--
Compilation failed because of web ui. Will retrigger the jenkins job.
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039910#comment-16039910
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039831#comment-16039831
]
Haibo Chen commented on YARN-6670:
--
The patch is updated to address 1) and 2). In cases where the
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039597#comment-16039597
]
Haibo Chen commented on YARN-6670:
--
Thanks [~kkaranasos] for your review!
bq. The parameter names that
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037814#comment-16037814
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037812#comment-16037812
]
Konstantinos Karanasos commented on YARN-6670:
--
Thanks for the patch, [~haibochen].
A couple
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037632#comment-16037632
]
Haibo Chen commented on YARN-6670:
--
Filed YARN-6690 to consolidate the configs with ResourceTypes, and
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037483#comment-16037483
]
Haibo Chen commented on YARN-6670:
--
Thanks [~kasha] for your review !
In ResourceTypes, a new class,
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035468#comment-16035468
]
Karthik Kambatla commented on YARN-6670:
Couple of comments:
# I think there is value in keeping
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033932#comment-16033932
]
Haibo Chen commented on YARN-6670:
--
Findbug warnings are unrelated. Will update the patch to fix the
[
https://issues.apache.org/jira/browse/YARN-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033930#comment-16033930
]
Hadoop QA commented on YARN-6670:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
27 matches
Mail list logo