Re: [zones-discuss] Webrev for CR 6909222
Jordan Vaughan wrote: Maybe I'm not understanding the bug's evaluation but it seems to say that the problem is caused by the presence of boot archive files. Jerry Jerry, It is. However, bootadm(1M) infers the existence of boot archives from the existence of /boot/solaris/bin/create_ramdisk. If we remove the latter from a zone, then bootadm(1M) won't try to update boot archives in the zone's root filesystem. Changing package variants during ipkg p2v should remove /boot/solaris/bin/create_ramdisk and thus prevent bootadm(1M) from updating ipkg-branded zones' boot archives. Jordan, OK, thanks for the clarification. I just checked the pkg metadata and change-variant will work properly to address this: % pkg contents -m | egrep create_ramdisk file 5e6129cf9f1b34c37c0bd34c2c1feb841dbc9436 chash=0e9054d31e87beecb9eda2e28f70c1ab443ef878 group=sys mode=0555 opensolaris.zone=global owner=root path=boot/solaris/bin/create_ramdisk pkg.csize=5148 pkg.size=14675 variant.opensolaris.zone=global Thanks, Jerry ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On 01/ 4/10 10:25 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: On 01/ 4/10 09:54 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: On 01/ 4/10 07:26 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c [...] Jordan, I don't think so since the boot_archive files are not delivered by any pkg. Thus, there is nothing in the change-variant process which will touch those files. Thanks, Jerry /boot/solaris/bin/create_ramdisk is installed by SUNWckr, right? ---8<--- jv227347 arrakis [10:13:45 0]% pkg search /boot/solaris/bin/create_ramdisk INDEX ACTION VALUE PACKAGE path file boot/solaris/bin/create_ramdisk pkg:/sunwc...@0.5.11-0.79 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.108 [...] pkg:/sunw...@0.5.11-0.127 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.128 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.129 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.130 ---8<--- Will changing variants not affect SUNWckr? Jordan, Maybe I'm not understanding the bug's evaluation but it seems to say that the problem is caused by the presence of boot archive files. Jerry Jerry, It is. However, bootadm(1M) infers the existence of boot archives from the existence of /boot/solaris/bin/create_ramdisk. If we remove the latter from a zone, then bootadm(1M) won't try to update boot archives in the zone's root filesystem. Changing package variants during ipkg p2v should remove /boot/solaris/bin/create_ramdisk and thus prevent bootadm(1M) from updating ipkg-branded zones' boot archives. Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Jordan Vaughan wrote: On 01/ 4/10 09:54 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: On 01/ 4/10 07:26 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c [...] Jordan, I don't think so since the boot_archive files are not delivered by any pkg. Thus, there is nothing in the change-variant process which will touch those files. Thanks, Jerry /boot/solaris/bin/create_ramdisk is installed by SUNWckr, right? ---8<--- jv227347 arrakis [10:13:45 0]% pkg search /boot/solaris/bin/create_ramdisk INDEX ACTION VALUE PACKAGE path file boot/solaris/bin/create_ramdisk pkg:/sunwc...@0.5.11-0.79 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.108 [...] pkg:/sunw...@0.5.11-0.127 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.128 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.129 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.130 ---8<--- Will changing variants not affect SUNWckr? Jordan, Maybe I'm not understanding the bug's evaluation but it seems to say that the problem is caused by the presence of boot archive files. Jerry ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On 01/ 4/10 09:54 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: On 01/ 4/10 07:26 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c [...] Jordan, I don't think so since the boot_archive files are not delivered by any pkg. Thus, there is nothing in the change-variant process which will touch those files. Thanks, Jerry /boot/solaris/bin/create_ramdisk is installed by SUNWckr, right? ---8<--- jv227347 arrakis [10:13:45 0]% pkg search /boot/solaris/bin/create_ramdisk INDEX ACTION VALUE PACKAGE path file boot/solaris/bin/create_ramdisk pkg:/sunwc...@0.5.11-0.79 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.108 [...] pkg:/sunw...@0.5.11-0.127 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.128 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.129 path file boot/solaris/bin/create_ramdisk pkg:/sunw...@0.5.11-0.130 ---8<--- Will changing variants not affect SUNWckr? Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On 01/ 4/10 09:57 AM, Enda O'Connor wrote: Hi Jordan Not being too familiar with the underlying technology, I assume s10_boot.ksh is run every boot, as otherwise a patch can deliver create_ramdisk to the system after it's removed. Enda Correct. Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Jordan Vaughan wrote: On 12/23/09 12:40 AM, Frank Batschulat (Home) wrote: On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, we probably should update the s10container dev guide to point out that we remove $ZONEROOT/boot/solaris/bin/create_ramdisk and essentially disable bootarchive update within the s10 branded zone ? http://hub.opensolaris.org/bin/view/Community+Group+zones/s10brand_dev_guide there may be ISVs/OEMs that potentially add/change stuff there ? cheers frankB The developer guide is not the best place to post such notices. I don't know which document is most suitable or whether posting such a notice is worthwhile. Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org Hi Jordan Not being too familiar with the underlying technology, I assume s10_boot.ksh is run every boot, as otherwise a patch can deliver create_ramdisk to the system after it's removed. Enda -- Enda O'Connor x19781 Software Product Engineering Patch System Test : Ireland : x19781/353-1-8199718 ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Jordan Vaughan wrote: On 01/ 4/10 07:26 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, This looks ok to me but don't we need to do a similar fix for the ipkg brand since we can also do p2v with that brand? Can you file a bug to track that? Thanks, Jerry Hi Jerry, Thanks for reviewing my fix. Won't package variants solve the problem for the ipkg brand? Jordan, I don't think so since the boot_archive files are not delivered by any pkg. Thus, there is nothing in the change-variant process which will touch those files. Thanks, Jerry ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On 12/23/09 12:40 AM, Frank Batschulat (Home) wrote: On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, we probably should update the s10container dev guide to point out that we remove $ZONEROOT/boot/solaris/bin/create_ramdisk and essentially disable bootarchive update within the s10 branded zone ? http://hub.opensolaris.org/bin/view/Community+Group+zones/s10brand_dev_guide there may be ISVs/OEMs that potentially add/change stuff there ? cheers frankB The developer guide is not the best place to post such notices. I don't know which document is most suitable or whether posting such a notice is worthwhile. Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On 01/ 4/10 07:26 AM, Jerry Jelinek wrote: Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, This looks ok to me but don't we need to do a similar fix for the ipkg brand since we can also do p2v with that brand? Can you file a bug to track that? Thanks, Jerry Hi Jerry, Thanks for reviewing my fix. Won't package variants solve the problem for the ipkg brand? Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, This looks ok to me but don't we need to do a similar fix for the ipkg brand since we can also do p2v with that brand? Can you file a bug to track that? Thanks, Jerry ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
> On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan > wrote: > >> I need someone to review my fix for >> >> 6909222 reboot of system upgraded from 128 to build 129 generated error >> from an s10 zone due to boot-archive >> >> My webrev is accessible via >> >> http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, we probably should update the s10container dev guide to point out that we remove $ZONEROOT/boot/solaris/bin/create_ramdisk and essentially disable bootarchive update within the s10 branded zone ? http://hub.opensolaris.org/bin/view/Community+Group+zones/s10brand_dev_guide there may be ISVs/OEMs that potentially add/change stuff there ? cheers frankB ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Hi Frank, Thanks for reviewing my fix. Native-branded zones will disappear when Solaris Express dies (which should happen in a few builds); therefore, it isn't worthwhile to fix this problem for native-branded zones. No special script code is needed for ipkg-branded zones because IPS package variants will handle the problem. Yes, I added the same code to s10_boot.ksh in case administrators inadvertently resurrect create_ramdisk. However, your comment raises an issue: My fix won't prevent the mkisofs(8) error message in all cases. If a zone administrator somehow reinstalls create_ramdisk (say, through an update) without rebooting the zone, then if an administrator in the global zone updates boot archives via bootadm(1M), then the global zone administrator will see the mkisofs(8) error. This isn't a problem because the error is harmless and the aforementioned scenario will rarely occur. Thanks again for the review, Jordan On 12/22/09 07:06 AM, Frank Batschulat (Home) wrote: On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, looks good to me. what about /usr/lib/brand/ipkg/p2v and perhaps /usr/lib/brand/ipkg/pkgcreatezone for the ipkg brand ? and usr/src/lib/brand/native/zone/p2v.ksh and usr/src/lib/brand/native/zone/image_install.ksh for the native brand ? I'd assume that in the future running an s10u9 update for an s10u8 branded zone, could that potentially put back the ' /boot/solaris/bin/create_ramdisk' script but that'd be taken care of by the s10_boot.ksh then. cheers frankB ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan wrote: > I need someone to review my fix for > > 6909222 reboot of system upgraded from 128 to build 129 generated error > from an s10 zone due to boot-archive > > My webrev is accessible via > > http://cr.opensolaris.org/~flippedb/onnv-s10c Jordan, looks good to me. what about /usr/lib/brand/ipkg/p2v and perhaps /usr/lib/brand/ipkg/pkgcreatezone for the ipkg brand ? and usr/src/lib/brand/native/zone/p2v.ksh and usr/src/lib/brand/native/zone/image_install.ksh for the native brand ? I'd assume that in the future running an s10u9 update for an s10u8 branded zone, could that potentially put back the ' /boot/solaris/bin/create_ramdisk' script but that'd be taken care of by the s10_boot.ksh then. cheers frankB ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
Excellent suggestion. I'll update CR 6912451. Meanwhile, I removed the XXX comments and regenerated the webrev. Thanks, Jordan On 12/21/09 06:12 PM, Edward Pilatowicz wrote: i'd probably leave out the XXX comment and instead update 6912451 to mention that part of the fix for 6912451 would involve removing the fix for 6909222 (since it would essentially be obsoleting this fix.) ed On Mon, Dec 21, 2009 at 03:46:00PM -0800, Jordan Vaughan wrote: I need someone to review my fix for 6909222 reboot of system upgraded from 128 to build 129 generated error from an s10 zone due to boot-archive My webrev is accessible via http://cr.opensolaris.org/~flippedb/onnv-s10c Thanks, Jordan ___ zones-discuss mailing list zones-discuss@opensolaris.org ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
i'd probably leave out the XXX comment and instead update 6912451 to mention that part of the fix for 6912451 would involve removing the fix for 6909222 (since it would essentially be obsoleting this fix.) ed On Mon, Dec 21, 2009 at 03:46:00PM -0800, Jordan Vaughan wrote: > I need someone to review my fix for > > 6909222 reboot of system upgraded from 128 to build 129 generated > error from an s10 zone due to boot-archive > > My webrev is accessible via > > http://cr.opensolaris.org/~flippedb/onnv-s10c > > Thanks, > Jordan > ___ > zones-discuss mailing list > zones-discuss@opensolaris.org ___ zones-discuss mailing list zones-discuss@opensolaris.org
Re: [zones-discuss] Webrev for CR 6909222
The bug mentions that this can also impact a nevada zone that was p2v'ed. Should you fix usr/src/lib/brand/native/zone as well? -Steve On Mon, Dec 21, 2009 at 03:46:00PM -0800, Jordan Vaughan wrote: > I need someone to review my fix for > > 6909222 reboot of system upgraded from 128 to build 129 generated error > from an s10 zone due to boot-archive > > My webrev is accessible via > > http://cr.opensolaris.org/~flippedb/onnv-s10c > > Thanks, > Jordan > ___ > zones-discuss mailing list > zones-discuss@opensolaris.org ___ zones-discuss mailing list zones-discuss@opensolaris.org
