RE: [Zope-dev] Re: Call for testing (2.6.4 / 2.7.0)
> Before the Owned API was changed getOwner() did return the wrapped user, > now it returns the unwrapped user. If I replace getOwner() by the new > getWrappedOwner() all tests pass. > > I'm not sure what this line in getOwner() means: > > > return aq_base(self.getWrappedOwner()) # ugh, backward compat. > > > Looks like backward compatibility code that breaks backward compatibility. I think that's right. I checked in changes to all 3 branches that reverts the getOwner call to its original implementation (plus a deprecation warning for a case we want to get away from). I'm still tracking down what I hope is one final issue for rc2, but you should be able to update now and your original tests should pass. Brian Lloyd[EMAIL PROTECTED] V.P. Engineering 540.361.1716 Zope Corporation http://www.zope.com ___ Zope-Dev maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Features for Zope 2.8
On Thu, Jan 29, 2004 at 11:22:30AM +0100, Christian Theune wrote: > Hi. > > As Zope 2.7 looks like could-be-out-soon. I'd like to ask if there is > room for including the post-traverse patch in Zope 2.8. I'm currently > maintaining it as a patch on a branch for Zope 2.7, but would like to > see it back in the mainstream. (snip) > If this is feature could be a candidate for 2.8, i'll write a more > in-depth proposal on it, and can provide the necessary code. I would like this feature. The lack of context when an AccessRule is triggered has frustrated me at times. -- Paul Winkler http://www.slinkp.com Look! Up in the sky! It's MEAT-EATING FOOT TAXI DRIVER! (random hero from isometric.spaceninja.com) ___ Zope-Dev maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Call for testing (2.6.4 / 2.7.0)
Hi! Casey Duncan wrote: These tests seem pretty naive. I don't thing user objects promise to compare to one another in any way. Looks to me like the tests should be changed to something like: self.failUnless(f.getOwner() is ownership) That's not the problem. I had a closer look at this: Before the Owned API was changed getOwner() did return the wrapped user, now it returns the unwrapped user. If I replace getOwner() by the new getWrappedOwner() all tests pass. I'm not sure what this line in getOwner() means: return aq_base(self.getWrappedOwner()) # ugh, backward compat. Looks like backward compatibility code that breaks backward compatibility. Cheers, Yuppie ___ Zope-Dev maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Features for Zope 2.8
Hi. As Zope 2.7 looks like could-be-out-soon. I'd like to ask if there is room for including the post-traverse patch in Zope 2.8. I'm currently maintaining it as a patch on a branch for Zope 2.7, but would like to see it back in the mainstream. Short description of it: - Sometimes you want to run code before the published object as in the before_traverse hooks. But there youmiss to variables: The object to be published and security context. - During traversal you can register yourself to be called after those two variables have been determined. Thisresults in a chain of methods to be callen. - When the methods are callen, they get the necessary contexts and can return None (everything as usual) orreturn something else, that should be used for publication instead of the object that was found by traversal. (Note: I intended it that the REQUEST['PUBLISHED'] remains the one found bytraversal.) This also discontinues the chain of post traversal calls. If this is feature could be a candidate for 2.8, i'll write a more in-depth proposal on it, and can provide the necessary code. Cheers, Christian -- Christian Theune, gocept gmbh & co. kg http://www.gocept.com - [EMAIL PROTECTED] fon: 03496 3099112 fax: 03496 3099118 mobile: 0179 7808366 signature.asc Description: Dies ist ein digital signierter Nachrichtenteil ___ Zope-Dev maillist - [EMAIL PROTECTED] http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
