Re: [Zope-dev] New Zope 3 name: BlueBream

2010-01-05 Thread Souheil CHELFOUH
I like Bream. BlueBream or Blue Bream.
Just change the name Zope3 so we get over it eventually.
I'm a "zope3" user btw !

2010/1/5 Lennart Regebro :
> On Tue, Jan 5, 2010 at 16:55, Gediminas Paulauskas  wrote:
>> If we released "Zope 3 the web framework" as version 3.5, little would
>> change for existing Zope 3 users since it still includes all zope.app
>> packages with backward compatibility imports. Wasn't this the plan
>> last year? I see no more confusion than was before, only less. The
>> reasons mentioned here are now false, because Zope 3.5 is based on
>> ZTK, Zope 2.12 is based on ZTK, and Grok is based on ZTK. Explanations
>> written at http://download.zope.org/zope3.4/ are still true, and after
>> renaming some occurrences of "Zope 3" to ZTK, Zope 3.5 KGS would be
>> the same "Zope 3" thing as Zope 3.4 was.
>
> Absolutely. But the confusion between Zope 3 and Zope 2 persists.
> Renaming Zope 3 in to "Bream" or "Blue Bream" or "BlueBream" (see
> there, a good reason for just "Bream") gets rid of that confusion. I
> don't think corporate people in general has a problem with renaming.
> Renaming would also partly circumvent the "Oh no zope" reaction that
> you *still* get from Python people, and which is almost exclusively
> based on the unpythonishness of Zope 2.
>
> I'm not a Zope 3 developer, so I explicitly do not vote, as I don't
> think I should have a say. :-) But I think a renaming would be
> benefinial.
>
> But in the end this is yet another "non-decision".  It is up to
> whoever makes a Zope 3.5 KGS. If, for example, Baiju and Stephan
> decides they want to do that, and they decide they want to call it
> "Bream", then Bream it is. If say, Jan and Gediminas makes a 3.5 KGS,
> and they don't want to rename it, then it will still be called "Zope".
> In fact, it's perfectly possible to do both, but that *would* be
> confusing as then Bream in fact would become a Zope 3 fork, not a new
> name for Zope 3, so that would probably be less than ideal.
>
> There is also the absolute possibility that no 3.5 KGS ever happens,
> in which case this discussion is moot.
>
> So: Talk less, do more. ;-)
>
> --
> Lennart Regebro: Python, Zope, Plone, Grok
> http://regebro.wordpress.com/
> +33 661 58 14 64
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.app.authentication

2010-01-22 Thread Souheil CHELFOUH
Hello guys,

I'm coding some stuff, using zope.app.authentication and this package
appears to do too many things, in my opinion.
Would it be wise to cut off some of the functionalities ? The pure PAU
components could go in a dedicated package, like
zope.pluggableauthservice
The whole handling of principals, groups and folder makes it a bit
hard to read and introduces a lot of redundancy if we wish to roll our
own things.
What do you guys think ?

Cheers
- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.authentication

2010-01-22 Thread Souheil CHELFOUH
I don't think so. The PAU is quite a big chunk and would really
deserve to live on its own piece of land.
zope.authentication is really about the authentication basics, not all
the pluggability and plugin that PAU brings in.
zope.app.authentication is just too confuse as it defines PAU and a
whole set of persistent authentication-relatied components and other
things that could be easily (logically) cut off.

2010/1/22 Hanno Schlichting :
> On Fri, Jan 22, 2010 at 7:59 PM, Souheil CHELFOUH  wrote:
>> I'm coding some stuff, using zope.app.authentication and this package
>> appears to do too many things, in my opinion.
>> Would it be wise to cut off some of the functionalities ? The pure PAU
>> components could go in a dedicated package, like
>> zope.pluggableauthservice
>
> I don't have a good understanding of any of the security related
> features of Zope 3, but it looks like we already have a lot of
> packages. Would it make sense to put it into any of the existing ones?
>
> There's at least:
>
> zope.authentication
> zope.login
> zope.password
> zope.principalannotation
> zope.principalregistry
> zope.security
> zope.securitypolicy
>
> Hanno
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.authentication

2010-01-26 Thread Souheil CHELFOUH
Hello,

I took the liberty to start the work by a first simple move :
splitting apart what is "strictly" about PAU's core and the rest.
PAU and some plugins have been put in :
http://svn.zope.org/repos/main/zope.pluggableauth/trunk/

The rest has been kept in:
http://svn.zope.org/repos/main/zope.app.authentication/branches/zope.pluggableauth-trollfot/

The tests pass and nothing has been changed but the imports.

I people could already give me their feelings about it, it would be
very constructive.
There is still a lot of code that might need work. My concern was
about the factories and the events.
They look unnecessary to me in the core. I'm not sure, however, that
people want to split that part.

I hope to get some feedback so I can go on with the work and not lose
the current momentum.

- Souheil

2010/1/26 Christian Theune :
> On 01/22/2010 07:59 PM, Souheil CHELFOUH wrote:
>> Hello guys,
>>
>> I'm coding some stuff, using zope.app.authentication and this package
>> appears to do too many things, in my opinion.
>> Would it be wise to cut off some of the functionalities ? The pure PAU
>> components could go in a dedicated package, like
>> zope.pluggableauthservice
>> The whole handling of principals, groups and folder makes it a bit
>> hard to read and introduces a lot of redundancy if we wish to roll our
>> own things.
>> What do you guys think ?
>
> Yeah, I think it would be nice to give that code a refactoring. Whenever
> I work with it I feel the urge to do so.
>
> There's also subtle API annoyances that I'd like to get rid of but don't
> remember exactly right now.
>
> How about a specific proposal?
>
> Christian
>
> --
> Christian Theune · c...@gocept.com
> gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
> http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
> Zope and Plone consulting and development
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.authentication

2010-01-26 Thread Souheil CHELFOUH
Christian,

I hear you and understand you.
I'm not advertizing for an immediate and brainless action.
What I did this week end is simply to split the PAU from all the
components provided with it (well, most of it).
That was motivated by my current work and by the will to see the
dependencies become cleaner and the code shorter.
I understand that the momentum is not everything, but when I can
dedicate myself to a task, be motivated by it and paid for it, then, I
don't see any reasons to hold back ;-)
In this case, I'll just wait for your feedbacks, zope devs, and we'll
take the time (obviously) to do the things correctly.

Let me know what you guys think, about what has to be done, when you can
- Souheil

2010/1/26 Christian Theune :
> Hi,
>
> On 01/26/2010 09:06 AM, Souheil CHELFOUH wrote:
>> Hello,
>>
>> I took the liberty to start the work by a first simple move :
>> splitting apart what is "strictly" about PAU's core and the rest.
>> PAU and some plugins have been put in :
>> http://svn.zope.org/repos/main/zope.pluggableauth/trunk/
>>
>> The rest has been kept in:
>> http://svn.zope.org/repos/main/zope.app.authentication/branches/zope.pluggableauth-trollfot/
>>
>> The tests pass and nothing has been changed but the imports.
>>
>> I people could already give me their feelings about it, it would be
>> very constructive.
>> There is still a lot of code that might need work. My concern was
>> about the factories and the events.
>> They look unnecessary to me in the core. I'm not sure, however, that
>> people want to split that part.
>>
>> I hope to get some feedback so I can go on with the work and not lose
>> the current momentum.
>
> As Martijn left the steering group, we're currently in discussions on
> how to proceed internally.
>
> One thing I'd like to mention here is that we do need to be careful
> balancing momentum with other qualities of the work we do: you want
> feedback and I'd like to give feedback. I can't drop the regular work I
> do on the spot for that though.
>
> And I think architectural changes don't need to be implemented within
> days or weeks.
>
> Christian
>
> --
> Christian Theune · c...@gocept.com
> gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
> http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
> Zope and Plone consulting and development
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.app.authentication

2010-01-26 Thread Souheil CHELFOUH
Well, the first step is already to cut the dependencies and get a sane
tree and a reusable package.
The second step, however, if people feel like it, will be to refactor
a bit and _that_ will need careful planning, yes.
But, one thing at a time :)

However, I'll polish a bit zope.plugabbleauth and it will be eligible
for a release, I guess.

2010/1/26 Christian Theune :
> Hi,
>
> On 01/26/2010 03:02 PM, Jan-Wijbrand Kolman wrote:
>> Hi,
>>
>>
>> Just my quick 2 euro cents here:
>>
>> As far as I can tell, what Souheil did so far is no architectural change, 
>> but a
>> change like so many in the recent past where a zope.app.something package has
>> been refactored into a zope.something package and keeping backwards
>> compatibility in zope.app.something.
>>
>> I'm not sure how this became looking way bigger than it is, except for the
>> explicit requests for feedback by Souheil. He requested feedback, I guess, 
>> as he
>> might not yet be completely confident about making these changes and needs 
>> some
>> support - I can fully understand that myself.
>
> Thanks for stepping in -- in addition to Martijn whose ghost is now
> haunting me ... ;)
>
> I think there's a communication problem here. I was asserting something
> about slowing down architectural changes in general but also having the
> feeling that he's talking about architectural changes and thus asking
> for feedback. So Souheil naturally kept running with that ...
>
> Then I went off and talked about stuff I imagine "could happen" while
> doing architectural changes anyway ... so that's how it gre.
>
> So I guess I should be writing a proposal for that stuff.
>
> If it's a pure dependency refactoring, well then, that's what we already
> all agreed about. Isn't it?
>
> Christian
>
> --
> Christian Theune · c...@gocept.com
> gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
> http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
> Zope and Plone consulting and development
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Releasing Zope packages

2010-02-05 Thread Souheil CHELFOUH
Hello,

I'm about to release zope.pluggableauth.
Is there a comprehensive documentation listing all the needed steps ?
As I don't want to miss my first zope release, I'd like to be sure.
For instance, the headers specify "A copy of the ZPL should accompany
this distribution.", though i never saw this ZPL doc inside any of the
zope.* packages.
I don't want to delay this for too long, so I'll eagerly wait for your answers.

- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Releasing Zope packages

2010-02-05 Thread Souheil CHELFOUH
That is already OK, i meant something more... legal ?
About the headers, the licence, etc.
This is where I really don't want to screw up

2010/2/5 Baiju M :
> On Fri, Feb 5, 2010 at 7:57 PM, Souheil CHELFOUH  wrote:
>> Hello,
>>
>> I'm about to release zope.pluggableauth.
>> Is there a comprehensive documentation listing all the needed steps ?
>
> http://docs.zope.org/zopetoolkit/process/releasing-software.html
>
> Regards,
> Baiju M
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Reminder : zope.app.authentication

2010-02-05 Thread Souheil CHELFOUH
I worked last month on the package `zope.app.authentication` that is
still very monolithic.
As a first step to refactor it and in order to cut dependencies, I
created and released the pluggable auth utility in a standalone
package : http://pypi.python.org/pypi/zope.pluggableauth
This package, now, has to be used by zope.app.authentication. I did
that in a branch :
http://svn.zope.org/repos/main/zope.app.authentication/branches/zope.pluggableauth-trollfot/
Everything work as expected. I only removed what now lies in
zope.pluggableauth and used import to preserve the backward
compatibility.
I didn't remove or alter any tests, only to adapt the __repr__ of some
classes that are now moved.
Everything seems OK for a release.

So, the following steps would be : merge the branch with the trunk, if
there no complains. Then, release the new trunk as a 3.7.0 version.

Any feedback or insight is welcome.
If it's possible, I like to get the ownership on the
zope.app.authentication so I can proceed with the release.

Thank you
- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] How to use Tramline

2010-02-05 Thread Souheil CHELFOUH
You could try the hurry.file package, by Martijn Faassen.
It will get you started with both a file item and a Trameline support.
If you use Grok and if you deploy using WSGI, then, I can also point
you toward gp.fileupload
it's a WSGI middleware that will do exactly what you want. it's much
easier to setup than trameline.
Visit #Grok for more details, if you need specific Grok help.

- Souheil

2010/2/5 Hannes :
> Hi Zopers,
>
> I want to get Tramline working, but I definitely need your help! The
> documentation on this is not complete at all
>
> Maybe someone can give me some (more) complete stuff about:
>
> - Do I need to inherit from some Tramline class to use it? I saw
> something like TramlineBase, but I couldn't find that class in the
> Tramline sources
>
> - a short step-by-step guide, starting with
>    (1) form submission
>    (2) how do I get the "remote file path"?
>    (3) how does it work with the two directories "repository" and
> "upload". Is this done automatically?
>    (4) how do I actually store the "file ID" in the ZODB? (I want to
> store the uploaded files on the filesystem, not inside ZODB)
>
> I already read the stuff about attTramline from Plone and the HurryFile
> documentation, but I didn't understood it.
>
> By the way, I'm working with Grok, but there was nobody who could help
> me
>
>
> thanks a lot in advance.
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Reminder : zope.app.authentication

2010-02-08 Thread Souheil CHELFOUH
it's `trollfot`
Thank you :)

2010/2/8 Michael Howitz :
> Am 05.02.2010 um 17:31 schrieb Souheil CHELFOUH:
> [...]
>> If it's possible, I like to get the ownership on the
>> zope.app.authentication so I can proceed with the release.
>
> What's your pypi-name?
>
>
> Yours sincerely,
> --
> Michael Howitz · m...@gocept.com · software developer
> gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
> http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
> Zope and Plone consulting and development
>
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] RFC: Making zope.i18nmessageid an optional dependency of zope.schema

2010-02-23 Thread Souheil CHELFOUH
It looks good. But, the try/except and instanciation of the
MessageFactory could be done only once, in the __init__ of the package
for instance. That would be a central place to change it and to import
from.

2010/2/23 Stephan Richter :
> On Tuesday 23 February 2010, Tres Seaver wrote:
>>   In order to make zope.schema more useful outside of Zope, I would like
>> to make the dependency on zope.i18nmessageid optional.  I have checked
>> in a branch which does this:
>>
>>   http://svn.zope.org/zope.schema/branches/tseaver-optional_i18nmessageid
>>
>> Objections?
>>
>
> The changes look good.
>
> Regards,
> Stephan
> --
> Entrepreneur and Software Geek
> Google me. "Zope Stephan Richter"
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Zope3 sessions and database conflicts

2010-03-04 Thread Souheil CHELFOUH
Could you please, Kevin, explain how you acheived that ?

Thank you
- Souheil

2010/3/4 kevin gill :
>> Hi,
>> For quite some time I see messages like this in my z3.log:
>>
>> 2010-03-02T16:27:14 WARNING ZopePublication Competing writes/reads
>> at
>> /BSPSite/act/++vh++http:zis.act.at:80/bankneu/++/images/sponsor_logo.png:
>> database conflict error (oid 0x063f, class BTrees.OOBTree.OOBucket, serial
>> this txn started with 0x038484dc7d5ac044 2010-03-02 14:52:29.379960,
>> serial
>> currently committed 0x038484ff3c6b5455 2010-03-02 15:27:14.160763)
>>
>> I followed an advice from the zope-dev list and added some debug messages
>> in
>> ZODB.Connection.py where the objects are registered for writing.
>>
>> The following debug messages (I print the key/values of the object in
>> question) occur before and after the database conflict error:
>>
>> ---
>> 2010-03-02T16:27:14 DEBUG zbsp keys:
>> ['6ZZzgjNK0p.bIIlruXb4JkDo-T0J-XipPcVFGtcj0
>> LH6dMdI9akYvg', . , '7MmOPQOlkAHoa3T
>> nydH9IIgKBqoVyn3Q.yH6OXJeLj7epObIy3M5Lg']
>> ---
>> 2010-03-02T16:27:14 DEBUG zbsp values: [> object at 0x43723bec>, > 0x4372356c>, ,
>> .
>> ,
>> ,
>> > 0x43640b6c>,]
>> ---
>>
>> So it seems these are the session data containers.
>>
>> I wonder why they are written? Perhaps this happens when somebody else is
>> logging into the system (so a new session is added) and others are
>> concurrently reading from the session? However, this would mean that the
>> session mechanism has a flaw, as this is a standard procedure?
>>
>> Any ideas of how to fix this?
>
> I had a serious problem with the session machinery.
>
> I use a very long timeout on sessions and thus have a large number of
> sessions saved (up to 30k). The sweep machinery kicks in and sweeps
> everything. It takes so long that all the threads do the sweep and you get
> these errors.
>
> I customised the sweep for my site as follows:
>
> 1. Only sweep at night
> 2. Sweep a random subset of the data (20 records), but sweep very often
> 3. Different timeouts for authenticated sessions and anonymous sessions.
>
> Regards,
>
> Kevin
>
>
>>
>> Best Regards,
>> Hermann
>>
>> --
>> herm...@qwer.tk
>> GPG key ID: 299893C7 (on keyservers)
>> FP: 0124 2584 8809 EF2A DBF9  4902 64B4 D16B 2998 93C7
>> ___
>> Zope-Dev maillist  -  zope-...@zope.org
>> https://mail.zope.org/mailman/listinfo/zope-dev
>> **  No cross posts or HTML encoding!  **
>> (Related lists -
>>  https://mail.zope.org/mailman/listinfo/zope-announce
>>  https://mail.zope.org/mailman/listinfo/zope )
>>
>>
>>
>
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.lifecycleevent dependencies

2013-04-17 Thread Souheil CHELFOUH
Hello all,

I've been poking the dependencies of several zope packages and it appears
that :

zope.interface >= 4.0 contains IObjectEvent and its implementation
ObjectEvent
zope.component >= 4.0 contains import of IObjectEvent and ObjectEvent
zope.lifecycleevent >= 4.0 imports IObjectEvent and ObjectEvent from
zope.component, and doesn't import anything else from this package, only in
the tests.

We could free zope.lifecycleevent from the zope.component dependency,
making it a test dependency only

- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.lifecycleevent dependencies

2013-04-23 Thread Souheil CHELFOUH
pull requested.


2013/4/17 Tres Seaver 

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 04/17/2013 11:59 AM, Souheil CHELFOUH wrote:
> > Hello all,
> >
> > I've been poking the dependencies of several zope packages and it
> > appears that :
> >
> > zope.interface >= 4.0 contains IObjectEvent and its implementation
> > ObjectEvent zope.component >= 4.0 contains import of IObjectEvent and
> > ObjectEvent zope.lifecycleevent >= 4.0 imports IObjectEvent and
> > ObjectEvent from zope.component, and doesn't import anything else from
> > this package, only in the tests.
> >
> > We could free zope.lifecycleevent from the zope.component dependency,
> > making it a test dependency only
>
> +1.
>
>
> Tres.
> - --
> ===
> Tres Seaver  +1 540-429-0999  tsea...@palladion.com
> Palladion Software   "Excellence by Design"http://palladion.com
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with undefined - http://www.enigmail.net/
>
> iEYEARECAAYFAlFu7FsACgkQ+gerLs4ltQ5oRACeK73oh/ihQznzvx/JfZIRZYPI
> rREAoL96RAeVFu4S86Hi/OSCdO4vS70u
> =DzI1
> -END PGP SIGNATURE-
>
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zmi_views menu in zope.dublincore

2010-06-06 Thread Souheil CHELFOUH
I totally agree. I ran into that not later than friday and I thought the same.

2010/6/6 Ilshad Khabibullin :
> Hi,
>
> zope/dublincore/browser/configure.zcml uses zmi_views menu.
> Then if we use zope.dublincore (and it is great package) then we need
> zope.app.zcmlfiles and many other zope.app.* packages.
>
> I think it's wrong.
>
> Your opinions?
>
> If we really need this, may be just remove 
> from zope.dublincore ?...
>
> --
> Ilshad R. Khabibullin
> http://astoon.zwiki.org
> +7 922 600 56 06
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Persistent principal folder?

2010-08-23 Thread Souheil CHELFOUH
The code you're interested in is in dolmen.authentication,
dolmen.app.x are UI packages

2010/8/23 Michael Howitz :
> Am 21.08.2010 um 00:11 schrieb Vincent Fretin:
> [...]
>> Hi,
>>
>> Souheil Chelfouh initially extracted the pluggable auth utility from
>> zope.app.authentication to zope.pluggableauth to not have all the
>> browser views and this principalfolder implementation.
>> In Dolmen http://www.dolmen-project.org/ (set of libraries you can use
>> with Grok to build a small CMS), we have our own principal folder
>> plugin implementation
>> http://pypi.python.org/pypi/dolmen.app.authentication which is based
>> on dolmen.authentication and zope.pluggableauth.
>
> Hi,
>
> I looked at dolmen.app.authentication, but it contains UI code, too and it 
> has many grok resp. dolmen dependencies, so it is not really better than 
> zope.app.authentication for my use case.
>
>> And you have an example of a User content type in:
>> http://gitweb.dolmen-project.org/menhir.contenttype.user.git
>
> Same here.
>
>
> Yours sincerely,
> --
> Michael Howitz · m...@gocept.com · software developer
> gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
> http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
> Zope and Plone consulting and development
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] changes in zope.app.wsgi

2010-11-12 Thread Souheil CHELFOUH
That would ve very welcome, I'd have a real use for such features.


2010/11/12 Jan-Jaap Driessen :
> On the trunk of zope.app.wsgi I added functionality for injecting WSGI
> middleware to tests using zope.app.wsgi.testlayer.BrowserLayer.
>
> I'd like to release these changes as version 3.10, unless someone disagrees.
>
> Thanks,
>
> --
> Jan-Jaap Driessen
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.schema validation can create read/write conflicts

2010-12-22 Thread Souheil CHELFOUH
Hello,

I've been experiencing, for quite some time, now, read/write conflicts
in my projects.
I've decided to hunt the problem down and it brought me down to the
field validation in zope.schema.

My use case is the following :

class SomeAdapter(object):
   my_object = FieldProperty(ISomeInterface['my_object'])

   def __init__(self, context):
   self.my_object = context


If "my _object" from ISomeInterface is an Object field and has a
'schema' property, zope.schema will validate it.
The validation code writes an attribute on the value that is being
validated and therefore can create a read/write error.

The incriminated code is here :
http://svn.zope.org/zope.schema/trunk/src/zope/schema/_field.py?rev=111614&r1=110535&r2=111614

In my case, the value was an OOBTree and that caused a lot of read/write errors.
Can we do something about this validation code ?
Could it be a possible solution to change the "__validating_schema"
attribute into a _v_ attribute, to avoid the persistency ?

Thank you for reading me.

- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.schema validation can create read/write conflicts

2010-12-24 Thread Souheil CHELFOUH
Done and commited.
If anyone can and want to release, it's ready.

2010/12/23 Tres Seaver :
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 12/22/2010 05:48 PM, Souheil CHELFOUH wrote:
>> Hello,
>>
>> I've been experiencing, for quite some time, now, read/write conflicts
>> in my projects.
>> I've decided to hunt the problem down and it brought me down to the
>> field validation in zope.schema.
>>
>> My use case is the following :
>>
>> class SomeAdapter(object):
>>    my_object = FieldProperty(ISomeInterface['my_object'])
>>
>>    def __init__(self, context):
>>        self.my_object = context
>>
>>
>> If "my _object" from ISomeInterface is an Object field and has a
>> 'schema' property, zope.schema will validate it.
>> The validation code writes an attribute on the value that is being
>> validated and therefore can create a read/write error.
>>
>> The incriminated code is here :
>> http://svn.zope.org/zope.schema/trunk/src/zope/schema/_field.py?rev=111614&r1=110535&r2=111614
>>
>> In my case, the value was an OOBTree and that caused a lot of read/write 
>> errors.
>> Can we do something about this validation code ?
>> Could it be a possible solution to change the "__validating_schema"
>> attribute into a _v_ attribute, to avoid the persistency ?
>>
>> Thank you for reading me.
>
> +1.
>
>
> Tres.
> - --
> ===
> Tres Seaver          +1 540-429-0999          tsea...@palladion.com
> Palladion Software   "Excellence by Design"    http://palladion.com
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk0ShsAACgkQ+gerLs4ltQ5jyACgjEN4G3aHYJeNapNX/1cZxnwD
> 60cAn0dhsk02xG3KO7YhdRjippbCqrc8
> =rs5b
> -END PGP SIGNATURE-
>
> ___
> Zope-Dev maillist  -  zope-...@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Work on the zope.publisher components and their genericity

2011-03-24 Thread Souheil CHELFOUH
Hello,

I've been working a lot on zope.publisher lately, trying to extract
its essence to make my own publisher and flatten the publication
process.
This led me to the prototyping of some essential components I wanted
to factor out of zope.publisher.
Mainly, these are definitions, aka interfaces, therefore I created
some new entries in zope.browser.

Here are the changelogs :

Added definitions to the base browser publishing process, including :

  * IRequest and IResponse
  * IPublisher
  * Errors definitions with : IPublishingError, IBadRequest, INotFound
and IRedirect
  * Views publishing help : IDefaultViewName, that permits to retrieve
the name of the default view for a context.

This allows us to move toward a greater interoperability with other
systems, severing a lot of zope packages' ties with ``zope.publisher``,
where all these concepts were initially defined. ``zope.publisher`` will
now use these interfaces as mixins to create zope publication
specific definitions. Components that don't need the full blow
definition can now register on broader interfaces, making them
available to non ``zope.publisher`` aware applications.


I would like very much to see that review and criticized constructively.
zope.browser hosts some irrelevant definitions and i added things I
thought would make sense.
The next step would be to lighten the dependencies of some zope
component on zope.publisher.
If possible, i'd like to see this 1.4 released.

Thank you for your attention
- Souheil
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Work on the zope.publisher components and their genericity

2011-03-24 Thread Souheil CHELFOUH
Thank you for taking the time to answer, Jim.

The work, according to its descriptive nature, was done on the trunk.
I can revert the change and make a branch, if that's more appropriate
for this kind of evolution.
No problem.

- Souheil

2011/3/24 Jim Fulton :
> On Thu, Mar 24, 2011 at 12:17 PM, Souheil CHELFOUH  wrote:
>> Hello,
>>
>> I've been working a lot on zope.publisher lately, trying to extract
>> its essence to make my own publisher and flatten the publication
>> process.
>> This led me to the prototyping of some essential components I wanted
>> to factor out of zope.publisher.
>> Mainly, these are definitions, aka interfaces, therefore I created
>> some new entries in zope.browser.
>>
>> Here are the changelogs :
>>
>> Added definitions to the base browser publishing process, including :
>>
>>  * IRequest and IResponse
>>  * IPublisher
>>  * Errors definitions with : IPublishingError, IBadRequest, INotFound
>>    and IRedirect
>>  * Views publishing help : IDefaultViewName, that permits to retrieve
>>    the name of the default view for a context.
>>
>> This allows us to move toward a greater interoperability with other
>> systems, severing a lot of zope packages' ties with ``zope.publisher``,
>> where all these concepts were initially defined. ``zope.publisher`` will
>> now use these interfaces as mixins to create zope publication
>> specific definitions. Components that don't need the full blow
>> definition can now register on broader interfaces, making them
>> available to non ``zope.publisher`` aware applications.
>>
>>
>> I would like very much to see that review and criticized constructively.
>
> Is there a branch to review?
>
>> zope.browser hosts some irrelevant definitions and i added things I
>> thought would make sense.
>> The next step would be to lighten the dependencies of some zope
>> component on zope.publisher.
>> If possible, i'd like to see this 1.4 released.
>>
>> Thank you for your attention
>
> Thanks for digging into this.  I'd be happy to do a review and give some
> feedback.
>
> Jim
>
>
> --
> Jim Fulton
> http://www.linkedin.com/in/jimfulton
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Work on the zope.publisher components and their genericity

2011-03-24 Thread Souheil CHELFOUH
Here lies the branch:
http://svn.zope.org/repos/main/zope.browser/branches/publisher_definition/

Changes have been rolled back accordingly.
Cheers

- Souheil

2011/3/24 Jim Fulton :
> On Thu, Mar 24, 2011 at 4:14 PM, Souheil CHELFOUH  wrote:
>> Thank you for taking the time to answer, Jim.
>>
>> The work, according to its descriptive nature, was done on the trunk.
>> I can revert the change and make a branch, if that's more appropriate
>> for this kind of evolution.
>> No problem.
>
> Please do. Thanks.
>
> Jim
>
> --
> Jim Fulton
> http://www.linkedin.com/in/jimfulton
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zope.traversing/trunk/s Standard cleanup :

2011-03-25 Thread Souheil CHELFOUH
zope.browserpage is included in the configure.zcml of the "browser" module.
Should we introduce "browser-only" dependencies, for this module, by
adding a 'browser' section in the setup.py requires ?
That would permit people that don't use the "browser" module to have
lighter dependencies, but, at the same time, it's a bit opaque at
first glance.

2011/3/25 Souheil CHELFOUH :
> Log message for revision 121128:
>  Standard cleanup :
>    - Removed unused imports
>    - Removed unused dependency on zope.tal
>    - Added missing dependency on zope.browserpage
>    - Cosmetics including pep8 normalization
>
>
>
> Changed:
>  U   zope.traversing/trunk/setup.py
>  U   zope.traversing/trunk/src/zope/traversing/adapters.py
>  U   zope.traversing/trunk/src/zope/traversing/api.py
>  U   zope.traversing/trunk/src/zope/traversing/browser/absoluteurl.py
>  U   zope.traversing/trunk/src/zope/traversing/browser/interfaces.py
>  U   zope.traversing/trunk/src/zope/traversing/browser/tests.py
>  U   zope.traversing/trunk/src/zope/traversing/namespace.py
>  U   zope.traversing/trunk/src/zope/traversing/publicationtraverse.py
>  U   zope.traversing/trunk/src/zope/traversing/testing.py
>
> -=-
> Modified: zope.traversing/trunk/setup.py
> ===
> --- zope.traversing/trunk/setup.py      2011-03-25 16:29:46 UTC (rev 121127)
> +++ zope.traversing/trunk/setup.py      2011-03-25 17:06:56 UTC (rev 121128)
> @@ -36,28 +36,30 @@
>       packages=find_packages('src'),
>       package_dir = {'': 'src'},
>       namespace_packages=['zope',],
> -      extras_require = dict(test=['zope.browserpage',
> -                                  'zope.browserresource[zcml]>=3.12',
> -                                  'zope.component[zcml]',
> -                                  'zope.configuration',
> -                                  'zope.container',
> -                                  'zope.pagetemplate',
> -                                  'zope.security[zcml]>=3.8',
> -                                  'zope.site',
> -                                  'zope.tal >= 3.5.0',
> -                                  'zope.testing',
> -                                  'ZODB3',
> -                                  ]),
> -      install_requires=['setuptools',
> -                        'zope.component',
> -                        'zope.i18n',
> -                        'zope.i18nmessageid',
> -                        'zope.interface',
> -                        'zope.proxy',
> -                        'zope.publisher',
> -                        'zope.security',
> -                        'zope.location>=3.7.0',
> -                        ],
> +      extras_require = dict(test=[
> +          'ZODB3',
> +          'zope.annotation',
> +          'zope.browserresource[zcml]>=3.12',
> +          'zope.component[zcml]',
> +          'zope.configuration',
> +          'zope.container',
> +          'zope.pagetemplate',
> +          'zope.security[zcml]>=3.8',
> +          'zope.site',
> +          'zope.testing',
> +          ]),
> +      install_requires=[
> +          'setuptools',
> +          'zope.browserpage',
> +          'zope.component',
> +          'zope.i18n',
> +          'zope.i18nmessageid',
> +          'zope.interface',
> +          'zope.location>=3.7.0',
> +          'zope.proxy',
> +          'zope.publisher',
> +          'zope.security',
> +          ],
>       include_package_data = True,
>       zip_safe = False,
>       )
>
> Modified: zope.traversing/trunk/src/zope/traversing/adapters.py
> ===
> --- zope.traversing/trunk/src/zope/traversing/adapters.py       2011-03-25 
> 16:29:46 UTC (rev 121127)
> +++ zope.traversing/trunk/src/zope/traversing/adapters.py       2011-03-25 
> 17:06:56 UTC (rev 121128)
> @@ -16,19 +16,18 @@
>  from types import StringTypes
>
>  import zope.interface
> -import zope.component
>
>  from zope.location.interfaces import ILocationInfo, LocationError
>  from zope.traversing.interfaces import ITraversable, ITraverser
> -
>  from zope.traversing.namespace import namespaceLookup
> -from zope.tra

Re: [Zope-dev] Zope world (Was: Test fixture concepts)

2011-03-28 Thread Souheil CHELFOUH
I back you up on this.
The problem, on the other hand, is that : to see changes we need a
dynamic, a momentum
Lately, the work has been to maintain and not to push evolutions.
What I'm currently trying to acheive, orchestrating that from the Grok
community, is to try and open more and more zope packages to the
outside world pluggability.
If we can submit concrete ideas to the zope dev list and push them
without giving it up to the global inertia, we might acheive something
that would benefit everybody

2011/3/28 Sebastien Douche :
> On Sat, Mar 26, 2011 at 15:18, Wolfgang Schnerring  wrote:
>
> Hi folks,
>
>> An honest counter question: Why not use zope.testrunner? What
>> advantages does py.test offer?
>
> On the technical side, I don't know. But from my point of view, the
> most important thing is the "social" side. I'm a bit tired to be
> "compartmentalized" : you must use "generics" tools (Nose, WebOb,
> Paster...) or Zope tools (Zope3, KGS, zope.testbrowser, zope.testing,
> zc.buildout, z3c.testsetup...). Pyramid is the first step in the right
> direction : the fusion of 3 communities (bfg, pylons, tg) with some
> Zope ideas. Thanks so much Chris and Ben, for the first time in my
> Python life, I see a fusion and not a fork. PSF said at last Pycon
> "PSF is the Python foundation, not the CPython foundation" and offers
> 10k$ to PyPy.
>
> Sincerely, you rock my word: Buildout, Zope2, Zope3, Doctest, you
> created so many fantastic tools (I use Zope tools since 99), but now
> it's time to see outside the Zope world and share ideas and tools.
>
> Sorry for the noise, it's just a cry of my heart.
>
>
>
> --
> Sebastien Douche 
> Twitter: @sdouche (agile, lean, python, git, open source)
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Work on the zope.publisher components and their genericity

2011-03-28 Thread Souheil CHELFOUH
For people interested in what's hiding behind that, I started a demo here :

http://gitweb.dolmen-project.org/CromlechDemo.git

We're trying to publish things with a simplified publisher and to keep
the backward compatibility
We want to make the grok components independant from zope.publisher,
to be useable in more frameworks
The global idea is to simplify the flow of the publishing, the auth, etc.

There's no tests, , this is a proof of concept. Please, test
accordingly, if you want to test and have a look.


2011/3/28 Matthias :
>> http://svn.zope.org/repos/main/zope.browser/branches/publisher_definition/
>>
>> Changes have been rolled back accordingly.
>> Cheers
>>
>> - Souheil
>
> I'd love to se these changes being incorporated soon. They'll allow
> cutting down on zope.publisher dependencies and therefor opening zope to
> other frameworks.
>
> -Matthias
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-25 Thread Souheil CHELFOUH
A quick note :

This quite an advanced vocabulary, why not make another package with a
dependency on zope.schema ?
I don't quite see the point to have that in the "core".

Furthermore, for the dict class in use in the vocabulary, you could
add a "factory" class that can be overriden easily.
That would allow people with OrderDict capabilities to use them
without having to re-sort later on.

By the way, good work on that, it's something that is often needed in
advanced forms. I'll make sure to try it.
Thank you for the effort.

- Souheil

2012/1/25 Marius Gedminas :
> On Wed, Jan 25, 2012 at 01:55:28AM +0200, Jan-Carel Brand wrote:
>> On Wed, 2012-01-25 at 00:52 +0200, Marius Gedminas wrote:
>> > On Tue, Jan 24, 2012 at 07:34:03PM +0200, Jan-Carel Brand wrote:
>> > > I now subclass PersistentMapping instead of SimpleVocabulary, so this is
>> > > not an issue anymore.
>> >
>> > Ok.  But why Persistent?  None of the other vocabularies are
>> > persistent...
>>
>> Yeah, using PersistentMapping was a mistake, firstly because persistence
>> is not necessary and secondly because it introduces a dependency on
>> Persistence.
> <...>
>> > > I've changed the TreeVocabulary to subclass from PersistentDict. So the
>> > > vocabulary itself now acts as a dict.
>> >
>> > So is it PersistentMapping or PersistentDict then?  ;)
>>
>> It was first the one, and then the other :)
>
> For extra fun: one is an alias for the other in newer ZODB versions.
>
>> > > > > Perhaps I should rephrase :)
>> > > > >
>> > > > > I would like my changes to be merged with the zope.schema trunk. The
>> > > > > tests I've added provide 100% coverage of the TreeVocabulary code.
>> > > > >
>> > > > > I would just like someone to sign it off.
>> > > >
>> > > > -1 because of the concerns above.
>> > >
>> > > Fair enough. Have your concerns been addressed properly?
>> >
>> > Thank you, yes.
>> >
>> > I'm still wondering about the possibility of ordered trees.
>>
>> Python 2.7 has an OrderedDict class in the collections module:
>> http://docs.python.org/dev/whatsnew/2.7.html#pep-0372
>
> Yes.  And if I pass an OrderedDict to your .fromDict(), it will be
> discarded and all the items inserted into a regular dict, forgetting
> their original order.
>
> But anyway, I'm fine with you saying "explicit ordering is not
> supported; it's up to the widget to sort each tree level appropriately".
> In the class docstring, say.  ;-)
>
>> > And I'm -1 for subclassing PersistentMapping.  It may tempt people into
>> > storing tree vocabularies in the ZODB, and then maybe even modifying
>> > them.  And you have plenty of non-persistent dicts in the internal
>> > structure.
>> >
>> > I think it would be better to subclass a regular dict, and document that
>> > you ITreeVocabulary is a dict-like object by making it inherit
>> > IEnumerableMapping.
>>
>> Thanks for the suggestion, I did that.
>
> I've no objections remaining (other than that little thing about
> explicit ordering).
>
> Marius Gedminas
> --
> http://pov.lt/ -- Zope 3/BlueBream consulting and development
>
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-27 Thread Souheil CHELFOUH
Yes, Marius got exactly what I meant, this is how I usually make the
not-so-pluggable stuff pluggable :)
About the fact to release it out of zope.schema, it's also to be able
to make it live a bit and prove itself.
Then, including it and changing the API can be easily justified. I'm
not afraid of the changes in zope.schema.
z3c.form is not the only form option, I'll probably use it in
dolmen.forms that came from zeam.form.
So, whatever you decide, we'll try to make it easy for you to contribute.
It tends to get to complicated to do anything in zope, lately :)


2012/1/26 Marius Gedminas :
> On Thu, Jan 26, 2012 at 04:02:54PM +0200, Jan-Carel Brand wrote:
>> On Wed, 2012-01-25 at 18:56 +0100, Souheil CHELFOUH wrote:
>> > A quick note :
>> >
>> > This quite an advanced vocabulary, why not make another package with a
>> > dependency on zope.schema ?
>> > I don't quite see the point to have that in the "core".
>>
>> Ok, Charlie also expressed his reservations. I'll put it in a different
>> package then.
>>
>> I'm not too sure what to name it though. For example, under what
>> namespace? zope or z3c?
>
> My gut feeling says "z3c".
>
> OTOH I don't think a single class warrants a whole separate PyPI
> package.  Especially if it's going to be used with z3c.form (hint, hint
> ;) or that collective.forgotthenamealready you mentioned upthread.
>
>> I'm guessing zope.vocabulary, or rather zope.treevocabulary?
>
> (Or z3c.treevocabulary)
>
> But I'd rather see this in zope.schema.
>
> Incidentally, since this would be a new feature, it would need a minor
> version bump in setup.py (4.0.2dev -> 4.1dev).
>
>> > Furthermore, for the dict class in use in the vocabulary, you could
>> > add a "factory" class that can be overriden easily.
>> > That would allow people with OrderDict capabilities to use them
>> > without having to re-sort later on.
>>
>> Could you please elaborate on what you mean?
>
> I think he meant something like
>
>    class TreeVocabulary(object):
>
>        # you can subclass and use OrderedDictionary instead
>        dict_factory = dict
>
> This would mean that you can't subclass dict and would instead have to
> delegate __getitem__, __iter__, __len__, keys, values, items and all the
> rest by hand.
>
> I'm actually feeling a bit guilty about raising this question.  As I
> said, I don't have a use-case for ordered TreeVocabularies myself.  (Or
> unordered ones either, for that matter ;)  The only reason for hashing
> this out now is to avoid painful API changes if we ever decide that we
> need those.  Feel free to cry YAGNI at any time.  It's already hard
> enough to contribute to zope3-or-is-it-bluebream-or-is-it-ztk-aaaugh as
> it is, without us adding extra barriers in place.
>
>> If I create a factory class to create TreeVocabulary instances, how will
>> overriding that factory (without creating a separate
>> SortableTreeVocabulary) allow people to use OrderedDict?
>>
>> Incidentally, I came upon this: http://pypi.python.org/pypi/ordereddict
>> which provides the OrderedDict to Python 2.4 to 2.7
>
> Oh, neat.  I've used http://pypi.python.org/pypi/odict in the past, but
> it doesn't have the blessing of stdlib'ness.
>
>> I think it might make sense to just subclass OrderedDict and implement
>> an ordered tree from the start.
>
>> > By the way, good work on that, it's something that is often needed in
>> > advanced forms. I'll make sure to try it.
>> > Thank you for the effort.
>>
>> Thanks! Much appreciated.
>
> Thanks!
>
> Marius Gedminas
> --
> http://pov.lt/ -- Zope 3/BlueBream consulting and development
>
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> https://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  https://mail.zope.org/mailman/listinfo/zope-announce
>  https://mail.zope.org/mailman/listinfo/zope )
>
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] TreeVocabulary in zope.schema.vocabulary

2012-01-30 Thread Souheil CHELFOUH
Snip snip

> Marius and Souheil, what do you think about this? I think it probably
> still makes sense to have a dict_factory as Souheil suggested, but then
> we make the default type OrderedDict and not dict.
>

This sounds perfectly reasonnable.

> Any objections?

Not really
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )