Re: [Zope-dev] utilities and python version in zope2.12
On 15/07/2009 Andreas Jung wrote: > On 14.07.09 18:14, Jonas Meurer wrote: > > Hey, > > > > is there any reason why my patch has been ignored so far? if there are > > issues with it, please tell me so I can fix them ... > > Please submit patches to the bugtracker. Don't expect that I follow any > posting and check it for patches. all right: https://bugs.launchpad.net/zope2/+bug/399633 greetings, jonas ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] utilities and python version in zope2.12
On 14.07.09 18:14, Jonas Meurer wrote: > Hey, > > is there any reason why my patch has been ignored so far? if there are > issues with it, please tell me so I can fix them ... Please submit patches to the bugtracker. Don't expect that I follow any posting and check it for patches. Andreas begin:vcard fn:Andreas Jung n:Jung;Andreas org:ZOPYX Ltd. & Co. KG adr;quoted-printable:;;Charlottenstr. 37/1;T=C3=BCbingen;;72070;Germany email;internet:i...@zopyx.com title:CEO tel;work:+49-7071-793376 tel;fax:+49-7071-7936840 tel;home:+49-7071-793257 x-mozilla-html:FALSE url:www.zopyx.com version:2.1 end:vcard ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] utilities and python version in zope2.12
Hey, is there any reason why my patch has been ignored so far? if there are issues with it, please tell me so I can fix them ... greetings, jonas On 10/07/2009 Jonas Meurer wrote: > Hello again, > > On 07/07/2009 Andreas Jung wrote: > > As Tres already pointed out: the *relevant* scripts are registered using > > entry points afaik and will use the right Python interpreter. > > > > Wrong references to old Python versions in > > > > src/AccessControl/securitySuite/regressionSecurity.py > > src/Products/ZCTextIndex/tests/mhindex.py > > > > should be fixed but this only a cosmetic issue here. > > and as I can see in svn, you already fixed both of them. thanks for > that. > > but what about all the scripts that still have python2.4 hardcoded as > interpreter? if zope2.12 doesn't support python2.4, these should be > fixed as well in my eyes. > > here's a list of scripts that use hardcoded python2.4 interpreter: > > src/Zope2/utilities/check_catalog.py > src/Zope2/utilities/compilezpy.py > src/Zope2/utilities/copyzopeskel.py > src/Zope2/utilities/decompilezpy.py > src/Zope2/utilities/load_site.py > src/Zope2/utilities/mkzeoinstance.py > src/Zope2/utilities/mkzopeinstance.py > src/Zope2/utilities/requestprofiler.py > src/Zope2/utilities/zpasswd.py > > and one test has a python2.4 requirement in documentation: > > src/ZPublisher/tests/generate_conflicts.py > > see the attached patch to fix these remaining ones. > > greetings, > jonas ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] utilities and python version in zope2.12
Hello again, On 07/07/2009 Andreas Jung wrote: > As Tres already pointed out: the *relevant* scripts are registered using > entry points afaik and will use the right Python interpreter. > > Wrong references to old Python versions in > > src/AccessControl/securitySuite/regressionSecurity.py > src/Products/ZCTextIndex/tests/mhindex.py > > should be fixed but this only a cosmetic issue here. and as I can see in svn, you already fixed both of them. thanks for that. but what about all the scripts that still have python2.4 hardcoded as interpreter? if zope2.12 doesn't support python2.4, these should be fixed as well in my eyes. here's a list of scripts that use hardcoded python2.4 interpreter: src/Zope2/utilities/check_catalog.py src/Zope2/utilities/compilezpy.py src/Zope2/utilities/copyzopeskel.py src/Zope2/utilities/decompilezpy.py src/Zope2/utilities/load_site.py src/Zope2/utilities/mkzeoinstance.py src/Zope2/utilities/mkzopeinstance.py src/Zope2/utilities/requestprofiler.py src/Zope2/utilities/zpasswd.py and one test has a python2.4 requirement in documentation: src/ZPublisher/tests/generate_conflicts.py see the attached patch to fix these remaining ones. greetings, jonas diff -rNu Zope2.12.old/src/ZPublisher/tests/generate_conflicts.py Zope2.12/src/ZPublisher/tests/generate_conflicts.py --- Zope2.12.old/src/ZPublisher/tests/generate_conflicts.py 2009-07-10 16:24:51.0 +0200 +++ Zope2.12/src/ZPublisher/tests/generate_conflicts.py 2009-07-10 16:25:06.0 +0200 @@ -1,10 +1,10 @@ ## This script requires: -## - python2.4 +## - python >= 2.4 ## - Zope 3's zope.testbrowser package: ## http://www.zope.org/Members/benji_york/ZopeTestbrowser-0.9.0.tgz ## ## The just run: -## $python2.4 generate_conflicts.py +## $python generate_conflicts.py import base64 import string import threading diff -rNu Zope2.12.old/src/Zope2/utilities/check_catalog.py Zope2.12/src/Zope2/utilities/check_catalog.py --- Zope2.12.old/src/Zope2/utilities/check_catalog.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/check_catalog.py 2009-07-10 16:25:22.0 +0200 @@ -1,4 +1,3 @@ -#!/usr/bin/env python2.4 ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/compilezpy.py Zope2.12/src/Zope2/utilities/compilezpy.py --- Zope2.12.old/src/Zope2/utilities/compilezpy.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/compilezpy.py 2009-07-10 16:25:39.0 +0200 @@ -1,5 +1,3 @@ -#!/usr/bin/env python2.4 - ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/copyzopeskel.py Zope2.12/src/Zope2/utilities/copyzopeskel.py --- Zope2.12.old/src/Zope2/utilities/copyzopeskel.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/copyzopeskel.py 2009-07-10 16:25:44.0 +0200 @@ -1,5 +1,3 @@ -#!/usr/bin/env python2.4 - ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/decompilezpy.py Zope2.12/src/Zope2/utilities/decompilezpy.py --- Zope2.12.old/src/Zope2/utilities/decompilezpy.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/decompilezpy.py 2009-07-10 16:26:00.0 +0200 @@ -1,5 +1,3 @@ -#!/usr/bin/env python2.4 - ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/load_site.py Zope2.12/src/Zope2/utilities/load_site.py --- Zope2.12.old/src/Zope2/utilities/load_site.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/load_site.py 2009-07-10 16:26:05.0 +0200 @@ -1,5 +1,3 @@ -#!/usr/bin/env python2.4 - ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/mkzeoinstance.py Zope2.12/src/Zope2/utilities/mkzeoinstance.py --- Zope2.12.old/src/Zope2/utilities/mkzeoinstance.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/mkzeoinstance.py 2009-07-10 16:26:11.0 +0200 @@ -1,5 +1,3 @@ -#!/usr/bin/env python2.4 - ## # # Copyright (c) 2002 Zope Corporation and Contributors. All Rights Reserved. diff -rNu Zope2.12.old/src/Zope2/utilities/mkzopeinstance.py Zope2.12/src/Zope2/utilities/mkzopeinstance.py --- Zope2.12.old/src/Zope2/utilities/mkzopeinstance.py 2009-07-10 16:24:50.0 +0200 +++ Zope2.12/src/Zope2/utilities/mkzopeinstance.py 2009-07-10 16:26:15.
Re: [Zope-dev] utilities and python version in zope2.12
As Tres already pointed out: the *relevant* scripts are registered using
entry points afaik and will use the right Python interpreter.
Wrong references to old Python versions in
src/AccessControl/securitySuite/regressionSecurity.py
src/Products/ZCTextIndex/tests/mhindex.py
should be fixed but this only a cosmetic issue here.
Andreas
On 06.07.09 23:01, Jonas Meurer wrote:
> On 05/07/2009 Tres Seaver wrote:
>
>> Jonas Meurer wrote:
>>
>>> Hello,
>>>
>>> I just recognized that lots of utilities in zope2.12 still do have
>>> python2.4 as interpreter while the release notes of zope2.12 talk about
>>> python2.5 and python2.6 being the only supported python versions.
>>>
>> True, but likely harmless: anything installed via a "console script"
>> entry point will have its shebang line rewritten to use whatver
>> fully-qualified interpreter path is used to run 'setup.py'.
>>
>> I would be glad to check in a patch which changed them all, however ;)
>>
> I would be happy to provide a patch, but what exactly should I replace
> python2.4 with?
>
> The WHATSNEW document talks about both python2.5 and python2.6 being
> supported. I think that using /usr/bin/python is not an option, as that
> one might link to python3{.0/.1} in the future as well.
>
> I see two solutions:
>
> chose either python2.5 or python2.6 as prefered version and stick to
> that one, or fix the build system to always set the python interpreter
> for all scripts.
>
> Even worse, at grepping for "env python" I found that two scripts still
> have the python2.1 interpreter hardcoded:
>
> src/AccessControl/securitySuite/regressionSecurity.py
> src/Products/ZCTextIndex/tests/mhindex.py
>
> some more stats:
>
> 27 scripts do have set an interpreter in their first line:
>
> 2 scripts with python2.1
> 9 scripts with python2.4
> 16 scripts with python (system default)
>
> I would suggest to fix the build system (configure script) to set the
> python interpreter to whatever is given as --with-python.
>
> greetings,
> jonas
>
>
>
> ___
> Zope-Dev maillist - Zope-Dev@zope.org
> http://mail.zope.org/mailman/listinfo/zope-dev
> ** No cross posts or HTML encoding! **
> (Related lists -
> http://mail.zope.org/mailman/listinfo/zope-announce
> http://mail.zope.org/mailman/listinfo/zope )
>
--
ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany
Web: www.zopyx.com - Email: i...@zopyx.com - Phone +49 - 7071 - 793376
Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535
Geschäftsführer/Gesellschafter: ZOPYX Limited, Birmingham, UK
E-Publishing, Python, Zope & Plone development, Consulting
begin:vcard
fn:Andreas Jung
n:Jung;Andreas
org:ZOPYX Ltd. & Co. KG
adr;quoted-printable:;;Charlottenstr. 37/1;T=C3=BCbingen;;72070;Germany
email;internet:i...@zopyx.com
title:CEO
tel;work:+49-7071-793376
tel;fax:+49-7071-7936840
tel;home:+49-7071-793257
x-mozilla-html:FALSE
url:www.zopyx.com
version:2.1
end:vcard
___
Zope-Dev maillist - Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] utilities and python version in zope2.12
On 05/07/2009 Tres Seaver wrote:
> Jonas Meurer wrote:
> > Hello,
> >
> > I just recognized that lots of utilities in zope2.12 still do have
> > python2.4 as interpreter while the release notes of zope2.12 talk about
> > python2.5 and python2.6 being the only supported python versions.
>
> True, but likely harmless: anything installed via a "console script"
> entry point will have its shebang line rewritten to use whatver
> fully-qualified interpreter path is used to run 'setup.py'.
>
> I would be glad to check in a patch which changed them all, however ;)
I would be happy to provide a patch, but what exactly should I replace
python2.4 with?
The WHATSNEW document talks about both python2.5 and python2.6 being
supported. I think that using /usr/bin/python is not an option, as that
one might link to python3{.0/.1} in the future as well.
I see two solutions:
chose either python2.5 or python2.6 as prefered version and stick to
that one, or fix the build system to always set the python interpreter
for all scripts.
Even worse, at grepping for "env python" I found that two scripts still
have the python2.1 interpreter hardcoded:
src/AccessControl/securitySuite/regressionSecurity.py
src/Products/ZCTextIndex/tests/mhindex.py
some more stats:
27 scripts do have set an interpreter in their first line:
2 scripts with python2.1
9 scripts with python2.4
16 scripts with python (system default)
I would suggest to fix the build system (configure script) to set the
python interpreter to whatever is given as --with-python.
greetings,
jonas
signature.asc
Description: Digital signature
___
Zope-Dev maillist - Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] utilities and python version in zope2.12
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jonas Meurer wrote: > Hello, > > I just recognized that lots of utilities in zope2.12 still do have > python2.4 as interpreter while the release notes of zope2.12 talk about > python2.5 and python2.6 being the only supported python versions. True, but likely harmless: anything installed via a "console script" entry point will have its shebang line rewritten to use whatver fully-qualified interpreter path is used to run 'setup.py'. I would be glad to check in a patch which changed them all, however ;) Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKUWBr+gerLs4ltQ4RAt9RAKDa5DL4nNyu031Yp1yZWdy+zagPOACfaK3+ 6zIFfRx5KY7oTGZuw7wzX2Y= =uVYA -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
