Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-20 Thread Gary Poster
On Dec 20, 2006, at 7:15 AM, Christian Theune wrote: Hi, Gary Poster wrote: On Dec 19, 2006, at 2:34 AM, Christian Theune wrote: Hi again, Gary Poster wrote: I don't have a very strong feeling about it, but lean towards "bug fix". It didn't break any of our code (or at least any of our t

Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-20 Thread Christian Theune
Hi, Gary Poster wrote: > On Dec 19, 2006, at 2:34 AM, Christian Theune wrote: > >> Hi again, >> >> Gary Poster wrote: >>> I don't have a very strong feeling about it, but lean towards "bug >>> fix". It didn't break any of our code (or at least any of our >>> tests :-) ) so it seems safe from my

Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-20 Thread Gary Poster
On Dec 19, 2006, at 2:34 AM, Christian Theune wrote: Hi again, Gary Poster wrote: I don't have a very strong feeling about it, but lean towards "bug fix". It didn't break any of our code (or at least any of our tests :-) ) so it seems safe from my perspective. I was trying to apply the pat

Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-19 Thread Christian Theune
Christian Theune wrote: > I'd both apply r70331 and r71548 to 3.3 and 3.2 then. JFTR: I've backported the small restructuring and the bugfix in r71612 (3.2) and r71611 (3.3) Christian -- gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany www.gocept.com - [EMAIL PROTECTED] -

Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-18 Thread Christian Theune
Hi again, Gary Poster wrote: > I don't have a very strong feeling about it, but lean towards "bug > fix". It didn't break any of our code (or at least any of our > tests :-) ) so it seems safe from my perspective. I was trying to apply the patch to the 3.3 branch and noticed that the patch i

Re: [Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-18 Thread Gary Poster
On Dec 14, 2006, at 7:55 AM, Christian Theune wrote: Hi, ... Zagy and I fixed this issue, by making the methods "_getCurrentValue" and "_getFormValue" use a common method to retrieve the "input value" and handle the case of converting to the "form value" cleanly. However, we are not sure,

[Zope3-dev] Cleaning up the widget mess a little bit: bug or feature

2006-12-14 Thread Christian Theune
Hi, Zagy and I stumbled over the widgets today, and I already had a workaround sitting on a widget that we wrote and wanted to remove this issue. The issue is that the method "_getCurrentValue" sometimes returns an 'input value' and sometimes 'a form value' (specifically: it returns a form value