Review: Needs Fixing
1. Need some test cases of this functionality, including error conditions, for
both new functions.
2. For the element() case, I think you should use the x:parse() function in the
built-in XML module (http://www.zorba-xquery.com/modules/xml) with the
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Commit Message changed to:
Implementation of higher order functions.
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
Your team Zorba Coders is subscribed
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-02-27T10-41-28.476Z/log.html
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the
output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-2013-02-27T10-41-28.476Z is finished. The final
status was:
4
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150755
Your team Zorba Coders is subscribed
Sorin Marian Nasoi has proposed merging
lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba.
Commit message:
- update FOTS snaphot to Feb 27th
- fixes in reporting module
Requested reviews:
Sorin Marian Nasoi (sorin.marian.nasoi)
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/update_fots_snaphot-2013-02-27T12-00-56.12Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Review: Approve
Looks like modules/w3c/xpath_functions.xq already declares
fn:current-dateTime() as xs:dateTimeStamp. While modules/w3c/xpath_functions.xq
declares datetime:current-dateTime() as xs:dateTime.
Verified FOTS/xs-dateTimeStamp tests are passing.
Verified
import module namespace
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
--
Validation queue job update_fots_snaphot-2013-02-27T12-00-56.12Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-02-27T12-23-49.716Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed to branch
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Note: the failures in xs-anyURI are not regressions: the xs-anyURI was newly
added in FOTS.
This is in fact the reason I propose this update of the FOTS snaphot.
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Cezar you did not update the expected_failures in test/fots/CMakeLists.txt
according to your fixes.
I will add a fix asap.
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
Fixed bug #1125444 (input group-by exprs were not treated by index-flwor_vars()
functoin, leading to erroneous loop hoisting).
Requested reviews:
Markos Zaharioudakis (markos-za)
It seems that there are 2 regressions:
- 1 in FOTS/xs-double test set, xs-float-003 test case
- 1 in FOTS/xs-float, xs-double-003 test case
I am looking into those now.
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Commit Message changed to:
Implementation of higher order functions.
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
Your team Zorba Coders is subscribed
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-02-27T13-23-20.254Z/log.html
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
It seems that there are 2 regressions:
- 1 in FOTS/xs-double test set, xs-float-003 test case
- 1 in FOTS/xs-float, xs-double-003 test case
I am looking into those now.
Cezar, after you enabled the XSD 1.1 support in FOTSZorbaManifest.xml there are
2 test cases that regressed (before these
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the
output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-2013-02-27T13-23-20.254Z is finished. The final
status was:
4
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150791
Your team Zorba Coders is subscribed
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
Your team Zorba Coders is subscribed
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-02-27T14-09-20.948Z/log.html
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Commit Message changed to:
Implementation of higher order functions.
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/150801
Your team Zorba Coders is subscribed
Additional info. : if you want to say we support XML version 1.1 I think we
also have to say we support XML versions 1.0:5+ 1.1.
This means the following setting in FOTSZorbaManifest.xml:
[...]
dependency type=xml-version value=1.0 satisfied=true/
dependency type=xml-version value=1.0:4-
- Which options are enabled by default?
The only option available as default is XML_PARSE_NOERROR this way zorba can
manage the error messages and no extra message are shown, but this option is
not optional.
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150789
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150789
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-02-27T15-59-48.996Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150789
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job markos-scratch-2013-02-27T15-59-48.996Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150789
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150789
--
Additional info. : if you want to say we support XML version 1.1 I think we
also have to say we support XML versions 1.0:5+ 1.1.
This means the following setting in FOTSZorbaManifest.xml:
[...]
dependency type=xml-version value=1.0 satisfied=true/
dependency type=xml-version
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/update_fots_snaphot-2013-02-27T16-43-46.063Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job update_fots_snaphot-2013-02-27T16-43-46.063Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/update_fots_snaphot into lp:zorba
has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update_fots_snaphot/+merge/150769
--
- There should be a private canonicalize function that does the schema
validation if the input is not validated similarly to most other modules.
Matthias: could you give an example from other modules of what you're referring
to here?
--
I set xsd-version 1.1 support to true (and left only XML 1.0 support) and
added the report of failing test cases in
https://bugs.launchpad.net/zorba/+bug/924754.
The following test cases fail:
- 4 test cases fn-adjust-dateTime-to-timezone test set
- 1 in fn-normalize-unicode test set
- 1 in
- There should be a private canonicalize function that does the schema
validation if the input is not validated similarly to most other modules.
Matthias: could you give an example from other modules of what you're
referring to here?
zorba_modules/html/src/html.xq:119
--
I fixed the 2 +INF tests.
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
I'm afraid this won't work. We have to use ZORBA_FIND_JAR(), or else it's very
inconvenient to build this module using downloaded jars (not from the Ubuntu
repository). We will need to find some way to make that macro available for the
PPA building situation. (Or, possibly
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Description changed to:
Unicode category code clean-up.
peek_behind() simplification.
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Commit Message changed to:
Unicode category code clean-up.
peek_behind() simplification.
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-02-28T02-41-44.506Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job pjl-misc-2013-02-28T02-41-44.506Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-02-28T04-12-43.118Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job pjl-misc-2013-02-28T04-12-43.118Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/150948
Your team Zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
Fixed bug in the throwing of error XQTY0086 during node construction
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-02-28T05-44-52.255Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The attempt to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job markos-scratch-2013-02-28T05-44-52.255Z is finished.
The
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
--
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-02-28T06-39-46.395Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job markos-scratch-2013-02-28T06-39-46.395Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/150955
--
75 matches
Mail list logo
