Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073175 into lp:zorba

2013-04-17 Thread Chris Hillery
As noted, this change as it stands is not acceptable. Marking proposal as Rejected. -- https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-04-16 Thread Chris Hillery
php_test10 failed because the .php file uses a <

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-04-16 Thread Chris Hillery
FYI, the ruby test at least failed because it tried to open this file: /home/ceej/zo/testing/zorbatest/tester/remotequeue/bug1132937-2013-04-17T01-00-27.847Z/bzr/zorba/build/swig/ruby/../tests/satellites.json but that file doesn't exist. However, if you remove the "../" from the path, it exists.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-04-16 Thread Chris Hillery
Review: Needs Fixing I think actually there are some error conditions that we're not catching currently. For instance, the following input in serialize-direct-uri.xq: { "scheme" : "file", "path" : "d:/a/b/c" } is a non-opaque URI because it has a path, rather than an opaque-part. But it produc

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-04-16 Thread Chris Hillery
Also, currently serialize-direct-uri.xq fails because the expected output file serialize-direct-uri.xml.res is missing a couple results, namely the opaque URI tests at the end. Did you forget to commit that file? -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your tea

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-04-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1132937 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640 -- https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123835 into lp:zorba

2013-04-15 Thread Chris Hillery
Ok, maybe ignore point #1 - that function is there after all. I'm not sure how I missed it; must have been a typo in my search. Anyway, I'll review the code more thoroughly a bit later tonight. Points #2 and #3 still need to be fixed. -- https://code.launchpad.net/~zorba-coders/zorba/bug1123835/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123835 into lp:zorba

2013-04-15 Thread Chris Hillery
Review: Needs Fixing 1. It looks like you didn't check in some changes? sequences_impl.cpp refers to a method URI::get_encoded_fragment() that doesn't exist. 2. sequences_impl.cpp now shows up on my system as "ISO-8859 English text" rather than "ASCII English text" when I use the "file" command

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169191 into lp:zorba

2013-04-15 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169191/+merge/159035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169191 into lp:zorba

2013-04-15 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1169191 into lp:zorba has been updated. Commit Message changed to: Only attempt to resolve a base URI against the entity-retrieval URI if said entity-retrieval URI itself absolute. For more details, see: https://code.launchpad.net/~zorba-coders/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169191 into lp:zorba

2013-04-15 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1169191 into lp:zorba. Commit message: Only attempt to resolve a base URI against the entity-retrieval URI if said entity-retrieval URI itself absolute. Requested reviews: Chris Hillery (ceejatec) For more details, see: https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-15 Thread Chris Hillery
Review: Approve I agree with your logic, Juan; thanks for spelling it out. I hadn't realized that your new flag were not checked in the inner loop of fn:subsequence(), but looking at the implementation it appears that is the case. So I have no problem with it. Voting Approve now, although clea

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba

2013-04-11 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1147518 into lp:zorba

2013-04-11 Thread Chris Hillery
I could write a script to automatically vote Needs Fixing on any merge proposal that has RAISE_ERROR in it. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1147518/+merge/158449 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Pos

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-compare_null into lp:zorba

2013-04-10 Thread Chris Hillery
Not merging this proposal immediately as there are some open questions about null. Matthias will update and merge as those issues settle. -- https://code.launchpad.net/~zorba-coders/zorba/feature-compare_null/+merge/157008 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1026250 into lp:zorba

2013-04-10 Thread Chris Hillery
Matthias will get this scheduled within 28msec, hopefully soon. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193 -- https://code.launchpad.net/~zorba-coders/zorba/bug116002

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba has been updated. Commit Message changed to: Fix for bug1160028. Fix URI of the type when validating with xsi:type attribute specified. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1160028

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1130998 into lp:zorba has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/156700 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/1567

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba

2013-04-10 Thread Chris Hillery
Review: Approve Looks good! -- https://code.launchpad.net/~zorba-coders/zorba/bug1064978/+merge/150696 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-10 Thread Chris Hillery
Nicolae has taken over this bug and I don't believe is using this branch, so rejecting the proposal. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/156700 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041 -- h

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-ModuleInfo/+merge/148616 -- https://code.launchpad.net/~zorba-coders/zorba/feature-M

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ModuleInfo into lp:zorba

2013-04-10 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ModuleInfo/+merge/148616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module

2013-04-10 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsu

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/functx-uri-fix into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/functx-uri-fix into lp:zorba has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/functx-uri-fix/+merge/88012 -- https://code.launchpad.net/~zorba-coders/zorba/functx-uri-fix/+me

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/functx-uri-fix into lp:zorba

2013-04-10 Thread Chris Hillery
Review: Disapprove I believe this branch has fallen too far behind the times. I will re-do the change to add the slash as part of 3.0. -- https://code.launchpad.net/~zorba-coders/zorba/functx-uri-fix/+merge/88012 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https:/

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2013-04-10 Thread Chris Hillery
Nicolae, is this proposal still necessary? If not, please mark it "Rejected". -- https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/148300 Your team Zorba Coders is requested to review the proposed merge of lp:~nbrinza/zorba/error-messages into lp:zorba. -- Mailing list: https://la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-09 Thread Chris Hillery
Review: Needs Fixing Oh, actually, two quick things: 1. Add a test case that would have failed before and succeeds now 2. Add a note about the fixed bug to the Changelog. -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribe

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-09 Thread Chris Hillery
Review: Approve Other than Till's comment, I approve. I'm still a bit wary about having to add a new flag and test logic to fn:subsequence(), since that's used a lot, so if you happen to think of a way to do this without such checks that would be ideal. But, if this flag is necessary, then so b

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123016 into lp:zorba

2013-04-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1123016 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082 -- https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123016 into lp:zorba

2013-04-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1123016 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082 -- https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123016 into lp:zorba

2013-04-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1123016 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082 -- https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123016 into lp:zorba

2013-04-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1123016 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082 -- https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123016 into lp:zorba

2013-04-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1123016/+merge/155082 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/157752 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

[Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-03 Thread Chris Hillery
The proposal to merge lp:~nbrinza/zorba/bugs2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156818 -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156818 Your team Zorba Coders is subsc

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-03 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156818 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-03 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156766 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Chris Hillery
I'm afraid there's no way I'm going to be able to give this the review it deserves. Should I request William to review it? -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~z

[Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs3 into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~nbrinza/zorba/bugs3 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/bugs3/+merge/156734 -- https://code.launchpad.net/~nbrinza/zorba/bugs3/+merge/156734 Your team Zorba Coders is subsc

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs3 into lp:zorba

2013-04-02 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs3/+merge/156734 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

[Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~nbrinza/zorba/bugs2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156732 -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156732 Your team Zorba Coders is subsc

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-02 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/156732 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-02 Thread Chris Hillery
Review: Needs Fixing Unfortunately this fix isn't in the right place. By changing the CharRef regexp, you've broken some valid XML character references like . Also, the error message for � is not very good. Nicolae - can you help point us in the right direction here? There is already code in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-02 Thread Chris Hillery
Have you merged the trunk? That's the more likely cause of merge conflicts. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/156700 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.l

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-02 Thread Chris Hillery
Unfortunately you've got a ton of merge conflicts here. Can you try merging from the latest trunk onto your branch and push it back to your branch? -- https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/156700 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing lis

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/155878 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/1558

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/155878 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/1558

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-04-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-oauth-redirect/+merge/156456 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://lau

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module has been updated. Commit Message changed to: Handle HTTP redirects manually, so we create a unique nonce for each request. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-oauth-r

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-oauth-redirect into lp:zorba/oauth-module. Commit message: Handle HTTP redirects manually, so we create a unique nonce for each request. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/bugs2 into lp:zorba

2013-04-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/bugs2/+merge/155778 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More h

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-oauth-header/+merge/156450 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module has been updated. Commit Message changed to: Insert Authorization header as first node into http:request element, so it will always be valid according to the schema. For more details, see: https://code.lau

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

2013-04-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module. Commit message: Insert Authorization header as first node into http:request element, so it will always be valid according to the schema. Requested reviews: Matthias Brantner (matthias

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/1563

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
Review: Approve As they were likely unused, I don't have a problem with those removals. Not sure how to handle this situation more generally going forward. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322 Your team Zorba Coders is subscribed to branch lp:zorba. -- Ma

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Chris Hillery
Review: Approve The changes seem OK for now; however, they don't actually *fix* the two related bugs, do they? -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.ne

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module has been updated. Commit Message changed to: Set ZORBA_PROJECT_UNAVAILABLE when OpenSSL not found. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/security-module-bug-113

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module has been updated. Commit Message changed to: Set ZORBA_PROPERTY_UNAVAILABLE when libtidy not found. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1133260/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/security-module-bug-1133260/+merge/155880 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1133260/+merge/155879 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1133260/+merge/155878 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/security-module-bug-1133260 into lp:zorba/security-module. Commit message: Set ZORBA_PROJECT_UNAVAILABLE when OpenSSL not found. Requested reviews: Chris Hillery (ceejatec) Juan Zacarias (juan457) Related bugs: Bug #1133260 in

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1133260 into lp:zorba has been updated. Commit Message changed to: Support global property ZORBA_PROJECT_UNAVAILABLE so non-core modules can inform Zorba build that they failed to find their dependencies. For more details, see: https://code.laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/html-module-bug-1133260 into lp:zorba/html-module. Commit message: Set ZORBA_PROPERTY_UNAVAILABLE when libtidy not found. Requested reviews: Chris Hillery (ceejatec) Juan Zacarias (juan457) Related bugs: Bug #1133260 in Zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1133260 into lp:zorba

2013-03-27 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1133260 into lp:zorba. Commit message: Support global property ZORBA_PROJECT_UNAVAILABLE so non-core modules can inform Zorba build that they failed to find their dependencies. Requested reviews: Chris Hillery (ceejatec) Juan

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-03-27 Thread Chris Hillery
If xs:dateTimeStamp can be added quickly, do it as part of this merge. If it'll take more than a few hours, file a separate bug and propose the change separately. -- https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640 Your team Zorba Coders is subscribed to branch lp:zorba.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1132937 into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1132937/+merge/155640 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixing_issues_FOTS_driver/+merge/155294 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixing_issues_FOTS_driver/+merge/155294 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixing_issues_FOTS_driver into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Needs Information I don't think it's correct to try deep-equal() for test cases. Certainly this doesn't match with the description of that assertion at http://dev.w3.org/2011/QT3-test-suite/catalog-schema.html#elem_assert-xml . Can you tell me why you did that? I'm also confused how th

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba

2013-03-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Approve Juan - I've updated the branch to remove the EXPECTED_FOTS_FAILURE()s for 8 more tests - fn-nilled-38, 39, 41, 44, 45, 47, 51, and 52. Sorin, please confirm that these are the tests you mentioned (your link above doesn't go anywhere useful, I'm afraid). Also Juan - at least her

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba

2013-03-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/FOTS_run_time_decrease/+merge/155598 -- https://code.launchpad.net/~zorba-coders/zorba/F

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/FOTS_run_time_decrease into lp:zorba

2013-03-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/FOTS_run_time_decrease/+merge/155598 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba

2013-03-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842/+merge/154671 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123842 into lp:zorba

2013-03-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123842/+merge/154671 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_March_21 into lp:zorba

2013-03-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_March_21/+merge/154793 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-import-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123162 into lp:zorba

2013-03-20 Thread Chris Hillery
Sorry, I killed this merge, because until https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 is merged the RQ won't even run the FOTS tests. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123162/+merge/154529 Your team Zorba Coders is subscribed to branch lp:zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-import-fots into lp:zorba has been updated. Commit Message changed to: Fix erroneous ELSEIF() condition. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https://code.launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-import-fots into lp:zorba

2013-03-20 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-import-fots into lp:zorba. Commit message: Fix erroneous ELSEIF() condition. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-import-fots/+merge/154533 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_March_20 into lp:zorba

2013-03-20 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_March_20/+merge/154269 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403/+merge/153784 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-19 Thread Chris Hillery
Review: Approve What I wanted: - verbose=false => passing tests shown condensed, failing tests shown in full - verbose=true => all tests shown in full - ctest in "fots-activate-sets" mode uses verbose=false, and in "fots-activate-cases" mode uses verbose=true What you did: - verbose=false =>

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1134403 into lp:zorba

2013-03-18 Thread Chris Hillery
Review: Needs Fixing The ctest tests should not be run with verbose enabled. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1134403/+merge/153784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@l

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba

2013-03-18 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update_FOTS_snapshot/+merge/153683 -- https://code.launchpad.net/~zorba-coders/zorba/updat

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update_FOTS_snapshot into lp:zorba

2013-03-18 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update_FOTS_snapshot/+merge/153683 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove-wordlists into lp:zorba

2013-03-13 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/remove-wordlists/+merge/153187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove-wordlists into lp:zorba

2013-03-13 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/remove-wordlists into lp:zorba has been updated. Commit Message changed to: Removed unused "wordlists" folder. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove-wordlists/+merge/153187 -- https://code.launchpad.net/~zorba-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsub

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba

2013-03-12 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

<    3   4   5   6   7   8   9   10   11   >