On Fri, 17 Apr 2026 14:12:02 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 83:
>
>> 81: * @param value the integer value as a {@code String}
>> 82: */
>> 83: public static Version get(String value)
>
> Why use `String` here, which is inconsistent with the `value` method.
>
> If you keep using string, the spec might need to quote the numbers 13 and 19,
> to make them string like.
It's for facilitating the usage of PHC strings. Now that PHC support is
factored out, I can change it to `int`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3430245373
