On Fri, 1 May 2026 19:08:24 GMT, Sean Mullan <[email protected]> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line 
> 166:
> 
>> 164: 
>> 165:         /**
>> 166:          * Set the memory value to the builder.
> 
> This doesn't read right. I'd suggest rewording as "Sets the memory parameter 
> of this builder." Same comment for similar methods.

Will change, maybe we don't need the second half of the sentence...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3431429886

Reply via email to