On Fri, 17 Apr 2026 15:15:30 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 437:
>
>> 435:
>> 436: /**
>> 437: * {@return the optional secret value, byte[0] if not used}
>
> What is `byte[0]`. Also, is that an algorithm detail? Should you return an
> `Optional`?
I mean "an empty byte array". Well, `Optional` would work too but it seems
un-necessary if we don't need to distinguish between empty and absent secret
values. Maybe we don't need to mention the empty byte array case?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3503484234
