On Fri, 17 Apr 2026 14:58:12 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> additional data cleanup. > > src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line > 168: > >> 166: * Set the memory value to the builder. >> 167: * >> 168: * @param m the memory value in Kibibytes > > I know KiB but this is the first time I see the "kibibyte" word. Maybe some > explanation? > > And, must its first letter be capitalized? Then I will just use KiB throughout. As for the capital first letter, that seems to be the convention. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3431460873
