On Fri, 17 Apr 2026 14:52:38 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 101:
>
>> 99: * <p>
>> 100: * The {@code Builder} is initialized via the {@code newBuilder}
>> method of
>> 101: * {@code Argon2ParameterSpec}. As stated in the class description,
>
> I know "the class" here means `Argon2ParameterSpec`, but in the rendered
> HTML, this line is on its own page for `Builder`. Hopefully no one will find
> it confused.
Agree, I will change it.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 102:
>
>> 100: * The {@code Builder} is initialized via the {@code newBuilder}
>> method of
>> 101: * {@code Argon2ParameterSpec}. As stated in the class description,
>> 102: * required parameters must be supplied by calling various methods.
>> Finally,
>
> "Various" seems vague.
Yes, will change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3431417795
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3431420905
