On Thu, 6 Aug 2026 18:26:58 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > Address Sean's review comments and other misc changes, e.g. from jdk27 to > 28. > Will there also be support as `SecretKeyFactory` (similar as to what > Bouncycastle is providing in > [bcgit/bc-java@1c15bed](https://github.com/bcgit/bc-java/commit/1c15beda06a5f716941ae07680c81a335b6e78e0)) > or just as `KDF`. The former would ease migrating from Bouncycastle to > native Java. I am inclined to just `KDF` support. Even if we add Argon2 `SecretKeyFactory` impl to SunJCE provider, it still can't accept BC's `org.bouncycastle.jcajce.spec.Argon2KeySpec` object and will have to add a standard Argon2 specific key spec class. So, explicit changes are needed anyway. The savings do not seem significant enough to justify adding a new `Argon2KeySpec` class solely for this migration path. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29597#issuecomment-5209007917
