On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   import cleanup.

src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 214:

> 212:                         for (int k = 0; k < lanes; k++) {
> 213:                             Argon2Position pos =  new Argon2Position(r, 
> k, s);
> 214:                             workers.submit(() -> {

Returned `Future` object is ignored. Futures should be collected and checked, 
or exceptions (e.g. OutOfMemoryError, RuntimeException) captured and propagated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778536083

Reply via email to