On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > import cleanup. src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 85: > 83: return value; > 84: } > 85: }; Unnecessary semicolon src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 206: > 204: int poolSize = Math.min(lanes, > 205: Runtime.getRuntime().availableProcessors()); > 206: ExecutorService workers = > Executors.newFixedThreadPool(poolSize); 'ExecutorService' used without 'try'-with-resources statement src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 341: > 339: } > 340: int z = (startPosition + zz) % this.columns; > 341: return z; Should we just `return (startPosition + zz) % this.columns;`? src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 512: > 510: } > 511: > 512: Block(byte byteVal) { This constructor is never used src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 582: > 580: String result = ""; > 581: for (int i = 0; i < value.length; i++) { > 582: result += "[" + i + "]" + Long.toHexString(value[i]) + > "\n"; Nit: String concatenation '+=' in loop, better to use `StringBuilder` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778045987 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778088378 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778060491 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778101417 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3778026552
