On Thu, 13 Aug 2026 19:38:08 GMT, Artur Barashev <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 214:
>
>> 212: for (int k = 0; k < lanes; k++) {
>> 213: Argon2Position pos = new Argon2Position(r,
>> k, s);
>> 214: workers.submit(() -> {
>
> Returned `Future` object is ignored. Futures should be collected and checked,
> or exceptions (e.g. OutOfMemoryError, RuntimeException) captured and
> propagated.
To address another comment, I've removed all these concurrency code.
> src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 222:
>
>> 220: });
>> 221: }
>> 222: latch.await();
>
> If `latch.await()` is interrupted, control jumps past both shutdown() calls.
> Wouldn't it be better to add a `finally` clause (after `catch
> (InterruptedException ie)`) and move shutdown() calls there?
This part of code will be removed to address another comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4201363001
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4201367680
