On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   import cleanup.

src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 452:

> 450:         private static void compressG(Block a, Block b, Block dst,
> 451:                 boolean xor) {
> 452:             Block blockR = Block.xor(a, b);

Do we really need to allocate a new block on every call here? Reusable 
per-worker buffers would substantially reduce GC pressure and unexpected OOME 
risk.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3779808726

Reply via email to