4 dec 2008 kl. 14.05 skrev Henning Westerholt:
On Thursday 04 December 2008, Alfred E. Heggestad wrote:
please find attached a patch for a new module called 'prefix_route'
we want to merge this into the main SER v2.1 CVS, but would prefer
some review comments from the community before it is merged.
the module description can be found in the README file (in the
patch).
Hi Alfred,
nice work! I've no comments to the code, just a few related
questions with
regards to the new sip-router project:
I noticed that this module has some similarities to the carrierroute
[1]
module i maintain for the kamailio project (matching mode, structure
of the
tree..). Do you plan also the merge this to the sip-router
repository later
on? If yes, perhaps it makes then sense trying to merge both modules
then?
Without looking at Alfred's work, I want to throw myself into the
debate...
My general feeling about carrierroute is that it is a bag filled with
candy,
but a bit too much for one module. It is very clear that it fits
someone's
business platform. Maybe we should consider breaking it up in
smaller, more focused modules?
Like the work I began in Asterisk, with breaking up Voicemail. It's
been one huge monolithic module that wasn't very adaptive.
I like small adaptive buildingblocks.
Just my 10 cents.
/O
_______________________________________________
Serdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/serdev
