Henning Westerholt wrote:
On Thursday 04 December 2008, Alfred E. Heggestad wrote:
please find attached a patch for a new module called 'prefix_route'
we want to merge this into the main SER v2.1 CVS, but would prefer
some review comments from the community before it is merged.
the module description can be found in the README file (in the patch).
Hi Alfred,
nice work! I've no comments to the code, just a few related questions with
regards to the new sip-router project:
I noticed that this module has some similarities to the carrierroute [1]
module i maintain for the kamailio project (matching mode, structure of the
tree..). Do you plan also the merge this to the sip-router repository later
on? If yes, perhaps it makes then sense trying to merge both modules then?
Please let me know what do you think,
Hi Henning
thanks for your input and thoughts.
I had a look at the carrierroute module, and it looks very comprehensive
and full of nice features. the prefix_route module was implemented to
solve a very specific problem, and my initial feeling is that they
are too specific to have so much overlap.
For now I have committed the prefix_route code to CVS, but I think
we should evaluate these modules in the future, and possibly look
at any common code that can be reused. Also with regards to Olle's
comments, we might later create some new and modular modules like
"prefix/carrier-route NG" with input from lessons learned here..
/alfred
Henning
[1] http://www.kamailio.org/docs/modules/devel/carrierroute.html
_______________________________________________
Serdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/serdev
