On Thursday 04 December 2008, Johansson Olle E wrote: > > I noticed that this module has some similarities to the carrierroute > > [1] module i maintain for the kamailio project (matching mode, structure > > of the tree..). Do you plan also the merge this to the sip-router > > repository later on? If yes, perhaps it makes then sense trying to merge > > both modules then? > > Without looking at Alfred's work, I want to throw myself into the > debate... > > My general feeling about carrierroute is that it is a bag filled with > candy, but a bit too much for one module. It is very clear that it fits > someone's business platform. Maybe we should consider breaking it up in > smaller, more focused modules? > > Like the work I began in Asterisk, with breaking up Voicemail. It's > been one huge monolithic module that wasn't very adaptive. > I like small adaptive buildingblocks.
Hi Olle, thanks for the comments. I agree that its a complicated module, and one functions is in there (cr_prime_route) to mainly support the special needs of our infrastructure. There exists some functionality that could be moved to a new module, for example the config file functionality. But on the other hand our admins like to have only one interface for all machines. Another option would be to move this failure_route functionality, but this is only one function, so there is not much to gain here. One thing i don't agree with it that its only fits to one (our) business plattform. Some people use it with way bigger routing sets then we do, and we redesigned it in a general way to make it more usable for other people with different needs. More details of the refactorings we did can be found in some posting to the (kamailio) user list a few weeks ago. With regards to the eventual merge, it was just some idea i got during the code review. Some other module, e.g. dispatcher and lcr fills a different niche, have a different functionality. After all, the 'market' for a module to support PSTN routing with that routing sets size for carriers is not that huge. Cheers, Henning _______________________________________________ Serdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/serdev
