Henning Westerholt wrote:
On Saturday 06 December 2008, Alfred E. Heggestad wrote:
[..]
I noticed that this module has some similarities to the carrierroute [1]
module i maintain for the kamailio project (matching mode, structure of
the tree..). Do you plan also the merge this to the sip-router repository
later on? If yes, perhaps it makes then sense trying to merge both
modules then?
Please let me know what do you think,
thanks for your input and thoughts.
I had a look at the carrierroute module, and it looks very comprehensive
and full of nice features. the prefix_route module was implemented to
solve a very specific problem, and my initial feeling is that they
are too specific to have so much overlap.
Hi Alfred,
thanks for the reply.
For now I have committed the prefix_route code to CVS, but I think
we should evaluate these modules in the future, and possibly look
at any common code that can be reused. Also with regards to Olle's
comments, we might later create some new and modular modules like
"prefix/carrier-route NG" with input from lessons learned here..
Sounds good. One thing that perhaps could be interesting for you (with the POV
of further integration) is the trie library i commited some time ago to
the 'lib/trie' diretory in the sip-router repository. It provides a generic
digit matching tree in shared memory, but also supports non-digit operation.
thanks,
I had a quick look at lib/trie in sip-router, and it looks like it can be
used also for the prefix_route module. when the move to sip-router is done,
I will have a look again and see if prefix_route can be ported to use this
new api.
I also support this kind of code reuse :) I also wish that more base functions
like sip_msg/str functions were present in the core/lib, so that they did not
have to be re-implemented in every module.
/alfred
Cheers,
Henning
_______________________________________________
Serdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/serdev
