On Mon, 9 Sep 2024 19:02:25 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. >> >> `MEMFLAGS` implies that we can use more than one at the same time, but those >> are exclusive values, so `MemTag` is a more suitable name. >> >> This fix also includes a cleanup of all the related parameter names and >> local variable names. >> >> Testing is pending... >> >> Note: there is more history in old closed PRs >> [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) >> and >> [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472) > > Gerard Ziemski has updated the pull request incrementally with one additional > commit since the last revision: > > fix test At least in the GC code we sometimes spell out the template parameter name with CamelCase: Iterator, Function, ClosureType, OopClosureT, Parallel, ... I'm OK with using MT as the template parameter name. I'm also OK with using mem_tag, but you might hit problems when classes both have template parameter name and functions that take a MemTag. I see that GrowableArrayCHeap has this situation, but it looks like that is accidental code and isn't really needed, so maybe this isn't a big concern. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20872#issuecomment-2341288588
