On Wed, 14 May 2025 01:07:36 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This is an alternative (and opposite) approach to >> https://github.com/openjdk/jdk/pull/24895. We basically convert most `[cds]` >> logs to `[aot]` logs. However, for the few logs that might be needed by >> existing user scripts, we use macros like `aot_log_info`, `aot_log_debug` so >> that they can be selected/printed using the `[cds]` tag. >> >> We have a few hundred logs that start with `[cds]`. To aid reviewing, this >> PR will convert only part of them. I will create a second PR that coverts >> the rest of the logs. >> >> Please see **aotLogging.hpp** for how the macros work. > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > Removed PrintAOTLogsAsCDSLogs and improved comments
Hi, Just one comment. I'm approving, the UL code looks good to me. src/hotspot/share/cds/aotLogging.hpp line 82: > 80: // > 81: // [2] When using CDS archives > 82: // - These logs can be selected ONLY with -Xlog:cds. They are always > printed with [cds] decoration OK, so if I use `-Xlog:all`, what will they be selected as? ------------- Marked as reviewed by jsjolen (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25136#pullrequestreview-2838902352 PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2088151655
