On Fri, 16 May 2025 04:38:47 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This is an alternative (and opposite) approach to >> https://github.com/openjdk/jdk/pull/24895. We basically convert most `[cds]` >> logs to `[aot]` logs. However, for the few logs that might be needed by >> existing user scripts, we use macros like `aot_log_info`, `aot_log_debug` so >> that they can be selected/printed using the `[cds]` tag. >> >> We have a few hundred logs that start with `[cds]`. To aid reviewing, this >> PR will convert only part of them. The rest of the logs are converted in >> https://github.com/openjdk/jdk/pull/25238. Both PRs will be integrated at >> the same time after review. >> >> Please see **aotLogging.hpp** for how the macros work. > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > @jdksjolen review comments
Changes make sense, looks good! ------------- Marked as reviewed by matsaave (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25136#pullrequestreview-2847605104
