On Thu, 15 May 2025 02:05:57 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This is an alternative (and opposite) approach to >> https://github.com/openjdk/jdk/pull/24895. We basically convert most `[cds]` >> logs to `[aot]` logs. However, for the few logs that might be needed by >> existing user scripts, we use macros like `aot_log_info`, `aot_log_debug` so >> that they can be selected/printed using the `[cds]` tag. >> >> We have a few hundred logs that start with `[cds]`. To aid reviewing, this >> PR will convert only part of them. The rest of the logs are converted in >> https://github.com/openjdk/jdk/pull/25238. Both PRs will be integrated at >> the same time after review. >> >> Please see **aotLogging.hpp** for how the macros work. > > Ioi Lam has updated the pull request with a new target base due to a merge or > a rebase. The pull request now contains 28 commits: > > - Merge master > - Fixed makefile; Fixed copyright > - Merge branch 'master' into 8356595-convert-cds-log-to-aot-log > - Improved comments: [cds] logs will be printed if no -XX:AOTxxx flags are > used > - @dholmes-ora review - fixed typos > - Removed PrintAOTLogsAsCDSLogs and improved comments > - More conversion; clean up; bug fixes > - Fixed macos build > - @stefank suggestions > - Merge remote-tracking branch '8355638-xlog-aot-as-alias-for-xlog-cds' into > 8355638-xlog-aot-as-alias-for-xlog-cds-alt-impl > - ... and 18 more: https://git.openjdk.org/jdk/compare/5e50a584...2a4355f8
Okay, nothing further from me. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25136#pullrequestreview-2842582318
