On Wed, 14 May 2025 07:18:37 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> src/hotspot/share/cds/aotLogging.hpp line 82: >> >>> 80: // >>> 81: // [2] When using CDS archives >>> 82: // - These logs can be selected ONLY with -Xlog:cds. They are >>> always printed with [cds] decoration >> >> OK, so if I use `-Xlog:all`, what will they be selected as? > > `-Xlog:all` will enable all `LogTagSets`. Each `aot_log_xxx()` statement will > print exactly one log. When using AOT caches, the log will be printed with > `[aot]` decorations. When using CDS archives, the log will be printed with > `[cds]` decorations.
Alright, I think we should simplify the comments a bit then. Just 'when using AOT cache, these logs are selected via the aot tag, and not the cds tag. When using CDS, these logs are selected via the cds tag, and not the aot tag.' but with the structure you had. The "ONLY with -Xlog:aot" makes it sound like `-Xlog:all` won't select cds or aot tags anymore. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25136#discussion_r2090483374
